annotate src/share/vm/gc_implementation/g1/ptrQueue.cpp @ 1705:2d160770d2e5

6814437: G1: remove the _new_refs array Summary: The per-worker _new_refs array is used to hold references that point into the collection set. It is populated during RSet updating and subsequently processed. In the event of an evacuation failure it processed again to recreate the RSets of regions in the collection set. Remove the per-worker _new_refs array by processing the references directly. Use a DirtyCardQueue to hold the cards containing the references so that the RSets of regions in the collection set can be recreated when handling an evacuation failure. Reviewed-by: iveresov, jmasa, tonyp
author johnc
date Mon, 02 Aug 2010 12:51:43 -0700
parents c18cbe5936b8
children f95d63e2154a
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
1 /*
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1317
diff changeset
2 * Copyright (c) 2001, 2009, Oracle and/or its affiliates. All rights reserved.
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
4 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
7 * published by the Free Software Foundation.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
8 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
13 * accompanied this code).
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
14 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1317
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1317
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1317
diff changeset
21 * questions.
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
22 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
23 */
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
24
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
25 # include "incls/_precompiled.incl"
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
26 # include "incls/_ptrQueue.cpp.incl"
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
27
1317
d4197f8d516a 6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents: 1169
diff changeset
28 PtrQueue::PtrQueue(PtrQueueSet* qset_, bool perm, bool active) :
d4197f8d516a 6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents: 1169
diff changeset
29 _qset(qset_), _buf(NULL), _index(0), _active(active),
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
30 _perm(perm), _lock(NULL)
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
31 {}
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
32
441
da9cb4e97a5f 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint
iveresov
parents: 342
diff changeset
33 void PtrQueue::flush() {
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
34 if (!_perm && _buf != NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
35 if (_index == _sz) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
36 // No work to do.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
37 qset()->deallocate_buffer(_buf);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
38 } else {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
39 // We must NULL out the unused entries, then enqueue.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
40 for (size_t i = 0; i < _index; i += oopSize) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
41 _buf[byte_index_to_index((int)i)] = NULL;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
42 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
43 qset()->enqueue_complete_buffer(_buf);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
44 }
441
da9cb4e97a5f 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint
iveresov
parents: 342
diff changeset
45 _buf = NULL;
da9cb4e97a5f 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint
iveresov
parents: 342
diff changeset
46 _index = 0;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
47 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
48 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
49
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
50
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
51 static int byte_index_to_index(int ind) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
52 assert((ind % oopSize) == 0, "Invariant.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
53 return ind / oopSize;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
54 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
55
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
56 static int index_to_byte_index(int byte_ind) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
57 return byte_ind * oopSize;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
58 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
59
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
60 void PtrQueue::enqueue_known_active(void* ptr) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
61 assert(0 <= _index && _index <= _sz, "Invariant.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
62 assert(_index == 0 || _buf != NULL, "invariant");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
63
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
64 while (_index == 0) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
65 handle_zero_index();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
66 }
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
67
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
68 assert(_index > 0, "postcondition");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
69 _index -= oopSize;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
70 _buf[byte_index_to_index((int)_index)] = ptr;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
71 assert(0 <= _index && _index <= _sz, "Invariant.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
72 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
73
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
74 void PtrQueue::locking_enqueue_completed_buffer(void** buf) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
75 assert(_lock->owned_by_self(), "Required.");
1169
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
76
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
77 // We have to unlock _lock (which may be Shared_DirtyCardQ_lock) before
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
78 // we acquire DirtyCardQ_CBL_mon inside enqeue_complete_buffer as they
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
79 // have the same rank and we may get the "possible deadlock" message
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
80 _lock->unlock();
1169
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
81
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
82 qset()->enqueue_complete_buffer(buf);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
83 // We must relock only because the caller will unlock, for the normal
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
84 // case.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
85 _lock->lock_without_safepoint_check();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
86 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
87
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
88
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
89 PtrQueueSet::PtrQueueSet(bool notify_when_complete) :
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
90 _max_completed_queue(0),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
91 _cbl_mon(NULL), _fl_lock(NULL),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
92 _notify_when_complete(notify_when_complete),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
93 _sz(0),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
94 _completed_buffers_head(NULL),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
95 _completed_buffers_tail(NULL),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
96 _n_completed_buffers(0),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
97 _process_completed_threshold(0), _process_completed(false),
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
98 _buf_free_list(NULL), _buf_free_list_sz(0)
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
99 {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
100 _fl_owner = this;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
101 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
102
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
103 void** PtrQueueSet::allocate_buffer() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
104 assert(_sz > 0, "Didn't set a buffer size.");
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
105 MutexLockerEx x(_fl_owner->_fl_lock, Mutex::_no_safepoint_check_flag);
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
106 if (_fl_owner->_buf_free_list != NULL) {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
107 void** res = BufferNode::make_buffer_from_node(_fl_owner->_buf_free_list);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
108 _fl_owner->_buf_free_list = _fl_owner->_buf_free_list->next();
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
109 _fl_owner->_buf_free_list_sz--;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
110 return res;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
111 } else {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
112 // Allocate space for the BufferNode in front of the buffer.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
113 char *b = NEW_C_HEAP_ARRAY(char, _sz + BufferNode::aligned_size());
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
114 return BufferNode::make_buffer_from_block(b);
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
115 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
116 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
117
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
118 void PtrQueueSet::deallocate_buffer(void** buf) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
119 assert(_sz > 0, "Didn't set a buffer size.");
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
120 MutexLockerEx x(_fl_owner->_fl_lock, Mutex::_no_safepoint_check_flag);
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
121 BufferNode *node = BufferNode::make_node_from_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
122 node->set_next(_fl_owner->_buf_free_list);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
123 _fl_owner->_buf_free_list = node;
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
124 _fl_owner->_buf_free_list_sz++;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
125 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
126
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
127 void PtrQueueSet::reduce_free_list() {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
128 assert(_fl_owner == this, "Free list reduction is allowed only for the owner");
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
129 // For now we'll adopt the strategy of deleting half.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
130 MutexLockerEx x(_fl_lock, Mutex::_no_safepoint_check_flag);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
131 size_t n = _buf_free_list_sz / 2;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
132 while (n > 0) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
133 assert(_buf_free_list != NULL, "_buf_free_list_sz must be wrong.");
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
134 void* b = BufferNode::make_block_from_node(_buf_free_list);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
135 _buf_free_list = _buf_free_list->next();
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
136 FREE_C_HEAP_ARRAY(char, b);
1084
5f932a151fd4 6895788: G1: SATB and update buffer allocation code allocates too much space
johnc
parents: 844
diff changeset
137 _buf_free_list_sz --;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
138 n--;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
139 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
140 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
141
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
142 void PtrQueue::handle_zero_index() {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
143 assert(0 == _index, "Precondition.");
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
144 // This thread records the full buffer and allocates a new one (while
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
145 // holding the lock if there is one).
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
146 if (_buf != NULL) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
147 if (_lock) {
1169
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
148 assert(_lock->owned_by_self(), "Required.");
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
149
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
150 // The current PtrQ may be the shared dirty card queue and
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
151 // may be being manipulated by more than one worker thread
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
152 // during a pause. Since the enqueuing of the completed
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
153 // buffer unlocks the Shared_DirtyCardQ_lock more than one
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
154 // worker thread can 'race' on reading the shared queue attributes
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
155 // (_buf and _index) and multiple threads can call into this
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
156 // routine for the same buffer. This will cause the completed
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
157 // buffer to be added to the CBL multiple times.
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
158
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
159 // We "claim" the current buffer by caching value of _buf in
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
160 // a local and clearing the field while holding _lock. When
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
161 // _lock is released (while enqueueing the completed buffer)
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
162 // the thread that acquires _lock will skip this code,
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
163 // preventing the subsequent the multiple enqueue, and
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
164 // install a newly allocated buffer below.
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
165
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
166 void** buf = _buf; // local pointer to completed buffer
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
167 _buf = NULL; // clear shared _buf field
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
168
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
169 locking_enqueue_completed_buffer(buf); // enqueue completed buffer
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
170
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
171 // While the current thread was enqueuing the buffer another thread
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
172 // may have a allocated a new buffer and inserted it into this pointer
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
173 // queue. If that happens then we just return so that the current
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
174 // thread doesn't overwrite the buffer allocated by the other thread
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
175 // and potentially losing some dirtied cards.
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
176
09646c4656ca 6915005: G1: Hang in PtrQueueSet::completed_buffers_list_length with gcl001
johnc
parents: 1111
diff changeset
177 if (_buf != NULL) return;
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
178 } else {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
179 if (qset()->process_or_enqueue_complete_buffer(_buf)) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
180 // Recycle the buffer. No allocation.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
181 _sz = qset()->buffer_size();
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
182 _index = _sz;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
183 return;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
184 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
185 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
186 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
187 // Reallocate the buffer
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
188 _buf = qset()->allocate_buffer();
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
189 _sz = qset()->buffer_size();
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
190 _index = _sz;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
191 assert(0 <= _index && _index <= _sz, "Invariant.");
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
192 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
193
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
194 bool PtrQueueSet::process_or_enqueue_complete_buffer(void** buf) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
195 if (Thread::current()->is_Java_thread()) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
196 // We don't lock. It is fine to be epsilon-precise here.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
197 if (_max_completed_queue == 0 || _max_completed_queue > 0 &&
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
198 _n_completed_buffers >= _max_completed_queue + _completed_queue_padding) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
199 bool b = mut_process_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
200 if (b) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
201 // True here means that the buffer hasn't been deallocated and the caller may reuse it.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
202 return true;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
203 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
204 }
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
205 }
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
206 // The buffer will be enqueued. The caller will have to get a new one.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
207 enqueue_complete_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
208 return false;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
209 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
210
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
211 void PtrQueueSet::enqueue_complete_buffer(void** buf, size_t index) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
212 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
213 BufferNode* cbn = BufferNode::new_from_buffer(buf);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
214 cbn->set_index(index);
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
215 if (_completed_buffers_tail == NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
216 assert(_completed_buffers_head == NULL, "Well-formedness");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
217 _completed_buffers_head = cbn;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
218 _completed_buffers_tail = cbn;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
219 } else {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
220 _completed_buffers_tail->set_next(cbn);
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
221 _completed_buffers_tail = cbn;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
222 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
223 _n_completed_buffers++;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
224
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
225 if (!_process_completed && _process_completed_threshold >= 0 &&
794
315a5d70b295 6484957: G1: parallel concurrent refinement
iveresov
parents: 616
diff changeset
226 _n_completed_buffers >= _process_completed_threshold) {
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
227 _process_completed = true;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
228 if (_notify_when_complete)
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
229 _cbl_mon->notify();
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
230 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
231 debug_only(assert_completed_buffer_list_len_correct_locked());
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
232 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
233
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
234 int PtrQueueSet::completed_buffers_list_length() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
235 int n = 0;
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
236 BufferNode* cbn = _completed_buffers_head;
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
237 while (cbn != NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
238 n++;
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
239 cbn = cbn->next();
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
240 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
241 return n;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
242 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
243
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
244 void PtrQueueSet::assert_completed_buffer_list_len_correct() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
245 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
246 assert_completed_buffer_list_len_correct_locked();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
247 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
248
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
249 void PtrQueueSet::assert_completed_buffer_list_len_correct_locked() {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
250 guarantee(completed_buffers_list_length() == _n_completed_buffers,
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
251 "Completed buffer length is wrong.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
252 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
253
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
254 void PtrQueueSet::set_buffer_size(size_t sz) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
255 assert(_sz == 0 && sz > 0, "Should be called only once.");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
256 _sz = sz * oopSize;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
257 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
258
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
259 // Merge lists of buffers. Notify the processing threads.
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
260 // The source queue is emptied as a result. The queues
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
261 // must share the monitor.
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
262 void PtrQueueSet::merge_bufferlists(PtrQueueSet *src) {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
263 assert(_cbl_mon == src->_cbl_mon, "Should share the same lock");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
264 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
265 if (_completed_buffers_tail == NULL) {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
266 assert(_completed_buffers_head == NULL, "Well-formedness");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
267 _completed_buffers_head = src->_completed_buffers_head;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
268 _completed_buffers_tail = src->_completed_buffers_tail;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
269 } else {
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
270 assert(_completed_buffers_head != NULL, "Well formedness");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
271 if (src->_completed_buffers_head != NULL) {
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
272 _completed_buffers_tail->set_next(src->_completed_buffers_head);
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
273 _completed_buffers_tail = src->_completed_buffers_tail;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
274 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
275 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
276 _n_completed_buffers += src->_n_completed_buffers;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
277
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
278 src->_n_completed_buffers = 0;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
279 src->_completed_buffers_head = NULL;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
280 src->_completed_buffers_tail = NULL;
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
281
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
282 assert(_completed_buffers_head == NULL && _completed_buffers_tail == NULL ||
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
283 _completed_buffers_head != NULL && _completed_buffers_tail != NULL,
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
284 "Sanity");
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
285 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
286
1111
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
287 void PtrQueueSet::notify_if_necessary() {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
288 MutexLockerEx x(_cbl_mon, Mutex::_no_safepoint_check_flag);
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
289 if (_n_completed_buffers >= _process_completed_threshold || _max_completed_queue == 0) {
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
290 _process_completed = true;
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
291 if (_notify_when_complete)
44f61c24ddab 6862387: tune concurrent refinement further
iveresov
parents: 1084
diff changeset
292 _cbl_mon->notify();
616
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
293 }
4f360ec815ba 6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents: 470
diff changeset
294 }