graal-compiler: src/share/vm/gc_implementation/g1/vm_operations

annotate src/share/vm/gc_implementation/g1/vm_operations_g1.cpp @ 1840:4e0094bc41fa

6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent Summary: Clear the concurrent marking "in progress" flag while the FullGCCount_lock is held. This avoids a race that can cause back to back System.gc() calls, when ExplicitGCInvokesConcurrent is enabled, to fail to initiate a marking cycle causing the requesting thread to hang. Reviewed-by: tonyp, ysr

author	johnc
date	Fri, 01 Oct 2010 18:23:16 -0700
parents	4e5661ba9d98
children	f95d63e2154a

rev	line source
342 37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	1 /*
1552 c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories trims parents: 1088 diff changeset	2 * Copyright (c) 2001, 2009, Oracle and/or its affiliates. All rights reserved.
342 37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	4 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	5 * This code is free software; you can redistribute it and/or modify it
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	6 * under the terms of the GNU General Public License version 2 only, as
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	7 * published by the Free Software Foundation.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	8 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	9 * This code is distributed in the hope that it will be useful, but WITHOUT
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	12 * version 2 for more details (a copy is included in the LICENSE file that
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	13 * accompanied this code).
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	14 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	15 * You should have received a copy of the GNU General Public License version
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	16 * 2 along with this work; if not, write to the Free Software Foundation,
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	18 *
1552 c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories trims parents: 1088 diff changeset	19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories trims parents: 1088 diff changeset	20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories trims parents: 1088 diff changeset	21 * questions.
342 37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	22 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	23 */
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	24
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	25 #include "incls/_precompiled.incl"
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	26 #include "incls/_vm_operations_g1.cpp.incl"
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	27
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	28 void VM_G1CollectForAllocation::doit() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	29 JvmtiGCForAllocationMarker jgcm;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	30 G1CollectedHeap* g1h = G1CollectedHeap::heap();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	31 _res = g1h->satisfy_failed_allocation(_size);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	32 assert(g1h->is_in_or_null(_res), "result not in heap");
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	33 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	34
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	35 void VM_G1CollectFull::doit() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	36 JvmtiGCFullMarker jgcm;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	37 G1CollectedHeap* g1h = G1CollectedHeap::heap();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	38 GCCauseSetter x(g1h, _gc_cause);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	39 g1h->do_full_collection(false /* clear_all_soft_refs */);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	40 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	41
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	42 void VM_G1IncCollectionPause::doit() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	43 JvmtiGCForAllocationMarker jgcm;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	44 G1CollectedHeap* g1h = G1CollectedHeap::heap();
1656 4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	45 assert(!_should_initiate_conc_mark \|\|
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	46 ((_gc_cause == GCCause::_gc_locker && GCLockerInvokesConcurrent) \|\|
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	47 (_gc_cause == GCCause::_java_lang_system_gc && ExplicitGCInvokesConcurrent)),
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	48 "only a GC locker or a System.gc() induced GC should start a cycle");
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	49
1088 3fc996d4edd2 6902303: G1: ScavengeALot should cause an incremental, rather than a full, collection ysr parents: 844 diff changeset	50 GCCauseSetter x(g1h, _gc_cause);
1656 4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	51 if (_should_initiate_conc_mark) {
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	52 // It's safer to read full_collections_completed() here, given
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	53 // that noone else will be updating it concurrently. Since we'll
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	54 // only need it if we're initiating a marking cycle, no point in
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	55 // setting it earlier.
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	56 _full_collections_completed_before = g1h->full_collections_completed();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	57
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	58 // At this point we are supposed to start a concurrent cycle. We
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	59 // will do so if one is not already in progress.
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	60 bool res = g1h->g1_policy()->force_initial_mark_if_outside_cycle();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	61 }
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	62 g1h->do_collection_pause_at_safepoint(_target_pause_time_ms);
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	63 }
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	64
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	65 void VM_G1IncCollectionPause::doit_epilogue() {
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	66 VM_GC_Operation::doit_epilogue();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	67
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	68 // If the pause was initiated by a System.gc() and
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	69 // +ExplicitGCInvokesConcurrent, we have to wait here for the cycle
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	70 // that just started (or maybe one that was already in progress) to
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	71 // finish.
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	72 if (_gc_cause == GCCause::_java_lang_system_gc &&
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	73 _should_initiate_conc_mark) {
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	74 assert(ExplicitGCInvokesConcurrent,
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	75 "the only way to be here is if ExplicitGCInvokesConcurrent is set");
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	76
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	77 G1CollectedHeap* g1h = G1CollectedHeap::heap();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	78
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	79 // In the doit() method we saved g1h->full_collections_completed()
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	80 // in the _full_collections_completed_before field. We have to
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	81 // wait until we observe that g1h->full_collections_completed()
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	82 // has increased by at least one. This can happen if a) we started
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	83 // a cycle and it completes, b) a cycle already in progress
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	84 // completes, or c) a Full GC happens.
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	85
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	86 // If the condition has already been reached, there's no point in
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	87 // actually taking the lock and doing the wait.
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	88 if (g1h->full_collections_completed() <=
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	89 _full_collections_completed_before) {
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	90 // The following is largely copied from CMS
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	91
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	92 Thread* thr = Thread::current();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	93 assert(thr->is_Java_thread(), "invariant");
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	94 JavaThread* jt = (JavaThread*)thr;
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	95 ThreadToNativeFromVM native(jt);
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	96
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	97 MutexLockerEx x(FullGCCount_lock, Mutex::_no_safepoint_check_flag);
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	98 while (g1h->full_collections_completed() <=
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	99 _full_collections_completed_before) {
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	100 FullGCCount_lock->wait(Mutex::_no_safepoint_check_flag);
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	101 }
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	102 }
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly tonyp parents: 1552 diff changeset	103 }
342 37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	104 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	105
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	106 void VM_CGC_Operation::doit() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	107 gclog_or_tty->date_stamp(PrintGC && PrintGCDateStamps);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	108 TraceCPUTime tcpu(PrintGCDetails, true, gclog_or_tty);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	109 TraceTime t(_printGCMessage, PrintGC, true, gclog_or_tty);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	110 SharedHeap* sh = SharedHeap::heap();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	111 // This could go away if CollectedHeap gave access to _gc_is_active...
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	112 if (sh != NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	113 IsGCActiveMark x;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	114 _cl->do_void();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	115 } else {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	116 _cl->do_void();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	117 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	118 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	119
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	120 bool VM_CGC_Operation::doit_prologue() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	121 Heap_lock->lock();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	122 SharedHeap::heap()->_thread_holds_heap_lock_for_gc = true;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	123 return true;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	124 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	125
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	126 void VM_CGC_Operation::doit_epilogue() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	127 SharedHeap::heap()->_thread_holds_heap_lock_for_gc = false;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	128 Heap_lock->unlock();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector ysr parents: diff changeset	129 }

Mercurial > hg > graal-compiler

annotate src/share/vm/gc_implementation/g1/vm_operations_g1.cpp @ 1840:4e0094bc41fa