Mercurial > hg > graal-compiler
annotate src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp @ 1960:878b57474103
6978187: G1: assert(ParallelGCThreads> 1 || n_yielded() == _hrrs->occupied()) strikes again
Summary: An evacuation failure while copying the roots caused an object, A, to be forwarded to itself. During the subsequent RSet updating a reference to A was processed causing the reference to be added to the RSet of A's heap region. As a result of adding to the remembered set we ran into the issue described in 6930581 - the sparse table expanded and the RSet scanning code walked the cards in one instance of RHashTable (_cur) while the occupied() counts the cards in the expanded table (_next).
Reviewed-by: tonyp, iveresov
| author | johnc |
|---|---|
| date | Tue, 16 Nov 2010 14:07:33 -0800 |
| parents | 2d160770d2e5 |
| children | f95d63e2154a |
| rev | line source |
|---|---|
| 342 | 1 /* |
| 1705 | 2 * Copyright (c) 2001, 2010, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1261
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1261
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1261
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 25 /* | |
| 26 * This really ought to be an inline function, but apparently the C++ | |
| 27 * compiler sometimes sees fit to ignore inline declarations. Sigh. | |
| 28 */ | |
| 29 | |
| 30 // This must a ifdef'ed because the counting it controls is in a | |
| 31 // perf-critical inner loop. | |
| 32 #define FILTERINTOCSCLOSURE_DOHISTOGRAMCOUNT 0 | |
| 33 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
34 template <class T> inline void FilterIntoCSClosure::do_oop_nv(T* p) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
35 T heap_oop = oopDesc::load_heap_oop(p); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
36 if (!oopDesc::is_null(heap_oop) && |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
37 _g1->obj_in_cs(oopDesc::decode_heap_oop_not_null(heap_oop))) { |
| 342 | 38 _oc->do_oop(p); |
| 39 #if FILTERINTOCSCLOSURE_DOHISTOGRAMCOUNT | |
| 1705 | 40 if (_dcto_cl != NULL) |
| 41 _dcto_cl->incr_count(); | |
| 342 | 42 #endif |
| 43 } | |
| 44 } | |
| 45 | |
| 46 #define FILTEROUTOFREGIONCLOSURE_DOHISTOGRAMCOUNT 0 | |
| 47 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
48 template <class T> inline void FilterOutOfRegionClosure::do_oop_nv(T* p) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
49 T heap_oop = oopDesc::load_heap_oop(p); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
50 if (!oopDesc::is_null(heap_oop)) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
51 HeapWord* obj_hw = (HeapWord*)oopDesc::decode_heap_oop_not_null(heap_oop); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
52 if (obj_hw < _r_bottom || obj_hw >= _r_end) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
53 _oc->do_oop(p); |
| 342 | 54 #if FILTEROUTOFREGIONCLOSURE_DOHISTOGRAMCOUNT |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
55 _out_of_region++; |
| 342 | 56 #endif |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
57 } |
| 342 | 58 } |
| 59 } | |
| 60 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
61 template <class T> inline void FilterInHeapRegionAndIntoCSClosure::do_oop_nv(T* p) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
62 T heap_oop = oopDesc::load_heap_oop(p); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
63 if (!oopDesc::is_null(heap_oop) && |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
64 _g1->obj_in_cs(oopDesc::decode_heap_oop_not_null(heap_oop))) |
| 342 | 65 _oc->do_oop(p); |
| 66 } | |
| 67 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
68 template <class T> inline void FilterAndMarkInHeapRegionAndIntoCSClosure::do_oop_nv(T* p) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
69 T heap_oop = oopDesc::load_heap_oop(p); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
70 if (!oopDesc::is_null(heap_oop)) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
71 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); |
| 342 | 72 HeapRegion* hr = _g1->heap_region_containing((HeapWord*) obj); |
| 73 if (hr != NULL) { | |
| 74 if (hr->in_collection_set()) | |
| 75 _oc->do_oop(p); | |
| 76 else if (!hr->is_young()) | |
| 77 _cm->grayRoot(obj); | |
| 78 } | |
| 79 } | |
| 80 } | |
| 81 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
82 // This closure is applied to the fields of the objects that have just been copied. |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
83 template <class T> inline void G1ParScanClosure::do_oop_nv(T* p) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
84 T heap_oop = oopDesc::load_heap_oop(p); |
| 342 | 85 |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
86 if (!oopDesc::is_null(heap_oop)) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
87 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
88 if (_g1->in_cset_fast_test(obj)) { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
89 // We're not going to even bother checking whether the object is |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
90 // already forwarded or not, as this usually causes an immediate |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
91 // stall. We'll try to prefetch the object (for write, given that |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
92 // we might need to install the forwarding reference) and we'll |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
93 // get back to it when pop it from the queue |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
94 Prefetch::write(obj->mark_addr(), 0); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
95 Prefetch::read(obj->mark_addr(), (HeapWordSize*2)); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
96 |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
97 // slightly paranoid test; I'm trying to catch potential |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
98 // problems before we go into push_on_queue to know where the |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
99 // problem is coming from |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
100 assert(obj == oopDesc::load_decode_heap_oop(p), |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
101 "p should still be pointing to obj"); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
102 _par_scan_state->push_on_queue(p); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
103 } else { |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
104 _par_scan_state->update_rs(_from, p, _par_scan_state->queue_num()); |
|
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
105 } |
| 342 | 106 } |
| 107 } | |
| 1261 | 108 |
| 109 template <class T> inline void G1ParPushHeapRSClosure::do_oop_nv(T* p) { | |
| 110 T heap_oop = oopDesc::load_heap_oop(p); | |
| 111 | |
| 112 if (!oopDesc::is_null(heap_oop)) { | |
| 113 oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); | |
| 114 if (_g1->in_cset_fast_test(obj)) { | |
| 115 Prefetch::write(obj->mark_addr(), 0); | |
| 116 Prefetch::read(obj->mark_addr(), (HeapWordSize*2)); | |
| 1705 | 117 |
| 118 // Place on the references queue | |
| 1261 | 119 _par_scan_state->push_on_queue(p); |
| 120 } | |
| 121 } | |
| 122 } | |
| 1705 | 123 |