Mercurial > hg > graal-compiler
annotate src/cpu/sparc/vm/metaspaceShared_sparc.cpp @ 6812:988bf00cc564
7200261: G1: Liveness counting inconsistencies during marking verification
Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures.
Reviewed-by: brutisso, jwilhelm, jmasa
| author | johnc |
|---|---|
| date | Thu, 27 Sep 2012 15:44:01 -0700 |
| parents | da91efe96a93 |
| children | f0c2369fda5a |
| rev | line source |
|---|---|
| 0 | 1 /* |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
2426
diff
changeset
|
2 * Copyright (c) 2004, 2012, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
727
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
727
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
727
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "assembler_sparc.inline.hpp" | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
2426
diff
changeset
|
27 #include "memory/metaspaceShared.hpp" |
| 0 | 28 |
| 29 // Generate the self-patching vtable method: | |
| 30 // | |
| 31 // This method will be called (as any other Klass virtual method) with | |
| 32 // the Klass itself as the first argument. Example: | |
| 33 // | |
| 34 // oop obj; | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
2426
diff
changeset
|
35 // int size = obj->klass()->oop_size(this); |
| 0 | 36 // |
| 37 // for which the virtual method call is Klass::oop_size(); | |
| 38 // | |
| 39 // The dummy method is called with the Klass object as the first | |
| 40 // operand, and an object as the second argument. | |
| 41 // | |
| 42 | |
| 43 //===================================================================== | |
| 44 | |
| 45 // All of the dummy methods in the vtable are essentially identical, | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
2426
diff
changeset
|
46 // differing only by an ordinal constant, and they bear no relationship |
| 0 | 47 // to the original method which the caller intended. Also, there needs |
| 48 // to be 'vtbl_list_size' instances of the vtable in order to | |
| 49 // differentiate between the 'vtable_list_size' original Klass objects. | |
| 50 | |
| 51 #define __ masm-> | |
| 52 | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
2426
diff
changeset
|
53 void MetaspaceShared::generate_vtable_methods(void** vtbl_list, |
| 0 | 54 void** vtable, |
| 55 char** md_top, | |
| 56 char* md_end, | |
| 57 char** mc_top, | |
| 58 char* mc_end) { | |
| 59 | |
| 60 intptr_t vtable_bytes = (num_virtuals * vtbl_list_size) * sizeof(void*); | |
| 61 *(intptr_t *)(*md_top) = vtable_bytes; | |
| 62 *md_top += sizeof(intptr_t); | |
| 63 void** dummy_vtable = (void**)*md_top; | |
| 64 *vtable = dummy_vtable; | |
| 65 *md_top += vtable_bytes; | |
| 66 | |
| 67 guarantee(*md_top <= md_end, "Insufficient space for vtables."); | |
| 68 | |
| 69 // Get ready to generate dummy methods. | |
| 70 | |
| 71 CodeBuffer cb((unsigned char*)*mc_top, mc_end - *mc_top); | |
| 72 MacroAssembler* masm = new MacroAssembler(&cb); | |
| 73 | |
| 74 Label common_code; | |
| 75 for (int i = 0; i < vtbl_list_size; ++i) { | |
| 76 for (int j = 0; j < num_virtuals; ++j) { | |
| 77 dummy_vtable[num_virtuals * i + j] = (void*)masm->pc(); | |
| 78 __ save(SP, -256, SP); | |
|
2376
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
79 int offset = (i << 8) + j; |
|
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
80 Register src = G0; |
|
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
81 if (!Assembler::is_simm13(offset)) { |
|
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
82 __ sethi(offset, L0); |
|
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
83 src = L0; |
|
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
84 offset = offset & ((1 << 10) - 1); |
|
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
85 } |
| 0 | 86 __ brx(Assembler::always, false, Assembler::pt, common_code); |
| 87 | |
| 88 // Load L0 with a value indicating vtable/offset pair. | |
| 89 // -- bits[ 7..0] (8 bits) which virtual method in table? | |
|
2376
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
90 // -- bits[13..8] (6 bits) which virtual method table? |
|
c7f3d0b4570f
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
1972
diff
changeset
|
91 __ delayed()->or3(src, offset, L0); |
| 0 | 92 } |
| 93 } | |
| 94 | |
| 95 __ bind(common_code); | |
| 96 | |
| 97 // Expecting to be called with the "this" pointer in O0/I0 (where | |
| 98 // "this" is a Klass object). In addition, L0 was set (above) to | |
| 99 // identify the method and table. | |
| 100 | |
| 101 // Look up the correct vtable pointer. | |
| 102 | |
| 103 __ set((intptr_t)vtbl_list, L2); // L2 = address of new vtable list. | |
| 104 __ srl(L0, 8, L3); // Isolate L3 = vtable identifier. | |
| 105 __ sll(L3, LogBytesPerWord, L3); | |
| 106 __ ld_ptr(L2, L3, L3); // L3 = new (correct) vtable pointer. | |
| 107 __ st_ptr(L3, Address(I0, 0)); // Save correct vtable ptr in entry. | |
| 108 | |
| 109 // Restore registers and jump to the correct method; | |
| 110 | |
| 111 __ and3(L0, 255, L4); // Isolate L3 = method offset;. | |
| 112 __ sll(L4, LogBytesPerWord, L4); | |
| 113 __ ld_ptr(L3, L4, L4); // Get address of correct virtual method | |
| 727 | 114 __ jmpl(L4, 0, G0); // Jump to correct method. |
| 0 | 115 __ delayed()->restore(); // Restore registers. |
| 116 | |
| 117 __ flush(); | |
| 118 *mc_top = (char*)__ pc(); | |
| 119 | |
| 120 guarantee(*mc_top <= mc_end, "Insufficient space for method wrappers."); | |
| 121 } |