Mercurial > hg > graal-compiler
annotate src/share/vm/classfile/stackMapTable.hpp @ 9126:bc26f978b0ce
HotSpotResolvedObjectType: implement hasFinalizeSubclass() correctly
don't use the (wrong) cached value, but ask the runtime on each request.
Fixes regression on xml.* benchmarks @ specjvm2008. The problem was:
After the constructor of Object was deoptimized due to an assumption violation,
it was recompiled again after some time. However, on recompilation, the value
of hasFinalizeSubclass for the class was not updated and it was compiled again
with a, now wrong, assumption, which then triggers deoptimization again.
This was repeated until it hit the recompilation limit (defined by
PerMethodRecompilationCutoff), and therefore only executed by the interpreter
from now on, causing the performance regression.
author | Bernhard Urban <bernhard.urban@jku.at> |
---|---|
date | Mon, 15 Apr 2013 19:54:58 +0200 |
parents | da91efe96a93 |
children | 2993491d47df |
rev | line source |
---|---|
0 | 1 /* |
6605 | 2 * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #ifndef SHARE_VM_CLASSFILE_STACKMAPTABLE_HPP |
26 #define SHARE_VM_CLASSFILE_STACKMAPTABLE_HPP | |
27 | |
28 #include "classfile/stackMapFrame.hpp" | |
6605 | 29 #include "classfile/verifier.hpp" |
1972 | 30 #include "memory/allocation.hpp" |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6605
diff
changeset
|
31 #include "oops/constantPool.hpp" |
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6605
diff
changeset
|
32 #include "oops/method.hpp" |
1972 | 33 #include "utilities/globalDefinitions.hpp" |
34 #ifdef TARGET_ARCH_x86 | |
35 # include "bytes_x86.hpp" | |
36 #endif | |
37 #ifdef TARGET_ARCH_sparc | |
38 # include "bytes_sparc.hpp" | |
39 #endif | |
40 #ifdef TARGET_ARCH_zero | |
41 # include "bytes_zero.hpp" | |
42 #endif | |
2192
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
43 #ifdef TARGET_ARCH_arm |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
44 # include "bytes_arm.hpp" |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
45 #endif |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
46 #ifdef TARGET_ARCH_ppc |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
47 # include "bytes_ppc.hpp" |
b92c45f2bc75
7016023: Enable building ARM and PPC from src/closed repository
bobv
parents:
1972
diff
changeset
|
48 #endif |
1972 | 49 |
0 | 50 class StackMapReader; |
51 | |
52 // StackMapTable class is the StackMap table used by type checker | |
53 class StackMapTable : public StackObj { | |
54 private: | |
55 // Logically, the _frame_count (as well as many fields in the StackFrame) | |
56 // should be a u2, but if we defined the variable as that type it will | |
57 // be difficult to detect/recover from overflow or underflow conditions. | |
58 // Widening the type and making it signed will help detect these. | |
59 int32_t _code_length; | |
60 int32_t _frame_count; // Stackmap frame count | |
61 StackMapFrame** _frame_array; | |
62 | |
63 public: | |
64 StackMapTable(StackMapReader* reader, StackMapFrame* init_frame, | |
65 u2 max_locals, u2 max_stack, | |
66 char* code_data, int code_len, TRAPS); | |
67 | |
68 inline int32_t get_frame_count() const { return _frame_count; } | |
69 inline int get_offset(int index) const { | |
70 return _frame_array[index]->offset(); | |
71 } | |
72 | |
73 // Match and/or update current_frame to the frame in stackmap table with | |
74 // specified offset. Return true if the two frames match. | |
75 bool match_stackmap( | |
76 StackMapFrame* current_frame, int32_t offset, | |
6605 | 77 bool match, bool update, ErrorContext* ctx, TRAPS) const; |
0 | 78 // Match and/or update current_frame to the frame in stackmap table with |
79 // specified offset and frame index. Return true if the two frames match. | |
80 bool match_stackmap( | |
81 StackMapFrame* current_frame, int32_t offset, int32_t frame_index, | |
6605 | 82 bool match, bool update, ErrorContext* ctx, TRAPS) const; |
0 | 83 |
84 // Check jump instructions. Make sure there are no uninitialized | |
85 // instances on backward branch. | |
86 void check_jump_target(StackMapFrame* frame, int32_t target, TRAPS) const; | |
87 | |
88 // The following methods are only used inside this class. | |
89 | |
90 // Returns the frame array index where the frame with offset is stored. | |
91 int get_index_from_offset(int32_t offset) const; | |
92 | |
93 // Make sure that there's no uninitialized object exist on backward branch. | |
94 void check_new_object( | |
95 const StackMapFrame* frame, int32_t target, TRAPS) const; | |
96 | |
6605 | 97 void print_on(outputStream* str) const; |
0 | 98 }; |
99 | |
100 class StackMapStream : StackObj { | |
101 private: | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6605
diff
changeset
|
102 Array<u1>* _data; |
0 | 103 int _index; |
104 public: | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6605
diff
changeset
|
105 StackMapStream(Array<u1>* ah) |
0 | 106 : _data(ah), _index(0) { |
107 } | |
108 u1 get_u1(TRAPS) { | |
109 if (_data == NULL || _index >= _data->length()) { | |
110 stackmap_format_error("access beyond the end of attribute", CHECK_0); | |
111 } | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6605
diff
changeset
|
112 return _data->at(_index++); |
0 | 113 } |
114 u2 get_u2(TRAPS) { | |
115 if (_data == NULL || _index >= _data->length() - 1) { | |
116 stackmap_format_error("access beyond the end of attribute", CHECK_0); | |
117 } | |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6605
diff
changeset
|
118 u2 res = Bytes::get_Java_u2(_data->adr_at(_index)); |
0 | 119 _index += 2; |
120 return res; | |
121 } | |
122 bool at_end() { | |
123 return (_data == NULL) || (_index == _data->length()); | |
124 } | |
125 static void stackmap_format_error(const char* msg, TRAPS); | |
126 }; | |
127 | |
128 class StackMapReader : StackObj { | |
129 private: | |
130 // information about the class and method | |
131 constantPoolHandle _cp; | |
132 ClassVerifier* _verifier; | |
133 StackMapStream* _stream; | |
134 char* _code_data; | |
135 int32_t _code_length; | |
136 | |
137 // information get from the attribute | |
138 int32_t _frame_count; // frame count | |
139 | |
140 int32_t chop(VerificationType* locals, int32_t length, int32_t chops); | |
141 VerificationType parse_verification_type(u1* flags, TRAPS); | |
142 void check_verification_type_array_size( | |
143 int32_t size, int32_t max_size, TRAPS) { | |
144 if (size < 0 || size > max_size) { | |
145 // Since this error could be caused someone rewriting the method | |
146 // but not knowing to update the stackmap data, we call the the | |
147 // verifier's error method, which may not throw an exception and | |
148 // failover to the old verifier instead. | |
149 _verifier->class_format_error( | |
150 "StackMapTable format error: bad type array size"); | |
151 } | |
152 } | |
153 | |
154 enum { | |
155 SAME_LOCALS_1_STACK_ITEM_EXTENDED = 247, | |
156 SAME_EXTENDED = 251, | |
157 FULL = 255 | |
158 }; | |
159 | |
160 public: | |
161 // Constructor | |
162 StackMapReader(ClassVerifier* v, StackMapStream* stream, char* code_data, | |
163 int32_t code_len, TRAPS) : | |
164 _verifier(v), _stream(stream), | |
165 _code_data(code_data), _code_length(code_len) { | |
166 methodHandle m = v->method(); | |
167 if (m->has_stackmap_table()) { | |
168 _cp = constantPoolHandle(THREAD, m->constants()); | |
169 _frame_count = _stream->get_u2(CHECK); | |
170 } else { | |
171 // There's no stackmap table present. Frame count and size are 0. | |
172 _frame_count = 0; | |
173 } | |
174 } | |
175 | |
176 inline int32_t get_frame_count() const { return _frame_count; } | |
177 StackMapFrame* next(StackMapFrame* pre_frame, bool first, | |
178 u2 max_locals, u2 max_stack, TRAPS); | |
179 | |
180 void check_end(TRAPS) { | |
181 if (!_stream->at_end()) { | |
182 StackMapStream::stackmap_format_error("wrong attribute size", CHECK); | |
183 } | |
184 } | |
185 }; | |
1972 | 186 |
187 #endif // SHARE_VM_CLASSFILE_STACKMAPTABLE_HPP |