Mercurial > hg > graal-compiler
annotate src/share/vm/oops/arrayOop.hpp @ 10185:d50cc62e94ff
8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t
Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime.
Reviewed-by: twisti, johnc
Contributed-by: Martin Doerr <martin.doerr@sap.com>
author | johnc |
---|---|
date | Wed, 24 Apr 2013 14:48:43 -0700 |
parents | da91efe96a93 |
children | 7944aba7ba41 |
rev | line source |
---|---|
0 | 1 /* |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
4708
diff
changeset
|
2 * Copyright (c) 1997, 2012, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
579
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
579
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
579
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #ifndef SHARE_VM_OOPS_ARRAYOOP_HPP |
26 #define SHARE_VM_OOPS_ARRAYOOP_HPP | |
27 | |
28 #include "memory/universe.inline.hpp" | |
29 #include "oops/oop.hpp" | |
30 | |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
31 // arrayOopDesc is the abstract baseclass for all arrays. It doesn't |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
32 // declare pure virtual to enforce this because that would allocate a vtbl |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
33 // in each instance, which we don't want. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
34 |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
35 // The layout of array Oops is: |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
36 // |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
37 // markOop |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
4708
diff
changeset
|
38 // Klass* // 32 bits if compressed but declared 64 in LP64. |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
39 // length // shares klass memory or allocated after declared fields. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
40 |
0 | 41 |
42 class arrayOopDesc : public oopDesc { | |
43 friend class VMStructs; | |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
44 |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
45 // Interpreter/Compiler offsets |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
46 |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
47 // Header size computation. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
48 // The header is considered the oop part of this type plus the length. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
49 // Returns the aligned header_size_in_bytes. This is not equivalent to |
165
437d03ea40b1
6703888: Compressed Oops: use the 32-bits gap after klass in a object
kvn
parents:
113
diff
changeset
|
50 // sizeof(arrayOopDesc) which should not appear in the code. |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
51 static int header_size_in_bytes() { |
165
437d03ea40b1
6703888: Compressed Oops: use the 32-bits gap after klass in a object
kvn
parents:
113
diff
changeset
|
52 size_t hs = align_size_up(length_offset_in_bytes() + sizeof(int), |
437d03ea40b1
6703888: Compressed Oops: use the 32-bits gap after klass in a object
kvn
parents:
113
diff
changeset
|
53 HeapWordSize); |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
54 #ifdef ASSERT |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
55 // make sure it isn't called before UseCompressedOops is initialized. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
56 static size_t arrayoopdesc_hs = 0; |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
57 if (arrayoopdesc_hs == 0) arrayoopdesc_hs = hs; |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
58 assert(arrayoopdesc_hs == hs, "header size can't change"); |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
59 #endif // ASSERT |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
60 return (int)hs; |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
61 } |
0 | 62 |
63 public: | |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
64 // The _length field is not declared in C++. It is allocated after the |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
65 // declared nonstatic fields in arrayOopDesc if not compressed, otherwise |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
66 // it occupies the second half of the _klass field in oopDesc. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
67 static int length_offset_in_bytes() { |
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
4708
diff
changeset
|
68 return UseCompressedKlassPointers ? klass_gap_offset_in_bytes() : |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
69 sizeof(arrayOopDesc); |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
70 } |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
71 |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
72 // Returns the offset of the first element. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
73 static int base_offset_in_bytes(BasicType type) { |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
74 return header_size(type) * HeapWordSize; |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
75 } |
0 | 76 |
77 // Returns the address of the first element. | |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
78 void* base(BasicType type) const { |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
79 return (void*) (((intptr_t) this) + base_offset_in_bytes(type)); |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
80 } |
0 | 81 |
82 // Tells whether index is within bounds. | |
83 bool is_within_bounds(int index) const { return 0 <= index && index < length(); } | |
84 | |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
85 // Accessors for instance variable which is not a C++ declared nonstatic |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
86 // field. |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
87 int length() const { |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
88 return *(int*)(((intptr_t)this) + length_offset_in_bytes()); |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
89 } |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
90 void set_length(int length) { |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
91 *(int*)(((intptr_t)this) + length_offset_in_bytes()) = length; |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
92 } |
0 | 93 |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
94 // Should only be called with constants as argument |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
95 // (will not constant fold otherwise) |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
96 // Returns the header size in words aligned to the requirements of the |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
97 // array object type. |
0 | 98 static int header_size(BasicType type) { |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
99 size_t typesize_in_bytes = header_size_in_bytes(); |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
100 return (int)(Universe::element_type_should_be_aligned(type) |
1571
2d127394260e
6916623: Align object to 16 bytes to use Compressed Oops with java heap up to 64Gb
kvn
parents:
579
diff
changeset
|
101 ? align_object_offset(typesize_in_bytes/HeapWordSize) |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
29
diff
changeset
|
102 : typesize_in_bytes/HeapWordSize); |
0 | 103 } |
104 | |
481
7d7a7c599c17
6578152: fill_region_with_object has usability and safety issues
jcoomes
parents:
196
diff
changeset
|
105 // Return the maximum length of an array of BasicType. The length can passed |
7d7a7c599c17
6578152: fill_region_with_object has usability and safety issues
jcoomes
parents:
196
diff
changeset
|
106 // to typeArrayOop::object_size(scale, length, header_size) without causing an |
4070
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
107 // overflow. We also need to make sure that this will not overflow a size_t on |
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
108 // 32 bit platforms when we convert it to a byte size. |
0 | 109 static int32_t max_array_length(BasicType type) { |
110 assert(type >= 0 && type < T_CONFLICT, "wrong type"); | |
29
d5fc211aea19
6633953: type2aelembytes{T_ADDRESS} should be 8 bytes in 64 bit VM
kvn
parents:
0
diff
changeset
|
111 assert(type2aelembytes(type) != 0, "wrong type"); |
4070
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
112 |
4075
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
113 const size_t max_element_words_per_size_t = |
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
114 align_size_down((SIZE_MAX/HeapWordSize - header_size(type)), MinObjAlignment); |
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
115 const size_t max_elements_per_size_t = |
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
116 HeapWordSize * max_element_words_per_size_t / type2aelembytes(type); |
4070
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
117 if ((size_t)max_jint < max_elements_per_size_t) { |
4075
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
118 // It should be ok to return max_jint here, but parts of the code |
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
119 // (CollectedHeap, Klass::oop_oop_iterate(), and more) uses an int for |
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
120 // passing around the size (in words) of an object. So, we need to avoid |
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
121 // overflowing an int when we add the header. See CRs 4718400 and 7110613. |
aa4c21b00f7f
7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow
brutisso
parents:
4070
diff
changeset
|
122 return align_size_down(max_jint - header_size(type), MinObjAlignment); |
481
7d7a7c599c17
6578152: fill_region_with_object has usability and safety issues
jcoomes
parents:
196
diff
changeset
|
123 } |
4070
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
124 return (int32_t)max_elements_per_size_t; |
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
125 } |
481
7d7a7c599c17
6578152: fill_region_with_object has usability and safety issues
jcoomes
parents:
196
diff
changeset
|
126 |
4070
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
127 // for unit testing |
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
128 #ifndef PRODUCT |
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
129 static bool check_max_length_overflow(BasicType type); |
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
130 static int32_t old_max_array_length(BasicType type); |
4708 | 131 static void test_max_array_length(); |
4070
6fd81579526f
7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise
brutisso
parents:
1972
diff
changeset
|
132 #endif |
0 | 133 }; |
1972 | 134 |
135 #endif // SHARE_VM_OOPS_ARRAYOOP_HPP |