Mercurial > hg > graal-compiler
annotate src/os_cpu/linux_x86/vm/atomic_linux_x86.inline.hpp @ 2030:fb712ff22571
7000559: G1: assertion failure !outer || (full_collections_started == _full_collections_completed + 1)
Summary: The concurrent marking thread can complete its operation and increment the full GC counter during a Full GC. This causes the nesting of increments to the start and end of Full GCs that we are expecting to be wrong. the fix is for the marking thread to join the suspendible thread set before incrementing the counter so that it's blocked until the Full GC (or any other safepoint) is finished. The change also includes some minor code cleanup (I renamed a parameter).
Reviewed-by: brutisso, ysr
| author | tonyp |
|---|---|
| date | Tue, 14 Dec 2010 16:19:44 -0500 |
| parents | f95d63e2154a |
| children | 4fc084dac61e |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 1972 | 2 * Copyright (c) 1999, 2010, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
0
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #ifndef OS_CPU_LINUX_X86_VM_ATOMIC_LINUX_X86_INLINE_HPP |
| 26 #define OS_CPU_LINUX_X86_VM_ATOMIC_LINUX_X86_INLINE_HPP | |
| 27 | |
| 28 #include "orderAccess_linux_x86.inline.hpp" | |
| 29 #include "runtime/atomic.hpp" | |
| 30 #include "runtime/os.hpp" | |
| 31 #include "vm_version_x86.hpp" | |
| 32 | |
| 0 | 33 // Implementation of class atomic |
| 34 | |
| 35 inline void Atomic::store (jbyte store_value, jbyte* dest) { *dest = store_value; } | |
| 36 inline void Atomic::store (jshort store_value, jshort* dest) { *dest = store_value; } | |
| 37 inline void Atomic::store (jint store_value, jint* dest) { *dest = store_value; } | |
| 38 inline void Atomic::store_ptr(intptr_t store_value, intptr_t* dest) { *dest = store_value; } | |
| 39 inline void Atomic::store_ptr(void* store_value, void* dest) { *(void**)dest = store_value; } | |
| 40 | |
| 41 inline void Atomic::store (jbyte store_value, volatile jbyte* dest) { *dest = store_value; } | |
| 42 inline void Atomic::store (jshort store_value, volatile jshort* dest) { *dest = store_value; } | |
| 43 inline void Atomic::store (jint store_value, volatile jint* dest) { *dest = store_value; } | |
| 44 inline void Atomic::store_ptr(intptr_t store_value, volatile intptr_t* dest) { *dest = store_value; } | |
| 45 inline void Atomic::store_ptr(void* store_value, volatile void* dest) { *(void* volatile *)dest = store_value; } | |
| 46 | |
| 47 | |
| 48 // Adding a lock prefix to an instruction on MP machine | |
| 49 #define LOCK_IF_MP(mp) "cmp $0, " #mp "; je 1f; lock; 1: " | |
| 50 | |
| 51 inline jint Atomic::add (jint add_value, volatile jint* dest) { | |
| 52 jint addend = add_value; | |
| 53 int mp = os::is_MP(); | |
| 54 __asm__ volatile ( LOCK_IF_MP(%3) "xaddl %0,(%2)" | |
| 55 : "=r" (addend) | |
| 56 : "0" (addend), "r" (dest), "r" (mp) | |
| 57 : "cc", "memory"); | |
| 58 return addend + add_value; | |
| 59 } | |
| 60 | |
| 61 inline void Atomic::inc (volatile jint* dest) { | |
| 62 int mp = os::is_MP(); | |
| 63 __asm__ volatile (LOCK_IF_MP(%1) "addl $1,(%0)" : | |
| 64 : "r" (dest), "r" (mp) : "cc", "memory"); | |
| 65 } | |
| 66 | |
| 67 inline void Atomic::inc_ptr(volatile void* dest) { | |
| 68 inc_ptr((volatile intptr_t*)dest); | |
| 69 } | |
| 70 | |
| 71 inline void Atomic::dec (volatile jint* dest) { | |
| 72 int mp = os::is_MP(); | |
| 73 __asm__ volatile (LOCK_IF_MP(%1) "subl $1,(%0)" : | |
| 74 : "r" (dest), "r" (mp) : "cc", "memory"); | |
| 75 } | |
| 76 | |
| 77 inline void Atomic::dec_ptr(volatile void* dest) { | |
| 78 dec_ptr((volatile intptr_t*)dest); | |
| 79 } | |
| 80 | |
| 81 inline jint Atomic::xchg (jint exchange_value, volatile jint* dest) { | |
| 82 __asm__ volatile ( "xchgl (%2),%0" | |
| 83 : "=r" (exchange_value) | |
| 84 : "0" (exchange_value), "r" (dest) | |
| 85 : "memory"); | |
| 86 return exchange_value; | |
| 87 } | |
| 88 | |
| 89 inline void* Atomic::xchg_ptr(void* exchange_value, volatile void* dest) { | |
| 90 return (void*)xchg_ptr((intptr_t)exchange_value, (volatile intptr_t*)dest); | |
| 91 } | |
| 92 | |
| 93 | |
| 94 inline jint Atomic::cmpxchg (jint exchange_value, volatile jint* dest, jint compare_value) { | |
| 95 int mp = os::is_MP(); | |
| 96 __asm__ volatile (LOCK_IF_MP(%4) "cmpxchgl %1,(%3)" | |
| 97 : "=a" (exchange_value) | |
| 98 : "r" (exchange_value), "a" (compare_value), "r" (dest), "r" (mp) | |
| 99 : "cc", "memory"); | |
| 100 return exchange_value; | |
| 101 } | |
| 102 | |
| 103 extern "C" { | |
| 104 // defined in linux_x86.s | |
| 105 jlong _Atomic_cmpxchg_long(jlong, volatile jlong*, jlong, bool); | |
| 106 } | |
| 107 | |
| 108 #ifdef AMD64 | |
| 109 inline void Atomic::store (jlong store_value, jlong* dest) { *dest = store_value; } | |
| 110 inline void Atomic::store (jlong store_value, volatile jlong* dest) { *dest = store_value; } | |
| 111 | |
| 112 inline intptr_t Atomic::add_ptr(intptr_t add_value, volatile intptr_t* dest) { | |
| 113 intptr_t addend = add_value; | |
| 114 bool mp = os::is_MP(); | |
| 115 __asm__ __volatile__ (LOCK_IF_MP(%3) "xaddq %0,(%2)" | |
| 116 : "=r" (addend) | |
| 117 : "0" (addend), "r" (dest), "r" (mp) | |
| 118 : "cc", "memory"); | |
| 119 return addend + add_value; | |
| 120 } | |
| 121 | |
| 122 inline void* Atomic::add_ptr(intptr_t add_value, volatile void* dest) { | |
| 123 return (void*)add_ptr(add_value, (volatile intptr_t*)dest); | |
| 124 } | |
| 125 | |
| 126 inline void Atomic::inc_ptr(volatile intptr_t* dest) { | |
| 127 bool mp = os::is_MP(); | |
| 128 __asm__ __volatile__ (LOCK_IF_MP(%1) "addq $1,(%0)" | |
| 129 : | |
| 130 : "r" (dest), "r" (mp) | |
| 131 : "cc", "memory"); | |
| 132 } | |
| 133 | |
| 134 inline void Atomic::dec_ptr(volatile intptr_t* dest) { | |
| 135 bool mp = os::is_MP(); | |
| 136 __asm__ __volatile__ (LOCK_IF_MP(%1) "subq $1,(%0)" | |
| 137 : | |
| 138 : "r" (dest), "r" (mp) | |
| 139 : "cc", "memory"); | |
| 140 } | |
| 141 | |
| 142 inline intptr_t Atomic::xchg_ptr(intptr_t exchange_value, volatile intptr_t* dest) { | |
| 143 __asm__ __volatile__ ("xchgq (%2),%0" | |
| 144 : "=r" (exchange_value) | |
| 145 : "0" (exchange_value), "r" (dest) | |
| 146 : "memory"); | |
| 147 return exchange_value; | |
| 148 } | |
| 149 | |
| 150 inline jlong Atomic::cmpxchg (jlong exchange_value, volatile jlong* dest, jlong compare_value) { | |
| 151 bool mp = os::is_MP(); | |
| 152 __asm__ __volatile__ (LOCK_IF_MP(%4) "cmpxchgq %1,(%3)" | |
| 153 : "=a" (exchange_value) | |
| 154 : "r" (exchange_value), "a" (compare_value), "r" (dest), "r" (mp) | |
| 155 : "cc", "memory"); | |
| 156 return exchange_value; | |
| 157 } | |
| 158 | |
| 159 inline intptr_t Atomic::cmpxchg_ptr(intptr_t exchange_value, volatile intptr_t* dest, intptr_t compare_value) { | |
| 160 return (intptr_t)cmpxchg((jlong)exchange_value, (volatile jlong*)dest, (jlong)compare_value); | |
| 161 } | |
| 162 | |
| 163 inline void* Atomic::cmpxchg_ptr(void* exchange_value, volatile void* dest, void* compare_value) { | |
| 164 return (void*)cmpxchg((jlong)exchange_value, (volatile jlong*)dest, (jlong)compare_value); | |
| 165 } | |
| 166 | |
| 167 #else | |
| 168 //inline void Atomic::store (jlong store_value, jlong* dest) { *dest = store_value; } | |
| 169 //inline void Atomic::store (jlong store_value, volatile jlong* dest) { *dest = store_value; } | |
| 170 | |
| 171 inline intptr_t Atomic::add_ptr(intptr_t add_value, volatile intptr_t* dest) { | |
| 172 return (intptr_t)Atomic::add((jint)add_value, (volatile jint*)dest); | |
| 173 } | |
| 174 | |
| 175 inline void* Atomic::add_ptr(intptr_t add_value, volatile void* dest) { | |
| 176 return (void*)Atomic::add((jint)add_value, (volatile jint*)dest); | |
| 177 } | |
| 178 | |
| 179 | |
| 180 inline void Atomic::inc_ptr(volatile intptr_t* dest) { | |
| 181 inc((volatile jint*)dest); | |
| 182 } | |
| 183 | |
| 184 inline void Atomic::dec_ptr(volatile intptr_t* dest) { | |
| 185 dec((volatile jint*)dest); | |
| 186 } | |
| 187 | |
| 188 inline intptr_t Atomic::xchg_ptr(intptr_t exchange_value, volatile intptr_t* dest) { | |
| 189 return (intptr_t)xchg((jint)exchange_value, (volatile jint*)dest); | |
| 190 } | |
| 191 | |
| 192 inline jlong Atomic::cmpxchg (jlong exchange_value, volatile jlong* dest, jlong compare_value) { | |
| 193 return _Atomic_cmpxchg_long(exchange_value, dest, compare_value, os::is_MP()); | |
| 194 } | |
| 195 | |
| 196 inline intptr_t Atomic::cmpxchg_ptr(intptr_t exchange_value, volatile intptr_t* dest, intptr_t compare_value) { | |
| 197 return (intptr_t)cmpxchg((jint)exchange_value, (volatile jint*)dest, (jint)compare_value); | |
| 198 } | |
| 199 | |
| 200 inline void* Atomic::cmpxchg_ptr(void* exchange_value, volatile void* dest, void* compare_value) { | |
| 201 return (void*)cmpxchg((jint)exchange_value, (volatile jint*)dest, (jint)compare_value); | |
| 202 } | |
| 203 #endif // AMD64 | |
| 1972 | 204 |
| 205 #endif // OS_CPU_LINUX_X86_VM_ATOMIC_LINUX_X86_INLINE_HPP |