Mercurial > hg > graal-compiler
annotate src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp @ 2030:fb712ff22571
7000559: G1: assertion failure !outer || (full_collections_started == _full_collections_completed + 1)
Summary: The concurrent marking thread can complete its operation and increment the full GC counter during a Full GC. This causes the nesting of increments to the start and end of Full GCs that we are expecting to be wrong. the fix is for the marking thread to join the suspendible thread set before incrementing the counter so that it's blocked until the Full GC (or any other safepoint) is finished. The change also includes some minor code cleanup (I renamed a parameter).
Reviewed-by: brutisso, ysr
| author | tonyp |
|---|---|
| date | Tue, 14 Dec 2010 16:19:44 -0500 |
| parents | f95d63e2154a |
| children | 4fc084dac61e |
| rev | line source |
|---|---|
| 0 | 1 /* |
|
1711
a6bff45449bc
6973570: OrderAccess::storestore() scales poorly on multi-socket x64 and sparc: cache-line ping-ponging
ysr
parents:
1552
diff
changeset
|
2 * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
844
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
844
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
844
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #ifndef OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_INLINE_HPP |
| 26 #define OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_INLINE_HPP | |
| 27 | |
| 28 #include "runtime/orderAccess.hpp" | |
| 29 #include "vm_version_x86.hpp" | |
| 30 | |
| 0 | 31 // Implementation of class OrderAccess. |
| 32 | |
| 33 // For Sun Studio - implementation is in solaris_i486.il. | |
| 34 // For gcc - implementation is just below. | |
| 35 extern "C" void _OrderAccess_acquire(); | |
| 36 extern "C" void _OrderAccess_fence(); | |
| 37 | |
| 38 inline void OrderAccess::loadload() { acquire(); } | |
| 39 inline void OrderAccess::storestore() { release(); } | |
| 40 inline void OrderAccess::loadstore() { acquire(); } | |
| 41 inline void OrderAccess::storeload() { fence(); } | |
| 42 | |
| 43 inline void OrderAccess::acquire() { | |
| 44 _OrderAccess_acquire(); | |
| 45 | |
| 46 } | |
| 47 | |
| 48 inline void OrderAccess::release() { | |
|
1711
a6bff45449bc
6973570: OrderAccess::storestore() scales poorly on multi-socket x64 and sparc: cache-line ping-ponging
ysr
parents:
1552
diff
changeset
|
49 // Avoid hitting the same cache-line from |
|
a6bff45449bc
6973570: OrderAccess::storestore() scales poorly on multi-socket x64 and sparc: cache-line ping-ponging
ysr
parents:
1552
diff
changeset
|
50 // different threads. |
|
a6bff45449bc
6973570: OrderAccess::storestore() scales poorly on multi-socket x64 and sparc: cache-line ping-ponging
ysr
parents:
1552
diff
changeset
|
51 volatile jint local_dummy = 0; |
| 0 | 52 } |
| 53 | |
| 54 inline void OrderAccess::fence() { | |
| 55 if (os::is_MP()) { | |
| 56 _OrderAccess_fence(); | |
| 57 } | |
| 58 } | |
| 59 | |
| 60 #ifdef _GNU_SOURCE | |
| 61 | |
| 62 extern "C" { | |
| 63 inline void _OrderAccess_acquire() { | |
|
1711
a6bff45449bc
6973570: OrderAccess::storestore() scales poorly on multi-socket x64 and sparc: cache-line ping-ponging
ysr
parents:
1552
diff
changeset
|
64 volatile intptr_t local_dummy; |
| 0 | 65 #ifdef AMD64 |
|
1711
a6bff45449bc
6973570: OrderAccess::storestore() scales poorly on multi-socket x64 and sparc: cache-line ping-ponging
ysr
parents:
1552
diff
changeset
|
66 __asm__ volatile ("movq 0(%%rsp), %0" : "=r" (local_dummy) : : "memory"); |
| 0 | 67 #else |
|
1711
a6bff45449bc
6973570: OrderAccess::storestore() scales poorly on multi-socket x64 and sparc: cache-line ping-ponging
ysr
parents:
1552
diff
changeset
|
68 __asm__ volatile ("movl 0(%%esp),%0" : "=r" (local_dummy) : : "memory"); |
| 0 | 69 #endif // AMD64 |
| 70 } | |
| 71 inline void _OrderAccess_fence() { | |
|
671
d0994e5bebce
6822204: volatile fences should prefer lock:addl to actual mfence instructions
never
parents:
0
diff
changeset
|
72 // Always use locked addl since mfence is sometimes expensive |
| 0 | 73 __asm__ volatile ("lock; addl $0,0(%%esp)" : : : "cc", "memory"); |
| 74 } | |
| 75 | |
| 76 } | |
| 77 | |
| 78 #endif // GNU_SOURCE | |
| 79 | |
| 80 inline jbyte OrderAccess::load_acquire(volatile jbyte* p) { return *p; } | |
| 81 inline jshort OrderAccess::load_acquire(volatile jshort* p) { return *p; } | |
| 82 inline jint OrderAccess::load_acquire(volatile jint* p) { return *p; } | |
| 83 inline jlong OrderAccess::load_acquire(volatile jlong* p) { return *p; } | |
| 84 inline jubyte OrderAccess::load_acquire(volatile jubyte* p) { return *p; } | |
| 85 inline jushort OrderAccess::load_acquire(volatile jushort* p) { return *p; } | |
| 86 inline juint OrderAccess::load_acquire(volatile juint* p) { return *p; } | |
| 87 inline julong OrderAccess::load_acquire(volatile julong* p) { return *p; } | |
| 88 inline jfloat OrderAccess::load_acquire(volatile jfloat* p) { return *p; } | |
| 89 inline jdouble OrderAccess::load_acquire(volatile jdouble* p) { return *p; } | |
| 90 | |
| 91 inline intptr_t OrderAccess::load_ptr_acquire(volatile intptr_t* p) { return *p; } | |
| 92 inline void* OrderAccess::load_ptr_acquire(volatile void* p) { return *(void* volatile *)p; } | |
| 93 inline void* OrderAccess::load_ptr_acquire(const volatile void* p) { return *(void* const volatile *)p; } | |
| 94 | |
| 95 inline void OrderAccess::release_store(volatile jbyte* p, jbyte v) { *p = v; } | |
| 96 inline void OrderAccess::release_store(volatile jshort* p, jshort v) { *p = v; } | |
| 97 inline void OrderAccess::release_store(volatile jint* p, jint v) { *p = v; } | |
| 98 inline void OrderAccess::release_store(volatile jlong* p, jlong v) { *p = v; } | |
| 99 inline void OrderAccess::release_store(volatile jubyte* p, jubyte v) { *p = v; } | |
| 100 inline void OrderAccess::release_store(volatile jushort* p, jushort v) { *p = v; } | |
| 101 inline void OrderAccess::release_store(volatile juint* p, juint v) { *p = v; } | |
| 102 inline void OrderAccess::release_store(volatile julong* p, julong v) { *p = v; } | |
| 103 inline void OrderAccess::release_store(volatile jfloat* p, jfloat v) { *p = v; } | |
| 104 inline void OrderAccess::release_store(volatile jdouble* p, jdouble v) { *p = v; } | |
| 105 | |
| 106 inline void OrderAccess::release_store_ptr(volatile intptr_t* p, intptr_t v) { *p = v; } | |
| 107 inline void OrderAccess::release_store_ptr(volatile void* p, void* v) { *(void* volatile *)p = v; } | |
| 108 | |
| 109 inline void OrderAccess::store_fence(jbyte* p, jbyte v) { *p = v; fence(); } | |
| 110 inline void OrderAccess::store_fence(jshort* p, jshort v) { *p = v; fence(); } | |
| 111 inline void OrderAccess::store_fence(jint* p, jint v) { *p = v; fence(); } | |
| 112 inline void OrderAccess::store_fence(jlong* p, jlong v) { *p = v; fence(); } | |
| 113 inline void OrderAccess::store_fence(jubyte* p, jubyte v) { *p = v; fence(); } | |
| 114 inline void OrderAccess::store_fence(jushort* p, jushort v) { *p = v; fence(); } | |
| 115 inline void OrderAccess::store_fence(juint* p, juint v) { *p = v; fence(); } | |
| 116 inline void OrderAccess::store_fence(julong* p, julong v) { *p = v; fence(); } | |
| 117 inline void OrderAccess::store_fence(jfloat* p, jfloat v) { *p = v; fence(); } | |
| 118 inline void OrderAccess::store_fence(jdouble* p, jdouble v) { *p = v; fence(); } | |
| 119 | |
| 120 inline void OrderAccess::store_ptr_fence(intptr_t* p, intptr_t v) { *p = v; fence(); } | |
| 121 inline void OrderAccess::store_ptr_fence(void** p, void* v) { *p = v; fence(); } | |
| 122 | |
| 123 inline void OrderAccess::release_store_fence(volatile jbyte* p, jbyte v) { *p = v; fence(); } | |
| 124 inline void OrderAccess::release_store_fence(volatile jshort* p, jshort v) { *p = v; fence(); } | |
| 125 inline void OrderAccess::release_store_fence(volatile jint* p, jint v) { *p = v; fence(); } | |
| 126 inline void OrderAccess::release_store_fence(volatile jlong* p, jlong v) { *p = v; fence(); } | |
| 127 inline void OrderAccess::release_store_fence(volatile jubyte* p, jubyte v) { *p = v; fence(); } | |
| 128 inline void OrderAccess::release_store_fence(volatile jushort* p, jushort v) { *p = v; fence(); } | |
| 129 inline void OrderAccess::release_store_fence(volatile juint* p, juint v) { *p = v; fence(); } | |
| 130 inline void OrderAccess::release_store_fence(volatile julong* p, julong v) { *p = v; fence(); } | |
| 131 inline void OrderAccess::release_store_fence(volatile jfloat* p, jfloat v) { *p = v; fence(); } | |
| 132 inline void OrderAccess::release_store_fence(volatile jdouble* p, jdouble v) { *p = v; fence(); } | |
| 133 | |
| 134 inline void OrderAccess::release_store_ptr_fence(volatile intptr_t* p, intptr_t v) { *p = v; fence(); } | |
| 135 inline void OrderAccess::release_store_ptr_fence(volatile void* p, void* v) { *(void* volatile *)p = v; fence(); } | |
| 1972 | 136 |
| 137 #endif // OS_CPU_SOLARIS_X86_VM_ORDERACCESS_SOLARIS_X86_INLINE_HPP |