Mercurial > hg > graal-compiler
annotate src/os_cpu/solaris_x86/vm/solaris_x86_32.il @ 2030:fb712ff22571
7000559: G1: assertion failure !outer || (full_collections_started == _full_collections_completed + 1)
Summary: The concurrent marking thread can complete its operation and increment the full GC counter during a Full GC. This causes the nesting of increments to the start and end of Full GCs that we are expecting to be wrong. the fix is for the marking thread to join the suspendible thread set before incrementing the counter so that it's blocked until the Full GC (or any other safepoint) is finished. The change also includes some minor code cleanup (I renamed a parameter).
Reviewed-by: brutisso, ysr
| author | tonyp |
|---|---|
| date | Tue, 14 Dec 2010 16:19:44 -0500 |
| parents | c18cbe5936b8 |
| children | 0a8e0d4345b3 4fc084dac61e |
| rev | line source |
|---|---|
| 0 | 1 // |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1547
diff
changeset
|
2 // Copyright (c) 2003, 2009, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 // DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 // | |
| 5 // This code is free software; you can redistribute it and/or modify it | |
| 6 // under the terms of the GNU General Public License version 2 only, as | |
| 7 // published by the Free Software Foundation. | |
| 8 // | |
| 9 // This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 // ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 // FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 // version 2 for more details (a copy is included in the LICENSE file that | |
| 13 // accompanied this code). | |
| 14 // | |
| 15 // You should have received a copy of the GNU General Public License version | |
| 16 // 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 // Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 // | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1547
diff
changeset
|
19 // Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1547
diff
changeset
|
20 // or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1547
diff
changeset
|
21 // questions. |
| 0 | 22 // |
| 23 // | |
| 24 | |
| 25 | |
| 26 // Support for u8 os::setup_fpu() | |
| 27 .inline _solaris_raw_setup_fpu,1 | |
| 28 movl 0(%esp), %eax | |
| 29 fldcw (%eax) | |
| 30 .end | |
| 31 | |
| 32 // The argument size of each inline directive is ignored by the compiler | |
| 33 // and is set to 0 for compatibility reason. | |
| 34 | |
| 35 // Get the raw thread ID from %gs:0 | |
| 36 .inline _raw_thread_id,0 | |
| 37 movl %gs:0, %eax | |
| 38 .end | |
| 39 | |
|
472
7b920868b475
6773838: There is no calling stack for Compiler thread in hs_err file on x86
coleenp
parents:
0
diff
changeset
|
40 // Get current fp |
|
7b920868b475
6773838: There is no calling stack for Compiler thread in hs_err file on x86
coleenp
parents:
0
diff
changeset
|
41 .inline _get_current_fp,0 |
|
7b920868b475
6773838: There is no calling stack for Compiler thread in hs_err file on x86
coleenp
parents:
0
diff
changeset
|
42 .volatile |
| 0 | 43 movl %ebp, %eax |
| 44 .end | |
| 45 | |
| 46 // Support for jint Atomic::add(jint inc, volatile jint* dest) | |
| 47 // An additional bool (os::is_MP()) is passed as the last argument. | |
| 48 .inline _Atomic_add,3 | |
| 49 movl 0(%esp), %eax // inc | |
| 50 movl 4(%esp), %edx // dest | |
| 51 movl %eax, %ecx | |
| 52 cmpl $0, 8(%esp) // MP test | |
|
1547
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
53 jne 1f |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
54 xaddl %eax, (%edx) |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
55 jmp 2f |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
56 1: lock |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
57 xaddl %eax, (%edx) |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
58 2: addl %ecx, %eax |
| 0 | 59 .end |
| 60 | |
| 61 // Support for jint Atomic::xchg(jint exchange_value, volatile jint* dest). | |
| 62 .inline _Atomic_xchg,2 | |
| 63 movl 0(%esp), %eax // exchange_value | |
| 64 movl 4(%esp), %ecx // dest | |
| 65 xchgl (%ecx), %eax | |
| 66 .end | |
| 67 | |
| 68 // Support for jint Atomic::cmpxchg(jint exchange_value, | |
| 69 // volatile jint *dest, | |
| 70 // jint compare_value) | |
| 71 // An additional bool (os::is_MP()) is passed as the last argument. | |
| 72 .inline _Atomic_cmpxchg,4 | |
| 73 movl 8(%esp), %eax // compare_value | |
| 74 movl 0(%esp), %ecx // exchange_value | |
| 75 movl 4(%esp), %edx // dest | |
| 76 cmp $0, 12(%esp) // MP test | |
|
1547
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
77 jne 1f |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
78 cmpxchgl %ecx, (%edx) |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
79 jmp 2f |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
80 1: lock |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
81 cmpxchgl %ecx, (%edx) |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
82 2: |
| 0 | 83 .end |
| 84 | |
| 85 // Support for jlong Atomic::cmpxchg(jlong exchange_value, | |
| 86 // volatile jlong* dest, | |
| 87 // jlong compare_value) | |
| 88 // An additional bool (os::is_MP()) is passed as the last argument. | |
| 89 .inline _Atomic_cmpxchg_long,6 | |
| 90 pushl %ebx | |
| 91 pushl %edi | |
| 92 movl 20(%esp), %eax // compare_value (low) | |
| 93 movl 24(%esp), %edx // compare_value (high) | |
| 94 movl 16(%esp), %edi // dest | |
| 95 movl 8(%esp), %ebx // exchange_value (low) | |
| 96 movl 12(%esp), %ecx // exchange_high (high) | |
| 97 cmp $0, 28(%esp) // MP test | |
|
1547
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
98 jne 1f |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
99 cmpxchg8b (%edi) |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
100 jmp 2f |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
101 1: lock |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
102 cmpxchg8b (%edi) |
|
fb1a39993f69
6951319: enable solaris builds using Sun Studio 12 update 1
jcoomes
parents:
894
diff
changeset
|
103 2: popl %edi |
| 0 | 104 popl %ebx |
| 105 .end | |
| 106 | |
|
894
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
107 // Support for void Atomic::load(volatile jlong* src, volatile jlong* dest). |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
108 .inline _Atomic_load_long,2 |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
109 movl 0(%esp), %eax // src |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
110 fildll (%eax) |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
111 movl 4(%esp), %eax // dest |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
112 fistpll (%eax) |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
113 .end |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
114 |
|
665be97e8704
6863420: os::javaTimeNanos() go backward on Solaris x86
kvn
parents:
579
diff
changeset
|
115 |
| 0 | 116 // Support for OrderAccess::acquire() |
| 117 .inline _OrderAccess_acquire,0 | |
| 118 movl 0(%esp), %eax | |
| 119 .end | |
| 120 | |
| 121 // Support for OrderAccess::fence() | |
| 122 .inline _OrderAccess_fence,0 | |
| 123 lock | |
| 124 addl $0, (%esp) | |
| 125 .end | |
| 126 | |
| 127 // Support for u2 Bytes::swap_u2(u2 x) | |
| 128 .inline _raw_swap_u2,1 | |
| 129 movl 0(%esp), %eax | |
| 130 xchgb %al, %ah | |
| 131 .end | |
| 132 | |
| 133 // Support for u4 Bytes::swap_u4(u4 x) | |
| 134 .inline _raw_swap_u4,1 | |
| 135 movl 0(%esp), %eax | |
| 136 bswap %eax | |
| 137 .end | |
| 138 | |
| 139 // Support for u8 Bytes::swap_u8_base(u4 x, u4 y) | |
| 140 .inline _raw_swap_u8,2 | |
| 141 movl 4(%esp), %eax // y | |
| 142 movl 0(%esp), %edx // x | |
| 143 bswap %eax | |
| 144 bswap %edx | |
| 145 .end |