Mercurial > hg > graal-compiler
comparison src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp @ 20504:6948da6d7c13
8052172: Evacuation failure handling in G1 does not evacuate all objects if -XX:-G1DeferredRSUpdate is set
Summary: Remove -XX:-G1DeferredRSUpdate functionality as it is racy. During evacuation failure handling, threads where evacuation failure handling occurred may try to add remembered sets to regions which remembered sets are currently being scanned. The iterator to handle the remembered set scan does not support addition of entries during scan and so may skip valid references.
Reviewed-by: iveresov, brutisso, mgerdin
author | tschatzl |
---|---|
date | Tue, 30 Sep 2014 09:44:36 +0200 |
parents | 7baf47cb97cb |
children |
comparison
equal
deleted
inserted
replaced
20503:fa56205f142c | 20504:6948da6d7c13 |
---|---|
234 } | 234 } |
235 | 235 |
236 _last_gc_worker_times_ms.verify(); | 236 _last_gc_worker_times_ms.verify(); |
237 _last_gc_worker_other_times_ms.verify(); | 237 _last_gc_worker_other_times_ms.verify(); |
238 | 238 |
239 if (G1DeferredRSUpdate) { | 239 _last_redirty_logged_cards_time_ms.verify(); |
240 _last_redirty_logged_cards_time_ms.verify(); | 240 _last_redirty_logged_cards_processed_cards.verify(); |
241 _last_redirty_logged_cards_processed_cards.verify(); | |
242 } | |
243 } | 241 } |
244 | 242 |
245 void G1GCPhaseTimes::note_string_dedup_fixup_start() { | 243 void G1GCPhaseTimes::note_string_dedup_fixup_start() { |
246 _cur_string_dedup_queue_fixup_worker_times_ms.reset(); | 244 _cur_string_dedup_queue_fixup_worker_times_ms.reset(); |
247 _cur_string_dedup_table_fixup_worker_times_ms.reset(); | 245 _cur_string_dedup_table_fixup_worker_times_ms.reset(); |
349 print_stats(2, "Choose CSet", | 347 print_stats(2, "Choose CSet", |
350 (_recorded_young_cset_choice_time_ms + | 348 (_recorded_young_cset_choice_time_ms + |
351 _recorded_non_young_cset_choice_time_ms)); | 349 _recorded_non_young_cset_choice_time_ms)); |
352 print_stats(2, "Ref Proc", _cur_ref_proc_time_ms); | 350 print_stats(2, "Ref Proc", _cur_ref_proc_time_ms); |
353 print_stats(2, "Ref Enq", _cur_ref_enq_time_ms); | 351 print_stats(2, "Ref Enq", _cur_ref_enq_time_ms); |
354 if (G1DeferredRSUpdate) { | 352 print_stats(2, "Redirty Cards", _recorded_redirty_logged_cards_time_ms); |
355 print_stats(2, "Redirty Cards", _recorded_redirty_logged_cards_time_ms); | 353 if (G1Log::finest()) { |
356 if (G1Log::finest()) { | 354 _last_redirty_logged_cards_time_ms.print(3, "Parallel Redirty"); |
357 _last_redirty_logged_cards_time_ms.print(3, "Parallel Redirty"); | 355 _last_redirty_logged_cards_processed_cards.print(3, "Redirtied Cards"); |
358 _last_redirty_logged_cards_processed_cards.print(3, "Redirtied Cards"); | |
359 } | |
360 } | 356 } |
361 if (G1ReclaimDeadHumongousObjectsAtYoungGC) { | 357 if (G1ReclaimDeadHumongousObjectsAtYoungGC) { |
362 print_stats(2, "Humongous Reclaim", _cur_fast_reclaim_humongous_time_ms); | 358 print_stats(2, "Humongous Reclaim", _cur_fast_reclaim_humongous_time_ms); |
363 if (G1Log::finest()) { | 359 if (G1Log::finest()) { |
364 print_stats(3, "Humongous Total", _cur_fast_reclaim_humongous_total); | 360 print_stats(3, "Humongous Total", _cur_fast_reclaim_humongous_total); |