Mercurial > hg > graal-compiler

comparison src/share/vm/gc_implementation/g1/ptrQueue.hpp @ 1842:6e0aac35bfa9

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue Summary: Under certain circumstances a safepoint could happen between a JavaThread object being created and that object being added to the Java threads list. This could cause the active field of that thread's SATB queue to get out-of-sync with respect to the other Java threads. The solution is to activate the SATB queue, when necessary, before adding the thread to the Java threads list, not when the JavaThread object is created. The changeset also includes a small fix to rename the surrogate locker thread from "Surrogate Locker Thread (CMS)" to "Surrogate Locker Thread (Concurrent GC)" since it's also used in G1. Reviewed-by: iveresov, ysr, johnc, jcoomes
author tonyp
date Fri, 01 Oct 2010 16:43:05 -0400
parents c18cbe5936b8
children f95d63e2154a
comparison
equal deleted inserted replaced
1841:32a1f7bf0c21 1842:6e0aac35bfa9
85 void enqueue_known_active(void* ptr); 85 void enqueue_known_active(void* ptr);
86 86
87 size_t size() { 87 size_t size() {
88 assert(_sz >= _index, "Invariant."); 88 assert(_sz >= _index, "Invariant.");
89 return _buf == NULL ? 0 : _sz - _index; 89 return _buf == NULL ? 0 : _sz - _index;
90 }
91
92 bool is_empty() {
93 return _buf == NULL || _sz == _index;
90 } 94 }
91 95
92 // Set the "active" property of the queue to "b". An enqueue to an 96 // Set the "active" property of the queue to "b". An enqueue to an
93 // inactive thread is a no-op. Setting a queue to inactive resets its 97 // inactive thread is a no-op. Setting a queue to inactive resets its
94 // log to the empty state. 98 // log to the empty state.