comparison src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp @ 20503:fa56205f142c

8057799: Unnecessary NULL check in G1KeepAliveClosure Reviewed-by: tschatzl, stefank
author tonyp
date Wed, 10 Sep 2014 11:55:33 +0200
parents 7baf47cb97cb
children 6948da6d7c13
comparison
equal deleted inserted replaced
20502:13dbe89e447c 20503:fa56205f142c
5356 public: 5356 public:
5357 G1KeepAliveClosure(G1CollectedHeap* g1) : _g1(g1) {} 5357 G1KeepAliveClosure(G1CollectedHeap* g1) : _g1(g1) {}
5358 void do_oop(narrowOop* p) { guarantee(false, "Not needed"); } 5358 void do_oop(narrowOop* p) { guarantee(false, "Not needed"); }
5359 void do_oop(oop* p) { 5359 void do_oop(oop* p) {
5360 oop obj = *p; 5360 oop obj = *p;
5361 assert(obj != NULL, "the caller should have filtered out NULL values");
5361 5362
5362 G1CollectedHeap::in_cset_state_t cset_state = _g1->in_cset_state(obj); 5363 G1CollectedHeap::in_cset_state_t cset_state = _g1->in_cset_state(obj);
5363 if (obj == NULL || cset_state == G1CollectedHeap::InNeither) { 5364 if (cset_state == G1CollectedHeap::InNeither) {
5364 return; 5365 return;
5365 } 5366 }
5366 if (cset_state == G1CollectedHeap::InCSet) { 5367 if (cset_state == G1CollectedHeap::InCSet) {
5367 assert( obj->is_forwarded(), "invariant" ); 5368 assert( obj->is_forwarded(), "invariant" );
5368 *p = obj->forwardee(); 5369 *p = obj->forwardee();