Mercurial > hg > graal-compiler
diff src/share/vm/prims/jvmtiImpl.cpp @ 611:2f716c0acb64
6567360: 3/4 SIGBUS in jvmti RawMonitor magic check for unaligned bad monitor pointer
Summary: Change JvmtiEnvBase::is_valid() and JvmtiRawMonitor::is_valid() to fetch the _magic fields via Bytes::get_native_u[248]().
Reviewed-by: coleenp, swamyv
| author | dcubed |
|---|---|
| date | Mon, 02 Mar 2009 14:05:07 -0700 |
| parents | a61af66fc99e |
| children | c18cbe5936b8 |
line wrap: on
line diff
--- a/src/share/vm/prims/jvmtiImpl.cpp Mon Mar 02 14:03:03 2009 -0700 +++ b/src/share/vm/prims/jvmtiImpl.cpp Mon Mar 02 14:05:07 2009 -0700 @@ -238,6 +238,35 @@ } +bool +JvmtiRawMonitor::is_valid() { + int value = 0; + + // This object might not be a JvmtiRawMonitor so we can't assume + // the _magic field is properly aligned. Get the value in a safe + // way and then check against JVMTI_RM_MAGIC. + + switch (sizeof(_magic)) { + case 2: + value = Bytes::get_native_u2((address)&_magic); + break; + + case 4: + value = Bytes::get_native_u4((address)&_magic); + break; + + case 8: + value = Bytes::get_native_u8((address)&_magic); + break; + + default: + guarantee(false, "_magic field is an unexpected size"); + } + + return value == JVMTI_RM_MAGIC; +} + + // // class JvmtiBreakpoint //