Mercurial > hg > graal-compiler

diff src/share/vm/memory/allocation.cpp @ 7176:59c790074993

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8003635: NPG: AsynchGetCallTrace broken by Method* virtual call Summary: Make metaspace::contains be lock free and used to see if something is in metaspace, also compare Method* with vtbl pointer. Reviewed-by: dholmes, sspitsyn, dcubed, jmasa
author coleenp
date Wed, 28 Nov 2012 17:50:21 -0500
parents 716c64bda5ba
children 6f817ce50129 f75faf51e8c4
line wrap: on
line diff
--- a/src/share/vm/memory/allocation.cpp	Wed Nov 28 08:43:26 2012 -0800
+++ b/src/share/vm/memory/allocation.cpp	Wed Nov 28 17:50:21 2012 -0500
@@ -66,10 +66,17 @@
 }
 
 bool MetaspaceObj::is_metadata() const {
-  // ClassLoaderDataGraph::contains((address)this); has lock inversion problems
+  // GC Verify checks use this in guarantees.
+  // TODO: either replace them with is_metaspace_object() or remove them.
+  // is_metaspace_object() is slower than this test.  This test doesn't
+  // seem very useful for metaspace objects anymore though.
   return !Universe::heap()->is_in_reserved(this);
 }
 
+bool MetaspaceObj::is_metaspace_object() const {
+  return Metaspace::contains((void*)this);
+}
+
 void MetaspaceObj::print_address_on(outputStream* st) const {
   st->print(" {"INTPTR_FORMAT"}", this);
 }