Mercurial > hg > graal-compiler
view src/share/vm/ci/ciInstance.hpp @ 18036:00cf2b6f51b9 hs25.20-b23
8050978: Fix bad field access check in C1 and C2
Summary: JCK8 test vm/constantpool/accessControl/accessControl004/accessControl00402m3/accessControl00402m3.html fails with -Xbatch -Xcomp due to bad field access check in C1 and C2. Fix: In ciField::ciField(), just before the canonical holder is stored into the _holder variable (and which is used by ciField::will_link()) perform an additional access check with the holder declared in the class file. If this check fails, store the declared holder instead and ciField::will_link() will bail out compilation for this field later on. Then, the interpreter will throw an PrivilegedAccessException at runtime.
Reviewed-by: kvn, vlivanov
Contributed-by: andreas.schoesser@sap.com
author | goetz |
---|---|
date | Fri, 18 Jul 2014 09:04:01 +0200 |
parents | c7f3d0b4570f |
children |
line wrap: on
line source
/* * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ #ifndef SHARE_VM_CI_CIINSTANCE_HPP #define SHARE_VM_CI_CIINSTANCE_HPP #include "ci/ciObject.hpp" #include "oops/instanceOop.hpp" // ciInstance // // This class represents an instanceOop in the HotSpot virtual // machine. This is an oop which corresponds to a non-array // instance of java.lang.Object. class ciInstance : public ciObject { CI_PACKAGE_ACCESS protected: ciInstance(instanceHandle h_i) : ciObject(h_i) { assert(h_i()->is_instance(), "wrong type"); } ciInstance(ciKlass* klass) : ciObject(klass) {} instanceOop get_instanceOop() { return (instanceOop)get_oop(); } const char* type_string() { return "ciInstance"; } void print_impl(outputStream* st); public: // If this object is a java mirror, return the corresponding type. // Otherwise, return NULL. // (Remember that a java mirror is an instance of java.lang.Class.) ciType* java_mirror_type(); // What kind of ciObject is this? bool is_instance() { return true; } bool is_java_object() { return true; } // Constant value of a field. ciConstant field_value(ciField* field); // Constant value of a field at the specified offset. ciConstant field_value_by_offset(int field_offset); ciKlass* java_lang_Class_klass(); }; #endif // SHARE_VM_CI_CIINSTANCE_HPP