Mercurial > hg > graal-compiler
view visualizer/Filter/src/com/sun/hotspot/igv/filter/RemoveFilter.java @ 11825:463f51256c86
AMD64HotSpot: emit jump to IC miss handler directly instead of emitting it inside verfied_entry
for empty methods we emitted something like this if a inline cache is needed:
prefix:
00: < IC check >
...
0b: jne <ic_miss_call>
11: nop
...
verified_entry:
20: ret
ic_miss_call:
21: jmp <entry of runtime function>
when a method is deoptimized, HotSpot patches the verified_entry (0x20) with a
jump to a stub that handles call-sites that has been made non-entrant. since this jump
is 5 bytes long, it will overwrite ic_miss_call and blow up every caller that
calls this method via the unverified entry (prefix).
the fix is to emit the jump to the runtime function inside the unverfied entry:
prefix:
00: < IC check >
...
0b: je <verified_entry>
11: jeq <entry of runtime function>
16: nop
...
verified_entry:
20: ret
author | Bernhard Urban <bernhard.urban@jku.at> |
---|---|
date | Mon, 30 Sep 2013 09:32:18 +0200 |
parents | 015fb895586b |
children |
line wrap: on
line source
/* * Copyright (c) 2008, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ package com.sun.hotspot.igv.filter; import com.sun.hotspot.igv.graph.Diagram; import com.sun.hotspot.igv.graph.Figure; import com.sun.hotspot.igv.graph.Selector; import java.util.ArrayList; import java.util.HashSet; import java.util.List; import java.util.Set; /** * * @author Thomas Wuerthinger */ public class RemoveFilter extends AbstractFilter { private List<RemoveRule> rules; private String name; public RemoveFilter(String name) { this.name = name; rules = new ArrayList<>(); } @Override public String getName() { return name; } @Override public void apply(Diagram diagram) { for (RemoveRule r : rules) { List<Figure> selected = r.getSelector().selected(diagram); Set<Figure> toRemove = new HashSet<>(selected); if (r.getRemoveOrphans()) { boolean changed; do { changed = false; for (Figure f : diagram.getFigures()) { if (!toRemove.contains(f)) { if (toRemove.containsAll(f.getPredecessors()) && toRemove.containsAll(f.getSuccessors())) { toRemove.add(f); changed = true; } } } } while (changed); } diagram.removeAllFigures(toRemove); } } public void addRule(RemoveRule rule) { rules.add(rule); } public static class RemoveRule { private Selector selector; private boolean removeOrphans; public RemoveRule(Selector selector) { this(selector, false); } public RemoveRule(Selector selector, boolean removeOrphans) { this.selector = selector; this.removeOrphans = removeOrphans; } public Selector getSelector() { return selector; } public boolean getRemoveOrphans() { return removeOrphans; } } }