Mercurial > hg > graal-compiler
view src/cpu/x86/vm/stubRoutines_x86_64.hpp @ 1047:beb8f45ee9f0
6889740: G1: OpenDS fails with "unhandled exception in compiled code"
Summary: Incorrect code was being generated for the store operation in the null case of the aastore bytecode template. The bad code was generated by the store_heap_oop routine which takes a Register as its second argument. Passing NULL_WORD (0) as the second argument causes the value to be converted to Register(0), which is rax. Thus the generated store was "mov (dst), $rax" instead of "mov (dst), $0x0". Changed calls to store_heap_oop that pass NULL_WORD as the second argument to a new routine store_heap_oop_null.
Reviewed-by: kvn, twisti
author | johnc |
---|---|
date | Thu, 29 Oct 2009 09:42:26 -0700 |
parents | 9ee9cf798b59 |
children | 9eba43136cb5 |
line wrap: on
line source
/* * Copyright 2003-2008 Sun Microsystems, Inc. All Rights Reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, * CA 95054 USA or visit www.sun.com if you need additional information or * have any questions. * */ // This file holds the platform specific parts of the StubRoutines // definition. See stubRoutines.hpp for a description on how to // extend it. static bool returns_to_call_stub(address return_pc) { return return_pc == _call_stub_return_address; } enum platform_dependent_constants { code_size1 = 19000, // simply increase if too small (assembler will // crash if too small) code_size2 = 22000 // simply increase if too small (assembler will // crash if too small) }; class x86 { friend class StubGenerator; private: static address _get_previous_fp_entry; static address _verify_mxcsr_entry; static address _f2i_fixup; static address _f2l_fixup; static address _d2i_fixup; static address _d2l_fixup; static address _float_sign_mask; static address _float_sign_flip; static address _double_sign_mask; static address _double_sign_flip; static address _mxcsr_std; public: static address get_previous_fp_entry() { return _get_previous_fp_entry; } static address verify_mxcsr_entry() { return _verify_mxcsr_entry; } static address f2i_fixup() { return _f2i_fixup; } static address f2l_fixup() { return _f2l_fixup; } static address d2i_fixup() { return _d2i_fixup; } static address d2l_fixup() { return _d2l_fixup; } static address float_sign_mask() { return _float_sign_mask; } static address float_sign_flip() { return _float_sign_flip; } static address double_sign_mask() { return _double_sign_mask; } static address double_sign_flip() { return _double_sign_flip; } static address mxcsr_std() { return _mxcsr_std; } };