Mercurial > hg > graal-compiler
view src/share/vm/oops/methodCounters.hpp @ 10185:d50cc62e94ff
8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t
Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime.
Reviewed-by: twisti, johnc
Contributed-by: Martin Doerr <martin.doerr@sap.com>
author | johnc |
---|---|
date | Wed, 24 Apr 2013 14:48:43 -0700 |
parents | aeaca88565e6 |
children | 836a62f43af9 631667807de7 |
line wrap: on
line source
/* * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ #ifndef SHARE_VM_OOPS_METHODCOUNTERS_HPP #define SHARE_VM_OOPS_METHODCOUNTERS_HPP #include "oops/metadata.hpp" #include "interpreter/invocationCounter.hpp" class MethodCounters: public MetaspaceObj { friend class VMStructs; private: int _interpreter_invocation_count; // Count of times invoked (reused as prev_event_count in tiered) u2 _interpreter_throwout_count; // Count of times method was exited via exception while interpreting u2 _number_of_breakpoints; // fullspeed debugging support InvocationCounter _invocation_counter; // Incremented before each activation of the method - used to trigger frequency-based optimizations InvocationCounter _backedge_counter; // Incremented before each backedge taken - used to trigger frequencey-based optimizations #ifdef TIERED float _rate; // Events (invocation and backedge counter increments) per millisecond jlong _prev_time; // Previous time the rate was acquired #endif MethodCounters() : _interpreter_invocation_count(0), _interpreter_throwout_count(0), _number_of_breakpoints(0) #ifdef TIERED , _rate(0), _prev_time(0) #endif { invocation_counter()->init(); backedge_counter()->init(); } public: static MethodCounters* allocate(ClassLoaderData* loader_data, TRAPS); void deallocate_contents(ClassLoaderData* loader_data) {} DEBUG_ONLY(bool on_stack() { return false; }) // for template static int size() { return sizeof(MethodCounters) / wordSize; } bool is_klass() const { return false; } void clear_counters(); int interpreter_invocation_count() { return _interpreter_invocation_count; } void set_interpreter_invocation_count(int count) { _interpreter_invocation_count = count; } int increment_interpreter_invocation_count() { return ++_interpreter_invocation_count; } void interpreter_throwout_increment() { if (_interpreter_throwout_count < 65534) { _interpreter_throwout_count++; } } int interpreter_throwout_count() const { return _interpreter_throwout_count; } void set_interpreter_throwout_count(int count) { _interpreter_throwout_count = count; } u2 number_of_breakpoints() const { return _number_of_breakpoints; } void incr_number_of_breakpoints() { ++_number_of_breakpoints; } void decr_number_of_breakpoints() { --_number_of_breakpoints; } void clear_number_of_breakpoints() { _number_of_breakpoints = 0; } #ifdef TIERED jlong prev_time() const { return _prev_time; } void set_prev_time(jlong time) { _prev_time = time; } float rate() const { return _rate; } void set_rate(float rate) { _rate = rate; } #endif // invocation counter InvocationCounter* invocation_counter() { return &_invocation_counter; } InvocationCounter* backedge_counter() { return &_backedge_counter; } static ByteSize interpreter_invocation_counter_offset() { return byte_offset_of(MethodCounters, _interpreter_invocation_count); } static ByteSize invocation_counter_offset() { return byte_offset_of(MethodCounters, _invocation_counter); } static ByteSize backedge_counter_offset() { return byte_offset_of(MethodCounters, _backedge_counter); } static int interpreter_invocation_counter_offset_in_bytes() { return offset_of(MethodCounters, _interpreter_invocation_count); } }; #endif //SHARE_VM_OOPS_METHODCOUNTERS_HPP