Mercurial > hg > graal-compiler
view src/share/vm/runtime/fieldDescriptor.cpp @ 10185:d50cc62e94ff
8012715: G1: GraphKit accesses PtrQueue::_index as int but is size_t
Summary: In graphKit INT operations were generated to access PtrQueue::_index which has type size_t. This is 64 bit on 64-bit machines. No problems occur on little endian machines as long as the index fits into 32 bit, but on big endian machines the upper part is read, which is zero. This leads to unnecessary branches to the slow path in the runtime.
Reviewed-by: twisti, johnc
Contributed-by: Martin Doerr <martin.doerr@sap.com>
author | johnc |
---|---|
date | Wed, 24 Apr 2013 14:48:43 -0700 |
parents | 927a311d00f9 |
children | 0f7ca53be929 b2e698d2276c |
line wrap: on
line source
/* * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. * */ #include "precompiled.hpp" #include "classfile/systemDictionary.hpp" #include "classfile/vmSymbols.hpp" #include "memory/resourceArea.hpp" #include "memory/universe.inline.hpp" #include "oops/annotations.hpp" #include "oops/instanceKlass.hpp" #include "oops/fieldStreams.hpp" #include "runtime/fieldDescriptor.hpp" #include "runtime/handles.inline.hpp" #include "runtime/signature.hpp" oop fieldDescriptor::loader() const { return _cp->pool_holder()->class_loader(); } Symbol* fieldDescriptor::generic_signature() const { if (!has_generic_signature()) { return NULL; } int idx = 0; InstanceKlass* ik = field_holder(); for (AllFieldStream fs(ik); !fs.done(); fs.next()) { if (idx == _index) { return fs.generic_signature(); } else { idx ++; } } assert(false, "should never happen"); return NULL; } AnnotationArray* fieldDescriptor::annotations() const { InstanceKlass* ik = field_holder(); Array<AnnotationArray*>* md = ik->fields_annotations(); if (md == NULL) return NULL; return md->at(index()); } AnnotationArray* fieldDescriptor::type_annotations() const { InstanceKlass* ik = field_holder(); Array<AnnotationArray*>* type_annos = ik->fields_type_annotations(); if (type_annos == NULL) return NULL; return type_annos->at(index()); } constantTag fieldDescriptor::initial_value_tag() const { return constants()->tag_at(initial_value_index()); } jint fieldDescriptor::int_initial_value() const { return constants()->int_at(initial_value_index()); } jlong fieldDescriptor::long_initial_value() const { return constants()->long_at(initial_value_index()); } jfloat fieldDescriptor::float_initial_value() const { return constants()->float_at(initial_value_index()); } jdouble fieldDescriptor::double_initial_value() const { return constants()->double_at(initial_value_index()); } oop fieldDescriptor::string_initial_value(TRAPS) const { return constants()->uncached_string_at(initial_value_index(), CHECK_0); } void fieldDescriptor::initialize(InstanceKlass* ik, int index) { _cp = ik->constants(); FieldInfo* f = ik->field(index); assert(!f->is_internal(), "regular Java fields only"); _access_flags = accessFlags_from(f->access_flags()); guarantee(f->name_index() != 0 && f->signature_index() != 0, "bad constant pool index for fieldDescriptor"); _index = index; } #ifndef PRODUCT void fieldDescriptor::print_on(outputStream* st) const { access_flags().print_on(st); name()->print_value_on(st); st->print(" "); signature()->print_value_on(st); st->print(" @%d ", offset()); if (WizardMode && has_initial_value()) { st->print("(initval "); constantTag t = initial_value_tag(); if (t.is_int()) { st->print("int %d)", int_initial_value()); } else if (t.is_long()){ st->print_jlong(long_initial_value()); } else if (t.is_float()){ st->print("float %f)", float_initial_value()); } else if (t.is_double()){ st->print("double %lf)", double_initial_value()); } } } void fieldDescriptor::print_on_for(outputStream* st, oop obj) { print_on(st); BasicType ft = field_type(); jint as_int = 0; switch (ft) { case T_BYTE: as_int = (jint)obj->byte_field(offset()); st->print(" %d", obj->byte_field(offset())); break; case T_CHAR: as_int = (jint)obj->char_field(offset()); { jchar c = obj->char_field(offset()); as_int = c; st->print(" %c %d", isprint(c) ? c : ' ', c); } break; case T_DOUBLE: st->print(" %lf", obj->double_field(offset())); break; case T_FLOAT: as_int = obj->int_field(offset()); st->print(" %f", obj->float_field(offset())); break; case T_INT: as_int = obj->int_field(offset()); st->print(" %d", obj->int_field(offset())); break; case T_LONG: st->print(" "); st->print_jlong(obj->long_field(offset())); break; case T_SHORT: as_int = obj->short_field(offset()); st->print(" %d", obj->short_field(offset())); break; case T_BOOLEAN: as_int = obj->bool_field(offset()); st->print(" %s", obj->bool_field(offset()) ? "true" : "false"); break; case T_ARRAY: st->print(" "); NOT_LP64(as_int = obj->int_field(offset())); obj->obj_field(offset())->print_value_on(st); break; case T_OBJECT: st->print(" "); NOT_LP64(as_int = obj->int_field(offset())); obj->obj_field(offset())->print_value_on(st); break; default: ShouldNotReachHere(); break; } // Print a hint as to the underlying integer representation. This can be wrong for // pointers on an LP64 machine if (ft == T_LONG || ft == T_DOUBLE LP64_ONLY(|| !is_java_primitive(ft)) ) { st->print(" (%x %x)", obj->int_field(offset()), obj->int_field(offset()+sizeof(jint))); } else if (as_int < 0 || as_int > 9) { st->print(" (%x)", as_int); } } #endif /* PRODUCT */