# HG changeset patch # User Doug Simon # Date 1396371074 -7200 # Node ID 31a9c79399c8616dcdbd9efe01f066fba70e5024 # Parent 3e06a56ab0e675774de11b3806d99e18a367e783 disabled current Checkstyle configurations (until Checkstyle supports Java8) diff -r 3e06a56ab0e6 -r 31a9c79399c8 graal/com.oracle.graal.graph/.checkstyle_checks.xml --- a/graal/com.oracle.graal.graph/.checkstyle_checks.xml Tue Apr 01 15:50:55 2014 +0200 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,211 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff -r 3e06a56ab0e6 -r 31a9c79399c8 graal/com.oracle.graal.graph/.checkstyle_checks.xml.disabled --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/graal/com.oracle.graal.graph/.checkstyle_checks.xml.disabled Tue Apr 01 18:51:14 2014 +0200 @@ -0,0 +1,211 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff -r 3e06a56ab0e6 -r 31a9c79399c8 graal/com.oracle.truffle.api/.checkstyle_checks.xml --- a/graal/com.oracle.truffle.api/.checkstyle_checks.xml Tue Apr 01 15:50:55 2014 +0200 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,206 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff -r 3e06a56ab0e6 -r 31a9c79399c8 graal/com.oracle.truffle.api/.checkstyle_checks.xml.disabled --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/graal/com.oracle.truffle.api/.checkstyle_checks.xml.disabled Tue Apr 01 18:51:14 2014 +0200 @@ -0,0 +1,206 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff -r 3e06a56ab0e6 -r 31a9c79399c8 mx/mx_graal.py --- a/mx/mx_graal.py Tue Apr 01 15:50:55 2014 +0200 +++ b/mx/mx_graal.py Tue Apr 01 18:51:14 2014 +0200 @@ -1710,7 +1710,7 @@ if p.native: continue - csConfig = join(mx.project(p.checkstyleProj).dir, '.checkstyle_checks.xml') + csConfig = join(mx.project(p.checkstyleProj).dir, '.checkstyle_checks.xml.disabled') dom = xml.dom.minidom.parse(csConfig) for module in dom.getElementsByTagName('module'): if module.getAttribute('name') == 'RegexpHeader': diff -r 3e06a56ab0e6 -r 31a9c79399c8 mxtool/mx.py --- a/mxtool/mx.py Tue Apr 01 15:50:55 2014 +0200 +++ b/mxtool/mx.py Tue Apr 01 18:51:14 2014 +0200 @@ -2372,10 +2372,10 @@ if p.native: continue sourceDirs = p.source_dirs() - dotCheckstyle = join(p.dir, '.checkstyle') - - if not exists(dotCheckstyle): - abort('ERROR: .checkstyle for Project {0} is missing'.format(p.name)) + + csConfig = join(p.dir, '.checkstyle_checks.xml') + if not exists(csConfig): + abort('ERROR: Checkstyle configuration for project {} is missing: {}'.format(p.name, csConfig)) # skip checking this Java project if its Java compliance level is "higher" than the configured JDK jdk = java(p.javaCompliance) @@ -2403,7 +2403,7 @@ log('[all Java sources in {0} already checked - skipping]'.format(sourceDir)) continue - dotCheckstyleXML = xml.dom.minidom.parse(dotCheckstyle) + dotCheckstyleXML = xml.dom.minidom.parse(csConfig) localCheckConfig = dotCheckstyleXML.getElementsByTagName('local-check-config')[0] configLocation = localCheckConfig.getAttribute('location') configType = localCheckConfig.getAttribute('type') @@ -2901,6 +2901,11 @@ out.close('fileset-config') update_file(dotCheckstyle, out.xml(indent=' ', newl='\n')) files.append(dotCheckstyle) + else: + # clean up existing .checkstyle file + dotCheckstyle = join(p.dir, ".checkstyle") + if exists(dotCheckstyle): + os.unlink(dotCheckstyle) out = XMLDoc() out.open('projectDescription') @@ -3548,6 +3553,7 @@ shutil.rmtree(join(p.dir, '.externalToolBuilders'), ignore_errors=True) shutil.rmtree(join(p.dir, 'nbproject'), ignore_errors=True) rm(join(p.dir, '.classpath')) + rm(join(p.dir, '.checkstyle')) rm(join(p.dir, '.project')) rm(join(p.dir, '.factorypath')) rm(join(p.dir, 'build.xml'))