# HG changeset patch # User Tom Rodriguez # Date 1422399247 28800 # Node ID 479d2d030bf38f3c5d9b898dfcedf1df5161b38c # Parent 48b79b8e18f1fcd9174cfdca8e49ac1fc3b4ff3b Fix inline policy of EdgesTest to ensure stable results diff -r 48b79b8e18f1 -r 479d2d030bf3 graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/policy/InlineEverythingPolicy.java --- a/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/policy/InlineEverythingPolicy.java Tue Jan 27 23:19:40 2015 +0100 +++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/policy/InlineEverythingPolicy.java Tue Jan 27 14:54:07 2015 -0800 @@ -29,7 +29,7 @@ import static com.oracle.graal.compiler.common.GraalOptions.MaximumDesiredSize; -public final class InlineEverythingPolicy implements InliningPolicy { +public class InlineEverythingPolicy implements InliningPolicy { public boolean continueInlining(StructuredGraph graph) { if (graph.getNodeCount() >= MaximumDesiredSize.getValue()) { diff -r 48b79b8e18f1 -r 479d2d030bf3 graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/policy/InlineMethodSubstitutionsPolicy.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/policy/InlineMethodSubstitutionsPolicy.java Tue Jan 27 14:54:07 2015 -0800 @@ -0,0 +1,47 @@ +/* + * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ +package com.oracle.graal.phases.common.inlining.policy; + +import com.oracle.graal.api.meta.*; +import com.oracle.graal.nodes.*; +import com.oracle.graal.nodes.java.*; +import com.oracle.graal.nodes.spi.*; +import com.oracle.graal.phases.common.inlining.walker.*; + +/** + * Inline every method which would be replaced by a substitution. Useful for testing purposes. + */ +public final class InlineMethodSubstitutionsPolicy extends InlineEverythingPolicy { + + @Override + public boolean isWorthInlining(Replacements replacements, MethodInvocation invocation, int inliningDepth, boolean fullyProcessed) { + CallTargetNode callTarget = invocation.callee().invoke().callTarget(); + if (callTarget instanceof MethodCallTargetNode) { + ResolvedJavaMethod calleeMethod = ((MethodCallTargetNode) callTarget).targetMethod(); + if (replacements.getMethodSubstitution(calleeMethod) != null) { + return true; + } + } + return false; + } +} diff -r 48b79b8e18f1 -r 479d2d030bf3 graal/com.oracle.graal.replacements.test/src/com/oracle/graal/replacements/test/EdgesTest.java --- a/graal/com.oracle.graal.replacements.test/src/com/oracle/graal/replacements/test/EdgesTest.java Tue Jan 27 23:19:40 2015 +0100 +++ b/graal/com.oracle.graal.replacements.test/src/com/oracle/graal/replacements/test/EdgesTest.java Tue Jan 27 14:54:07 2015 -0800 @@ -38,6 +38,7 @@ import com.oracle.graal.phases.*; import com.oracle.graal.phases.common.*; import com.oracle.graal.phases.common.inlining.*; +import com.oracle.graal.phases.common.inlining.policy.*; import com.oracle.graal.phases.tiers.*; public class EdgesTest extends GraalCompilerTest { @@ -115,7 +116,7 @@ StructuredGraph g = parseProfiled(javaMethod); Assumptions assumptions = new Assumptions(false); HighTierContext context = new HighTierContext(getProviders(), assumptions, null, getDefaultGraphBuilderSuite(), OptimisticOptimizations.ALL); - new InliningPhase(new CanonicalizerPhase(true)).apply(g, context); + new InliningPhase(new InlineMethodSubstitutionsPolicy(), new CanonicalizerPhase(true)).apply(g, context); new CanonicalizerPhase(false).apply(g, context); Assert.assertTrue(g.getNodes().filter(CheckCastNode.class).isEmpty()); }