# HG changeset patch # User Bernhard Urban # Date 1368456433 -7200 # Node ID 8f2f4c9e2dcfbd3a1c8a935cd8d8c3340e985e77 # Parent 843dde5a83afd79a68ce9675a884b7d108d2c6cd VerifyValueUsage: use method name and signature instead of `toString()' diff -r 843dde5a83af -r 8f2f4c9e2dcf graal/com.oracle.graal.phases/src/com/oracle/graal/phases/verify/VerifyValueUsage.java --- a/graal/com.oracle.graal.phases/src/com/oracle/graal/phases/verify/VerifyValueUsage.java Mon May 13 16:37:57 2013 +0200 +++ b/graal/com.oracle.graal.phases/src/com/oracle/graal/phases/verify/VerifyValueUsage.java Mon May 13 16:47:13 2013 +0200 @@ -51,7 +51,8 @@ @Override protected boolean verify(StructuredGraph graph) { for (ObjectEqualsNode cn : graph.getNodes().filter(ObjectEqualsNode.class)) { - if (!graph.method().toString().endsWith("equals(Object)>")) { + Signature signature = graph.method().getSignature(); + if (!(graph.method().getName().equals("equals") && signature.getParameterCount(false) == 1 && signature.getParameterKind(0).equals(Kind.Object))) { assert !((checkType(cn.x()) && !(cn.y() instanceof ConstantNode)) || (checkType(cn.y()) && !(cn.x() instanceof ConstantNode))) : "VerifyValueUsage: " + cn.x() + " or " + cn.y() + " in " + graph.method() + " uses object identity. Should use equals() instead."; }