Mercurial > hg > graal-compiler
changeset 11069:5ea20b3bd249
8017070: G1: assert(_card_counts[card_num] <= G1ConcRSHotCardLimit) failed
Summary: The assert is invalid when a card is being refined by two different threads and its count crosses the hot threshold - the refinement count will be updated once by each thread triggering the assert. Remove the assert and update the count using a bounded expression.
Reviewed-by: jmasa, tamao, brutisso
author | johnc |
---|---|
date | Mon, 01 Jul 2013 09:30:23 -0700 |
parents | b30744960351 |
children | 6e3634222155 |
files | src/share/vm/gc_implementation/g1/g1CardCounts.cpp |
diffstat | 1 files changed, 2 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/g1/g1CardCounts.cpp Sun Jun 30 21:42:07 2013 +0200 +++ b/src/share/vm/gc_implementation/g1/g1CardCounts.cpp Mon Jul 01 09:30:23 2013 -0700 @@ -152,12 +152,9 @@ if (card_num < _committed_max_card_num) { count = (uint) _card_counts[card_num]; if (count < G1ConcRSHotCardLimit) { - _card_counts[card_num] += 1; + _card_counts[card_num] = + (jubyte)(MIN2((uintx)(_card_counts[card_num] + 1), G1ConcRSHotCardLimit)); } - assert(_card_counts[card_num] <= G1ConcRSHotCardLimit, - err_msg("Refinement count overflow? " - "new count: "UINT32_FORMAT, - (uint) _card_counts[card_num])); } } return count;