Mercurial > hg > graal-compiler
changeset 20038:bbf53b35292e
added Checkstyle rule to forbid use of old synchronized classes such as StringBuffer, Vector, Hashtable and Stack
author | Doug Simon <doug.simon@oracle.com> |
---|---|
date | Thu, 26 Mar 2015 11:38:27 +0100 |
parents | 4d119424b4ce |
children | c38296febf23 |
files | graal/com.oracle.graal.graph/.checkstyle_checks.xml graal/com.oracle.truffle.api/.checkstyle_checks.xml graal/com.oracle.truffle.api/src/com/oracle/truffle/api/source/Source.java |
diffstat | 3 files changed, 12 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/graal/com.oracle.graal.graph/.checkstyle_checks.xml Wed Mar 25 11:48:13 2015 -0700 +++ b/graal/com.oracle.graal.graph/.checkstyle_checks.xml Thu Mar 26 11:38:27 2015 +0100 @@ -122,9 +122,13 @@ <property name="format" value=" ,"/> <property name="message" value="illegal space before a comma"/> <property name="ignoreComments" value="true"/> + <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Checks for whitespace before a comma."/> <metadata name="com.atlassw.tools.eclipse.checkstyle.customMessage" value="Illegal whitespace before a comma."/> - <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Checks for whitespace before a comma."/> </module> + <module name="RegexpSinglelineJava"> + <property name="format" value="new (Hashtable|Vector|Stack|StringBuffer)[^\w]"/> + <property name="message" value="Don't use old synchronized collection classes"/> + </module> </module> <module name="RegexpHeader"> <property name="header" value="/\*\n \* Copyright \(c\) (20[0-9][0-9], )?20[0-9][0-9], Oracle and/or its affiliates. All rights reserved.\n \* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.\n \*\n \* This code is free software; you can redistribute it and/or modify it\n \* under the terms of the GNU General Public License version 2 only, as\n \* published by the Free Software Foundation.\n \*\n \* This code is distributed in the hope that it will be useful, but WITHOUT\n \* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n \* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License\n \* version 2 for more details \(a copy is included in the LICENSE file that\n \* accompanied this code\).\n \*\n \* You should have received a copy of the GNU General Public License version\n \* 2 along with this work; if not, write to the Free Software Foundation,\n \* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.\n \*\n \* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA\n \* or visit www.oracle.com if you need additional information or have any\n \* questions.\n \*/\n"/>
--- a/graal/com.oracle.truffle.api/.checkstyle_checks.xml Wed Mar 25 11:48:13 2015 -0700 +++ b/graal/com.oracle.truffle.api/.checkstyle_checks.xml Thu Mar 26 11:38:27 2015 +0100 @@ -5,7 +5,7 @@ This configuration file was written by the eclipse-cs plugin configuration editor --> <!-- - Checkstyle-Configuration: Maxine Checks + Checkstyle-Configuration: Checks Description: none --> <module name="Checker"> @@ -122,8 +122,12 @@ <property name="format" value=" ,"/> <property name="message" value="illegal space before a comma"/> <property name="ignoreComments" value="true"/> + <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Checks for whitespace before a comma."/> <metadata name="com.atlassw.tools.eclipse.checkstyle.customMessage" value="Illegal whitespace before a comma."/> - <metadata name="com.atlassw.tools.eclipse.checkstyle.comment" value="Checks for whitespace before a comma."/> + </module> + <module name="RegexpSinglelineJava"> + <property name="format" value="new (Hashtable|Vector|Stack|StringBuffer)[^\w]"/> + <property name="message" value="Don't use old synchronized collection classes"/> </module> </module> <module name="RegexpHeader">
--- a/graal/com.oracle.truffle.api/src/com/oracle/truffle/api/source/Source.java Wed Mar 25 11:48:13 2015 -0700 +++ b/graal/com.oracle.truffle.api/src/com/oracle/truffle/api/source/Source.java Thu Mar 26 11:38:27 2015 +0100 @@ -84,7 +84,7 @@ private static final List<WeakReference<Source>> allSources = Collections.synchronizedList(new ArrayList<WeakReference<Source>>()); // Files and pseudo files are indexed. - private static final Map<String, WeakReference<Source>> filePathToSource = new Hashtable<>(); + private static final Map<String, WeakReference<Source>> filePathToSource = new HashMap<>(); private static boolean fileCacheEnabled = true;