Mercurial > hg > graal-compiler

changeset 15758:c4f012d2b58b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
[inlining-3] readability of checkInvokeConditions() part 2 of 2
author Miguel Garcia <miguel.m.garcia@oracle.com>
date Mon, 19 May 2014 14:57:10 +0200
parents ce5b2557396a
children fbeb421666cd
files graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/InliningUtil.java
diffstat 1 files changed, 4 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/InliningUtil.java	Mon May 19 14:51:44 2014 +0200
+++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/InliningUtil.java	Mon May 19 14:57:10 2014 +0200
@@ -470,7 +470,8 @@
         if (!(invoke.callTarget() instanceof MethodCallTargetNode)) {
             return "the invoke has already been lowered, or has been created as a low-level node";
         }
-        if (((MethodCallTargetNode) invoke.callTarget()).targetMethod() == null) {
+        MethodCallTargetNode callTarget = (MethodCallTargetNode) invoke.callTarget();
+        if (callTarget.targetMethod() == null) {
             return "target method is null";
         }
         if (invoke.stateAfter() == null) {
@@ -480,8 +481,8 @@
         if (!invoke.useForInlining()) {
             return "the invoke is marked to be not used for inlining";
         }
-        if (((MethodCallTargetNode) invoke.callTarget()).receiver() != null && ((MethodCallTargetNode) invoke.callTarget()).receiver().isConstant() &&
-                        ((MethodCallTargetNode) invoke.callTarget()).receiver().asConstant().isNull()) {
+        ValueNode receiver = callTarget.receiver();
+        if (receiver != null && receiver.isConstant() && receiver.asConstant().isNull()) {
             return "receiver is null";
         }
         return null;