Mercurial > hg > graal-compiler
changeset 13270:d86dc1b84973
modified ProfilingInfoTest to better handle variability in profiling info provided by the runtime
author | Doug Simon <doug.simon@oracle.com> |
---|---|
date | Mon, 09 Dec 2013 18:13:58 +0100 |
parents | 8950e87ffcc9 |
children | 038f55aab194 5a3491b0c2f0 |
files | graal/com.oracle.graal.api.meta/src/com/oracle/graal/api/meta/MetaUtil.java graal/com.oracle.graal.compiler.test/src/com/oracle/graal/compiler/test/ProfilingInfoTest.java |
diffstat | 2 files changed, 23 insertions(+), 10 deletions(-) [+] |
line wrap: on
line diff
--- a/graal/com.oracle.graal.api.meta/src/com/oracle/graal/api/meta/MetaUtil.java Mon Dec 09 17:03:57 2013 +0100 +++ b/graal/com.oracle.graal.api.meta/src/com/oracle/graal/api/meta/MetaUtil.java Mon Dec 09 18:13:58 2013 +0100 @@ -28,7 +28,7 @@ import java.lang.reflect.*; import java.util.*; -import com.oracle.graal.api.meta.ProfilingInfo.TriState; +import com.oracle.graal.api.meta.ProfilingInfo.*; /** * Miscellaneous collection of utility methods used by {@code com.oracle.graal.api.meta} and its @@ -536,11 +536,11 @@ buf.append(sep); } - if (info.getExceptionSeen(i) == TriState.TRUE) { + if (info.getExceptionSeen(i) != TriState.UNKNOWN) { buf.append(String.format("exceptionSeen@%d: %s%s", i, info.getExceptionSeen(i).name(), sep)); } - if (info.getNullSeen(i) == TriState.TRUE) { + if (info.getNullSeen(i) != TriState.UNKNOWN) { buf.append(String.format("nullSeen@%d: %s%s", i, info.getNullSeen(i).name(), sep)); }
--- a/graal/com.oracle.graal.compiler.test/src/com/oracle/graal/compiler/test/ProfilingInfoTest.java Mon Dec 09 17:03:57 2013 +0100 +++ b/graal/com.oracle.graal.compiler.test/src/com/oracle/graal/compiler/test/ProfilingInfoTest.java Mon Dec 09 18:13:58 2013 +0100 @@ -30,9 +30,19 @@ import com.oracle.graal.api.meta.*; import com.oracle.graal.api.meta.ProfilingInfo.TriState; +/** + * Tests profiling information provided by the runtime. + * <p> + * NOTE: These tests are actually not very robust. The problem is that only partial profiling + * information may be gathered for any given method. For example, HotSpot's advanced compilation + * policy can decide to only gather partial profiles in a first level compilation (see + * AdvancedThresholdPolicy::common(...) in advancedThresholdPolicy.cpp). Because of this, + * occasionally tests for {@link ProfilingInfo#getNullSeen(int)} can fail since HotSpot only set's + * the null_seen bit when doing full profiling. + */ public class ProfilingInfoTest extends GraalCompilerTest { - private static final int N = 100; + private static final int N = 10; private static final double DELTA = 1d / Integer.MAX_VALUE; @Test @@ -268,14 +278,17 @@ continueProfiling(snippet, new Object()); Assert.assertEquals(TriState.FALSE, info.getNullSeen(1)); - continueProfiling(snippet, (Object) null); - Assert.assertEquals(TriState.TRUE, info.getNullSeen(1)); + if (TriState.TRUE == info.getNullSeen(1)) { + // See the javadoc comment for ProfilingInfoTest. + continueProfiling(snippet, (Object) null); + Assert.assertEquals(TriState.TRUE, info.getNullSeen(1)); - continueProfiling(snippet, 0.0); - Assert.assertEquals(TriState.TRUE, info.getNullSeen(1)); + continueProfiling(snippet, 0.0); + Assert.assertEquals(TriState.TRUE, info.getNullSeen(1)); - continueProfiling(snippet, new Object()); - Assert.assertEquals(TriState.TRUE, info.getNullSeen(1)); + continueProfiling(snippet, new Object()); + Assert.assertEquals(TriState.TRUE, info.getNullSeen(1)); + } resetProfile(snippet); Assert.assertEquals(TriState.FALSE, info.getNullSeen(1));