Mercurial > hg > graal-jvmci-8
annotate src/share/vm/opto/bytecodeInfo.cpp @ 6615:09aad8452938
7190310: Inlining WeakReference.get(), and hoisting $referent may lead to non-terminating loops
Summary: In C2 add software membar after load from Reference.referent field to prevent commoning of loads across safepoint since GC can change its value. In C1 always generate Reference.get() intrinsic.
Reviewed-by: roland, twisti, dholmes, johnc
author | kvn |
---|---|
date | Mon, 20 Aug 2012 09:58:58 -0700 |
parents | 1d7922586cf6 |
children | 957c266d8bc5 b9a9ed0f8eeb c3e799c37717 |
rev | line source |
---|---|
0 | 1 /* |
2357
8033953d67ff
7012648: move JSR 292 to package java.lang.invoke and adjust names
jrose
parents:
1972
diff
changeset
|
2 * Copyright (c) 1998, 2011, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1507
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1507
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1507
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "classfile/systemDictionary.hpp" | |
27 #include "classfile/vmSymbols.hpp" | |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
28 #include "compiler/compileBroker.hpp" |
1972 | 29 #include "compiler/compileLog.hpp" |
30 #include "interpreter/linkResolver.hpp" | |
31 #include "oops/objArrayKlass.hpp" | |
32 #include "opto/callGenerator.hpp" | |
33 #include "opto/parse.hpp" | |
34 #include "runtime/handles.inline.hpp" | |
0 | 35 |
36 //============================================================================= | |
37 //------------------------------InlineTree------------------------------------- | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
38 InlineTree::InlineTree(Compile* c, |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
39 const InlineTree *caller_tree, ciMethod* callee, |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
40 JVMState* caller_jvms, int caller_bci, |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
41 float site_invoke_ratio, int max_inline_level) : |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
42 C(c), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
43 _caller_jvms(caller_jvms), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
44 _caller_tree((InlineTree*) caller_tree), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
45 _method(callee), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
46 _site_invoke_ratio(site_invoke_ratio), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
47 _max_inline_level(max_inline_level), |
3897
de847cac9235
7078382: JSR 292: don't count method handle adapters against inlining budgets
twisti
parents:
3784
diff
changeset
|
48 _count_inline_bcs(method()->code_size_for_inlining()) |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
49 { |
0 | 50 NOT_PRODUCT(_count_inlines = 0;) |
51 if (_caller_jvms != NULL) { | |
52 // Keep a private copy of the caller_jvms: | |
53 _caller_jvms = new (C) JVMState(caller_jvms->method(), caller_tree->caller_jvms()); | |
54 _caller_jvms->set_bci(caller_jvms->bci()); | |
900
9987d9d5eb0e
6833129: specjvm98 fails with NullPointerException in the compiler with -XX:DeoptimizeALot
cfang
parents:
726
diff
changeset
|
55 assert(!caller_jvms->should_reexecute(), "there should be no reexecute bytecode with inlining"); |
0 | 56 } |
57 assert(_caller_jvms->same_calls_as(caller_jvms), "consistent JVMS"); | |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
58 assert((caller_tree == NULL ? 0 : caller_tree->stack_depth() + 1) == stack_depth(), "correct (redundant) depth parameter"); |
0 | 59 assert(caller_bci == this->caller_bci(), "correct (redundant) bci parameter"); |
60 if (UseOldInlining) { | |
61 // Update hierarchical counts, count_inline_bcs() and count_inlines() | |
62 InlineTree *caller = (InlineTree *)caller_tree; | |
63 for( ; caller != NULL; caller = ((InlineTree *)(caller->caller_tree())) ) { | |
64 caller->_count_inline_bcs += count_inline_bcs(); | |
65 NOT_PRODUCT(caller->_count_inlines++;) | |
66 } | |
67 } | |
68 } | |
69 | |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
70 InlineTree::InlineTree(Compile* c, ciMethod* callee_method, JVMState* caller_jvms, |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
71 float site_invoke_ratio, int max_inline_level) : |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
72 C(c), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
73 _caller_jvms(caller_jvms), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
74 _caller_tree(NULL), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
75 _method(callee_method), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
76 _site_invoke_ratio(site_invoke_ratio), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
77 _max_inline_level(max_inline_level), |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
78 _count_inline_bcs(method()->code_size()) |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
79 { |
0 | 80 NOT_PRODUCT(_count_inlines = 0;) |
81 assert(!UseOldInlining, "do not use for old stuff"); | |
82 } | |
83 | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
84 static bool is_init_with_ea(ciMethod* callee_method, |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
85 ciMethod* caller_method, Compile* C) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
86 // True when EA is ON and a java constructor is called or |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
87 // a super constructor is called from an inlined java constructor. |
244 | 88 return C->do_escape_analysis() && EliminateAllocations && |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
89 ( callee_method->is_initializer() || |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
90 (caller_method->is_initializer() && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
91 caller_method != C->method() && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
92 caller_method->holder()->is_subclass_of(callee_method->holder())) |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
93 ); |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
94 } |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
95 |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
96 // positive filter: should callee be inlined? returns NULL, if yes, or rejection msg |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
97 const char* InlineTree::should_inline(ciMethod* callee_method, ciMethod* caller_method, int caller_bci, ciCallProfile& profile, WarmCallInfo* wci_result) const { |
0 | 98 // Allows targeted inlining |
99 if(callee_method->should_inline()) { | |
100 *wci_result = *(WarmCallInfo::always_hot()); | |
101 if (PrintInlining && Verbose) { | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
102 CompileTask::print_inline_indent(inline_level()); |
0 | 103 tty->print_cr("Inlined method is hot: "); |
104 } | |
105 return NULL; | |
106 } | |
107 | |
108 // positive filter: should send be inlined? returns NULL (--> yes) | |
109 // or rejection msg | |
3897
de847cac9235
7078382: JSR 292: don't count method handle adapters against inlining budgets
twisti
parents:
3784
diff
changeset
|
110 int size = callee_method->code_size_for_inlining(); |
0 | 111 |
112 // Check for too many throws (and not too huge) | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
113 if(callee_method->interpreter_throwout_count() > InlineThrowCount && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
114 size < InlineThrowMaxSize ) { |
0 | 115 wci_result->set_profit(wci_result->profit() * 100); |
116 if (PrintInlining && Verbose) { | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
117 CompileTask::print_inline_indent(inline_level()); |
0 | 118 tty->print_cr("Inlined method with many throws (throws=%d):", callee_method->interpreter_throwout_count()); |
119 } | |
120 return NULL; | |
121 } | |
122 | |
123 if (!UseOldInlining) { | |
124 return NULL; // size and frequency are represented in a new way | |
125 } | |
126 | |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
127 int default_max_inline_size = C->max_inline_size(); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
128 int inline_small_code_size = InlineSmallCode / 4; |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
129 int max_inline_size = default_max_inline_size; |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
130 |
0 | 131 int call_site_count = method()->scale_count(profile.count()); |
132 int invoke_count = method()->interpreter_invocation_count(); | |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
133 |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
134 assert(invoke_count != 0, "require invocation count greater than zero"); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
135 int freq = call_site_count / invoke_count; |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
136 |
0 | 137 // bump the max size if the call is frequent |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
138 if ((freq >= InlineFrequencyRatio) || |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
139 (call_site_count >= InlineFrequencyCount) || |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
140 is_init_with_ea(callee_method, caller_method, C)) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
141 |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
142 max_inline_size = C->freq_inline_size(); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
143 if (size <= max_inline_size && TraceFrequencyInlining) { |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
144 CompileTask::print_inline_indent(inline_level()); |
0 | 145 tty->print_cr("Inlined frequent method (freq=%d count=%d):", freq, call_site_count); |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
146 CompileTask::print_inline_indent(inline_level()); |
0 | 147 callee_method->print(); |
148 tty->cr(); | |
149 } | |
150 } else { | |
151 // Not hot. Check for medium-sized pre-existing nmethod at cold sites. | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
152 if (callee_method->has_compiled_code() && |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
153 callee_method->instructions_size(CompLevel_full_optimization) > inline_small_code_size) |
0 | 154 return "already compiled into a medium method"; |
155 } | |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
156 if (size > max_inline_size) { |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
157 if (max_inline_size > default_max_inline_size) |
0 | 158 return "hot method too big"; |
159 return "too big"; | |
160 } | |
161 return NULL; | |
162 } | |
163 | |
164 | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
165 // negative filter: should callee NOT be inlined? returns NULL, ok to inline, or rejection msg |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
166 const char* InlineTree::should_not_inline(ciMethod *callee_method, ciMethod* caller_method, WarmCallInfo* wci_result) const { |
0 | 167 // negative filter: should send NOT be inlined? returns NULL (--> inline) or rejection msg |
168 if (!UseOldInlining) { | |
169 const char* fail = NULL; | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
170 if ( callee_method->is_abstract()) fail = "abstract method"; |
0 | 171 // note: we allow ik->is_abstract() |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
172 if (!callee_method->holder()->is_initialized()) fail = "method holder not initialized"; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
173 if ( callee_method->is_native()) fail = "native method"; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
174 if ( callee_method->dont_inline()) fail = "don't inline by annotation"; |
0 | 175 |
176 if (fail) { | |
177 *wci_result = *(WarmCallInfo::always_cold()); | |
178 return fail; | |
179 } | |
180 | |
181 if (callee_method->has_unloaded_classes_in_signature()) { | |
182 wci_result->set_profit(wci_result->profit() * 0.1); | |
183 } | |
184 | |
185 // don't inline exception code unless the top method belongs to an | |
186 // exception class | |
187 if (callee_method->holder()->is_subclass_of(C->env()->Throwable_klass())) { | |
188 ciMethod* top_method = caller_jvms() ? caller_jvms()->of_depth(1)->method() : method(); | |
189 if (!top_method->holder()->is_subclass_of(C->env()->Throwable_klass())) { | |
190 wci_result->set_profit(wci_result->profit() * 0.1); | |
191 } | |
192 } | |
193 | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
194 if (callee_method->has_compiled_code() && |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
195 callee_method->instructions_size(CompLevel_full_optimization) > InlineSmallCode) { |
0 | 196 wci_result->set_profit(wci_result->profit() * 0.1); |
197 // %%% adjust wci_result->size()? | |
198 } | |
199 | |
200 return NULL; | |
201 } | |
202 | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
203 // First check all inlining restrictions which are required for correctness |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
204 if ( callee_method->is_abstract()) return "abstract method"; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
205 // note: we allow ik->is_abstract() |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
206 if (!callee_method->holder()->is_initialized()) return "method holder not initialized"; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
207 if ( callee_method->is_native()) return "native method"; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
208 if ( callee_method->dont_inline()) return "don't inline by annotation"; |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
209 if ( callee_method->has_unloaded_classes_in_signature()) return "unloaded signature classes"; |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1137
diff
changeset
|
210 |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
211 if (callee_method->force_inline() || callee_method->should_inline()) { |
0 | 212 // ignore heuristic controls on inlining |
213 return NULL; | |
214 } | |
215 | |
216 // Now perform checks which are heuristic | |
217 | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
218 if (callee_method->has_compiled_code() && |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
219 callee_method->instructions_size(CompLevel_full_optimization) > InlineSmallCode) { |
0 | 220 return "already compiled into a big method"; |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
221 } |
0 | 222 |
223 // don't inline exception code unless the top method belongs to an | |
224 // exception class | |
225 if (caller_tree() != NULL && | |
226 callee_method->holder()->is_subclass_of(C->env()->Throwable_klass())) { | |
227 const InlineTree *top = this; | |
228 while (top->caller_tree() != NULL) top = top->caller_tree(); | |
229 ciInstanceKlass* k = top->method()->holder(); | |
230 if (!k->is_subclass_of(C->env()->Throwable_klass())) | |
231 return "exception method"; | |
232 } | |
233 | |
5950
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
234 if (callee_method->should_not_inline()) { |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
235 return "disallowed by CompilerOracle"; |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
236 } |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
237 |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
238 if (UseStringCache) { |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
239 // Do not inline StringCache::profile() method used only at the beginning. |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
240 if (callee_method->name() == ciSymbol::profile_name() && |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
241 callee_method->holder()->name() == ciSymbol::java_lang_StringCache()) { |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
242 return "profiling method"; |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
243 } |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
244 } |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
245 |
0 | 246 // use frequency-based objections only for non-trivial methods |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
247 if (callee_method->code_size() <= MaxTrivialSize) return NULL; |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
248 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
249 // don't use counts with -Xcomp or CTW |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
250 if (UseInterpreter && !CompileTheWorld) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
251 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
252 if (!callee_method->has_compiled_code() && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
253 !callee_method->was_executed_more_than(0)) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
254 return "never executed"; |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
255 } |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
256 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
257 if (is_init_with_ea(callee_method, caller_method, C)) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
258 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
259 // Escape Analysis: inline all executed constructors |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
260 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
261 } else if (!callee_method->was_executed_more_than(MIN2(MinInliningThreshold, |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
262 CompileThreshold >> 1))) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
263 return "executed < MinInliningThreshold times"; |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
264 } |
0 | 265 } |
266 | |
267 return NULL; | |
268 } | |
269 | |
270 //-----------------------------try_to_inline----------------------------------- | |
271 // return NULL if ok, reason for not inlining otherwise | |
272 // Relocated from "InliningClosure::try_to_inline" | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
273 const char* InlineTree::try_to_inline(ciMethod* callee_method, ciMethod* caller_method, int caller_bci, ciCallProfile& profile, WarmCallInfo* wci_result) { |
0 | 274 |
275 // Old algorithm had funny accumulating BC-size counters | |
276 if (UseOldInlining && ClipInlining | |
277 && (int)count_inline_bcs() >= DesiredMethodLimit) { | |
278 return "size > DesiredMethodLimit"; | |
279 } | |
280 | |
281 const char *msg = NULL; | |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
282 msg = should_inline(callee_method, caller_method, caller_bci, profile, wci_result); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
283 if (msg != NULL) |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
284 return msg; |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
285 |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
286 msg = should_not_inline(callee_method, caller_method, wci_result); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
287 if (msg != NULL) |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
288 return msg; |
0 | 289 |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
290 if (InlineAccessors && callee_method->is_accessor()) { |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
291 // accessor methods are not subject to any of the following limits. |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
292 return NULL; |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
293 } |
0 | 294 |
295 // suppress a few checks for accessors and trivial methods | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
296 if (callee_method->code_size() > MaxTrivialSize) { |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
297 |
0 | 298 // don't inline into giant methods |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
299 if (C->unique() > (uint)NodeCountInliningCutoff) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
300 return "NodeCountInliningCutoff"; |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
301 } |
0 | 302 |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
303 if ((!UseInterpreter || CompileTheWorld) && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
304 is_init_with_ea(callee_method, caller_method, C)) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
305 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
306 // Escape Analysis stress testing when running Xcomp or CTW: |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
307 // inline constructors even if they are not reached. |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
308 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
309 } else if (profile.count() == 0) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
310 // don't inline unreached call sites |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
311 return "call site not reached"; |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
312 } |
0 | 313 } |
314 | |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
315 if (!C->do_inlining() && InlineAccessors) { |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
316 return "not an accessor"; |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
317 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
318 if (inline_level() > _max_inline_level) { |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
319 return "inlining too deep"; |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
320 } |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
321 |
3334
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
322 // detect direct and indirect recursive inlining |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
323 if (!callee_method->is_compiled_lambda_form()) { |
3334
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
324 // count the current method and the callee |
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
325 int inline_level = (method() == callee_method) ? 1 : 0; |
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
326 if (inline_level > MaxRecursiveInlineLevel) |
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
327 return "recursively inlining too deep"; |
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
328 // count callers of current method and callee |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
329 JVMState* jvms = caller_jvms(); |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
330 while (jvms != NULL && jvms->has_method()) { |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
331 if (jvms->method() == callee_method) { |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
332 inline_level++; |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
333 if (inline_level > MaxRecursiveInlineLevel) |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
334 return "recursively inlining too deep"; |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
335 } |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
336 jvms = jvms->caller(); |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
337 } |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
338 } |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
339 |
3897
de847cac9235
7078382: JSR 292: don't count method handle adapters against inlining budgets
twisti
parents:
3784
diff
changeset
|
340 int size = callee_method->code_size_for_inlining(); |
0 | 341 |
342 if (UseOldInlining && ClipInlining | |
343 && (int)count_inline_bcs() + size >= DesiredMethodLimit) { | |
344 return "size > DesiredMethodLimit"; | |
345 } | |
346 | |
347 // ok, inline this method | |
348 return NULL; | |
349 } | |
350 | |
351 //------------------------------pass_initial_checks---------------------------- | |
352 bool pass_initial_checks(ciMethod* caller_method, int caller_bci, ciMethod* callee_method) { | |
353 ciInstanceKlass *callee_holder = callee_method ? callee_method->holder() : NULL; | |
354 // Check if a callee_method was suggested | |
355 if( callee_method == NULL ) return false; | |
356 // Check if klass of callee_method is loaded | |
357 if( !callee_holder->is_loaded() ) return false; | |
358 if( !callee_holder->is_initialized() ) return false; | |
359 if( !UseInterpreter || CompileTheWorld /* running Xcomp or CTW */ ) { | |
360 // Checks that constant pool's call site has been visited | |
361 // stricter than callee_holder->is_initialized() | |
362 ciBytecodeStream iter(caller_method); | |
363 iter.force_bci(caller_bci); | |
364 Bytecodes::Code call_bc = iter.cur_bc(); | |
1137
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
365 // An invokedynamic instruction does not have a klass. |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
366 if (call_bc != Bytecodes::_invokedynamic) { |
1565 | 367 int index = iter.get_index_u2_cpcache(); |
1137
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
368 if (!caller_method->is_klass_loaded(index, true)) { |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
369 return false; |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
370 } |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
371 // Try to do constant pool resolution if running Xcomp |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
372 if( !caller_method->check_call(index, call_bc == Bytecodes::_invokestatic) ) { |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
373 return false; |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
374 } |
0 | 375 } |
376 } | |
377 // We will attempt to see if a class/field/etc got properly loaded. If it | |
378 // did not, it may attempt to throw an exception during our probing. Catch | |
379 // and ignore such exceptions and do not attempt to compile the method. | |
380 if( callee_method->should_exclude() ) return false; | |
381 | |
382 return true; | |
383 } | |
384 | |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
385 //------------------------------check_can_parse-------------------------------- |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
386 const char* InlineTree::check_can_parse(ciMethod* callee) { |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
387 // Certain methods cannot be parsed at all: |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
388 if ( callee->is_native()) return "native method"; |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
389 if ( callee->is_abstract()) return "abstract method"; |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
390 if (!callee->can_be_compiled()) return "not compilable (disabled)"; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
391 if (!callee->has_balanced_monitors()) return "not compilable (unbalanced monitors)"; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
392 if ( callee->get_flow_analysis()->failing()) return "not compilable (flow analysis failed)"; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
393 return NULL; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
394 } |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
395 |
0 | 396 //------------------------------print_inlining--------------------------------- |
397 // Really, the failure_msg can be a success message also. | |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
398 void InlineTree::print_inlining(ciMethod* callee_method, int caller_bci, const char* failure_msg) const { |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
399 CompileTask::print_inlining(callee_method, inline_level(), caller_bci, failure_msg ? failure_msg : "inline"); |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
400 if (callee_method == NULL) tty->print(" callee not monotonic or profiled"); |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
401 if (Verbose && callee_method) { |
0 | 402 const InlineTree *top = this; |
403 while( top->caller_tree() != NULL ) { top = top->caller_tree(); } | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
404 //tty->print(" bcs: %d+%d invoked: %d", top->count_inline_bcs(), callee_method->code_size(), callee_method->interpreter_invocation_count()); |
0 | 405 } |
406 } | |
407 | |
408 //------------------------------ok_to_inline----------------------------------- | |
409 WarmCallInfo* InlineTree::ok_to_inline(ciMethod* callee_method, JVMState* jvms, ciCallProfile& profile, WarmCallInfo* initial_wci) { | |
410 assert(callee_method != NULL, "caller checks for optimized virtual!"); | |
411 #ifdef ASSERT | |
412 // Make sure the incoming jvms has the same information content as me. | |
413 // This means that we can eventually make this whole class AllStatic. | |
414 if (jvms->caller() == NULL) { | |
415 assert(_caller_jvms == NULL, "redundant instance state"); | |
416 } else { | |
417 assert(_caller_jvms->same_calls_as(jvms->caller()), "redundant instance state"); | |
418 } | |
419 assert(_method == jvms->method(), "redundant instance state"); | |
420 #endif | |
421 const char *failure_msg = NULL; | |
422 int caller_bci = jvms->bci(); | |
423 ciMethod *caller_method = jvms->method(); | |
424 | |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
425 // Do some initial checks. |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
426 if (!pass_initial_checks(caller_method, caller_bci, callee_method)) { |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
427 if (PrintInlining) print_inlining(callee_method, caller_bci, "failed initial checks"); |
0 | 428 return NULL; |
429 } | |
430 | |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
431 // Do some parse checks. |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
432 failure_msg = check_can_parse(callee_method); |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
433 if (failure_msg != NULL) { |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
434 if (PrintInlining) print_inlining(callee_method, caller_bci, failure_msg); |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
435 return NULL; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
436 } |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
437 |
0 | 438 // Check if inlining policy says no. |
439 WarmCallInfo wci = *(initial_wci); | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
440 failure_msg = try_to_inline(callee_method, caller_method, caller_bci, profile, &wci); |
0 | 441 if (failure_msg != NULL && C->log() != NULL) { |
442 C->log()->begin_elem("inline_fail reason='"); | |
443 C->log()->text("%s", failure_msg); | |
444 C->log()->end_elem("'"); | |
445 } | |
446 | |
447 #ifndef PRODUCT | |
448 if (UseOldInlining && InlineWarmCalls | |
449 && (PrintOpto || PrintOptoInlining || PrintInlining)) { | |
450 bool cold = wci.is_cold(); | |
451 bool hot = !cold && wci.is_hot(); | |
452 bool old_cold = (failure_msg != NULL); | |
453 if (old_cold != cold || (Verbose || WizardMode)) { | |
454 tty->print(" OldInlining= %4s : %s\n WCI=", | |
455 old_cold ? "cold" : "hot", failure_msg ? failure_msg : "OK"); | |
456 wci.print(); | |
457 } | |
458 } | |
459 #endif | |
460 if (UseOldInlining) { | |
461 if (failure_msg == NULL) | |
462 wci = *(WarmCallInfo::always_hot()); | |
463 else | |
464 wci = *(WarmCallInfo::always_cold()); | |
465 } | |
466 if (!InlineWarmCalls) { | |
467 if (!wci.is_cold() && !wci.is_hot()) { | |
468 // Do not inline the warm calls. | |
469 wci = *(WarmCallInfo::always_cold()); | |
470 } | |
471 } | |
472 | |
473 if (!wci.is_cold()) { | |
474 // In -UseOldInlining, the failure_msg may also be a success message. | |
475 if (failure_msg == NULL) failure_msg = "inline (hot)"; | |
476 | |
477 // Inline! | |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
478 if (PrintInlining) print_inlining(callee_method, caller_bci, failure_msg); |
0 | 479 if (UseOldInlining) |
480 build_inline_tree_for_callee(callee_method, jvms, caller_bci); | |
481 if (InlineWarmCalls && !wci.is_hot()) | |
482 return new (C) WarmCallInfo(wci); // copy to heap | |
483 return WarmCallInfo::always_hot(); | |
484 } | |
485 | |
486 // Do not inline | |
487 if (failure_msg == NULL) failure_msg = "too cold to inline"; | |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
488 if (PrintInlining) print_inlining(callee_method, caller_bci, failure_msg); |
0 | 489 return NULL; |
490 } | |
491 | |
492 //------------------------------compute_callee_frequency----------------------- | |
493 float InlineTree::compute_callee_frequency( int caller_bci ) const { | |
494 int count = method()->interpreter_call_site_count(caller_bci); | |
495 int invcnt = method()->interpreter_invocation_count(); | |
496 float freq = (float)count/(float)invcnt; | |
497 // Call-site count / interpreter invocation count, scaled recursively. | |
498 // Always between 0.0 and 1.0. Represents the percentage of the method's | |
499 // total execution time used at this call site. | |
500 | |
501 return freq; | |
502 } | |
503 | |
504 //------------------------------build_inline_tree_for_callee------------------- | |
505 InlineTree *InlineTree::build_inline_tree_for_callee( ciMethod* callee_method, JVMState* caller_jvms, int caller_bci) { | |
506 float recur_frequency = _site_invoke_ratio * compute_callee_frequency(caller_bci); | |
507 // Attempt inlining. | |
508 InlineTree* old_ilt = callee_at(caller_bci, callee_method); | |
509 if (old_ilt != NULL) { | |
510 return old_ilt; | |
511 } | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
512 int max_inline_level_adjust = 0; |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
513 if (caller_jvms->method() != NULL) { |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
514 if (caller_jvms->method()->is_compiled_lambda_form()) |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
515 max_inline_level_adjust += 1; // don't count actions in MH or indy adapter frames |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
516 else if (callee_method->is_method_handle_intrinsic() || |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
517 callee_method->is_compiled_lambda_form()) { |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
518 max_inline_level_adjust += 1; // don't count method handle calls from java.lang.invoke implem |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
519 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
520 if (max_inline_level_adjust != 0 && PrintInlining && (Verbose || WizardMode)) { |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
521 CompileTask::print_inline_indent(inline_level()); |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
522 tty->print_cr(" \\-> discounting inline depth"); |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
523 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
524 if (max_inline_level_adjust != 0 && C->log()) { |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
525 int id1 = C->log()->identify(caller_jvms->method()); |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
526 int id2 = C->log()->identify(callee_method); |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
527 C->log()->elem("inline_level_discount caller='%d' callee='%d'", id1, id2); |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
528 } |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
529 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
530 InlineTree* ilt = new InlineTree(C, this, callee_method, caller_jvms, caller_bci, recur_frequency, _max_inline_level + max_inline_level_adjust); |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
531 _subtrees.append(ilt); |
0 | 532 |
533 NOT_PRODUCT( _count_inlines += 1; ) | |
534 | |
535 return ilt; | |
536 } | |
537 | |
538 | |
539 //---------------------------------------callee_at----------------------------- | |
540 InlineTree *InlineTree::callee_at(int bci, ciMethod* callee) const { | |
541 for (int i = 0; i < _subtrees.length(); i++) { | |
542 InlineTree* sub = _subtrees.at(i); | |
543 if (sub->caller_bci() == bci && callee == sub->method()) { | |
544 return sub; | |
545 } | |
546 } | |
547 return NULL; | |
548 } | |
549 | |
550 | |
551 //------------------------------build_inline_tree_root------------------------- | |
552 InlineTree *InlineTree::build_inline_tree_root() { | |
553 Compile* C = Compile::current(); | |
554 | |
555 // Root of inline tree | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
556 InlineTree* ilt = new InlineTree(C, NULL, C->method(), NULL, -1, 1.0F, MaxInlineLevel); |
0 | 557 |
558 return ilt; | |
559 } | |
560 | |
561 | |
562 //-------------------------find_subtree_from_root----------------------------- | |
563 // Given a jvms, which determines a call chain from the root method, | |
564 // find the corresponding inline tree. | |
565 // Note: This method will be removed or replaced as InlineTree goes away. | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
566 InlineTree* InlineTree::find_subtree_from_root(InlineTree* root, JVMState* jvms, ciMethod* callee) { |
0 | 567 InlineTree* iltp = root; |
568 uint depth = jvms && jvms->has_method() ? jvms->depth() : 0; | |
569 for (uint d = 1; d <= depth; d++) { | |
570 JVMState* jvmsp = jvms->of_depth(d); | |
571 // Select the corresponding subtree for this bci. | |
572 assert(jvmsp->method() == iltp->method(), "tree still in sync"); | |
573 ciMethod* d_callee = (d == depth) ? callee : jvms->of_depth(d+1)->method(); | |
574 InlineTree* sub = iltp->callee_at(jvmsp->bci(), d_callee); | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
575 if (sub == NULL) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
576 if (d == depth) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
577 sub = iltp->build_inline_tree_for_callee(d_callee, jvmsp, jvmsp->bci()); |
0 | 578 } |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
579 guarantee(sub != NULL, "should be a sub-ilt here"); |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
580 return sub; |
0 | 581 } |
582 iltp = sub; | |
583 } | |
584 return iltp; | |
585 } | |
3939 | 586 |
587 | |
588 | |
589 #ifndef PRODUCT | |
590 void InlineTree::print_impl(outputStream* st, int indent) const { | |
591 for (int i = 0; i < indent; i++) st->print(" "); | |
592 st->print(" @ %d ", caller_bci()); | |
593 method()->print_short_name(st); | |
594 st->cr(); | |
595 | |
596 for (int i = 0 ; i < _subtrees.length(); i++) { | |
597 _subtrees.at(i)->print_impl(st, indent + 2); | |
598 } | |
599 } | |
600 | |
601 void InlineTree::print_value_on(outputStream* st) const { | |
602 print_impl(st, 2); | |
603 } | |
604 #endif |