Mercurial > hg > graal-jvmci-8
annotate src/share/vm/memory/iterator.cpp @ 1994:6cd6d394f280
7001033: assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed())
7002546: regression on SpecJbb2005 on 7b118 comparing to 7b117 on small heaps
Summary: Relaxed assertion checking related to incremental_collection_failed flag to allow for ExplicitGCInvokesConcurrent behaviour where we do not want a failing scavenge to bail to a stop-world collection. Parameterized incremental_collection_will_fail() so we can selectively use, or not use, as appropriate, the statistical prediction at specific use sites. This essentially reverts the scavenge bail-out logic to what it was prior to some recent changes that had inadvertently started using the statistical prediction which can be noisy in the presence of bursty loads. Added some associated verbose non-product debugging messages.
Reviewed-by: johnc, tonyp
| author | ysr |
|---|---|
| date | Tue, 07 Dec 2010 21:55:53 -0800 |
| parents | f95d63e2154a |
| children | da91efe96a93 |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 1579 | 2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1000
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1000
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1000
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "memory/iterator.hpp" | |
| 27 #include "oops/oop.inline.hpp" | |
| 0 | 28 |
| 935 | 29 #ifdef ASSERT |
| 30 bool OopClosure::_must_remember_klasses = false; | |
| 31 #endif | |
| 32 | |
| 0 | 33 void ObjectToOopClosure::do_object(oop obj) { |
| 34 obj->oop_iterate(_cl); | |
| 35 } | |
| 36 | |
| 37 void VoidClosure::do_void() { | |
| 38 ShouldNotCallThis(); | |
| 39 } | |
| 935 | 40 |
| 41 #ifdef ASSERT | |
| 42 bool OopClosure::must_remember_klasses() { | |
| 43 return _must_remember_klasses; | |
| 44 } | |
| 45 void OopClosure::set_must_remember_klasses(bool v) { | |
| 46 _must_remember_klasses = v; | |
| 47 } | |
| 48 #endif | |
| 49 | |
| 993 | 50 |
| 989 | 51 MarkingCodeBlobClosure::MarkScope::MarkScope(bool activate) |
| 52 : _active(activate) | |
| 53 { | |
| 54 if (_active) nmethod::oops_do_marking_prologue(); | |
| 55 } | |
| 56 | |
| 57 MarkingCodeBlobClosure::MarkScope::~MarkScope() { | |
| 58 if (_active) nmethod::oops_do_marking_epilogue(); | |
| 59 } | |
| 60 | |
| 61 void MarkingCodeBlobClosure::do_code_blob(CodeBlob* cb) { | |
|
1563
1a5913bf5e19
6951083: oops and relocations should part of nmethod not CodeBlob
twisti
parents:
1000
diff
changeset
|
62 nmethod* nm = cb->as_nmethod_or_null(); |
|
1a5913bf5e19
6951083: oops and relocations should part of nmethod not CodeBlob
twisti
parents:
1000
diff
changeset
|
63 if (nm == NULL) return; |
| 989 | 64 if (!nm->test_set_oops_do_mark()) { |
| 65 NOT_PRODUCT(if (TraceScavenge) nm->print_on(tty, "oops_do, 1st visit\n")); | |
| 66 do_newly_marked_nmethod(nm); | |
| 67 } else { | |
| 68 NOT_PRODUCT(if (TraceScavenge) nm->print_on(tty, "oops_do, skipped on 2nd visit\n")); | |
| 69 } | |
| 70 } | |
| 71 | |
|
994
753cf9794df9
6885169: merge of 4957990 and 6863023 causes conflict on do_nmethods
jrose
parents:
993
diff
changeset
|
72 void CodeBlobToOopClosure::do_newly_marked_nmethod(nmethod* nm) { |
|
753cf9794df9
6885169: merge of 4957990 and 6863023 causes conflict on do_nmethods
jrose
parents:
993
diff
changeset
|
73 nm->oops_do(_cl, /*do_strong_roots_only=*/ true); |
| 989 | 74 } |
| 75 | |
| 76 void CodeBlobToOopClosure::do_code_blob(CodeBlob* cb) { | |
| 77 if (!_do_marking) { | |
|
1563
1a5913bf5e19
6951083: oops and relocations should part of nmethod not CodeBlob
twisti
parents:
1000
diff
changeset
|
78 nmethod* nm = cb->as_nmethod_or_null(); |
|
1a5913bf5e19
6951083: oops and relocations should part of nmethod not CodeBlob
twisti
parents:
1000
diff
changeset
|
79 NOT_PRODUCT(if (TraceScavenge && Verbose && nm != NULL) nm->print_on(tty, "oops_do, unmarked visit\n")); |
| 989 | 80 // This assert won't work, since there are lots of mini-passes |
| 81 // (mostly in debug mode) that co-exist with marking phases. | |
| 82 //assert(!(cb->is_nmethod() && ((nmethod*)cb)->test_oops_do_mark()), "found marked nmethod during mark-free phase"); | |
|
1563
1a5913bf5e19
6951083: oops and relocations should part of nmethod not CodeBlob
twisti
parents:
1000
diff
changeset
|
83 if (nm != NULL) { |
|
1a5913bf5e19
6951083: oops and relocations should part of nmethod not CodeBlob
twisti
parents:
1000
diff
changeset
|
84 nm->oops_do(_cl); |
|
1a5913bf5e19
6951083: oops and relocations should part of nmethod not CodeBlob
twisti
parents:
1000
diff
changeset
|
85 } |
| 989 | 86 } else { |
| 87 MarkingCodeBlobClosure::do_code_blob(cb); | |
| 88 } | |
| 89 } | |
| 90 | |
| 91 |