Mercurial > hg > graal-jvmci-8
annotate src/share/vm/oops/klassVtable.cpp @ 2119:d4fca0a6abde
7011386: race in objArrayKlass::array_klass_impl
Summary: Move _lower_dimension field initialization before _higher_dimension and add storestore barrier.
Reviewed-by: dholmes, iveresov, never
author | kvn |
---|---|
date | Tue, 11 Jan 2011 20:26:13 -0800 |
parents | 642e54d1850a |
children | 3582bf76420e |
rev | line source |
---|---|
0 | 1 /* |
1972 | 2 * Copyright (c) 1997, 2010, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1490
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1490
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1490
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "classfile/systemDictionary.hpp" | |
27 #include "classfile/vmSymbols.hpp" | |
28 #include "gc_implementation/shared/markSweep.inline.hpp" | |
29 #include "memory/gcLocker.hpp" | |
30 #include "memory/resourceArea.hpp" | |
31 #include "memory/universe.inline.hpp" | |
32 #include "oops/instanceKlass.hpp" | |
33 #include "oops/klassOop.hpp" | |
34 #include "oops/klassVtable.hpp" | |
35 #include "oops/methodOop.hpp" | |
36 #include "oops/objArrayOop.hpp" | |
37 #include "oops/oop.inline.hpp" | |
38 #include "prims/jvmtiRedefineClassesTrace.hpp" | |
39 #include "runtime/arguments.hpp" | |
40 #include "runtime/handles.inline.hpp" | |
41 #include "utilities/copy.hpp" | |
0 | 42 |
43 inline instanceKlass* klassVtable::ik() const { | |
44 Klass* k = _klass()->klass_part(); | |
45 assert(k->oop_is_instance(), "not an instanceKlass"); | |
46 return (instanceKlass*)k; | |
47 } | |
48 | |
49 | |
50 // this function computes the vtable size (including the size needed for miranda | |
51 // methods) and the number of miranda methods in this class | |
52 // Note on Miranda methods: Let's say there is a class C that implements | |
53 // interface I. Let's say there is a method m in I that neither C nor any | |
54 // of its super classes implement (i.e there is no method of any access, with | |
55 // the same name and signature as m), then m is a Miranda method which is | |
56 // entered as a public abstract method in C's vtable. From then on it should | |
57 // treated as any other public method in C for method over-ride purposes. | |
58 void klassVtable::compute_vtable_size_and_num_mirandas(int &vtable_length, | |
59 int &num_miranda_methods, | |
60 klassOop super, | |
61 objArrayOop methods, | |
62 AccessFlags class_flags, | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
63 Handle classloader, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
64 symbolHandle classname, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
65 objArrayOop local_interfaces, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
66 TRAPS |
0 | 67 ) { |
68 | |
69 No_Safepoint_Verifier nsv; | |
70 | |
71 // set up default result values | |
72 vtable_length = 0; | |
73 num_miranda_methods = 0; | |
74 | |
75 // start off with super's vtable length | |
76 instanceKlass* sk = (instanceKlass*)super->klass_part(); | |
77 vtable_length = super == NULL ? 0 : sk->vtable_length(); | |
78 | |
79 // go thru each method in the methods table to see if it needs a new entry | |
80 int len = methods->length(); | |
81 for (int i = 0; i < len; i++) { | |
82 assert(methods->obj_at(i)->is_method(), "must be a methodOop"); | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
83 methodHandle mh(THREAD, methodOop(methods->obj_at(i))); |
0 | 84 |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
85 if (needs_new_vtable_entry(mh, super, classloader, classname, class_flags, THREAD)) { |
0 | 86 vtable_length += vtableEntry::size(); // we need a new entry |
87 } | |
88 } | |
89 | |
90 // compute the number of mirandas methods that must be added to the end | |
91 num_miranda_methods = get_num_mirandas(super, methods, local_interfaces); | |
92 vtable_length += (num_miranda_methods * vtableEntry::size()); | |
93 | |
94 if (Universe::is_bootstrapping() && vtable_length == 0) { | |
95 // array classes don't have their superclass set correctly during | |
96 // bootstrapping | |
97 vtable_length = Universe::base_vtable_size(); | |
98 } | |
99 | |
100 if (super == NULL && !Universe::is_bootstrapping() && | |
101 vtable_length != Universe::base_vtable_size()) { | |
102 // Someone is attempting to redefine java.lang.Object incorrectly. The | |
103 // only way this should happen is from | |
104 // SystemDictionary::resolve_from_stream(), which will detect this later | |
105 // and throw a security exception. So don't assert here to let | |
106 // the exception occur. | |
107 vtable_length = Universe::base_vtable_size(); | |
108 } | |
109 assert(super != NULL || vtable_length == Universe::base_vtable_size(), | |
110 "bad vtable size for class Object"); | |
111 assert(vtable_length % vtableEntry::size() == 0, "bad vtable length"); | |
112 assert(vtable_length >= Universe::base_vtable_size(), "vtable too small"); | |
113 } | |
114 | |
115 int klassVtable::index_of(methodOop m, int len) const { | |
116 assert(m->vtable_index() >= 0, "do not ask this of non-vtable methods"); | |
117 return m->vtable_index(); | |
118 } | |
119 | |
120 int klassVtable::initialize_from_super(KlassHandle super) { | |
121 if (super.is_null()) { | |
122 return 0; | |
123 } else { | |
124 // copy methods from superKlass | |
125 // can't inherit from array class, so must be instanceKlass | |
126 assert(super->oop_is_instance(), "must be instance klass"); | |
127 instanceKlass* sk = (instanceKlass*)super()->klass_part(); | |
128 klassVtable* superVtable = sk->vtable(); | |
129 assert(superVtable->length() <= _length, "vtable too short"); | |
130 #ifdef ASSERT | |
131 superVtable->verify(tty, true); | |
132 #endif | |
133 superVtable->copy_vtable_to(table()); | |
134 #ifndef PRODUCT | |
135 if (PrintVtables && Verbose) { | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
136 ResourceMark rm; |
0 | 137 tty->print_cr("copy vtable from %s to %s size %d", sk->internal_name(), klass()->internal_name(), _length); |
138 } | |
139 #endif | |
140 return superVtable->length(); | |
141 } | |
142 } | |
143 | |
144 // Revised lookup semantics introduced 1.3 (Kestral beta) | |
145 void klassVtable::initialize_vtable(bool checkconstraints, TRAPS) { | |
146 | |
147 // Note: Arrays can have intermediate array supers. Use java_super to skip them. | |
148 KlassHandle super (THREAD, klass()->java_super()); | |
149 int nofNewEntries = 0; | |
150 | |
151 | |
152 if (PrintVtables && !klass()->oop_is_array()) { | |
153 ResourceMark rm(THREAD); | |
154 tty->print_cr("Initializing: %s", _klass->name()->as_C_string()); | |
155 } | |
156 | |
157 #ifdef ASSERT | |
158 oop* end_of_obj = (oop*)_klass() + _klass()->size(); | |
159 oop* end_of_vtable = (oop*)&table()[_length]; | |
160 assert(end_of_vtable <= end_of_obj, "vtable extends beyond end"); | |
161 #endif | |
162 | |
163 if (Universe::is_bootstrapping()) { | |
164 // just clear everything | |
165 for (int i = 0; i < _length; i++) table()[i].clear(); | |
166 return; | |
167 } | |
168 | |
169 int super_vtable_len = initialize_from_super(super); | |
170 if (klass()->oop_is_array()) { | |
171 assert(super_vtable_len == _length, "arrays shouldn't introduce new methods"); | |
172 } else { | |
173 assert(_klass->oop_is_instance(), "must be instanceKlass"); | |
174 | |
175 objArrayHandle methods(THREAD, ik()->methods()); | |
176 int len = methods()->length(); | |
177 int initialized = super_vtable_len; | |
178 | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
179 // update_inherited_vtable can stop for gc - ensure using handles |
0 | 180 for (int i = 0; i < len; i++) { |
181 HandleMark hm(THREAD); | |
182 assert(methods()->obj_at(i)->is_method(), "must be a methodOop"); | |
183 methodHandle mh(THREAD, (methodOop)methods()->obj_at(i)); | |
184 | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
185 bool needs_new_entry = update_inherited_vtable(ik(), mh, super_vtable_len, checkconstraints, CHECK); |
0 | 186 |
187 if (needs_new_entry) { | |
188 put_method_at(mh(), initialized); | |
189 mh()->set_vtable_index(initialized); // set primary vtable index | |
190 initialized++; | |
191 } | |
192 } | |
193 | |
194 // add miranda methods; it will also update the value of initialized | |
195 fill_in_mirandas(initialized); | |
196 | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
197 // In class hierarchies where the accessibility is not increasing (i.e., going from private -> |
0 | 198 // package_private -> publicprotected), the vtable might actually be smaller than our initial |
199 // calculation. | |
200 assert(initialized <= _length, "vtable initialization failed"); | |
201 for(;initialized < _length; initialized++) { | |
202 put_method_at(NULL, initialized); | |
203 } | |
204 NOT_PRODUCT(verify(tty, true)); | |
205 } | |
206 } | |
207 | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
208 // Called for cases where a method does not override its superclass' vtable entry |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
209 // For bytecodes not produced by javac together it is possible that a method does not override |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
210 // the superclass's method, but might indirectly override a super-super class's vtable entry |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
211 // If none found, return a null superk, else return the superk of the method this does override |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
212 instanceKlass* klassVtable::find_transitive_override(instanceKlass* initialsuper, methodHandle target_method, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
213 int vtable_index, Handle target_loader, symbolHandle target_classname, Thread * THREAD) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
214 instanceKlass* superk = initialsuper; |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
215 while (superk != NULL && superk->super() != NULL) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
216 instanceKlass* supersuperklass = instanceKlass::cast(superk->super()); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
217 klassVtable* ssVtable = supersuperklass->vtable(); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
218 if (vtable_index < ssVtable->length()) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
219 methodOop super_method = ssVtable->method_at(vtable_index); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
220 #ifndef PRODUCT |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
221 symbolHandle name(THREAD,target_method()->name()); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
222 symbolHandle signature(THREAD,target_method()->signature()); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
223 assert(super_method->name() == name() && super_method->signature() == signature(), "vtable entry name/sig mismatch"); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
224 #endif |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
225 if (supersuperklass->is_override(super_method, target_loader, target_classname, THREAD)) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
226 #ifndef PRODUCT |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
227 if (PrintVtables && Verbose) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
228 ResourceMark rm(THREAD); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
229 tty->print("transitive overriding superclass %s with %s::%s index %d, original flags: ", |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
230 supersuperklass->internal_name(), |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
231 _klass->internal_name(), (target_method() != NULL) ? |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
232 target_method()->name()->as_C_string() : "<NULL>", vtable_index); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
233 super_method->access_flags().print_on(tty); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
234 tty->print("overriders flags: "); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
235 target_method->access_flags().print_on(tty); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
236 tty->cr(); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
237 } |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
238 #endif /*PRODUCT*/ |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
239 break; // return found superk |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
240 } |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
241 } else { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
242 // super class has no vtable entry here, stop transitive search |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
243 superk = (instanceKlass*)NULL; |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
244 break; |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
245 } |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
246 // if no override found yet, continue to search up |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
247 superk = instanceKlass::cast(superk->super()); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
248 } |
0 | 249 |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
250 return superk; |
0 | 251 } |
252 | |
253 | |
254 // Update child's copy of super vtable for overrides | |
255 // OR return true if a new vtable entry is required | |
256 // Only called for instanceKlass's, i.e. not for arrays | |
257 // If that changed, could not use _klass as handle for klass | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
258 bool klassVtable::update_inherited_vtable(instanceKlass* klass, methodHandle target_method, int super_vtable_len, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
259 bool checkconstraints, TRAPS) { |
0 | 260 ResourceMark rm; |
261 bool allocate_new = true; | |
262 assert(klass->oop_is_instance(), "must be instanceKlass"); | |
263 | |
264 // Initialize the method's vtable index to "nonvirtual". | |
265 // If we allocate a vtable entry, we will update it to a non-negative number. | |
266 target_method()->set_vtable_index(methodOopDesc::nonvirtual_vtable_index); | |
267 | |
268 // Static and <init> methods are never in | |
269 if (target_method()->is_static() || target_method()->name() == vmSymbols::object_initializer_name()) { | |
270 return false; | |
271 } | |
272 | |
273 if (klass->is_final() || target_method()->is_final()) { | |
274 // a final method never needs a new entry; final methods can be statically | |
275 // resolved and they have to be present in the vtable only if they override | |
276 // a super's method, in which case they re-use its entry | |
277 allocate_new = false; | |
278 } | |
279 | |
280 // we need a new entry if there is no superclass | |
281 if (klass->super() == NULL) { | |
282 return allocate_new; | |
283 } | |
284 | |
285 // private methods always have a new entry in the vtable | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
286 // specification interpretation since classic has |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
287 // private methods not overriding |
0 | 288 if (target_method()->is_private()) { |
289 return allocate_new; | |
290 } | |
291 | |
292 // search through the vtable and update overridden entries | |
293 // Since check_signature_loaders acquires SystemDictionary_lock | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
294 // which can block for gc, once we are in this loop, use handles |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
295 // For classfiles built with >= jdk7, we now look for transitive overrides |
0 | 296 |
297 symbolHandle name(THREAD,target_method()->name()); | |
298 symbolHandle signature(THREAD,target_method()->signature()); | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
299 Handle target_loader(THREAD, _klass->class_loader()); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
300 symbolHandle target_classname(THREAD, _klass->name()); |
0 | 301 for(int i = 0; i < super_vtable_len; i++) { |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
302 methodOop super_method = method_at(i); |
0 | 303 // Check if method name matches |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
304 if (super_method->name() == name() && super_method->signature() == signature()) { |
0 | 305 |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
306 // get super_klass for method_holder for the found method |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
307 instanceKlass* super_klass = instanceKlass::cast(super_method->method_holder()); |
0 | 308 |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
309 if ((super_klass->is_override(super_method, target_loader, target_classname, THREAD)) || |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
310 ((klass->major_version() >= VTABLE_TRANSITIVE_OVERRIDE_VERSION) |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
311 && ((super_klass = find_transitive_override(super_klass, target_method, i, target_loader, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
312 target_classname, THREAD)) != (instanceKlass*)NULL))) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
313 // overriding, so no new entry |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
314 allocate_new = false; |
0 | 315 |
316 if (checkconstraints) { | |
317 // Override vtable entry if passes loader constraint check | |
318 // if loader constraint checking requested | |
319 // No need to visit his super, since he and his super | |
320 // have already made any needed loader constraints. | |
321 // Since loader constraints are transitive, it is enough | |
322 // to link to the first super, and we get all the others. | |
323 Handle super_loader(THREAD, super_klass->class_loader()); | |
324 | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
325 if (target_loader() != super_loader()) { |
0 | 326 ResourceMark rm(THREAD); |
327 char* failed_type_name = | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
328 SystemDictionary::check_signature_loaders(signature, target_loader, |
0 | 329 super_loader, true, |
330 CHECK_(false)); | |
331 if (failed_type_name != NULL) { | |
332 const char* msg = "loader constraint violation: when resolving " | |
333 "overridden method \"%s\" the class loader (instance" | |
334 " of %s) of the current class, %s, and its superclass loader " | |
335 "(instance of %s), have different Class objects for the type " | |
336 "%s used in the signature"; | |
337 char* sig = target_method()->name_and_sig_as_C_string(); | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
338 const char* loader1 = SystemDictionary::loader_name(target_loader()); |
0 | 339 char* current = _klass->name()->as_C_string(); |
340 const char* loader2 = SystemDictionary::loader_name(super_loader()); | |
341 size_t buflen = strlen(msg) + strlen(sig) + strlen(loader1) + | |
342 strlen(current) + strlen(loader2) + strlen(failed_type_name); | |
343 char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen); | |
344 jio_snprintf(buf, buflen, msg, sig, loader1, current, loader2, | |
345 failed_type_name); | |
346 THROW_MSG_(vmSymbols::java_lang_LinkageError(), buf, false); | |
347 } | |
348 } | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
349 } |
0 | 350 |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
351 put_method_at(target_method(), i); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
352 target_method()->set_vtable_index(i); |
0 | 353 #ifndef PRODUCT |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
354 if (PrintVtables && Verbose) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
355 tty->print("overriding with %s::%s index %d, original flags: ", |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
356 _klass->internal_name(), (target_method() != NULL) ? |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
357 target_method()->name()->as_C_string() : "<NULL>", i); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
358 super_method->access_flags().print_on(tty); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
359 tty->print("overriders flags: "); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
360 target_method->access_flags().print_on(tty); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
361 tty->cr(); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
362 } |
0 | 363 #endif /*PRODUCT*/ |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
364 } else { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
365 // allocate_new = true; default. We might override one entry, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
366 // but not override another. Once we override one, not need new |
0 | 367 #ifndef PRODUCT |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
368 if (PrintVtables && Verbose) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
369 tty->print("NOT overriding with %s::%s index %d, original flags: ", |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
370 _klass->internal_name(), (target_method() != NULL) ? |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
371 target_method()->name()->as_C_string() : "<NULL>", i); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
372 super_method->access_flags().print_on(tty); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
373 tty->print("overriders flags: "); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
374 target_method->access_flags().print_on(tty); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
375 tty->cr(); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
376 } |
0 | 377 #endif /*PRODUCT*/ |
378 } | |
379 } | |
380 } | |
381 return allocate_new; | |
382 } | |
383 | |
384 void klassVtable::put_method_at(methodOop m, int index) { | |
385 assert(m->is_oop_or_null(), "Not an oop or null"); | |
386 #ifndef PRODUCT | |
387 if (PrintVtables && Verbose) { | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
388 ResourceMark rm; |
0 | 389 tty->print_cr("adding %s::%s at index %d", _klass->internal_name(), |
390 (m != NULL) ? m->name()->as_C_string() : "<NULL>", index); | |
391 } | |
392 assert(unchecked_method_at(index)->is_oop_or_null(), "Not an oop or null"); | |
393 #endif | |
394 table()[index].set(m); | |
395 } | |
396 | |
397 // Find out if a method "m" with superclass "super", loader "classloader" and | |
398 // name "classname" needs a new vtable entry. Let P be a class package defined | |
399 // by "classloader" and "classname". | |
400 // NOTE: The logic used here is very similar to the one used for computing | |
401 // the vtables indices for a method. We cannot directly use that function because, | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
402 // we allocate the instanceKlass at load time, and that requires that the |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
403 // superclass has been loaded. |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
404 // However, the vtable entries are filled in at link time, and therefore |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
405 // the superclass' vtable may not yet have been filled in. |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
406 bool klassVtable::needs_new_vtable_entry(methodHandle target_method, |
0 | 407 klassOop super, |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
408 Handle classloader, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
409 symbolHandle classname, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
410 AccessFlags class_flags, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
411 TRAPS) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
412 if ((class_flags.is_final() || target_method()->is_final()) || |
0 | 413 // a final method never needs a new entry; final methods can be statically |
414 // resolved and they have to be present in the vtable only if they override | |
415 // a super's method, in which case they re-use its entry | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
416 (target_method()->is_static()) || |
0 | 417 // static methods don't need to be in vtable |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
418 (target_method()->name() == vmSymbols::object_initializer_name()) |
0 | 419 // <init> is never called dynamically-bound |
420 ) { | |
421 return false; | |
422 } | |
423 | |
424 // we need a new entry if there is no superclass | |
425 if (super == NULL) { | |
426 return true; | |
427 } | |
428 | |
429 // private methods always have a new entry in the vtable | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
430 // specification interpretation since classic has |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
431 // private methods not overriding |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
432 if (target_method()->is_private()) { |
0 | 433 return true; |
434 } | |
435 | |
436 // search through the super class hierarchy to see if we need | |
437 // a new entry | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
438 ResourceMark rm; |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
439 symbolOop name = target_method()->name(); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
440 symbolOop signature = target_method()->signature(); |
0 | 441 klassOop k = super; |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
442 methodOop super_method = NULL; |
0 | 443 instanceKlass *holder = NULL; |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
444 methodOop recheck_method = NULL; |
0 | 445 while (k != NULL) { |
446 // lookup through the hierarchy for a method with matching name and sign. | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
447 super_method = instanceKlass::cast(k)->lookup_method(name, signature); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
448 if (super_method == NULL) { |
0 | 449 break; // we still have to search for a matching miranda method |
450 } | |
451 // get the class holding the matching method | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
452 // make sure you use that class for is_override |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
453 instanceKlass* superk = instanceKlass::cast(super_method->method_holder()); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
454 // we want only instance method matches |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
455 // pretend private methods are not in the super vtable |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
456 // since we do override around them: e.g. a.m pub/b.m private/c.m pub, |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
457 // ignore private, c.m pub does override a.m pub |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
458 // For classes that were not javac'd together, we also do transitive overriding around |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
459 // methods that have less accessibility |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
460 if ((!super_method->is_static()) && |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
461 (!super_method->is_private())) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
462 if (superk->is_override(super_method, classloader, classname, THREAD)) { |
0 | 463 return false; |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
464 // else keep looking for transitive overrides |
0 | 465 } |
466 } | |
467 | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
468 // Start with lookup result and continue to search up |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
469 k = superk->super(); // haven't found an override match yet; continue to look |
0 | 470 } |
471 | |
472 // if the target method is public or protected it may have a matching | |
473 // miranda method in the super, whose entry it should re-use. | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
474 // Actually, to handle cases that javac would not generate, we need |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
475 // this check for all access permissions. |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
476 instanceKlass *sk = instanceKlass::cast(super); |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
477 if (sk->has_miranda_methods()) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
478 if (sk->lookup_method_in_all_interfaces(name, signature) != NULL) { |
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
479 return false; // found a matching miranda; we do not need a new entry |
0 | 480 } |
481 } | |
482 return true; // found no match; we need a new entry | |
483 } | |
484 | |
485 // Support for miranda methods | |
486 | |
487 // get the vtable index of a miranda method with matching "name" and "signature" | |
488 int klassVtable::index_of_miranda(symbolOop name, symbolOop signature) { | |
489 // search from the bottom, might be faster | |
490 for (int i = (length() - 1); i >= 0; i--) { | |
491 methodOop m = table()[i].method(); | |
492 if (is_miranda_entry_at(i) && | |
493 m->name() == name && m->signature() == signature) { | |
494 return i; | |
495 } | |
496 } | |
497 return methodOopDesc::invalid_vtable_index; | |
498 } | |
499 | |
500 // check if an entry is miranda | |
501 bool klassVtable::is_miranda_entry_at(int i) { | |
502 methodOop m = method_at(i); | |
503 klassOop method_holder = m->method_holder(); | |
504 instanceKlass *mhk = instanceKlass::cast(method_holder); | |
505 | |
506 // miranda methods are interface methods in a class's vtable | |
507 if (mhk->is_interface()) { | |
508 assert(m->is_public() && m->is_abstract(), "should be public and abstract"); | |
509 assert(ik()->implements_interface(method_holder) , "this class should implement the interface"); | |
510 assert(is_miranda(m, ik()->methods(), ik()->super()), "should be a miranda_method"); | |
511 return true; | |
512 } | |
513 return false; | |
514 } | |
515 | |
516 // check if a method is a miranda method, given a class's methods table and it's super | |
517 // the caller must make sure that the method belongs to an interface implemented by the class | |
518 bool klassVtable::is_miranda(methodOop m, objArrayOop class_methods, klassOop super) { | |
519 symbolOop name = m->name(); | |
520 symbolOop signature = m->signature(); | |
2018
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
521 |
0 | 522 if (instanceKlass::find_method(class_methods, name, signature) == NULL) { |
2018
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
523 // did not find it in the method table of the current class |
0 | 524 if (super == NULL) { |
525 // super doesn't exist | |
526 return true; | |
2018
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
527 } |
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
528 |
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
529 methodOop mo = instanceKlass::cast(super)->lookup_method(name, signature); |
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
530 if (mo == NULL || mo->access_flags().is_private() ) { |
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
531 // super class hierarchy does not implement it or protection is different |
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
532 return true; |
0 | 533 } |
534 } | |
2018
642e54d1850a
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
1972
diff
changeset
|
535 |
0 | 536 return false; |
537 } | |
538 | |
539 void klassVtable::add_new_mirandas_to_list(GrowableArray<methodOop>* list_of_current_mirandas, | |
540 objArrayOop current_interface_methods, | |
541 objArrayOop class_methods, | |
542 klassOop super) { | |
543 // iterate thru the current interface's method to see if it a miranda | |
544 int num_methods = current_interface_methods->length(); | |
545 for (int i = 0; i < num_methods; i++) { | |
546 methodOop im = methodOop(current_interface_methods->obj_at(i)); | |
547 bool is_duplicate = false; | |
548 int num_of_current_mirandas = list_of_current_mirandas->length(); | |
549 // check for duplicate mirandas in different interfaces we implement | |
550 for (int j = 0; j < num_of_current_mirandas; j++) { | |
551 methodOop miranda = list_of_current_mirandas->at(j); | |
552 if ((im->name() == miranda->name()) && | |
553 (im->signature() == miranda->signature())) { | |
554 is_duplicate = true; | |
555 break; | |
556 } | |
557 } | |
558 | |
559 if (!is_duplicate) { // we don't want duplicate miranda entries in the vtable | |
560 if (is_miranda(im, class_methods, super)) { // is it a miranda at all? | |
561 instanceKlass *sk = instanceKlass::cast(super); | |
562 // check if it is a duplicate of a super's miranda | |
563 if (sk->lookup_method_in_all_interfaces(im->name(), im->signature()) == NULL) { | |
564 list_of_current_mirandas->append(im); | |
565 } | |
566 } | |
567 } | |
568 } | |
569 } | |
570 | |
571 void klassVtable::get_mirandas(GrowableArray<methodOop>* mirandas, | |
572 klassOop super, objArrayOop class_methods, | |
573 objArrayOop local_interfaces) { | |
574 assert((mirandas->length() == 0) , "current mirandas must be 0"); | |
575 | |
576 // iterate thru the local interfaces looking for a miranda | |
577 int num_local_ifs = local_interfaces->length(); | |
578 for (int i = 0; i < num_local_ifs; i++) { | |
579 instanceKlass *ik = instanceKlass::cast(klassOop(local_interfaces->obj_at(i))); | |
580 add_new_mirandas_to_list(mirandas, ik->methods(), class_methods, super); | |
581 // iterate thru each local's super interfaces | |
582 objArrayOop super_ifs = ik->transitive_interfaces(); | |
583 int num_super_ifs = super_ifs->length(); | |
584 for (int j = 0; j < num_super_ifs; j++) { | |
585 instanceKlass *sik = instanceKlass::cast(klassOop(super_ifs->obj_at(j))); | |
586 add_new_mirandas_to_list(mirandas, sik->methods(), class_methods, super); | |
587 } | |
588 } | |
589 } | |
590 | |
591 // get number of mirandas | |
592 int klassVtable::get_num_mirandas(klassOop super, objArrayOop class_methods, objArrayOop local_interfaces) { | |
593 ResourceMark rm; | |
594 GrowableArray<methodOop>* mirandas = new GrowableArray<methodOop>(20); | |
595 get_mirandas(mirandas, super, class_methods, local_interfaces); | |
596 return mirandas->length(); | |
597 } | |
598 | |
599 // fill in mirandas | |
600 void klassVtable::fill_in_mirandas(int& initialized) { | |
601 ResourceMark rm; | |
602 GrowableArray<methodOop>* mirandas = new GrowableArray<methodOop>(20); | |
603 instanceKlass *this_ik = ik(); | |
604 get_mirandas(mirandas, this_ik->super(), this_ik->methods(), this_ik->local_interfaces()); | |
605 int num_mirandas = mirandas->length(); | |
606 for (int i = 0; i < num_mirandas; i++) { | |
607 put_method_at(mirandas->at(i), initialized); | |
608 initialized++; | |
609 } | |
610 } | |
611 | |
612 void klassVtable::copy_vtable_to(vtableEntry* start) { | |
613 Copy::disjoint_words((HeapWord*)table(), (HeapWord*)start, _length * vtableEntry::size()); | |
614 } | |
615 | |
616 void klassVtable::adjust_method_entries(methodOop* old_methods, methodOop* new_methods, | |
617 int methods_length, bool * trace_name_printed) { | |
618 // search the vtable for uses of either obsolete or EMCP methods | |
619 for (int j = 0; j < methods_length; j++) { | |
620 methodOop old_method = old_methods[j]; | |
621 methodOop new_method = new_methods[j]; | |
622 | |
623 // In the vast majority of cases we could get the vtable index | |
624 // by using: old_method->vtable_index() | |
625 // However, there are rare cases, eg. sun.awt.X11.XDecoratedPeer.getX() | |
626 // in sun.awt.X11.XFramePeer where methods occur more than once in the | |
627 // vtable, so, alas, we must do an exhaustive search. | |
628 for (int index = 0; index < length(); index++) { | |
629 if (unchecked_method_at(index) == old_method) { | |
630 put_method_at(new_method, index); | |
631 | |
632 if (RC_TRACE_IN_RANGE(0x00100000, 0x00400000)) { | |
633 if (!(*trace_name_printed)) { | |
634 // RC_TRACE_MESG macro has an embedded ResourceMark | |
635 RC_TRACE_MESG(("adjust: name=%s", | |
636 Klass::cast(old_method->method_holder())->external_name())); | |
637 *trace_name_printed = true; | |
638 } | |
639 // RC_TRACE macro has an embedded ResourceMark | |
640 RC_TRACE(0x00100000, ("vtable method update: %s(%s)", | |
641 new_method->name()->as_C_string(), | |
642 new_method->signature()->as_C_string())); | |
643 } | |
644 } | |
645 } | |
646 } | |
647 } | |
648 | |
649 | |
650 // Garbage collection | |
651 void klassVtable::oop_follow_contents() { | |
652 int len = length(); | |
653 for (int i = 0; i < len; i++) { | |
654 MarkSweep::mark_and_push(adr_method_at(i)); | |
655 } | |
656 } | |
657 | |
658 #ifndef SERIALGC | |
659 void klassVtable::oop_follow_contents(ParCompactionManager* cm) { | |
660 int len = length(); | |
661 for (int i = 0; i < len; i++) { | |
662 PSParallelCompact::mark_and_push(cm, adr_method_at(i)); | |
663 } | |
664 } | |
665 #endif // SERIALGC | |
666 | |
667 void klassVtable::oop_adjust_pointers() { | |
668 int len = length(); | |
669 for (int i = 0; i < len; i++) { | |
670 MarkSweep::adjust_pointer(adr_method_at(i)); | |
671 } | |
672 } | |
673 | |
674 #ifndef SERIALGC | |
675 void klassVtable::oop_update_pointers(ParCompactionManager* cm) { | |
676 const int n = length(); | |
677 for (int i = 0; i < n; i++) { | |
678 PSParallelCompact::adjust_pointer(adr_method_at(i)); | |
679 } | |
680 } | |
681 | |
682 void klassVtable::oop_update_pointers(ParCompactionManager* cm, | |
683 HeapWord* beg_addr, HeapWord* end_addr) { | |
684 const int n = length(); | |
685 const int entry_size = vtableEntry::size(); | |
686 | |
687 int beg_idx = 0; | |
688 HeapWord* const method_0 = (HeapWord*)adr_method_at(0); | |
689 if (beg_addr > method_0) { | |
690 // it's safe to use cast, as we have guarantees on vtable size to be sane | |
691 beg_idx = int((pointer_delta(beg_addr, method_0) + entry_size - 1) / entry_size); | |
692 } | |
693 | |
694 oop* const beg_oop = adr_method_at(beg_idx); | |
695 oop* const end_oop = MIN2((oop*)end_addr, adr_method_at(n)); | |
696 for (oop* cur_oop = beg_oop; cur_oop < end_oop; cur_oop += entry_size) { | |
697 PSParallelCompact::adjust_pointer(cur_oop); | |
698 } | |
699 } | |
700 #endif // SERIALGC | |
701 | |
702 // Iterators | |
703 void klassVtable::oop_oop_iterate(OopClosure* blk) { | |
704 int len = length(); | |
705 for (int i = 0; i < len; i++) { | |
706 blk->do_oop(adr_method_at(i)); | |
707 } | |
708 } | |
709 | |
710 void klassVtable::oop_oop_iterate_m(OopClosure* blk, MemRegion mr) { | |
711 int len = length(); | |
712 int i; | |
713 for (i = 0; i < len; i++) { | |
714 if ((HeapWord*)adr_method_at(i) >= mr.start()) break; | |
715 } | |
716 for (; i < len; i++) { | |
717 oop* adr = adr_method_at(i); | |
718 if ((HeapWord*)adr < mr.end()) blk->do_oop(adr); | |
719 } | |
720 } | |
721 | |
722 //----------------------------------------------------------------------------------------- | |
723 // Itable code | |
724 | |
725 // Initialize a itableMethodEntry | |
726 void itableMethodEntry::initialize(methodOop m) { | |
727 if (m == NULL) return; | |
728 | |
729 _method = m; | |
730 } | |
731 | |
732 klassItable::klassItable(instanceKlassHandle klass) { | |
733 _klass = klass; | |
734 | |
735 if (klass->itable_length() > 0) { | |
736 itableOffsetEntry* offset_entry = (itableOffsetEntry*)klass->start_of_itable(); | |
737 if (offset_entry != NULL && offset_entry->interface_klass() != NULL) { // Check that itable is initialized | |
738 // First offset entry points to the first method_entry | |
739 intptr_t* method_entry = (intptr_t *)(((address)klass->as_klassOop()) + offset_entry->offset()); | |
740 intptr_t* end = klass->end_of_itable(); | |
741 | |
742 _table_offset = (intptr_t*)offset_entry - (intptr_t*)klass->as_klassOop(); | |
743 _size_offset_table = (method_entry - ((intptr_t*)offset_entry)) / itableOffsetEntry::size(); | |
744 _size_method_table = (end - method_entry) / itableMethodEntry::size(); | |
745 assert(_table_offset >= 0 && _size_offset_table >= 0 && _size_method_table >= 0, "wrong computation"); | |
746 return; | |
747 } | |
748 } | |
749 | |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
750 // The length of the itable was either zero, or it has not yet been initialized. |
0 | 751 _table_offset = 0; |
752 _size_offset_table = 0; | |
753 _size_method_table = 0; | |
754 } | |
755 | |
756 // Garbage Collection | |
757 | |
758 void klassItable::oop_follow_contents() { | |
759 // offset table | |
760 itableOffsetEntry* ioe = offset_entry(0); | |
761 for(int i = 0; i < _size_offset_table; i++) { | |
762 MarkSweep::mark_and_push((oop*)&ioe->_interface); | |
763 ioe++; | |
764 } | |
765 | |
766 // method table | |
767 itableMethodEntry* ime = method_entry(0); | |
768 for(int j = 0; j < _size_method_table; j++) { | |
769 MarkSweep::mark_and_push((oop*)&ime->_method); | |
770 ime++; | |
771 } | |
772 } | |
773 | |
774 #ifndef SERIALGC | |
775 void klassItable::oop_follow_contents(ParCompactionManager* cm) { | |
776 // offset table | |
777 itableOffsetEntry* ioe = offset_entry(0); | |
778 for(int i = 0; i < _size_offset_table; i++) { | |
779 PSParallelCompact::mark_and_push(cm, (oop*)&ioe->_interface); | |
780 ioe++; | |
781 } | |
782 | |
783 // method table | |
784 itableMethodEntry* ime = method_entry(0); | |
785 for(int j = 0; j < _size_method_table; j++) { | |
786 PSParallelCompact::mark_and_push(cm, (oop*)&ime->_method); | |
787 ime++; | |
788 } | |
789 } | |
790 #endif // SERIALGC | |
791 | |
792 void klassItable::oop_adjust_pointers() { | |
793 // offset table | |
794 itableOffsetEntry* ioe = offset_entry(0); | |
795 for(int i = 0; i < _size_offset_table; i++) { | |
796 MarkSweep::adjust_pointer((oop*)&ioe->_interface); | |
797 ioe++; | |
798 } | |
799 | |
800 // method table | |
801 itableMethodEntry* ime = method_entry(0); | |
802 for(int j = 0; j < _size_method_table; j++) { | |
803 MarkSweep::adjust_pointer((oop*)&ime->_method); | |
804 ime++; | |
805 } | |
806 } | |
807 | |
808 #ifndef SERIALGC | |
809 void klassItable::oop_update_pointers(ParCompactionManager* cm) { | |
810 // offset table | |
811 itableOffsetEntry* ioe = offset_entry(0); | |
812 for(int i = 0; i < _size_offset_table; i++) { | |
813 PSParallelCompact::adjust_pointer((oop*)&ioe->_interface); | |
814 ioe++; | |
815 } | |
816 | |
817 // method table | |
818 itableMethodEntry* ime = method_entry(0); | |
819 for(int j = 0; j < _size_method_table; j++) { | |
820 PSParallelCompact::adjust_pointer((oop*)&ime->_method); | |
821 ime++; | |
822 } | |
823 } | |
824 | |
825 void klassItable::oop_update_pointers(ParCompactionManager* cm, | |
826 HeapWord* beg_addr, HeapWord* end_addr) { | |
827 // offset table | |
828 itableOffsetEntry* ioe = offset_entry(0); | |
829 for(int i = 0; i < _size_offset_table; i++) { | |
830 oop* p = (oop*)&ioe->_interface; | |
831 PSParallelCompact::adjust_pointer(p, beg_addr, end_addr); | |
832 ioe++; | |
833 } | |
834 | |
835 // method table | |
836 itableMethodEntry* ime = method_entry(0); | |
837 for(int j = 0; j < _size_method_table; j++) { | |
838 oop* p = (oop*)&ime->_method; | |
839 PSParallelCompact::adjust_pointer(p, beg_addr, end_addr); | |
840 ime++; | |
841 } | |
842 } | |
843 #endif // SERIALGC | |
844 | |
845 // Iterators | |
846 void klassItable::oop_oop_iterate(OopClosure* blk) { | |
847 // offset table | |
848 itableOffsetEntry* ioe = offset_entry(0); | |
849 for(int i = 0; i < _size_offset_table; i++) { | |
850 blk->do_oop((oop*)&ioe->_interface); | |
851 ioe++; | |
852 } | |
853 | |
854 // method table | |
855 itableMethodEntry* ime = method_entry(0); | |
856 for(int j = 0; j < _size_method_table; j++) { | |
857 blk->do_oop((oop*)&ime->_method); | |
858 ime++; | |
859 } | |
860 } | |
861 | |
862 void klassItable::oop_oop_iterate_m(OopClosure* blk, MemRegion mr) { | |
863 // offset table | |
864 itableOffsetEntry* ioe = offset_entry(0); | |
865 for(int i = 0; i < _size_offset_table; i++) { | |
866 oop* adr = (oop*)&ioe->_interface; | |
867 if (mr.contains(adr)) blk->do_oop(adr); | |
868 ioe++; | |
869 } | |
870 | |
871 // method table | |
872 itableMethodEntry* ime = method_entry(0); | |
873 for(int j = 0; j < _size_method_table; j++) { | |
874 oop* adr = (oop*)&ime->_method; | |
875 if (mr.contains(adr)) blk->do_oop(adr); | |
876 ime++; | |
877 } | |
878 } | |
879 | |
880 | |
881 static int initialize_count = 0; | |
882 | |
883 // Initialization | |
884 void klassItable::initialize_itable(bool checkconstraints, TRAPS) { | |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
885 // Cannot be setup doing bootstrapping, interfaces don't have |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
886 // itables, and klass with only ones entry have empty itables |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
887 if (Universe::is_bootstrapping() || |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
888 _klass->is_interface() || |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
889 _klass->itable_length() == itableOffsetEntry::size()) return; |
0 | 890 |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
891 // There's alway an extra itable entry so we can null-terminate it. |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
892 guarantee(size_offset_table() >= 1, "too small"); |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
893 int num_interfaces = size_offset_table() - 1; |
0 | 894 if (num_interfaces > 0) { |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
895 if (TraceItables) tty->print_cr("%3d: Initializing itables for %s", ++initialize_count, |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
896 _klass->name()->as_C_string()); |
0 | 897 |
898 | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
899 // Iterate through all interfaces |
0 | 900 int i; |
901 for(i = 0; i < num_interfaces; i++) { | |
902 itableOffsetEntry* ioe = offset_entry(i); | |
903 KlassHandle interf_h (THREAD, ioe->interface_klass()); | |
904 assert(interf_h() != NULL && ioe->offset() != 0, "bad offset entry in itable"); | |
905 initialize_itable_for_interface(ioe->offset(), interf_h, checkconstraints, CHECK); | |
906 } | |
907 | |
908 } | |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
909 // Check that the last entry is empty |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
910 itableOffsetEntry* ioe = offset_entry(size_offset_table() - 1); |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
911 guarantee(ioe->interface_klass() == NULL && ioe->offset() == 0, "terminator entry missing"); |
0 | 912 } |
913 | |
914 | |
915 void klassItable::initialize_itable_for_interface(int method_table_offset, KlassHandle interf_h, bool checkconstraints, TRAPS) { | |
916 objArrayHandle methods(THREAD, instanceKlass::cast(interf_h())->methods()); | |
917 int nof_methods = methods()->length(); | |
918 HandleMark hm; | |
919 KlassHandle klass = _klass; | |
1489
cff162798819
6888953: some calls to function-like macros are missing semicolons
jcoomes
parents:
676
diff
changeset
|
920 assert(nof_methods > 0, "at least one method must exist for interface to be in vtable"); |
0 | 921 Handle interface_loader (THREAD, instanceKlass::cast(interf_h())->class_loader()); |
922 int ime_num = 0; | |
923 | |
924 // Skip first methodOop if it is a class initializer | |
925 int i = ((methodOop)methods()->obj_at(0))->name() != vmSymbols::class_initializer_name() ? 0 : 1; | |
926 | |
927 // m, method_name, method_signature, klass reset each loop so they | |
928 // don't need preserving across check_signature_loaders call | |
929 // methods needs a handle in case of gc from check_signature_loaders | |
930 for(; i < nof_methods; i++) { | |
931 methodOop m = (methodOop)methods()->obj_at(i); | |
932 symbolOop method_name = m->name(); | |
933 symbolOop method_signature = m->signature(); | |
934 | |
935 // This is same code as in Linkresolver::lookup_instance_method_in_klasses | |
936 methodOop target = klass->uncached_lookup_method(method_name, method_signature); | |
937 while (target != NULL && target->is_static()) { | |
938 // continue with recursive lookup through the superclass | |
939 klassOop super = Klass::cast(target->method_holder())->super(); | |
940 target = (super == NULL) ? methodOop(NULL) : Klass::cast(super)->uncached_lookup_method(method_name, method_signature); | |
941 } | |
942 if (target == NULL || !target->is_public() || target->is_abstract()) { | |
943 // Entry do not resolve. Leave it empty | |
944 } else { | |
945 // Entry did resolve, check loader constraints before initializing | |
946 // if checkconstraints requested | |
947 methodHandle target_h (THREAD, target); // preserve across gc | |
948 if (checkconstraints) { | |
949 Handle method_holder_loader (THREAD, instanceKlass::cast(target->method_holder())->class_loader()); | |
950 if (method_holder_loader() != interface_loader()) { | |
951 ResourceMark rm(THREAD); | |
952 char* failed_type_name = | |
953 SystemDictionary::check_signature_loaders(method_signature, | |
954 method_holder_loader, | |
955 interface_loader, | |
956 true, CHECK); | |
957 if (failed_type_name != NULL) { | |
958 const char* msg = "loader constraint violation in interface " | |
959 "itable initialization: when resolving method \"%s\" the class" | |
960 " loader (instance of %s) of the current class, %s, " | |
961 "and the class loader (instance of %s) for interface " | |
962 "%s have different Class objects for the type %s " | |
963 "used in the signature"; | |
964 char* sig = target_h()->name_and_sig_as_C_string(); | |
965 const char* loader1 = SystemDictionary::loader_name(method_holder_loader()); | |
966 char* current = klass->name()->as_C_string(); | |
967 const char* loader2 = SystemDictionary::loader_name(interface_loader()); | |
968 char* iface = instanceKlass::cast(interf_h())->name()->as_C_string(); | |
969 size_t buflen = strlen(msg) + strlen(sig) + strlen(loader1) + | |
970 strlen(current) + strlen(loader2) + strlen(iface) + | |
971 strlen(failed_type_name); | |
972 char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen); | |
973 jio_snprintf(buf, buflen, msg, sig, loader1, current, loader2, | |
974 iface, failed_type_name); | |
975 THROW_MSG(vmSymbols::java_lang_LinkageError(), buf); | |
976 } | |
977 } | |
978 } | |
979 | |
980 // ime may have moved during GC so recalculate address | |
981 itableOffsetEntry::method_entry(_klass(), method_table_offset)[ime_num].initialize(target_h()); | |
982 } | |
983 // Progress to next entry | |
984 ime_num++; | |
985 } | |
986 } | |
987 | |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
988 // Update entry for specific methodOop |
0 | 989 void klassItable::initialize_with_method(methodOop m) { |
990 itableMethodEntry* ime = method_entry(0); | |
991 for(int i = 0; i < _size_method_table; i++) { | |
992 if (ime->method() == m) { | |
993 ime->initialize(m); | |
994 } | |
995 ime++; | |
996 } | |
997 } | |
998 | |
999 void klassItable::adjust_method_entries(methodOop* old_methods, methodOop* new_methods, | |
1000 int methods_length, bool * trace_name_printed) { | |
1001 // search the itable for uses of either obsolete or EMCP methods | |
1002 for (int j = 0; j < methods_length; j++) { | |
1003 methodOop old_method = old_methods[j]; | |
1004 methodOop new_method = new_methods[j]; | |
1005 itableMethodEntry* ime = method_entry(0); | |
1006 | |
610
70998f2e05ef
6805864: 4/3 Problem with jvmti->redefineClasses: some methods don't get redefined
dcubed
parents:
196
diff
changeset
|
1007 // The itable can describe more than one interface and the same |
70998f2e05ef
6805864: 4/3 Problem with jvmti->redefineClasses: some methods don't get redefined
dcubed
parents:
196
diff
changeset
|
1008 // method signature can be specified by more than one interface. |
70998f2e05ef
6805864: 4/3 Problem with jvmti->redefineClasses: some methods don't get redefined
dcubed
parents:
196
diff
changeset
|
1009 // This means we have to do an exhaustive search to find all the |
70998f2e05ef
6805864: 4/3 Problem with jvmti->redefineClasses: some methods don't get redefined
dcubed
parents:
196
diff
changeset
|
1010 // old_method references. |
0 | 1011 for (int i = 0; i < _size_method_table; i++) { |
1012 if (ime->method() == old_method) { | |
1013 ime->initialize(new_method); | |
1014 | |
1015 if (RC_TRACE_IN_RANGE(0x00100000, 0x00400000)) { | |
1016 if (!(*trace_name_printed)) { | |
1017 // RC_TRACE_MESG macro has an embedded ResourceMark | |
1018 RC_TRACE_MESG(("adjust: name=%s", | |
1019 Klass::cast(old_method->method_holder())->external_name())); | |
1020 *trace_name_printed = true; | |
1021 } | |
1022 // RC_TRACE macro has an embedded ResourceMark | |
1023 RC_TRACE(0x00200000, ("itable method update: %s(%s)", | |
1024 new_method->name()->as_C_string(), | |
1025 new_method->signature()->as_C_string())); | |
1026 } | |
652
4aaa9f5e02a8
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
610
diff
changeset
|
1027 break; |
0 | 1028 } |
1029 ime++; | |
1030 } | |
1031 } | |
1032 } | |
1033 | |
1034 | |
1035 // Setup | |
1036 class InterfaceVisiterClosure : public StackObj { | |
1037 public: | |
1038 virtual void doit(klassOop intf, int method_count) = 0; | |
1039 }; | |
1040 | |
1041 // Visit all interfaces with at-least one method (excluding <clinit>) | |
1042 void visit_all_interfaces(objArrayOop transitive_intf, InterfaceVisiterClosure *blk) { | |
1043 // Handle array argument | |
1044 for(int i = 0; i < transitive_intf->length(); i++) { | |
1045 klassOop intf = (klassOop)transitive_intf->obj_at(i); | |
1046 assert(Klass::cast(intf)->is_interface(), "sanity check"); | |
1047 | |
1048 // Find no. of methods excluding a <clinit> | |
1049 int method_count = instanceKlass::cast(intf)->methods()->length(); | |
1050 if (method_count > 0) { | |
1051 methodOop m = (methodOop)instanceKlass::cast(intf)->methods()->obj_at(0); | |
1052 assert(m != NULL && m->is_method(), "sanity check"); | |
1053 if (m->name() == vmSymbols::object_initializer_name()) { | |
1054 method_count--; | |
1055 } | |
1056 } | |
1057 | |
1058 // Only count interfaces with at least one method | |
1059 if (method_count > 0) { | |
1060 blk->doit(intf, method_count); | |
1061 } | |
1062 } | |
1063 } | |
1064 | |
1065 class CountInterfacesClosure : public InterfaceVisiterClosure { | |
1066 private: | |
1067 int _nof_methods; | |
1068 int _nof_interfaces; | |
1069 public: | |
1070 CountInterfacesClosure() { _nof_methods = 0; _nof_interfaces = 0; } | |
1071 | |
1072 int nof_methods() const { return _nof_methods; } | |
1073 int nof_interfaces() const { return _nof_interfaces; } | |
1074 | |
1075 void doit(klassOop intf, int method_count) { _nof_methods += method_count; _nof_interfaces++; } | |
1076 }; | |
1077 | |
1078 class SetupItableClosure : public InterfaceVisiterClosure { | |
1079 private: | |
1080 itableOffsetEntry* _offset_entry; | |
1081 itableMethodEntry* _method_entry; | |
1082 address _klass_begin; | |
1083 public: | |
1084 SetupItableClosure(address klass_begin, itableOffsetEntry* offset_entry, itableMethodEntry* method_entry) { | |
1085 _klass_begin = klass_begin; | |
1086 _offset_entry = offset_entry; | |
1087 _method_entry = method_entry; | |
1088 } | |
1089 | |
1090 itableMethodEntry* method_entry() const { return _method_entry; } | |
1091 | |
1092 void doit(klassOop intf, int method_count) { | |
1093 int offset = ((address)_method_entry) - _klass_begin; | |
1094 _offset_entry->initialize(intf, offset); | |
1095 _offset_entry++; | |
1096 _method_entry += method_count; | |
1097 } | |
1098 }; | |
1099 | |
1100 int klassItable::compute_itable_size(objArrayHandle transitive_interfaces) { | |
1101 // Count no of interfaces and total number of interface methods | |
1102 CountInterfacesClosure cic; | |
1103 visit_all_interfaces(transitive_interfaces(), &cic); | |
1104 | |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
1105 // There's alway an extra itable entry so we can null-terminate it. |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
1106 int itable_size = calc_itable_size(cic.nof_interfaces() + 1, cic.nof_methods()); |
0 | 1107 |
1108 // Statistics | |
1109 update_stats(itable_size * HeapWordSize); | |
1110 | |
1111 return itable_size; | |
1112 } | |
1113 | |
1114 | |
1115 // Fill out offset table and interface klasses into the itable space | |
1116 void klassItable::setup_itable_offset_table(instanceKlassHandle klass) { | |
1117 if (klass->itable_length() == 0) return; | |
1118 assert(!klass->is_interface(), "Should have zero length itable"); | |
1119 | |
1120 // Count no of interfaces and total number of interface methods | |
1121 CountInterfacesClosure cic; | |
1122 visit_all_interfaces(klass->transitive_interfaces(), &cic); | |
1123 int nof_methods = cic.nof_methods(); | |
1124 int nof_interfaces = cic.nof_interfaces(); | |
1125 | |
16
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
1126 // Add one extra entry so we can null-terminate the table |
f8236e79048a
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
0
diff
changeset
|
1127 nof_interfaces++; |
0 | 1128 |
1129 assert(compute_itable_size(objArrayHandle(klass->transitive_interfaces())) == | |
1130 calc_itable_size(nof_interfaces, nof_methods), | |
1131 "mismatch calculation of itable size"); | |
1132 | |
1133 // Fill-out offset table | |
1134 itableOffsetEntry* ioe = (itableOffsetEntry*)klass->start_of_itable(); | |
1135 itableMethodEntry* ime = (itableMethodEntry*)(ioe + nof_interfaces); | |
1136 intptr_t* end = klass->end_of_itable(); | |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
16
diff
changeset
|
1137 assert((oop*)(ime + nof_methods) <= (oop*)klass->start_of_static_fields(), "wrong offset calculation (1)"); |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
16
diff
changeset
|
1138 assert((oop*)(end) == (oop*)(ime + nof_methods), "wrong offset calculation (2)"); |
0 | 1139 |
1140 // Visit all interfaces and initialize itable offset table | |
1141 SetupItableClosure sic((address)klass->as_klassOop(), ioe, ime); | |
1142 visit_all_interfaces(klass->transitive_interfaces(), &sic); | |
1143 | |
1144 #ifdef ASSERT | |
1145 ime = sic.method_entry(); | |
1146 oop* v = (oop*) klass->end_of_itable(); | |
1147 assert( (oop*)(ime) == v, "wrong offset calculation (2)"); | |
1148 #endif | |
1149 } | |
1150 | |
1151 | |
1152 // m must be a method in an interface | |
1153 int klassItable::compute_itable_index(methodOop m) { | |
1154 klassOop intf = m->method_holder(); | |
1155 assert(instanceKlass::cast(intf)->is_interface(), "sanity check"); | |
1156 objArrayOop methods = instanceKlass::cast(intf)->methods(); | |
1157 int index = 0; | |
1158 while(methods->obj_at(index) != m) { | |
1159 index++; | |
1160 assert(index < methods->length(), "should find index for resolve_invoke"); | |
1161 } | |
1162 // Adjust for <clinit>, which is left out of table if first method | |
1163 if (methods->length() > 0 && ((methodOop)methods->obj_at(0))->name() == vmSymbols::class_initializer_name()) { | |
1164 index--; | |
1165 } | |
1166 return index; | |
1167 } | |
1168 | |
665
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1169 |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1170 // inverse to compute_itable_index |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1171 methodOop klassItable::method_for_itable_index(klassOop intf, int itable_index) { |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1172 assert(instanceKlass::cast(intf)->is_interface(), "sanity check"); |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1173 objArrayOop methods = instanceKlass::cast(intf)->methods(); |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1174 |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1175 int index = itable_index; |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1176 // Adjust for <clinit>, which is left out of table if first method |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1177 if (methods->length() > 0 && ((methodOop)methods->obj_at(0))->name() == vmSymbols::class_initializer_name()) { |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1178 index++; |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1179 } |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1180 |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1181 if (itable_index < 0 || index >= methods->length()) |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1182 return NULL; // help caller defend against bad indexes |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1183 |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1184 methodOop m = (methodOop)methods->obj_at(index); |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1185 assert(compute_itable_index(m) == itable_index, "correct inverse"); |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1186 |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1187 return m; |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1188 } |
c89f86385056
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
610
diff
changeset
|
1189 |
0 | 1190 void klassVtable::verify(outputStream* st, bool forced) { |
1191 // make sure table is initialized | |
1192 if (!Universe::is_fully_initialized()) return; | |
1193 #ifndef PRODUCT | |
1194 // avoid redundant verifies | |
1195 if (!forced && _verify_count == Universe::verify_count()) return; | |
1196 _verify_count = Universe::verify_count(); | |
1197 #endif | |
1198 oop* end_of_obj = (oop*)_klass() + _klass()->size(); | |
1199 oop* end_of_vtable = (oop *)&table()[_length]; | |
1200 if (end_of_vtable > end_of_obj) { | |
1490
f03d0a26bf83
6888954: argument formatting for assert() and friends
jcoomes
parents:
1489
diff
changeset
|
1201 fatal(err_msg("klass %s: klass object too short (vtable extends beyond " |
f03d0a26bf83
6888954: argument formatting for assert() and friends
jcoomes
parents:
1489
diff
changeset
|
1202 "end)", _klass->internal_name())); |
0 | 1203 } |
1204 | |
1205 for (int i = 0; i < _length; i++) table()[i].verify(this, st); | |
1206 // verify consistency with superKlass vtable | |
1207 klassOop super = _klass->super(); | |
1208 if (super != NULL) { | |
1209 instanceKlass* sk = instanceKlass::cast(super); | |
1210 klassVtable* vt = sk->vtable(); | |
1211 for (int i = 0; i < vt->length(); i++) { | |
1212 verify_against(st, vt, i); | |
1213 } | |
1214 } | |
1215 } | |
1216 | |
1217 void klassVtable::verify_against(outputStream* st, klassVtable* vt, int index) { | |
1218 vtableEntry* vte = &vt->table()[index]; | |
1219 if (vte->method()->name() != table()[index].method()->name() || | |
1220 vte->method()->signature() != table()[index].method()->signature()) { | |
1221 fatal("mismatched name/signature of vtable entries"); | |
1222 } | |
1223 } | |
1224 | |
1225 #ifndef PRODUCT | |
1226 void klassVtable::print() { | |
1227 ResourceMark rm; | |
1228 tty->print("klassVtable for klass %s (length %d):\n", _klass->internal_name(), length()); | |
1229 for (int i = 0; i < length(); i++) { | |
1230 table()[i].print(); | |
1231 tty->cr(); | |
1232 } | |
1233 } | |
1234 #endif | |
1235 | |
1236 void vtableEntry::verify(klassVtable* vt, outputStream* st) { | |
1237 NOT_PRODUCT(FlagSetting fs(IgnoreLockingAssertions, true)); | |
1238 assert(method() != NULL, "must have set method"); | |
1239 method()->verify(); | |
1240 // we sub_type, because it could be a miranda method | |
1241 if (!vt->klass()->is_subtype_of(method()->method_holder())) { | |
1242 #ifndef PRODUCT | |
1243 print(); | |
1244 #endif | |
1490
f03d0a26bf83
6888954: argument formatting for assert() and friends
jcoomes
parents:
1489
diff
changeset
|
1245 fatal(err_msg("vtableEntry " PTR_FORMAT ": method is from subclass", this)); |
0 | 1246 } |
1247 } | |
1248 | |
1249 #ifndef PRODUCT | |
1250 | |
1251 void vtableEntry::print() { | |
1252 ResourceMark rm; | |
1253 tty->print("vtableEntry %s: ", method()->name()->as_C_string()); | |
1254 if (Verbose) { | |
1255 tty->print("m %#lx ", (address)method()); | |
1256 } | |
1257 } | |
1258 | |
1259 class VtableStats : AllStatic { | |
1260 public: | |
1261 static int no_klasses; // # classes with vtables | |
1262 static int no_array_klasses; // # array classes | |
1263 static int no_instance_klasses; // # instanceKlasses | |
1264 static int sum_of_vtable_len; // total # of vtable entries | |
1265 static int sum_of_array_vtable_len; // total # of vtable entries in array klasses only | |
1266 static int fixed; // total fixed overhead in bytes | |
1267 static int filler; // overhead caused by filler bytes | |
1268 static int entries; // total bytes consumed by vtable entries | |
1269 static int array_entries; // total bytes consumed by array vtable entries | |
1270 | |
1271 static void do_class(klassOop k) { | |
1272 Klass* kl = k->klass_part(); | |
1273 klassVtable* vt = kl->vtable(); | |
1274 if (vt == NULL) return; | |
1275 no_klasses++; | |
1276 if (kl->oop_is_instance()) { | |
1277 no_instance_klasses++; | |
1278 kl->array_klasses_do(do_class); | |
1279 } | |
1280 if (kl->oop_is_array()) { | |
1281 no_array_klasses++; | |
1282 sum_of_array_vtable_len += vt->length(); | |
1283 } | |
1284 sum_of_vtable_len += vt->length(); | |
1285 } | |
1286 | |
1287 static void compute() { | |
1288 SystemDictionary::classes_do(do_class); | |
1289 fixed = no_klasses * oopSize; // vtable length | |
1290 // filler size is a conservative approximation | |
1291 filler = oopSize * (no_klasses - no_instance_klasses) * (sizeof(instanceKlass) - sizeof(arrayKlass) - 1); | |
1292 entries = sizeof(vtableEntry) * sum_of_vtable_len; | |
1293 array_entries = sizeof(vtableEntry) * sum_of_array_vtable_len; | |
1294 } | |
1295 }; | |
1296 | |
1297 int VtableStats::no_klasses = 0; | |
1298 int VtableStats::no_array_klasses = 0; | |
1299 int VtableStats::no_instance_klasses = 0; | |
1300 int VtableStats::sum_of_vtable_len = 0; | |
1301 int VtableStats::sum_of_array_vtable_len = 0; | |
1302 int VtableStats::fixed = 0; | |
1303 int VtableStats::filler = 0; | |
1304 int VtableStats::entries = 0; | |
1305 int VtableStats::array_entries = 0; | |
1306 | |
1307 void klassVtable::print_statistics() { | |
1308 ResourceMark rm; | |
1309 HandleMark hm; | |
1310 VtableStats::compute(); | |
1311 tty->print_cr("vtable statistics:"); | |
1312 tty->print_cr("%6d classes (%d instance, %d array)", VtableStats::no_klasses, VtableStats::no_instance_klasses, VtableStats::no_array_klasses); | |
1313 int total = VtableStats::fixed + VtableStats::filler + VtableStats::entries; | |
1314 tty->print_cr("%6d bytes fixed overhead (refs + vtable object header)", VtableStats::fixed); | |
1315 tty->print_cr("%6d bytes filler overhead", VtableStats::filler); | |
1316 tty->print_cr("%6d bytes for vtable entries (%d for arrays)", VtableStats::entries, VtableStats::array_entries); | |
1317 tty->print_cr("%6d bytes total", total); | |
1318 } | |
1319 | |
1320 bool klassVtable::check_no_old_entries() { | |
1321 // Check that there really is no entry | |
1322 for (int i = 0; i < length(); i++) { | |
1323 methodOop m = unchecked_method_at(i); | |
1324 if (m != NULL) { | |
1325 if (m->is_old()) { | |
1326 return false; | |
1327 } | |
1328 } | |
1329 } | |
1330 return true; | |
1331 } | |
1332 | |
1333 void klassVtable::dump_vtable() { | |
1334 tty->print_cr("vtable dump --"); | |
1335 for (int i = 0; i < length(); i++) { | |
1336 methodOop m = unchecked_method_at(i); | |
1337 if (m != NULL) { | |
1338 tty->print(" (%5d) ", i); | |
1339 m->access_flags().print_on(tty); | |
1340 tty->print(" -- "); | |
1341 m->print_name(tty); | |
1342 tty->cr(); | |
1343 } | |
1344 } | |
1345 } | |
1346 | |
1347 int klassItable::_total_classes; // Total no. of classes with itables | |
1348 long klassItable::_total_size; // Total no. of bytes used for itables | |
1349 | |
1350 void klassItable::print_statistics() { | |
1351 tty->print_cr("itable statistics:"); | |
1352 tty->print_cr("%6d classes with itables", _total_classes); | |
1353 tty->print_cr("%6d K uses for itables (average by class: %d bytes)", _total_size / K, _total_size / _total_classes); | |
1354 } | |
1355 | |
1356 #endif // PRODUCT |