Mercurial > hg > graal-jvmci-8
annotate src/share/vm/opto/loopTransform.cpp @ 24234:ea6f94ab283b default tip
Added tag jvmci-0.36 for changeset 8128b98d4736
author | Gilles Duboscq <gilles.m.duboscq@oracle.com> |
---|---|
date | Mon, 18 Sep 2017 18:49:45 +0200 |
parents | f13e777eb255 |
children |
rev | line source |
---|---|
0 | 1 /* |
14223
de6a9e811145
8029233: Update copyright year to match last edit in jdk8 hotspot repository for 2013
mikael
parents:
13045
diff
changeset
|
2 * Copyright (c) 2000, 2013, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1303
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1303
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1303
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "compiler/compileLog.hpp" | |
27 #include "memory/allocation.inline.hpp" | |
28 #include "opto/addnode.hpp" | |
29 #include "opto/callnode.hpp" | |
30 #include "opto/connode.hpp" | |
31 #include "opto/divnode.hpp" | |
32 #include "opto/loopnode.hpp" | |
33 #include "opto/mulnode.hpp" | |
34 #include "opto/rootnode.hpp" | |
35 #include "opto/runtime.hpp" | |
36 #include "opto/subnode.hpp" | |
0 | 37 |
38 //------------------------------is_loop_exit----------------------------------- | |
39 // Given an IfNode, return the loop-exiting projection or NULL if both | |
40 // arms remain in the loop. | |
41 Node *IdealLoopTree::is_loop_exit(Node *iff) const { | |
42 if( iff->outcnt() != 2 ) return NULL; // Ignore partially dead tests | |
43 PhaseIdealLoop *phase = _phase; | |
44 // Test is an IfNode, has 2 projections. If BOTH are in the loop | |
45 // we need loop unswitching instead of peeling. | |
46 if( !is_member(phase->get_loop( iff->raw_out(0) )) ) | |
47 return iff->raw_out(0); | |
48 if( !is_member(phase->get_loop( iff->raw_out(1) )) ) | |
49 return iff->raw_out(1); | |
50 return NULL; | |
51 } | |
52 | |
53 | |
54 //============================================================================= | |
55 | |
56 | |
57 //------------------------------record_for_igvn---------------------------- | |
58 // Put loop body on igvn work list | |
59 void IdealLoopTree::record_for_igvn() { | |
60 for( uint i = 0; i < _body.size(); i++ ) { | |
61 Node *n = _body.at(i); | |
62 _phase->_igvn._worklist.push(n); | |
63 } | |
64 } | |
65 | |
2465 | 66 //------------------------------compute_exact_trip_count----------------------- |
67 // Compute loop exact trip count if possible. Do not recalculate trip count for | |
68 // split loops (pre-main-post) which have their limits and inits behind Opaque node. | |
69 void IdealLoopTree::compute_exact_trip_count( PhaseIdealLoop *phase ) { | |
70 if (!_head->as_Loop()->is_valid_counted_loop()) { | |
71 return; | |
72 } | |
73 CountedLoopNode* cl = _head->as_CountedLoop(); | |
74 // Trip count may become nonexact for iteration split loops since | |
75 // RCE modifies limits. Note, _trip_count value is not reset since | |
76 // it is used to limit unrolling of main loop. | |
77 cl->set_nonexact_trip_count(); | |
78 | |
79 // Loop's test should be part of loop. | |
80 if (!phase->is_member(this, phase->get_ctrl(cl->loopexit()->in(CountedLoopEndNode::TestValue)))) | |
81 return; // Infinite loop | |
82 | |
83 #ifdef ASSERT | |
84 BoolTest::mask bt = cl->loopexit()->test_trip(); | |
85 assert(bt == BoolTest::lt || bt == BoolTest::gt || | |
3456 | 86 bt == BoolTest::ne, "canonical test is expected"); |
2465 | 87 #endif |
88 | |
89 Node* init_n = cl->init_trip(); | |
90 Node* limit_n = cl->limit(); | |
91 if (init_n != NULL && init_n->is_Con() && | |
92 limit_n != NULL && limit_n->is_Con()) { | |
93 // Use longs to avoid integer overflow. | |
94 int stride_con = cl->stride_con(); | |
6846 | 95 jlong init_con = cl->init_trip()->get_int(); |
96 jlong limit_con = cl->limit()->get_int(); | |
2465 | 97 int stride_m = stride_con - (stride_con > 0 ? 1 : -1); |
6846 | 98 jlong trip_count = (limit_con - init_con + stride_m)/stride_con; |
2465 | 99 if (trip_count > 0 && (julong)trip_count < (julong)max_juint) { |
100 // Set exact trip count. | |
101 cl->set_exact_trip_count((uint)trip_count); | |
102 } | |
103 } | |
104 } | |
105 | |
0 | 106 //------------------------------compute_profile_trip_cnt---------------------------- |
107 // Compute loop trip count from profile data as | |
108 // (backedge_count + loop_exit_count) / loop_exit_count | |
109 void IdealLoopTree::compute_profile_trip_cnt( PhaseIdealLoop *phase ) { | |
110 if (!_head->is_CountedLoop()) { | |
111 return; | |
112 } | |
113 CountedLoopNode* head = _head->as_CountedLoop(); | |
114 if (head->profile_trip_cnt() != COUNT_UNKNOWN) { | |
115 return; // Already computed | |
116 } | |
117 float trip_cnt = (float)max_jint; // default is big | |
118 | |
119 Node* back = head->in(LoopNode::LoopBackControl); | |
120 while (back != head) { | |
121 if ((back->Opcode() == Op_IfTrue || back->Opcode() == Op_IfFalse) && | |
122 back->in(0) && | |
123 back->in(0)->is_If() && | |
124 back->in(0)->as_If()->_fcnt != COUNT_UNKNOWN && | |
125 back->in(0)->as_If()->_prob != PROB_UNKNOWN) { | |
126 break; | |
127 } | |
128 back = phase->idom(back); | |
129 } | |
130 if (back != head) { | |
131 assert((back->Opcode() == Op_IfTrue || back->Opcode() == Op_IfFalse) && | |
132 back->in(0), "if-projection exists"); | |
133 IfNode* back_if = back->in(0)->as_If(); | |
134 float loop_back_cnt = back_if->_fcnt * back_if->_prob; | |
135 | |
136 // Now compute a loop exit count | |
137 float loop_exit_cnt = 0.0f; | |
138 for( uint i = 0; i < _body.size(); i++ ) { | |
139 Node *n = _body[i]; | |
140 if( n->is_If() ) { | |
141 IfNode *iff = n->as_If(); | |
142 if( iff->_fcnt != COUNT_UNKNOWN && iff->_prob != PROB_UNKNOWN ) { | |
143 Node *exit = is_loop_exit(iff); | |
144 if( exit ) { | |
145 float exit_prob = iff->_prob; | |
146 if (exit->Opcode() == Op_IfFalse) exit_prob = 1.0 - exit_prob; | |
147 if (exit_prob > PROB_MIN) { | |
148 float exit_cnt = iff->_fcnt * exit_prob; | |
149 loop_exit_cnt += exit_cnt; | |
150 } | |
151 } | |
152 } | |
153 } | |
154 } | |
155 if (loop_exit_cnt > 0.0f) { | |
156 trip_cnt = (loop_back_cnt + loop_exit_cnt) / loop_exit_cnt; | |
157 } else { | |
158 // No exit count so use | |
159 trip_cnt = loop_back_cnt; | |
160 } | |
161 } | |
162 #ifndef PRODUCT | |
163 if (TraceProfileTripCount) { | |
164 tty->print_cr("compute_profile_trip_cnt lp: %d cnt: %f\n", head->_idx, trip_cnt); | |
165 } | |
166 #endif | |
167 head->set_profile_trip_cnt(trip_cnt); | |
168 } | |
169 | |
170 //---------------------is_invariant_addition----------------------------- | |
171 // Return nonzero index of invariant operand for an Add or Sub | |
605 | 172 // of (nonconstant) invariant and variant values. Helper for reassociate_invariants. |
0 | 173 int IdealLoopTree::is_invariant_addition(Node* n, PhaseIdealLoop *phase) { |
174 int op = n->Opcode(); | |
175 if (op == Op_AddI || op == Op_SubI) { | |
176 bool in1_invar = this->is_invariant(n->in(1)); | |
177 bool in2_invar = this->is_invariant(n->in(2)); | |
178 if (in1_invar && !in2_invar) return 1; | |
179 if (!in1_invar && in2_invar) return 2; | |
180 } | |
181 return 0; | |
182 } | |
183 | |
184 //---------------------reassociate_add_sub----------------------------- | |
185 // Reassociate invariant add and subtract expressions: | |
186 // | |
187 // inv1 + (x + inv2) => ( inv1 + inv2) + x | |
188 // (x + inv2) + inv1 => ( inv1 + inv2) + x | |
189 // inv1 + (x - inv2) => ( inv1 - inv2) + x | |
190 // inv1 - (inv2 - x) => ( inv1 - inv2) + x | |
191 // (x + inv2) - inv1 => (-inv1 + inv2) + x | |
192 // (x - inv2) + inv1 => ( inv1 - inv2) + x | |
193 // (x - inv2) - inv1 => (-inv1 - inv2) + x | |
194 // inv1 + (inv2 - x) => ( inv1 + inv2) - x | |
195 // inv1 - (x - inv2) => ( inv1 + inv2) - x | |
196 // (inv2 - x) + inv1 => ( inv1 + inv2) - x | |
197 // (inv2 - x) - inv1 => (-inv1 + inv2) - x | |
198 // inv1 - (x + inv2) => ( inv1 - inv2) - x | |
199 // | |
200 Node* IdealLoopTree::reassociate_add_sub(Node* n1, PhaseIdealLoop *phase) { | |
201 if (!n1->is_Add() && !n1->is_Sub() || n1->outcnt() == 0) return NULL; | |
202 if (is_invariant(n1)) return NULL; | |
203 int inv1_idx = is_invariant_addition(n1, phase); | |
204 if (!inv1_idx) return NULL; | |
205 // Don't mess with add of constant (igvn moves them to expression tree root.) | |
206 if (n1->is_Add() && n1->in(2)->is_Con()) return NULL; | |
207 Node* inv1 = n1->in(inv1_idx); | |
208 Node* n2 = n1->in(3 - inv1_idx); | |
209 int inv2_idx = is_invariant_addition(n2, phase); | |
210 if (!inv2_idx) return NULL; | |
211 Node* x = n2->in(3 - inv2_idx); | |
212 Node* inv2 = n2->in(inv2_idx); | |
213 | |
214 bool neg_x = n2->is_Sub() && inv2_idx == 1; | |
215 bool neg_inv2 = n2->is_Sub() && inv2_idx == 2; | |
216 bool neg_inv1 = n1->is_Sub() && inv1_idx == 2; | |
217 if (n1->is_Sub() && inv1_idx == 1) { | |
218 neg_x = !neg_x; | |
219 neg_inv2 = !neg_inv2; | |
220 } | |
221 Node* inv1_c = phase->get_ctrl(inv1); | |
222 Node* inv2_c = phase->get_ctrl(inv2); | |
223 Node* n_inv1; | |
224 if (neg_inv1) { | |
225 Node *zero = phase->_igvn.intcon(0); | |
226 phase->set_ctrl(zero, phase->C->root()); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
227 n_inv1 = new (phase->C) SubINode(zero, inv1); |
0 | 228 phase->register_new_node(n_inv1, inv1_c); |
229 } else { | |
230 n_inv1 = inv1; | |
231 } | |
232 Node* inv; | |
233 if (neg_inv2) { | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
234 inv = new (phase->C) SubINode(n_inv1, inv2); |
0 | 235 } else { |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
236 inv = new (phase->C) AddINode(n_inv1, inv2); |
0 | 237 } |
238 phase->register_new_node(inv, phase->get_early_ctrl(inv)); | |
239 | |
240 Node* addx; | |
241 if (neg_x) { | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
242 addx = new (phase->C) SubINode(inv, x); |
0 | 243 } else { |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
244 addx = new (phase->C) AddINode(x, inv); |
0 | 245 } |
246 phase->register_new_node(addx, phase->get_ctrl(x)); | |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
247 phase->_igvn.replace_node(n1, addx); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
248 assert(phase->get_loop(phase->get_ctrl(n1)) == this, ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
249 _body.yank(n1); |
0 | 250 return addx; |
251 } | |
252 | |
253 //---------------------reassociate_invariants----------------------------- | |
254 // Reassociate invariant expressions: | |
255 void IdealLoopTree::reassociate_invariants(PhaseIdealLoop *phase) { | |
256 for (int i = _body.size() - 1; i >= 0; i--) { | |
257 Node *n = _body.at(i); | |
258 for (int j = 0; j < 5; j++) { | |
259 Node* nn = reassociate_add_sub(n, phase); | |
260 if (nn == NULL) break; | |
261 n = nn; // again | |
262 }; | |
263 } | |
264 } | |
265 | |
266 //------------------------------policy_peeling--------------------------------- | |
267 // Return TRUE or FALSE if the loop should be peeled or not. Peel if we can | |
268 // make some loop-invariant test (usually a null-check) happen before the loop. | |
269 bool IdealLoopTree::policy_peeling( PhaseIdealLoop *phase ) const { | |
270 Node *test = ((IdealLoopTree*)this)->tail(); | |
271 int body_size = ((IdealLoopTree*)this)->_body.size(); | |
272 // Peeling does loop cloning which can result in O(N^2) node construction | |
273 if( body_size > 255 /* Prevent overflow for large body_size */ | |
20671
9e69e8d1c900
8058148: MaxNodeLimit and LiveNodeCountInliningCutoff
vlivanov
parents:
17887
diff
changeset
|
274 || (body_size * body_size + phase->C->live_nodes()) > phase->C->max_node_limit() ) { |
0 | 275 return false; // too large to safely clone |
276 } | |
277 while( test != _head ) { // Scan till run off top of loop | |
278 if( test->is_If() ) { // Test? | |
279 Node *ctrl = phase->get_ctrl(test->in(1)); | |
280 if (ctrl->is_top()) | |
281 return false; // Found dead test on live IF? No peeling! | |
282 // Standard IF only has one input value to check for loop invariance | |
283 assert( test->Opcode() == Op_If || test->Opcode() == Op_CountedLoopEnd, "Check this code when new subtype is added"); | |
284 // Condition is not a member of this loop? | |
285 if( !is_member(phase->get_loop(ctrl)) && | |
286 is_loop_exit(test) ) | |
287 return true; // Found reason to peel! | |
288 } | |
289 // Walk up dominators to loop _head looking for test which is | |
290 // executed on every path thru loop. | |
291 test = phase->idom(test); | |
292 } | |
293 return false; | |
294 } | |
295 | |
296 //------------------------------peeled_dom_test_elim--------------------------- | |
297 // If we got the effect of peeling, either by actually peeling or by making | |
298 // a pre-loop which must execute at least once, we can remove all | |
299 // loop-invariant dominated tests in the main body. | |
300 void PhaseIdealLoop::peeled_dom_test_elim( IdealLoopTree *loop, Node_List &old_new ) { | |
301 bool progress = true; | |
302 while( progress ) { | |
303 progress = false; // Reset for next iteration | |
304 Node *prev = loop->_head->in(LoopNode::LoopBackControl);//loop->tail(); | |
305 Node *test = prev->in(0); | |
306 while( test != loop->_head ) { // Scan till run off top of loop | |
307 | |
308 int p_op = prev->Opcode(); | |
309 if( (p_op == Op_IfFalse || p_op == Op_IfTrue) && | |
310 test->is_If() && // Test? | |
311 !test->in(1)->is_Con() && // And not already obvious? | |
312 // Condition is not a member of this loop? | |
313 !loop->is_member(get_loop(get_ctrl(test->in(1))))){ | |
314 // Walk loop body looking for instances of this test | |
315 for( uint i = 0; i < loop->_body.size(); i++ ) { | |
316 Node *n = loop->_body.at(i); | |
317 if( n->is_If() && n->in(1) == test->in(1) /*&& n != loop->tail()->in(0)*/ ) { | |
318 // IfNode was dominated by version in peeled loop body | |
319 progress = true; | |
320 dominated_by( old_new[prev->_idx], n ); | |
321 } | |
322 } | |
323 } | |
324 prev = test; | |
325 test = idom(test); | |
326 } // End of scan tests in loop | |
327 | |
328 } // End of while( progress ) | |
329 } | |
330 | |
331 //------------------------------do_peeling------------------------------------- | |
332 // Peel the first iteration of the given loop. | |
333 // Step 1: Clone the loop body. The clone becomes the peeled iteration. | |
334 // The pre-loop illegally has 2 control users (old & new loops). | |
335 // Step 2: Make the old-loop fall-in edges point to the peeled iteration. | |
336 // Do this by making the old-loop fall-in edges act as if they came | |
337 // around the loopback from the prior iteration (follow the old-loop | |
338 // backedges) and then map to the new peeled iteration. This leaves | |
339 // the pre-loop with only 1 user (the new peeled iteration), but the | |
340 // peeled-loop backedge has 2 users. | |
341 // Step 3: Cut the backedge on the clone (so its not a loop) and remove the | |
342 // extra backedge user. | |
2445 | 343 // |
344 // orig | |
345 // | |
346 // stmt1 | |
347 // | | |
348 // v | |
349 // loop predicate | |
350 // | | |
351 // v | |
352 // loop<----+ | |
353 // | | | |
354 // stmt2 | | |
355 // | | | |
356 // v | | |
357 // if ^ | |
358 // / \ | | |
359 // / \ | | |
360 // v v | | |
361 // false true | | |
362 // / \ | | |
363 // / ----+ | |
364 // | | |
365 // v | |
366 // exit | |
367 // | |
368 // | |
369 // after clone loop | |
370 // | |
371 // stmt1 | |
372 // | | |
373 // v | |
374 // loop predicate | |
375 // / \ | |
376 // clone / \ orig | |
377 // / \ | |
378 // / \ | |
379 // v v | |
380 // +---->loop clone loop<----+ | |
381 // | | | | | |
382 // | stmt2 clone stmt2 | | |
383 // | | | | | |
384 // | v v | | |
385 // ^ if clone If ^ | |
386 // | / \ / \ | | |
387 // | / \ / \ | | |
388 // | v v v v | | |
389 // | true false false true | | |
390 // | / \ / \ | | |
391 // +---- \ / ----+ | |
392 // \ / | |
393 // 1v v2 | |
394 // region | |
395 // | | |
396 // v | |
397 // exit | |
398 // | |
399 // | |
400 // after peel and predicate move | |
401 // | |
402 // stmt1 | |
403 // / | |
404 // / | |
405 // clone / orig | |
406 // / | |
407 // / +----------+ | |
408 // / | | | |
409 // / loop predicate | | |
410 // / | | | |
411 // v v | | |
412 // TOP-->loop clone loop<----+ | | |
413 // | | | | | |
414 // stmt2 clone stmt2 | | | |
415 // | | | ^ | |
416 // v v | | | |
417 // if clone If ^ | | |
418 // / \ / \ | | | |
419 // / \ / \ | | | |
420 // v v v v | | | |
421 // true false false true | | | |
422 // | \ / \ | | | |
423 // | \ / ----+ ^ | |
424 // | \ / | | |
425 // | 1v v2 | | |
426 // v region | | |
427 // | | | | |
428 // | v | | |
429 // | exit | | |
430 // | | | |
431 // +--------------->-----------------+ | |
432 // | |
433 // | |
434 // final graph | |
435 // | |
436 // stmt1 | |
437 // | | |
438 // v | |
439 // stmt2 clone | |
440 // | | |
441 // v | |
442 // if clone | |
443 // / | | |
444 // / | | |
445 // v v | |
446 // false true | |
447 // | | | |
448 // | v | |
449 // | loop predicate | |
450 // | | | |
451 // | v | |
452 // | loop<----+ | |
453 // | | | | |
454 // | stmt2 | | |
455 // | | | | |
456 // | v | | |
457 // v if ^ | |
458 // | / \ | | |
459 // | / \ | | |
460 // | v v | | |
461 // | false true | | |
462 // | | \ | | |
463 // v v --+ | |
464 // region | |
465 // | | |
466 // v | |
467 // exit | |
468 // | |
0 | 469 void PhaseIdealLoop::do_peeling( IdealLoopTree *loop, Node_List &old_new ) { |
470 | |
471 C->set_major_progress(); | |
472 // Peeling a 'main' loop in a pre/main/post situation obfuscates the | |
473 // 'pre' loop from the main and the 'pre' can no longer have it's | |
474 // iterations adjusted. Therefore, we need to declare this loop as | |
475 // no longer a 'main' loop; it will need new pre and post loops before | |
476 // we can do further RCE. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
477 #ifndef PRODUCT |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
478 if (TraceLoopOpts) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
479 tty->print("Peel "); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
480 loop->dump_head(); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
481 } |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
482 #endif |
2445 | 483 Node* head = loop->_head; |
484 bool counted_loop = head->is_CountedLoop(); | |
485 if (counted_loop) { | |
486 CountedLoopNode *cl = head->as_CountedLoop(); | |
0 | 487 assert(cl->trip_count() > 0, "peeling a fully unrolled loop"); |
488 cl->set_trip_count(cl->trip_count() - 1); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
489 if (cl->is_main_loop()) { |
0 | 490 cl->set_normal_loop(); |
491 #ifndef PRODUCT | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
492 if (PrintOpto && VerifyLoopOptimizations) { |
0 | 493 tty->print("Peeling a 'main' loop; resetting to 'normal' "); |
494 loop->dump_head(); | |
495 } | |
496 #endif | |
497 } | |
498 } | |
2445 | 499 Node* entry = head->in(LoopNode::EntryControl); |
0 | 500 |
501 // Step 1: Clone the loop body. The clone becomes the peeled iteration. | |
502 // The pre-loop illegally has 2 control users (old & new loops). | |
2445 | 503 clone_loop( loop, old_new, dom_depth(head) ); |
0 | 504 |
505 // Step 2: Make the old-loop fall-in edges point to the peeled iteration. | |
506 // Do this by making the old-loop fall-in edges act as if they came | |
507 // around the loopback from the prior iteration (follow the old-loop | |
508 // backedges) and then map to the new peeled iteration. This leaves | |
509 // the pre-loop with only 1 user (the new peeled iteration), but the | |
510 // peeled-loop backedge has 2 users. | |
3845
c96c3eb1efae
7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents:
3788
diff
changeset
|
511 Node* new_entry = old_new[head->in(LoopNode::LoopBackControl)->_idx]; |
2445 | 512 _igvn.hash_delete(head); |
3845
c96c3eb1efae
7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents:
3788
diff
changeset
|
513 head->set_req(LoopNode::EntryControl, new_entry); |
2445 | 514 for (DUIterator_Fast jmax, j = head->fast_outs(jmax); j < jmax; j++) { |
515 Node* old = head->fast_out(j); | |
516 if (old->in(0) == loop->_head && old->req() == 3 && old->is_Phi()) { | |
3845
c96c3eb1efae
7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents:
3788
diff
changeset
|
517 Node* new_exit_value = old_new[old->in(LoopNode::LoopBackControl)->_idx]; |
2445 | 518 if (!new_exit_value ) // Backedge value is ALSO loop invariant? |
0 | 519 // Then loop body backedge value remains the same. |
520 new_exit_value = old->in(LoopNode::LoopBackControl); | |
521 _igvn.hash_delete(old); | |
522 old->set_req(LoopNode::EntryControl, new_exit_value); | |
523 } | |
524 } | |
525 | |
526 | |
527 // Step 3: Cut the backedge on the clone (so its not a loop) and remove the | |
528 // extra backedge user. | |
2445 | 529 Node* new_head = old_new[head->_idx]; |
530 _igvn.hash_delete(new_head); | |
531 new_head->set_req(LoopNode::LoopBackControl, C->top()); | |
532 for (DUIterator_Fast j2max, j2 = new_head->fast_outs(j2max); j2 < j2max; j2++) { | |
533 Node* use = new_head->fast_out(j2); | |
534 if (use->in(0) == new_head && use->req() == 3 && use->is_Phi()) { | |
0 | 535 _igvn.hash_delete(use); |
536 use->set_req(LoopNode::LoopBackControl, C->top()); | |
537 } | |
538 } | |
539 | |
540 | |
541 // Step 4: Correct dom-depth info. Set to loop-head depth. | |
2445 | 542 int dd = dom_depth(head); |
543 set_idom(head, head->in(1), dd); | |
0 | 544 for (uint j3 = 0; j3 < loop->_body.size(); j3++) { |
545 Node *old = loop->_body.at(j3); | |
546 Node *nnn = old_new[old->_idx]; | |
547 if (!has_ctrl(nnn)) | |
548 set_idom(nnn, idom(nnn), dd-1); | |
549 } | |
550 | |
551 // Now force out all loop-invariant dominating tests. The optimizer | |
552 // finds some, but we _know_ they are all useless. | |
553 peeled_dom_test_elim(loop,old_new); | |
554 | |
555 loop->record_for_igvn(); | |
556 } | |
557 | |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
558 #define EMPTY_LOOP_SIZE 7 // number of nodes in an empty loop |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
559 |
0 | 560 //------------------------------policy_maximally_unroll------------------------ |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
561 // Calculate exact loop trip count and return true if loop can be maximally |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
562 // unrolled. |
0 | 563 bool IdealLoopTree::policy_maximally_unroll( PhaseIdealLoop *phase ) const { |
564 CountedLoopNode *cl = _head->as_CountedLoop(); | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
565 assert(cl->is_normal_loop(), ""); |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
566 if (!cl->is_valid_counted_loop()) |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
567 return false; // Malformed counted loop |
0 | 568 |
2465 | 569 if (!cl->has_exact_trip_count()) { |
570 // Trip count is not exact. | |
0 | 571 return false; |
572 } | |
573 | |
2465 | 574 uint trip_count = cl->trip_count(); |
575 // Note, max_juint is used to indicate unknown trip count. | |
576 assert(trip_count > 1, "one iteration loop should be optimized out already"); | |
577 assert(trip_count < max_juint, "exact trip_count should be less than max_uint."); | |
0 | 578 |
579 // Real policy: if we maximally unroll, does it get too big? | |
580 // Allow the unrolled mess to get larger than standard loop | |
581 // size. After all, it will no longer be a loop. | |
582 uint body_size = _body.size(); | |
583 uint unroll_limit = (uint)LoopUnrollLimit * 4; | |
584 assert( (intx)unroll_limit == LoopUnrollLimit * 4, "LoopUnrollLimit must fit in 32bits"); | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
585 if (trip_count > unroll_limit || body_size > unroll_limit) { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
586 return false; |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
587 } |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
588 |
3345 | 589 // Fully unroll a loop with few iterations regardless next |
590 // conditions since following loop optimizations will split | |
591 // such loop anyway (pre-main-post). | |
592 if (trip_count <= 3) | |
593 return true; | |
594 | |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
595 // Take into account that after unroll conjoined heads and tails will fold, |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
596 // otherwise policy_unroll() may allow more unrolling than max unrolling. |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
597 uint new_body_size = EMPTY_LOOP_SIZE + (body_size - EMPTY_LOOP_SIZE) * trip_count; |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
598 uint tst_body_size = (new_body_size - EMPTY_LOOP_SIZE) / trip_count + EMPTY_LOOP_SIZE; |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
599 if (body_size != tst_body_size) // Check for int overflow |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
600 return false; |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
601 if (new_body_size > unroll_limit || |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
602 // Unrolling can result in a large amount of node construction |
20671
9e69e8d1c900
8058148: MaxNodeLimit and LiveNodeCountInliningCutoff
vlivanov
parents:
17887
diff
changeset
|
603 new_body_size >= phase->C->max_node_limit() - phase->C->live_nodes()) { |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
604 return false; |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
605 } |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
606 |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
607 // Do not unroll a loop with String intrinsics code. |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
608 // String intrinsics are large and have loops. |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
609 for (uint k = 0; k < _body.size(); k++) { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
610 Node* n = _body.at(k); |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
611 switch (n->Opcode()) { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
612 case Op_StrComp: |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
613 case Op_StrEquals: |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
614 case Op_StrIndexOf: |
7637
b30b3c2a0cf2
6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86
kvn
parents:
7196
diff
changeset
|
615 case Op_EncodeISOArray: |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
616 case Op_AryEq: { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
617 return false; |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
618 } |
17780 | 619 #if INCLUDE_RTM_OPT |
620 case Op_FastLock: | |
621 case Op_FastUnlock: { | |
622 // Don't unroll RTM locking code because it is large. | |
623 if (UseRTMLocking) { | |
624 return false; | |
625 } | |
626 } | |
627 #endif | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
628 } // switch |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
629 } |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
630 |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
631 return true; // Do maximally unroll |
0 | 632 } |
633 | |
634 | |
635 //------------------------------policy_unroll---------------------------------- | |
636 // Return TRUE or FALSE if the loop should be unrolled or not. Unroll if | |
637 // the loop is a CountedLoop and the body is small enough. | |
638 bool IdealLoopTree::policy_unroll( PhaseIdealLoop *phase ) const { | |
639 | |
640 CountedLoopNode *cl = _head->as_CountedLoop(); | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
641 assert(cl->is_normal_loop() || cl->is_main_loop(), ""); |
0 | 642 |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
643 if (!cl->is_valid_counted_loop()) |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
644 return false; // Malformed counted loop |
0 | 645 |
3345 | 646 // Protect against over-unrolling. |
647 // After split at least one iteration will be executed in pre-loop. | |
648 if (cl->trip_count() <= (uint)(cl->is_normal_loop() ? 2 : 1)) return false; | |
0 | 649 |
3333 | 650 int future_unroll_ct = cl->unrolled_count() * 2; |
12027
bcc4f6f54d83
8022993: Convert MAX_UNROLL constant to LoopMaxUnroll C2 flag
kvn
parents:
8779
diff
changeset
|
651 if (future_unroll_ct > LoopMaxUnroll) return false; |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
652 |
3333 | 653 // Check for initial stride being a small enough constant |
654 if (abs(cl->stride_con()) > (1<<2)*future_unroll_ct) return false; | |
0 | 655 |
656 // Don't unroll if the next round of unrolling would push us | |
657 // over the expected trip count of the loop. One is subtracted | |
658 // from the expected trip count because the pre-loop normally | |
659 // executes 1 iteration. | |
660 if (UnrollLimitForProfileCheck > 0 && | |
661 cl->profile_trip_cnt() != COUNT_UNKNOWN && | |
662 future_unroll_ct > UnrollLimitForProfileCheck && | |
663 (float)future_unroll_ct > cl->profile_trip_cnt() - 1.0) { | |
664 return false; | |
665 } | |
666 | |
667 // When unroll count is greater than LoopUnrollMin, don't unroll if: | |
668 // the residual iterations are more than 10% of the trip count | |
669 // and rounds of "unroll,optimize" are not making significant progress | |
670 // Progress defined as current size less than 20% larger than previous size. | |
671 if (UseSuperWord && cl->node_count_before_unroll() > 0 && | |
672 future_unroll_ct > LoopUnrollMin && | |
673 (future_unroll_ct - 1) * 10.0 > cl->profile_trip_cnt() && | |
674 1.2 * cl->node_count_before_unroll() < (double)_body.size()) { | |
675 return false; | |
676 } | |
677 | |
678 Node *init_n = cl->init_trip(); | |
679 Node *limit_n = cl->limit(); | |
3345 | 680 int stride_con = cl->stride_con(); |
0 | 681 // Non-constant bounds. |
682 // Protect against over-unrolling when init or/and limit are not constant | |
683 // (so that trip_count's init value is maxint) but iv range is known. | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
684 if (init_n == NULL || !init_n->is_Con() || |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
685 limit_n == NULL || !limit_n->is_Con()) { |
0 | 686 Node* phi = cl->phi(); |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
687 if (phi != NULL) { |
0 | 688 assert(phi->is_Phi() && phi->in(0) == _head, "Counted loop should have iv phi."); |
689 const TypeInt* iv_type = phase->_igvn.type(phi)->is_int(); | |
3345 | 690 int next_stride = stride_con * 2; // stride after this unroll |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
691 if (next_stride > 0) { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
692 if (iv_type->_lo + next_stride <= iv_type->_lo || // overflow |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
693 iv_type->_lo + next_stride > iv_type->_hi) { |
0 | 694 return false; // over-unrolling |
695 } | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
696 } else if (next_stride < 0) { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
697 if (iv_type->_hi + next_stride >= iv_type->_hi || // overflow |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
698 iv_type->_hi + next_stride < iv_type->_lo) { |
0 | 699 return false; // over-unrolling |
700 } | |
701 } | |
702 } | |
703 } | |
704 | |
3345 | 705 // After unroll limit will be adjusted: new_limit = limit-stride. |
706 // Bailout if adjustment overflow. | |
707 const TypeInt* limit_type = phase->_igvn.type(limit_n)->is_int(); | |
708 if (stride_con > 0 && ((limit_type->_hi - stride_con) >= limit_type->_hi) || | |
709 stride_con < 0 && ((limit_type->_lo - stride_con) <= limit_type->_lo)) | |
710 return false; // overflow | |
711 | |
0 | 712 // Adjust body_size to determine if we unroll or not |
713 uint body_size = _body.size(); | |
3930
da6a29fb0da5
7054211: No loop unrolling done in jdk7b144 for a test update() while loop
kvn
parents:
3850
diff
changeset
|
714 // Key test to unroll loop in CRC32 java code |
da6a29fb0da5
7054211: No loop unrolling done in jdk7b144 for a test update() while loop
kvn
parents:
3850
diff
changeset
|
715 int xors_in_loop = 0; |
0 | 716 // Also count ModL, DivL and MulL which expand mightly |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
717 for (uint k = 0; k < _body.size(); k++) { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
718 Node* n = _body.at(k); |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
719 switch (n->Opcode()) { |
3930
da6a29fb0da5
7054211: No loop unrolling done in jdk7b144 for a test update() while loop
kvn
parents:
3850
diff
changeset
|
720 case Op_XorI: xors_in_loop++; break; // CRC32 java code |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
721 case Op_ModL: body_size += 30; break; |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
722 case Op_DivL: body_size += 30; break; |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
723 case Op_MulL: body_size += 10; break; |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
724 case Op_StrComp: |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
725 case Op_StrEquals: |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
726 case Op_StrIndexOf: |
7637
b30b3c2a0cf2
6896617: Optimize sun.nio.cs.ISO_8859_1$Encode.encodeArrayLoop() on x86
kvn
parents:
7196
diff
changeset
|
727 case Op_EncodeISOArray: |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
728 case Op_AryEq: { |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
729 // Do not unroll a loop with String intrinsics code. |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
730 // String intrinsics are large and have loops. |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
731 return false; |
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
732 } |
17780 | 733 #if INCLUDE_RTM_OPT |
734 case Op_FastLock: | |
735 case Op_FastUnlock: { | |
736 // Don't unroll RTM locking code because it is large. | |
737 if (UseRTMLocking) { | |
738 return false; | |
739 } | |
740 } | |
741 #endif | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
742 } // switch |
0 | 743 } |
744 | |
745 // Check for being too big | |
2412
f9424955eb18
7029152: Ideal nodes for String intrinsics miss memory edge optimization
kvn
parents:
2403
diff
changeset
|
746 if (body_size > (uint)LoopUnrollLimit) { |
3930
da6a29fb0da5
7054211: No loop unrolling done in jdk7b144 for a test update() while loop
kvn
parents:
3850
diff
changeset
|
747 if (xors_in_loop >= 4 && body_size < (uint)LoopUnrollLimit*4) return true; |
da6a29fb0da5
7054211: No loop unrolling done in jdk7b144 for a test update() while loop
kvn
parents:
3850
diff
changeset
|
748 // Normal case: loop too big |
0 | 749 return false; |
750 } | |
751 | |
752 // Unroll once! (Each trip will soon do double iterations) | |
753 return true; | |
754 } | |
755 | |
756 //------------------------------policy_align----------------------------------- | |
757 // Return TRUE or FALSE if the loop should be cache-line aligned. Gather the | |
758 // expression that does the alignment. Note that only one array base can be | |
605 | 759 // aligned in a loop (unless the VM guarantees mutual alignment). Note that |
0 | 760 // if we vectorize short memory ops into longer memory ops, we may want to |
761 // increase alignment. | |
762 bool IdealLoopTree::policy_align( PhaseIdealLoop *phase ) const { | |
763 return false; | |
764 } | |
765 | |
766 //------------------------------policy_range_check----------------------------- | |
767 // Return TRUE or FALSE if the loop should be range-check-eliminated. | |
768 // Actually we do iteration-splitting, a more powerful form of RCE. | |
769 bool IdealLoopTree::policy_range_check( PhaseIdealLoop *phase ) const { | |
3345 | 770 if (!RangeCheckElimination) return false; |
0 | 771 |
772 CountedLoopNode *cl = _head->as_CountedLoop(); | |
773 // If we unrolled with no intention of doing RCE and we later | |
774 // changed our minds, we got no pre-loop. Either we need to | |
775 // make a new pre-loop, or we gotta disallow RCE. | |
3345 | 776 if (cl->is_main_no_pre_loop()) return false; // Disallowed for now. |
0 | 777 Node *trip_counter = cl->phi(); |
778 | |
779 // Check loop body for tests of trip-counter plus loop-invariant vs | |
780 // loop-invariant. | |
3345 | 781 for (uint i = 0; i < _body.size(); i++) { |
0 | 782 Node *iff = _body[i]; |
3345 | 783 if (iff->Opcode() == Op_If) { // Test? |
0 | 784 |
785 // Comparing trip+off vs limit | |
786 Node *bol = iff->in(1); | |
3345 | 787 if (bol->req() != 2) continue; // dead constant test |
1172 | 788 if (!bol->is_Bool()) { |
789 assert(UseLoopPredicate && bol->Opcode() == Op_Conv2B, "predicate check only"); | |
790 continue; | |
791 } | |
3345 | 792 if (bol->as_Bool()->_test._test == BoolTest::ne) |
793 continue; // not RC | |
794 | |
0 | 795 Node *cmp = bol->in(1); |
796 Node *rc_exp = cmp->in(1); | |
797 Node *limit = cmp->in(2); | |
798 | |
799 Node *limit_c = phase->get_ctrl(limit); | |
800 if( limit_c == phase->C->top() ) | |
801 return false; // Found dead test on live IF? No RCE! | |
802 if( is_member(phase->get_loop(limit_c) ) ) { | |
803 // Compare might have operands swapped; commute them | |
804 rc_exp = cmp->in(2); | |
805 limit = cmp->in(1); | |
806 limit_c = phase->get_ctrl(limit); | |
807 if( is_member(phase->get_loop(limit_c) ) ) | |
808 continue; // Both inputs are loop varying; cannot RCE | |
809 } | |
810 | |
811 if (!phase->is_scaled_iv_plus_offset(rc_exp, trip_counter, NULL, NULL)) { | |
812 continue; | |
813 } | |
814 // Yeah! Found a test like 'trip+off vs limit' | |
815 // Test is an IfNode, has 2 projections. If BOTH are in the loop | |
816 // we need loop unswitching instead of iteration splitting. | |
817 if( is_loop_exit(iff) ) | |
818 return true; // Found reason to split iterations | |
819 } // End of is IF | |
820 } | |
821 | |
822 return false; | |
823 } | |
824 | |
825 //------------------------------policy_peel_only------------------------------- | |
826 // Return TRUE or FALSE if the loop should NEVER be RCE'd or aligned. Useful | |
827 // for unrolling loops with NO array accesses. | |
828 bool IdealLoopTree::policy_peel_only( PhaseIdealLoop *phase ) const { | |
829 | |
830 for( uint i = 0; i < _body.size(); i++ ) | |
831 if( _body[i]->is_Mem() ) | |
832 return false; | |
833 | |
834 // No memory accesses at all! | |
835 return true; | |
836 } | |
837 | |
838 //------------------------------clone_up_backedge_goo-------------------------- | |
839 // If Node n lives in the back_ctrl block and cannot float, we clone a private | |
840 // version of n in preheader_ctrl block and return that, otherwise return n. | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
841 Node *PhaseIdealLoop::clone_up_backedge_goo( Node *back_ctrl, Node *preheader_ctrl, Node *n, VectorSet &visited, Node_Stack &clones ) { |
0 | 842 if( get_ctrl(n) != back_ctrl ) return n; |
843 | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
844 // Only visit once |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
845 if (visited.test_set(n->_idx)) { |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
846 Node *x = clones.find(n->_idx); |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
847 if (x != NULL) |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
848 return x; |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
849 return n; |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
850 } |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
851 |
0 | 852 Node *x = NULL; // If required, a clone of 'n' |
853 // Check for 'n' being pinned in the backedge. | |
854 if( n->in(0) && n->in(0) == back_ctrl ) { | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
855 assert(clones.find(n->_idx) == NULL, "dead loop"); |
0 | 856 x = n->clone(); // Clone a copy of 'n' to preheader |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
857 clones.push(x, n->_idx); |
0 | 858 x->set_req( 0, preheader_ctrl ); // Fix x's control input to preheader |
859 } | |
860 | |
861 // Recursive fixup any other input edges into x. | |
862 // If there are no changes we can just return 'n', otherwise | |
863 // we need to clone a private copy and change it. | |
864 for( uint i = 1; i < n->req(); i++ ) { | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
865 Node *g = clone_up_backedge_goo( back_ctrl, preheader_ctrl, n->in(i), visited, clones ); |
0 | 866 if( g != n->in(i) ) { |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
867 if( !x ) { |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
868 assert(clones.find(n->_idx) == NULL, "dead loop"); |
0 | 869 x = n->clone(); |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
870 clones.push(x, n->_idx); |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
871 } |
0 | 872 x->set_req(i, g); |
873 } | |
874 } | |
875 if( x ) { // x can legally float to pre-header location | |
876 register_new_node( x, preheader_ctrl ); | |
877 return x; | |
878 } else { // raise n to cover LCA of uses | |
879 set_ctrl( n, find_non_split_ctrl(back_ctrl->in(0)) ); | |
880 } | |
881 return n; | |
882 } | |
883 | |
20680
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
884 bool PhaseIdealLoop::cast_incr_before_loop(Node* incr, Node* ctrl, Node* loop) { |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
885 Node* castii = new (C) CastIINode(incr, TypeInt::INT, true); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
886 castii->set_req(0, ctrl); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
887 register_new_node(castii, ctrl); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
888 for (DUIterator_Fast imax, i = incr->fast_outs(imax); i < imax; i++) { |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
889 Node* n = incr->fast_out(i); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
890 if (n->is_Phi() && n->in(0) == loop) { |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
891 int nrep = n->replace_edge(incr, castii); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
892 return true; |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
893 } |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
894 } |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
895 return false; |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
896 } |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
897 |
0 | 898 //------------------------------insert_pre_post_loops-------------------------- |
899 // Insert pre and post loops. If peel_only is set, the pre-loop can not have | |
900 // more iterations added. It acts as a 'peel' only, no lower-bound RCE, no | |
901 // alignment. Useful to unroll loops that do no array accesses. | |
902 void PhaseIdealLoop::insert_pre_post_loops( IdealLoopTree *loop, Node_List &old_new, bool peel_only ) { | |
903 | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
904 #ifndef PRODUCT |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
905 if (TraceLoopOpts) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
906 if (peel_only) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
907 tty->print("PeelMainPost "); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
908 else |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
909 tty->print("PreMainPost "); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
910 loop->dump_head(); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
911 } |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
912 #endif |
0 | 913 C->set_major_progress(); |
914 | |
915 // Find common pieces of the loop being guarded with pre & post loops | |
916 CountedLoopNode *main_head = loop->_head->as_CountedLoop(); | |
917 assert( main_head->is_normal_loop(), "" ); | |
918 CountedLoopEndNode *main_end = main_head->loopexit(); | |
8779
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
919 guarantee(main_end != NULL, "no loop exit node"); |
0 | 920 assert( main_end->outcnt() == 2, "1 true, 1 false path only" ); |
921 uint dd_main_head = dom_depth(main_head); | |
922 uint max = main_head->outcnt(); | |
923 | |
924 Node *pre_header= main_head->in(LoopNode::EntryControl); | |
925 Node *init = main_head->init_trip(); | |
926 Node *incr = main_end ->incr(); | |
927 Node *limit = main_end ->limit(); | |
928 Node *stride = main_end ->stride(); | |
929 Node *cmp = main_end ->cmp_node(); | |
930 BoolTest::mask b_test = main_end->test_trip(); | |
931 | |
932 // Need only 1 user of 'bol' because I will be hacking the loop bounds. | |
933 Node *bol = main_end->in(CountedLoopEndNode::TestValue); | |
934 if( bol->outcnt() != 1 ) { | |
935 bol = bol->clone(); | |
936 register_new_node(bol,main_end->in(CountedLoopEndNode::TestControl)); | |
937 _igvn.hash_delete(main_end); | |
938 main_end->set_req(CountedLoopEndNode::TestValue, bol); | |
939 } | |
940 // Need only 1 user of 'cmp' because I will be hacking the loop bounds. | |
941 if( cmp->outcnt() != 1 ) { | |
942 cmp = cmp->clone(); | |
943 register_new_node(cmp,main_end->in(CountedLoopEndNode::TestControl)); | |
944 _igvn.hash_delete(bol); | |
945 bol->set_req(1, cmp); | |
946 } | |
947 | |
948 //------------------------------ | |
949 // Step A: Create Post-Loop. | |
950 Node* main_exit = main_end->proj_out(false); | |
951 assert( main_exit->Opcode() == Op_IfFalse, "" ); | |
952 int dd_main_exit = dom_depth(main_exit); | |
953 | |
954 // Step A1: Clone the loop body. The clone becomes the post-loop. The main | |
955 // loop pre-header illegally has 2 control users (old & new loops). | |
956 clone_loop( loop, old_new, dd_main_exit ); | |
957 assert( old_new[main_end ->_idx]->Opcode() == Op_CountedLoopEnd, "" ); | |
958 CountedLoopNode *post_head = old_new[main_head->_idx]->as_CountedLoop(); | |
959 post_head->set_post_loop(main_head); | |
960 | |
400
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
961 // Reduce the post-loop trip count. |
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
962 CountedLoopEndNode* post_end = old_new[main_end ->_idx]->as_CountedLoopEnd(); |
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
963 post_end->_prob = PROB_FAIR; |
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
964 |
0 | 965 // Build the main-loop normal exit. |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
966 IfFalseNode *new_main_exit = new (C) IfFalseNode(main_end); |
0 | 967 _igvn.register_new_node_with_optimizer( new_main_exit ); |
968 set_idom(new_main_exit, main_end, dd_main_exit ); | |
969 set_loop(new_main_exit, loop->_parent); | |
970 | |
971 // Step A2: Build a zero-trip guard for the post-loop. After leaving the | |
972 // main-loop, the post-loop may not execute at all. We 'opaque' the incr | |
973 // (the main-loop trip-counter exit value) because we will be changing | |
974 // the exit value (via unrolling) so we cannot constant-fold away the zero | |
975 // trip guard until all unrolling is done. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
976 Node *zer_opaq = new (C) Opaque1Node(C, incr); |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
977 Node *zer_cmp = new (C) CmpINode( zer_opaq, limit ); |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
978 Node *zer_bol = new (C) BoolNode( zer_cmp, b_test ); |
0 | 979 register_new_node( zer_opaq, new_main_exit ); |
980 register_new_node( zer_cmp , new_main_exit ); | |
981 register_new_node( zer_bol , new_main_exit ); | |
982 | |
983 // Build the IfNode | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
984 IfNode *zer_iff = new (C) IfNode( new_main_exit, zer_bol, PROB_FAIR, COUNT_UNKNOWN ); |
0 | 985 _igvn.register_new_node_with_optimizer( zer_iff ); |
986 set_idom(zer_iff, new_main_exit, dd_main_exit); | |
987 set_loop(zer_iff, loop->_parent); | |
988 | |
989 // Plug in the false-path, taken if we need to skip post-loop | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
3930
diff
changeset
|
990 _igvn.replace_input_of(main_exit, 0, zer_iff); |
0 | 991 set_idom(main_exit, zer_iff, dd_main_exit); |
992 set_idom(main_exit->unique_out(), zer_iff, dd_main_exit); | |
993 // Make the true-path, must enter the post loop | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
994 Node *zer_taken = new (C) IfTrueNode( zer_iff ); |
0 | 995 _igvn.register_new_node_with_optimizer( zer_taken ); |
996 set_idom(zer_taken, zer_iff, dd_main_exit); | |
997 set_loop(zer_taken, loop->_parent); | |
998 // Plug in the true path | |
999 _igvn.hash_delete( post_head ); | |
1000 post_head->set_req(LoopNode::EntryControl, zer_taken); | |
1001 set_idom(post_head, zer_taken, dd_main_exit); | |
1002 | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1003 Arena *a = Thread::current()->resource_area(); |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1004 VectorSet visited(a); |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1005 Node_Stack clones(a, main_head->back_control()->outcnt()); |
0 | 1006 // Step A3: Make the fall-in values to the post-loop come from the |
1007 // fall-out values of the main-loop. | |
1008 for (DUIterator_Fast imax, i = main_head->fast_outs(imax); i < imax; i++) { | |
1009 Node* main_phi = main_head->fast_out(i); | |
1010 if( main_phi->is_Phi() && main_phi->in(0) == main_head && main_phi->outcnt() >0 ) { | |
1011 Node *post_phi = old_new[main_phi->_idx]; | |
1012 Node *fallmain = clone_up_backedge_goo(main_head->back_control(), | |
1013 post_head->init_control(), | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1014 main_phi->in(LoopNode::LoopBackControl), |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1015 visited, clones); |
0 | 1016 _igvn.hash_delete(post_phi); |
1017 post_phi->set_req( LoopNode::EntryControl, fallmain ); | |
1018 } | |
1019 } | |
1020 | |
1021 // Update local caches for next stanza | |
1022 main_exit = new_main_exit; | |
1023 | |
1024 | |
1025 //------------------------------ | |
1026 // Step B: Create Pre-Loop. | |
1027 | |
1028 // Step B1: Clone the loop body. The clone becomes the pre-loop. The main | |
1029 // loop pre-header illegally has 2 control users (old & new loops). | |
1030 clone_loop( loop, old_new, dd_main_head ); | |
1031 CountedLoopNode* pre_head = old_new[main_head->_idx]->as_CountedLoop(); | |
1032 CountedLoopEndNode* pre_end = old_new[main_end ->_idx]->as_CountedLoopEnd(); | |
1033 pre_head->set_pre_loop(main_head); | |
1034 Node *pre_incr = old_new[incr->_idx]; | |
1035 | |
400
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
1036 // Reduce the pre-loop trip count. |
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
1037 pre_end->_prob = PROB_FAIR; |
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
1038 |
0 | 1039 // Find the pre-loop normal exit. |
1040 Node* pre_exit = pre_end->proj_out(false); | |
1041 assert( pre_exit->Opcode() == Op_IfFalse, "" ); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1042 IfFalseNode *new_pre_exit = new (C) IfFalseNode(pre_end); |
0 | 1043 _igvn.register_new_node_with_optimizer( new_pre_exit ); |
1044 set_idom(new_pre_exit, pre_end, dd_main_head); | |
1045 set_loop(new_pre_exit, loop->_parent); | |
1046 | |
1047 // Step B2: Build a zero-trip guard for the main-loop. After leaving the | |
1048 // pre-loop, the main-loop may not execute at all. Later in life this | |
1049 // zero-trip guard will become the minimum-trip guard when we unroll | |
1050 // the main-loop. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1051 Node *min_opaq = new (C) Opaque1Node(C, limit); |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1052 Node *min_cmp = new (C) CmpINode( pre_incr, min_opaq ); |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1053 Node *min_bol = new (C) BoolNode( min_cmp, b_test ); |
0 | 1054 register_new_node( min_opaq, new_pre_exit ); |
1055 register_new_node( min_cmp , new_pre_exit ); | |
1056 register_new_node( min_bol , new_pre_exit ); | |
1057 | |
400
cc80376deb0c
6667595: Set probability FAIR for pre-, post- loops and ALWAYS for main loop
kvn
parents:
367
diff
changeset
|
1058 // Build the IfNode (assume the main-loop is executed always). |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1059 IfNode *min_iff = new (C) IfNode( new_pre_exit, min_bol, PROB_ALWAYS, COUNT_UNKNOWN ); |
0 | 1060 _igvn.register_new_node_with_optimizer( min_iff ); |
1061 set_idom(min_iff, new_pre_exit, dd_main_head); | |
1062 set_loop(min_iff, loop->_parent); | |
1063 | |
1064 // Plug in the false-path, taken if we need to skip main-loop | |
1065 _igvn.hash_delete( pre_exit ); | |
1066 pre_exit->set_req(0, min_iff); | |
1067 set_idom(pre_exit, min_iff, dd_main_head); | |
1068 set_idom(pre_exit->unique_out(), min_iff, dd_main_head); | |
1069 // Make the true-path, must enter the main loop | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1070 Node *min_taken = new (C) IfTrueNode( min_iff ); |
0 | 1071 _igvn.register_new_node_with_optimizer( min_taken ); |
1072 set_idom(min_taken, min_iff, dd_main_head); | |
1073 set_loop(min_taken, loop->_parent); | |
1074 // Plug in the true path | |
1075 _igvn.hash_delete( main_head ); | |
1076 main_head->set_req(LoopNode::EntryControl, min_taken); | |
1077 set_idom(main_head, min_taken, dd_main_head); | |
1078 | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1079 visited.Clear(); |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1080 clones.clear(); |
0 | 1081 // Step B3: Make the fall-in values to the main-loop come from the |
1082 // fall-out values of the pre-loop. | |
1083 for (DUIterator_Fast i2max, i2 = main_head->fast_outs(i2max); i2 < i2max; i2++) { | |
1084 Node* main_phi = main_head->fast_out(i2); | |
1085 if( main_phi->is_Phi() && main_phi->in(0) == main_head && main_phi->outcnt() > 0 ) { | |
1086 Node *pre_phi = old_new[main_phi->_idx]; | |
1087 Node *fallpre = clone_up_backedge_goo(pre_head->back_control(), | |
1088 main_head->init_control(), | |
3788
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1089 pre_phi->in(LoopNode::LoopBackControl), |
e3cbc9ddd434
7044738: Loop unroll optimization causes incorrect result
kvn
parents:
3456
diff
changeset
|
1090 visited, clones); |
0 | 1091 _igvn.hash_delete(main_phi); |
1092 main_phi->set_req( LoopNode::EntryControl, fallpre ); | |
1093 } | |
1094 } | |
1095 | |
20680
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1096 // Nodes inside the loop may be control dependent on a predicate |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1097 // that was moved before the preloop. If the back branch of the main |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1098 // or post loops becomes dead, those nodes won't be dependent on the |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1099 // test that guards that loop nest anymore which could lead to an |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1100 // incorrect array access because it executes independently of the |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1101 // test that was guarding the loop nest. We add a special CastII on |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1102 // the if branch that enters the loop, between the input induction |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1103 // variable value and the induction variable Phi to preserve correct |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1104 // dependencies. |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1105 |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1106 // CastII for the post loop: |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1107 bool inserted = cast_incr_before_loop(zer_opaq->in(1), zer_taken, post_head); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1108 assert(inserted, "no castII inserted"); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1109 |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1110 // CastII for the main loop: |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1111 inserted = cast_incr_before_loop(pre_incr, min_taken, main_head); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1112 assert(inserted, "no castII inserted"); |
5b8e0f84f00f
8054478: C2: Incorrectly compiled char[] array access crashes JVM
roland
parents:
20671
diff
changeset
|
1113 |
0 | 1114 // Step B4: Shorten the pre-loop to run only 1 iteration (for now). |
1115 // RCE and alignment may change this later. | |
1116 Node *cmp_end = pre_end->cmp_node(); | |
1117 assert( cmp_end->in(2) == limit, "" ); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1118 Node *pre_limit = new (C) AddINode( init, stride ); |
0 | 1119 |
1120 // Save the original loop limit in this Opaque1 node for | |
1121 // use by range check elimination. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1122 Node *pre_opaq = new (C) Opaque1Node(C, pre_limit, limit); |
0 | 1123 |
1124 register_new_node( pre_limit, pre_head->in(0) ); | |
1125 register_new_node( pre_opaq , pre_head->in(0) ); | |
1126 | |
1127 // Since no other users of pre-loop compare, I can hack limit directly | |
1128 assert( cmp_end->outcnt() == 1, "no other users" ); | |
1129 _igvn.hash_delete(cmp_end); | |
1130 cmp_end->set_req(2, peel_only ? pre_limit : pre_opaq); | |
1131 | |
1132 // Special case for not-equal loop bounds: | |
1133 // Change pre loop test, main loop test, and the | |
1134 // main loop guard test to use lt or gt depending on stride | |
1135 // direction: | |
1136 // positive stride use < | |
1137 // negative stride use > | |
3456 | 1138 // |
1139 // not-equal test is kept for post loop to handle case | |
1140 // when init > limit when stride > 0 (and reverse). | |
0 | 1141 |
1142 if (pre_end->in(CountedLoopEndNode::TestValue)->as_Bool()->_test._test == BoolTest::ne) { | |
1143 | |
1144 BoolTest::mask new_test = (main_end->stride_con() > 0) ? BoolTest::lt : BoolTest::gt; | |
1145 // Modify pre loop end condition | |
1146 Node* pre_bol = pre_end->in(CountedLoopEndNode::TestValue)->as_Bool(); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1147 BoolNode* new_bol0 = new (C) BoolNode(pre_bol->in(1), new_test); |
0 | 1148 register_new_node( new_bol0, pre_head->in(0) ); |
1149 _igvn.hash_delete(pre_end); | |
1150 pre_end->set_req(CountedLoopEndNode::TestValue, new_bol0); | |
1151 // Modify main loop guard condition | |
1152 assert(min_iff->in(CountedLoopEndNode::TestValue) == min_bol, "guard okay"); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1153 BoolNode* new_bol1 = new (C) BoolNode(min_bol->in(1), new_test); |
0 | 1154 register_new_node( new_bol1, new_pre_exit ); |
1155 _igvn.hash_delete(min_iff); | |
1156 min_iff->set_req(CountedLoopEndNode::TestValue, new_bol1); | |
1157 // Modify main loop end condition | |
1158 BoolNode* main_bol = main_end->in(CountedLoopEndNode::TestValue)->as_Bool(); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1159 BoolNode* new_bol2 = new (C) BoolNode(main_bol->in(1), new_test); |
0 | 1160 register_new_node( new_bol2, main_end->in(CountedLoopEndNode::TestControl) ); |
1161 _igvn.hash_delete(main_end); | |
1162 main_end->set_req(CountedLoopEndNode::TestValue, new_bol2); | |
1163 } | |
1164 | |
1165 // Flag main loop | |
1166 main_head->set_main_loop(); | |
1167 if( peel_only ) main_head->set_main_no_pre_loop(); | |
1168 | |
3345 | 1169 // Subtract a trip count for the pre-loop. |
1170 main_head->set_trip_count(main_head->trip_count() - 1); | |
1171 | |
0 | 1172 // It's difficult to be precise about the trip-counts |
1173 // for the pre/post loops. They are usually very short, | |
1174 // so guess that 4 trips is a reasonable value. | |
1175 post_head->set_profile_trip_cnt(4.0); | |
1176 pre_head->set_profile_trip_cnt(4.0); | |
1177 | |
1178 // Now force out all loop-invariant dominating tests. The optimizer | |
1179 // finds some, but we _know_ they are all useless. | |
1180 peeled_dom_test_elim(loop,old_new); | |
17887 | 1181 loop->record_for_igvn(); |
0 | 1182 } |
1183 | |
1184 //------------------------------is_invariant----------------------------- | |
1185 // Return true if n is invariant | |
1186 bool IdealLoopTree::is_invariant(Node* n) const { | |
1172 | 1187 Node *n_c = _phase->has_ctrl(n) ? _phase->get_ctrl(n) : n; |
0 | 1188 if (n_c->is_top()) return false; |
1189 return !is_member(_phase->get_loop(n_c)); | |
1190 } | |
1191 | |
1192 | |
1193 //------------------------------do_unroll-------------------------------------- | |
1194 // Unroll the loop body one step - make each trip do 2 iterations. | |
1195 void PhaseIdealLoop::do_unroll( IdealLoopTree *loop, Node_List &old_new, bool adjust_min_trip ) { | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1196 assert(LoopUnrollLimit, ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1197 CountedLoopNode *loop_head = loop->_head->as_CountedLoop(); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1198 CountedLoopEndNode *loop_end = loop_head->loopexit(); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1199 assert(loop_end, ""); |
0 | 1200 #ifndef PRODUCT |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1201 if (PrintOpto && VerifyLoopOptimizations) { |
0 | 1202 tty->print("Unrolling "); |
1203 loop->dump_head(); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1204 } else if (TraceLoopOpts) { |
2465 | 1205 if (loop_head->trip_count() < (uint)LoopUnrollLimit) { |
3345 | 1206 tty->print("Unroll %d(%2d) ", loop_head->unrolled_count()*2, loop_head->trip_count()); |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
1207 } else { |
3345 | 1208 tty->print("Unroll %d ", loop_head->unrolled_count()*2); |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
1209 } |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1210 loop->dump_head(); |
0 | 1211 } |
1212 #endif | |
1213 | |
1214 // Remember loop node count before unrolling to detect | |
1215 // if rounds of unroll,optimize are making progress | |
1216 loop_head->set_node_count_before_unroll(loop->_body.size()); | |
1217 | |
1218 Node *ctrl = loop_head->in(LoopNode::EntryControl); | |
1219 Node *limit = loop_head->limit(); | |
1220 Node *init = loop_head->init_trip(); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1221 Node *stride = loop_head->stride(); |
0 | 1222 |
1223 Node *opaq = NULL; | |
3345 | 1224 if (adjust_min_trip) { // If not maximally unrolling, need adjustment |
1225 // Search for zero-trip guard. | |
0 | 1226 assert( loop_head->is_main_loop(), "" ); |
1227 assert( ctrl->Opcode() == Op_IfTrue || ctrl->Opcode() == Op_IfFalse, "" ); | |
1228 Node *iff = ctrl->in(0); | |
1229 assert( iff->Opcode() == Op_If, "" ); | |
1230 Node *bol = iff->in(1); | |
1231 assert( bol->Opcode() == Op_Bool, "" ); | |
1232 Node *cmp = bol->in(1); | |
1233 assert( cmp->Opcode() == Op_CmpI, "" ); | |
1234 opaq = cmp->in(2); | |
3345 | 1235 // Occasionally it's possible for a zero-trip guard Opaque1 node to be |
0 | 1236 // optimized away and then another round of loop opts attempted. |
1237 // We can not optimize this particular loop in that case. | |
3345 | 1238 if (opaq->Opcode() != Op_Opaque1) |
1239 return; // Cannot find zero-trip guard! Bail out! | |
1240 // Zero-trip test uses an 'opaque' node which is not shared. | |
1241 assert(opaq->outcnt() == 1 && opaq->in(1) == limit, ""); | |
0 | 1242 } |
1243 | |
1244 C->set_major_progress(); | |
1245 | |
3345 | 1246 Node* new_limit = NULL; |
1247 if (UnrollLimitCheck) { | |
1248 int stride_con = stride->get_int(); | |
1249 int stride_p = (stride_con > 0) ? stride_con : -stride_con; | |
1250 uint old_trip_count = loop_head->trip_count(); | |
1251 // Verify that unroll policy result is still valid. | |
1252 assert(old_trip_count > 1 && | |
1253 (!adjust_min_trip || stride_p <= (1<<3)*loop_head->unrolled_count()), "sanity"); | |
0 | 1254 |
3345 | 1255 // Adjust loop limit to keep valid iterations number after unroll. |
1256 // Use (limit - stride) instead of (((limit - init)/stride) & (-2))*stride | |
1257 // which may overflow. | |
1258 if (!adjust_min_trip) { | |
1259 assert(old_trip_count > 1 && (old_trip_count & 1) == 0, | |
1260 "odd trip count for maximally unroll"); | |
1261 // Don't need to adjust limit for maximally unroll since trip count is even. | |
1262 } else if (loop_head->has_exact_trip_count() && init->is_Con()) { | |
1263 // Loop's limit is constant. Loop's init could be constant when pre-loop | |
1264 // become peeled iteration. | |
6846 | 1265 jlong init_con = init->get_int(); |
3345 | 1266 // We can keep old loop limit if iterations count stays the same: |
1267 // old_trip_count == new_trip_count * 2 | |
1268 // Note: since old_trip_count >= 2 then new_trip_count >= 1 | |
1269 // so we also don't need to adjust zero trip test. | |
6846 | 1270 jlong limit_con = limit->get_int(); |
3345 | 1271 // (stride_con*2) not overflow since stride_con <= 8. |
1272 int new_stride_con = stride_con * 2; | |
1273 int stride_m = new_stride_con - (stride_con > 0 ? 1 : -1); | |
6846 | 1274 jlong trip_count = (limit_con - init_con + stride_m)/new_stride_con; |
3345 | 1275 // New trip count should satisfy next conditions. |
1276 assert(trip_count > 0 && (julong)trip_count < (julong)max_juint/2, "sanity"); | |
1277 uint new_trip_count = (uint)trip_count; | |
1278 adjust_min_trip = (old_trip_count != new_trip_count*2); | |
1279 } | |
1280 | |
1281 if (adjust_min_trip) { | |
1282 // Step 2: Adjust the trip limit if it is called for. | |
1283 // The adjustment amount is -stride. Need to make sure if the | |
1284 // adjustment underflows or overflows, then the main loop is skipped. | |
1285 Node* cmp = loop_end->cmp_node(); | |
1286 assert(cmp->in(2) == limit, "sanity"); | |
1287 assert(opaq != NULL && opaq->in(1) == limit, "sanity"); | |
1288 | |
1289 // Verify that policy_unroll result is still valid. | |
1290 const TypeInt* limit_type = _igvn.type(limit)->is_int(); | |
1291 assert(stride_con > 0 && ((limit_type->_hi - stride_con) < limit_type->_hi) || | |
1292 stride_con < 0 && ((limit_type->_lo - stride_con) > limit_type->_lo), "sanity"); | |
0 | 1293 |
3345 | 1294 if (limit->is_Con()) { |
1295 // The check in policy_unroll and the assert above guarantee | |
1296 // no underflow if limit is constant. | |
1297 new_limit = _igvn.intcon(limit->get_int() - stride_con); | |
1298 set_ctrl(new_limit, C->root()); | |
1299 } else { | |
3348
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1300 // Limit is not constant. |
3367 | 1301 if (loop_head->unrolled_count() == 1) { // only for first unroll |
3348
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1302 // Separate limit by Opaque node in case it is an incremented |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1303 // variable from previous loop to avoid using pre-incremented |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1304 // value which could increase register pressure. |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1305 // Otherwise reorg_offsets() optimization will create a separate |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1306 // Opaque node for each use of trip-counter and as result |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1307 // zero trip guard limit will be different from loop limit. |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1308 assert(has_ctrl(opaq), "should have it"); |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1309 Node* opaq_ctrl = get_ctrl(opaq); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1310 limit = new (C) Opaque2Node( C, limit ); |
3348
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1311 register_new_node( limit, opaq_ctrl ); |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1312 } |
3345 | 1313 if (stride_con > 0 && ((limit_type->_lo - stride_con) < limit_type->_lo) || |
1314 stride_con < 0 && ((limit_type->_hi - stride_con) > limit_type->_hi)) { | |
1315 // No underflow. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1316 new_limit = new (C) SubINode(limit, stride); |
3345 | 1317 } else { |
1318 // (limit - stride) may underflow. | |
1319 // Clamp the adjustment value with MININT or MAXINT: | |
1320 // | |
1321 // new_limit = limit-stride | |
1322 // if (stride > 0) | |
1323 // new_limit = (limit < new_limit) ? MININT : new_limit; | |
1324 // else | |
1325 // new_limit = (limit > new_limit) ? MAXINT : new_limit; | |
1326 // | |
1327 BoolTest::mask bt = loop_end->test_trip(); | |
1328 assert(bt == BoolTest::lt || bt == BoolTest::gt, "canonical test is expected"); | |
1329 Node* adj_max = _igvn.intcon((stride_con > 0) ? min_jint : max_jint); | |
1330 set_ctrl(adj_max, C->root()); | |
1331 Node* old_limit = NULL; | |
1332 Node* adj_limit = NULL; | |
1333 Node* bol = limit->is_CMove() ? limit->in(CMoveNode::Condition) : NULL; | |
1334 if (loop_head->unrolled_count() > 1 && | |
1335 limit->is_CMove() && limit->Opcode() == Op_CMoveI && | |
1336 limit->in(CMoveNode::IfTrue) == adj_max && | |
1337 bol->as_Bool()->_test._test == bt && | |
1338 bol->in(1)->Opcode() == Op_CmpI && | |
1339 bol->in(1)->in(2) == limit->in(CMoveNode::IfFalse)) { | |
1340 // Loop was unrolled before. | |
1341 // Optimize the limit to avoid nested CMove: | |
1342 // use original limit as old limit. | |
1343 old_limit = bol->in(1)->in(1); | |
1344 // Adjust previous adjusted limit. | |
1345 adj_limit = limit->in(CMoveNode::IfFalse); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1346 adj_limit = new (C) SubINode(adj_limit, stride); |
3345 | 1347 } else { |
1348 old_limit = limit; | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1349 adj_limit = new (C) SubINode(limit, stride); |
3345 | 1350 } |
1351 assert(old_limit != NULL && adj_limit != NULL, ""); | |
1352 register_new_node( adj_limit, ctrl ); // adjust amount | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1353 Node* adj_cmp = new (C) CmpINode(old_limit, adj_limit); |
3345 | 1354 register_new_node( adj_cmp, ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1355 Node* adj_bool = new (C) BoolNode(adj_cmp, bt); |
3345 | 1356 register_new_node( adj_bool, ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1357 new_limit = new (C) CMoveINode(adj_bool, adj_limit, adj_max, TypeInt::INT); |
3345 | 1358 } |
1359 register_new_node(new_limit, ctrl); | |
1360 } | |
1361 assert(new_limit != NULL, ""); | |
3348
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1362 // Replace in loop test. |
3398
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1363 assert(loop_end->in(1)->in(1) == cmp, "sanity"); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1364 if (cmp->outcnt() == 1 && loop_end->in(1)->outcnt() == 1) { |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1365 // Don't need to create new test since only one user. |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1366 _igvn.hash_delete(cmp); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1367 cmp->set_req(2, new_limit); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1368 } else { |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1369 // Create new test since it is shared. |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1370 Node* ctrl2 = loop_end->in(0); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1371 Node* cmp2 = cmp->clone(); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1372 cmp2->set_req(2, new_limit); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1373 register_new_node(cmp2, ctrl2); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1374 Node* bol2 = loop_end->in(1)->clone(); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1375 bol2->set_req(1, cmp2); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1376 register_new_node(bol2, ctrl2); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1377 _igvn.hash_delete(loop_end); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1378 loop_end->set_req(1, bol2); |
789d04408ca3
7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently
kvn
parents:
3383
diff
changeset
|
1379 } |
3348
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1380 // Step 3: Find the min-trip test guaranteed before a 'main' loop. |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1381 // Make it a 1-trip test (means at least 2 trips). |
3345 | 1382 |
3348
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1383 // Guard test uses an 'opaque' node which is not shared. Hence I |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1384 // can edit it's inputs directly. Hammer in the new limit for the |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1385 // minimum-trip guard. |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1386 assert(opaq->outcnt() == 1, ""); |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1387 _igvn.hash_delete(opaq); |
f879eafd5835
7042327: assert(opaq->outcnt() == 1 && opaq->in(1) == limit)
kvn
parents:
3345
diff
changeset
|
1388 opaq->set_req(1, new_limit); |
3345 | 1389 } |
1390 | |
1391 // Adjust max trip count. The trip count is intentionally rounded | |
1392 // down here (e.g. 15-> 7-> 3-> 1) because if we unwittingly over-unroll, | |
1393 // the main, unrolled, part of the loop will never execute as it is protected | |
1394 // by the min-trip test. See bug 4834191 for a case where we over-unrolled | |
1395 // and later determined that part of the unrolled loop was dead. | |
1396 loop_head->set_trip_count(old_trip_count / 2); | |
1397 | |
1398 // Double the count of original iterations in the unrolled loop body. | |
1399 loop_head->double_unrolled_count(); | |
1400 | |
1401 } else { // LoopLimitCheck | |
1402 | |
1403 // Adjust max trip count. The trip count is intentionally rounded | |
1404 // down here (e.g. 15-> 7-> 3-> 1) because if we unwittingly over-unroll, | |
1405 // the main, unrolled, part of the loop will never execute as it is protected | |
1406 // by the min-trip test. See bug 4834191 for a case where we over-unrolled | |
1407 // and later determined that part of the unrolled loop was dead. | |
1408 loop_head->set_trip_count(loop_head->trip_count() / 2); | |
1409 | |
1410 // Double the count of original iterations in the unrolled loop body. | |
1411 loop_head->double_unrolled_count(); | |
0 | 1412 |
3345 | 1413 // ----------- |
1414 // Step 2: Cut back the trip counter for an unroll amount of 2. | |
1415 // Loop will normally trip (limit - init)/stride_con. Since it's a | |
1416 // CountedLoop this is exact (stride divides limit-init exactly). | |
1417 // We are going to double the loop body, so we want to knock off any | |
1418 // odd iteration: (trip_cnt & ~1). Then back compute a new limit. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1419 Node *span = new (C) SubINode( limit, init ); |
3345 | 1420 register_new_node( span, ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1421 Node *trip = new (C) DivINode( 0, span, stride ); |
3345 | 1422 register_new_node( trip, ctrl ); |
1423 Node *mtwo = _igvn.intcon(-2); | |
1424 set_ctrl(mtwo, C->root()); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1425 Node *rond = new (C) AndINode( trip, mtwo ); |
3345 | 1426 register_new_node( rond, ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1427 Node *spn2 = new (C) MulINode( rond, stride ); |
3345 | 1428 register_new_node( spn2, ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1429 new_limit = new (C) AddINode( spn2, init ); |
3345 | 1430 register_new_node( new_limit, ctrl ); |
1431 | |
1432 // Hammer in the new limit | |
1433 Node *ctrl2 = loop_end->in(0); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1434 Node *cmp2 = new (C) CmpINode( loop_head->incr(), new_limit ); |
3345 | 1435 register_new_node( cmp2, ctrl2 ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1436 Node *bol2 = new (C) BoolNode( cmp2, loop_end->test_trip() ); |
3345 | 1437 register_new_node( bol2, ctrl2 ); |
1438 _igvn.hash_delete(loop_end); | |
1439 loop_end->set_req(CountedLoopEndNode::TestValue, bol2); | |
1440 | |
1441 // Step 3: Find the min-trip test guaranteed before a 'main' loop. | |
1442 // Make it a 1-trip test (means at least 2 trips). | |
1443 if( adjust_min_trip ) { | |
1444 assert( new_limit != NULL, "" ); | |
1445 // Guard test uses an 'opaque' node which is not shared. Hence I | |
1446 // can edit it's inputs directly. Hammer in the new limit for the | |
1447 // minimum-trip guard. | |
1448 assert( opaq->outcnt() == 1, "" ); | |
1449 _igvn.hash_delete(opaq); | |
1450 opaq->set_req(1, new_limit); | |
1451 } | |
1452 } // LoopLimitCheck | |
0 | 1453 |
1454 // --------- | |
1455 // Step 4: Clone the loop body. Move it inside the loop. This loop body | |
1456 // represents the odd iterations; since the loop trips an even number of | |
1457 // times its backedge is never taken. Kill the backedge. | |
1458 uint dd = dom_depth(loop_head); | |
1459 clone_loop( loop, old_new, dd ); | |
1460 | |
1461 // Make backedges of the clone equal to backedges of the original. | |
1462 // Make the fall-in from the original come from the fall-out of the clone. | |
1463 for (DUIterator_Fast jmax, j = loop_head->fast_outs(jmax); j < jmax; j++) { | |
1464 Node* phi = loop_head->fast_out(j); | |
1465 if( phi->is_Phi() && phi->in(0) == loop_head && phi->outcnt() > 0 ) { | |
1466 Node *newphi = old_new[phi->_idx]; | |
1467 _igvn.hash_delete( phi ); | |
1468 _igvn.hash_delete( newphi ); | |
1469 | |
1470 phi ->set_req(LoopNode:: EntryControl, newphi->in(LoopNode::LoopBackControl)); | |
1471 newphi->set_req(LoopNode::LoopBackControl, phi ->in(LoopNode::LoopBackControl)); | |
1472 phi ->set_req(LoopNode::LoopBackControl, C->top()); | |
1473 } | |
1474 } | |
1475 Node *clone_head = old_new[loop_head->_idx]; | |
1476 _igvn.hash_delete( clone_head ); | |
1477 loop_head ->set_req(LoopNode:: EntryControl, clone_head->in(LoopNode::LoopBackControl)); | |
1478 clone_head->set_req(LoopNode::LoopBackControl, loop_head ->in(LoopNode::LoopBackControl)); | |
1479 loop_head ->set_req(LoopNode::LoopBackControl, C->top()); | |
1480 loop->_head = clone_head; // New loop header | |
1481 | |
1482 set_idom(loop_head, loop_head ->in(LoopNode::EntryControl), dd); | |
1483 set_idom(clone_head, clone_head->in(LoopNode::EntryControl), dd); | |
1484 | |
1485 // Kill the clone's backedge | |
1486 Node *newcle = old_new[loop_end->_idx]; | |
1487 _igvn.hash_delete( newcle ); | |
1488 Node *one = _igvn.intcon(1); | |
1489 set_ctrl(one, C->root()); | |
1490 newcle->set_req(1, one); | |
1491 // Force clone into same loop body | |
1492 uint max = loop->_body.size(); | |
1493 for( uint k = 0; k < max; k++ ) { | |
1494 Node *old = loop->_body.at(k); | |
1495 Node *nnn = old_new[old->_idx]; | |
1496 loop->_body.push(nnn); | |
1497 if (!has_ctrl(old)) | |
1498 set_loop(nnn, loop); | |
1499 } | |
367
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
235
diff
changeset
|
1500 |
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
235
diff
changeset
|
1501 loop->record_for_igvn(); |
0 | 1502 } |
1503 | |
1504 //------------------------------do_maximally_unroll---------------------------- | |
1505 | |
1506 void PhaseIdealLoop::do_maximally_unroll( IdealLoopTree *loop, Node_List &old_new ) { | |
1507 CountedLoopNode *cl = loop->_head->as_CountedLoop(); | |
3345 | 1508 assert(cl->has_exact_trip_count(), "trip count is not exact"); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1509 assert(cl->trip_count() > 0, ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1510 #ifndef PRODUCT |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1511 if (TraceLoopOpts) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1512 tty->print("MaxUnroll %d ", cl->trip_count()); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1513 loop->dump_head(); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1514 } |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1515 #endif |
0 | 1516 |
1517 // If loop is tripping an odd number of times, peel odd iteration | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1518 if ((cl->trip_count() & 1) == 1) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1519 do_peeling(loop, old_new); |
0 | 1520 } |
1521 | |
1522 // Now its tripping an even number of times remaining. Double loop body. | |
1523 // Do not adjust pre-guards; they are not needed and do not exist. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1524 if (cl->trip_count() > 0) { |
3345 | 1525 assert((cl->trip_count() & 1) == 0, "missed peeling"); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1526 do_unroll(loop, old_new, false); |
0 | 1527 } |
1528 } | |
1529 | |
1530 //------------------------------dominates_backedge--------------------------------- | |
1531 // Returns true if ctrl is executed on every complete iteration | |
1532 bool IdealLoopTree::dominates_backedge(Node* ctrl) { | |
1533 assert(ctrl->is_CFG(), "must be control"); | |
1534 Node* backedge = _head->as_Loop()->in(LoopNode::LoopBackControl); | |
1535 return _phase->dom_lca_internal(ctrl, backedge) == ctrl; | |
1536 } | |
1537 | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1538 //------------------------------adjust_limit----------------------------------- |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1539 // Helper function for add_constraint(). |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1540 Node* PhaseIdealLoop::adjust_limit(int stride_con, Node * scale, Node *offset, Node *rc_limit, Node *loop_limit, Node *pre_ctrl) { |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1541 // Compute "I :: (limit-offset)/scale" |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1542 Node *con = new (C) SubINode(rc_limit, offset); |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1543 register_new_node(con, pre_ctrl); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1544 Node *X = new (C) DivINode(0, con, scale); |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1545 register_new_node(X, pre_ctrl); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1546 |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1547 // Adjust loop limit |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1548 loop_limit = (stride_con > 0) |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1549 ? (Node*)(new (C) MinINode(loop_limit, X)) |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1550 : (Node*)(new (C) MaxINode(loop_limit, X)); |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1551 register_new_node(loop_limit, pre_ctrl); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1552 return loop_limit; |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1553 } |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1554 |
0 | 1555 //------------------------------add_constraint--------------------------------- |
3345 | 1556 // Constrain the main loop iterations so the conditions: |
1557 // low_limit <= scale_con * I + offset < upper_limit | |
0 | 1558 // always holds true. That is, either increase the number of iterations in |
1559 // the pre-loop or the post-loop until the condition holds true in the main | |
1560 // loop. Stride, scale, offset and limit are all loop invariant. Further, | |
1561 // stride and scale are constants (offset and limit often are). | |
3345 | 1562 void PhaseIdealLoop::add_constraint( int stride_con, int scale_con, Node *offset, Node *low_limit, Node *upper_limit, Node *pre_ctrl, Node **pre_limit, Node **main_limit ) { |
0 | 1563 // For positive stride, the pre-loop limit always uses a MAX function |
1564 // and the main loop a MIN function. For negative stride these are | |
1565 // reversed. | |
1566 | |
1567 // Also for positive stride*scale the affine function is increasing, so the | |
1568 // pre-loop must check for underflow and the post-loop for overflow. | |
1569 // Negative stride*scale reverses this; pre-loop checks for overflow and | |
1570 // post-loop for underflow. | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1571 |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1572 Node *scale = _igvn.intcon(scale_con); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1573 set_ctrl(scale, C->root()); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1574 |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1575 if ((stride_con^scale_con) >= 0) { // Use XOR to avoid overflow |
3345 | 1576 // The overflow limit: scale*I+offset < upper_limit |
1577 // For main-loop compute | |
1578 // ( if (scale > 0) /* and stride > 0 */ | |
1579 // I < (upper_limit-offset)/scale | |
1580 // else /* scale < 0 and stride < 0 */ | |
1581 // I > (upper_limit-offset)/scale | |
1582 // ) | |
1583 // | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1584 // (upper_limit-offset) may overflow or underflow. |
3345 | 1585 // But it is fine since main loop will either have |
1586 // less iterations or will be skipped in such case. | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1587 *main_limit = adjust_limit(stride_con, scale, offset, upper_limit, *main_limit, pre_ctrl); |
0 | 1588 |
3345 | 1589 // The underflow limit: low_limit <= scale*I+offset. |
1590 // For pre-loop compute | |
1591 // NOT(scale*I+offset >= low_limit) | |
1592 // scale*I+offset < low_limit | |
1593 // ( if (scale > 0) /* and stride > 0 */ | |
1594 // I < (low_limit-offset)/scale | |
1595 // else /* scale < 0 and stride < 0 */ | |
1596 // I > (low_limit-offset)/scale | |
1597 // ) | |
1598 | |
1599 if (low_limit->get_int() == -max_jint) { | |
1600 if (!RangeLimitCheck) return; | |
1601 // We need this guard when scale*pre_limit+offset >= limit | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1602 // due to underflow. So we need execute pre-loop until |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1603 // scale*I+offset >= min_int. But (min_int-offset) will |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1604 // underflow when offset > 0 and X will be > original_limit |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1605 // when stride > 0. To avoid it we replace positive offset with 0. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1606 // |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1607 // Also (min_int+1 == -max_int) is used instead of min_int here |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1608 // to avoid problem with scale == -1 (min_int/(-1) == min_int). |
3345 | 1609 Node* shift = _igvn.intcon(31); |
1610 set_ctrl(shift, C->root()); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1611 Node* sign = new (C) RShiftINode(offset, shift); |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1612 register_new_node(sign, pre_ctrl); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1613 offset = new (C) AndINode(offset, sign); |
3345 | 1614 register_new_node(offset, pre_ctrl); |
1615 } else { | |
1616 assert(low_limit->get_int() == 0, "wrong low limit for range check"); | |
1617 // The only problem we have here when offset == min_int | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1618 // since (0-min_int) == min_int. It may be fine for stride > 0 |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1619 // but for stride < 0 X will be < original_limit. To avoid it |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1620 // max(pre_limit, original_limit) is used in do_range_check(). |
3345 | 1621 } |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1622 // Pass (-stride) to indicate pre_loop_cond = NOT(main_loop_cond); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1623 *pre_limit = adjust_limit((-stride_con), scale, offset, low_limit, *pre_limit, pre_ctrl); |
3345 | 1624 |
1625 } else { // stride_con*scale_con < 0 | |
1626 // For negative stride*scale pre-loop checks for overflow and | |
1627 // post-loop for underflow. | |
1628 // | |
1629 // The overflow limit: scale*I+offset < upper_limit | |
1630 // For pre-loop compute | |
1631 // NOT(scale*I+offset < upper_limit) | |
1632 // scale*I+offset >= upper_limit | |
1633 // scale*I+offset+1 > upper_limit | |
1634 // ( if (scale < 0) /* and stride > 0 */ | |
1635 // I < (upper_limit-(offset+1))/scale | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1636 // else /* scale > 0 and stride < 0 */ |
3345 | 1637 // I > (upper_limit-(offset+1))/scale |
1638 // ) | |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1639 // |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1640 // (upper_limit-offset-1) may underflow or overflow. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1641 // To avoid it min(pre_limit, original_limit) is used |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1642 // in do_range_check() for stride > 0 and max() for < 0. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1643 Node *one = _igvn.intcon(1); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1644 set_ctrl(one, C->root()); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1645 |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1646 Node *plus_one = new (C) AddINode(offset, one); |
3345 | 1647 register_new_node( plus_one, pre_ctrl ); |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1648 // Pass (-stride) to indicate pre_loop_cond = NOT(main_loop_cond); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1649 *pre_limit = adjust_limit((-stride_con), scale, plus_one, upper_limit, *pre_limit, pre_ctrl); |
3345 | 1650 |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1651 if (low_limit->get_int() == -max_jint) { |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1652 if (!RangeLimitCheck) return; |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1653 // We need this guard when scale*main_limit+offset >= limit |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1654 // due to underflow. So we need execute main-loop while |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1655 // scale*I+offset+1 > min_int. But (min_int-offset-1) will |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1656 // underflow when (offset+1) > 0 and X will be < main_limit |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1657 // when scale < 0 (and stride > 0). To avoid it we replace |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1658 // positive (offset+1) with 0. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1659 // |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1660 // Also (min_int+1 == -max_int) is used instead of min_int here |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1661 // to avoid problem with scale == -1 (min_int/(-1) == min_int). |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1662 Node* shift = _igvn.intcon(31); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1663 set_ctrl(shift, C->root()); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1664 Node* sign = new (C) RShiftINode(plus_one, shift); |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1665 register_new_node(sign, pre_ctrl); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1666 plus_one = new (C) AndINode(plus_one, sign); |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1667 register_new_node(plus_one, pre_ctrl); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1668 } else { |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1669 assert(low_limit->get_int() == 0, "wrong low limit for range check"); |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1670 // The only problem we have here when offset == max_int |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1671 // since (max_int+1) == min_int and (0-min_int) == min_int. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1672 // But it is fine since main loop will either have |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1673 // less iterations or will be skipped in such case. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1674 } |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1675 // The underflow limit: low_limit <= scale*I+offset. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1676 // For main-loop compute |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1677 // scale*I+offset+1 > low_limit |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1678 // ( if (scale < 0) /* and stride > 0 */ |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1679 // I < (low_limit-(offset+1))/scale |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1680 // else /* scale > 0 and stride < 0 */ |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1681 // I > (low_limit-(offset+1))/scale |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1682 // ) |
3345 | 1683 |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1684 *main_limit = adjust_limit(stride_con, scale, plus_one, low_limit, *main_limit, pre_ctrl); |
0 | 1685 } |
1686 } | |
1687 | |
1688 | |
1689 //------------------------------is_scaled_iv--------------------------------- | |
1690 // Return true if exp is a constant times an induction var | |
1691 bool PhaseIdealLoop::is_scaled_iv(Node* exp, Node* iv, int* p_scale) { | |
1692 if (exp == iv) { | |
1693 if (p_scale != NULL) { | |
1694 *p_scale = 1; | |
1695 } | |
1696 return true; | |
1697 } | |
1698 int opc = exp->Opcode(); | |
1699 if (opc == Op_MulI) { | |
1700 if (exp->in(1) == iv && exp->in(2)->is_Con()) { | |
1701 if (p_scale != NULL) { | |
1702 *p_scale = exp->in(2)->get_int(); | |
1703 } | |
1704 return true; | |
1705 } | |
1706 if (exp->in(2) == iv && exp->in(1)->is_Con()) { | |
1707 if (p_scale != NULL) { | |
1708 *p_scale = exp->in(1)->get_int(); | |
1709 } | |
1710 return true; | |
1711 } | |
1712 } else if (opc == Op_LShiftI) { | |
1713 if (exp->in(1) == iv && exp->in(2)->is_Con()) { | |
1714 if (p_scale != NULL) { | |
1715 *p_scale = 1 << exp->in(2)->get_int(); | |
1716 } | |
1717 return true; | |
1718 } | |
1719 } | |
1720 return false; | |
1721 } | |
1722 | |
1723 //-----------------------------is_scaled_iv_plus_offset------------------------------ | |
1724 // Return true if exp is a simple induction variable expression: k1*iv + (invar + k2) | |
1725 bool PhaseIdealLoop::is_scaled_iv_plus_offset(Node* exp, Node* iv, int* p_scale, Node** p_offset, int depth) { | |
1726 if (is_scaled_iv(exp, iv, p_scale)) { | |
1727 if (p_offset != NULL) { | |
1728 Node *zero = _igvn.intcon(0); | |
1729 set_ctrl(zero, C->root()); | |
1730 *p_offset = zero; | |
1731 } | |
1732 return true; | |
1733 } | |
1734 int opc = exp->Opcode(); | |
1735 if (opc == Op_AddI) { | |
1736 if (is_scaled_iv(exp->in(1), iv, p_scale)) { | |
1737 if (p_offset != NULL) { | |
1738 *p_offset = exp->in(2); | |
1739 } | |
1740 return true; | |
1741 } | |
23485
192643caadca
8145754: PhaseIdealLoop::is_scaled_iv_plus_offset() does not match AddI
thartmann
parents:
23065
diff
changeset
|
1742 if (is_scaled_iv(exp->in(2), iv, p_scale)) { |
192643caadca
8145754: PhaseIdealLoop::is_scaled_iv_plus_offset() does not match AddI
thartmann
parents:
23065
diff
changeset
|
1743 if (p_offset != NULL) { |
192643caadca
8145754: PhaseIdealLoop::is_scaled_iv_plus_offset() does not match AddI
thartmann
parents:
23065
diff
changeset
|
1744 *p_offset = exp->in(1); |
192643caadca
8145754: PhaseIdealLoop::is_scaled_iv_plus_offset() does not match AddI
thartmann
parents:
23065
diff
changeset
|
1745 } |
192643caadca
8145754: PhaseIdealLoop::is_scaled_iv_plus_offset() does not match AddI
thartmann
parents:
23065
diff
changeset
|
1746 return true; |
192643caadca
8145754: PhaseIdealLoop::is_scaled_iv_plus_offset() does not match AddI
thartmann
parents:
23065
diff
changeset
|
1747 } |
0 | 1748 if (exp->in(2)->is_Con()) { |
1749 Node* offset2 = NULL; | |
1750 if (depth < 2 && | |
1751 is_scaled_iv_plus_offset(exp->in(1), iv, p_scale, | |
1752 p_offset != NULL ? &offset2 : NULL, depth+1)) { | |
1753 if (p_offset != NULL) { | |
1754 Node *ctrl_off2 = get_ctrl(offset2); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1755 Node* offset = new (C) AddINode(offset2, exp->in(2)); |
0 | 1756 register_new_node(offset, ctrl_off2); |
1757 *p_offset = offset; | |
1758 } | |
1759 return true; | |
1760 } | |
1761 } | |
1762 } else if (opc == Op_SubI) { | |
1763 if (is_scaled_iv(exp->in(1), iv, p_scale)) { | |
1764 if (p_offset != NULL) { | |
1765 Node *zero = _igvn.intcon(0); | |
1766 set_ctrl(zero, C->root()); | |
1767 Node *ctrl_off = get_ctrl(exp->in(2)); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1768 Node* offset = new (C) SubINode(zero, exp->in(2)); |
0 | 1769 register_new_node(offset, ctrl_off); |
1770 *p_offset = offset; | |
1771 } | |
1772 return true; | |
1773 } | |
1774 if (is_scaled_iv(exp->in(2), iv, p_scale)) { | |
1775 if (p_offset != NULL) { | |
1776 *p_scale *= -1; | |
1777 *p_offset = exp->in(1); | |
1778 } | |
1779 return true; | |
1780 } | |
1781 } | |
1782 return false; | |
1783 } | |
1784 | |
1785 //------------------------------do_range_check--------------------------------- | |
1786 // Eliminate range-checks and other trip-counter vs loop-invariant tests. | |
1787 void PhaseIdealLoop::do_range_check( IdealLoopTree *loop, Node_List &old_new ) { | |
1788 #ifndef PRODUCT | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1789 if (PrintOpto && VerifyLoopOptimizations) { |
0 | 1790 tty->print("Range Check Elimination "); |
1791 loop->dump_head(); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1792 } else if (TraceLoopOpts) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1793 tty->print("RangeCheck "); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1794 loop->dump_head(); |
0 | 1795 } |
1796 #endif | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1797 assert(RangeCheckElimination, ""); |
0 | 1798 CountedLoopNode *cl = loop->_head->as_CountedLoop(); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1799 assert(cl->is_main_loop(), ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1800 |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1801 // protect against stride not being a constant |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1802 if (!cl->stride_is_con()) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1803 return; |
0 | 1804 |
1805 // Find the trip counter; we are iteration splitting based on it | |
1806 Node *trip_counter = cl->phi(); | |
1807 // Find the main loop limit; we will trim it's iterations | |
1808 // to not ever trip end tests | |
1809 Node *main_limit = cl->limit(); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1810 |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1811 // Need to find the main-loop zero-trip guard |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1812 Node *ctrl = cl->in(LoopNode::EntryControl); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1813 assert(ctrl->Opcode() == Op_IfTrue || ctrl->Opcode() == Op_IfFalse, ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1814 Node *iffm = ctrl->in(0); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1815 assert(iffm->Opcode() == Op_If, ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1816 Node *bolzm = iffm->in(1); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1817 assert(bolzm->Opcode() == Op_Bool, ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1818 Node *cmpzm = bolzm->in(1); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1819 assert(cmpzm->is_Cmp(), ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1820 Node *opqzm = cmpzm->in(2); |
3345 | 1821 // Can not optimize a loop if zero-trip Opaque1 node is optimized |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1822 // away and then another round of loop opts attempted. |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1823 if (opqzm->Opcode() != Op_Opaque1) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1824 return; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1825 assert(opqzm->in(1) == main_limit, "do not understand situation"); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1826 |
0 | 1827 // Find the pre-loop limit; we will expand it's iterations to |
1828 // not ever trip low tests. | |
1829 Node *p_f = iffm->in(0); | |
23065
6b40d295742c
8078866: compiler/eliminateAutobox/6934604/TestIntBoxing.java assert(p_f->Opcode() == Op_IfFalse) failed
roland
parents:
20680
diff
changeset
|
1830 // pre loop may have been optimized out |
6b40d295742c
8078866: compiler/eliminateAutobox/6934604/TestIntBoxing.java assert(p_f->Opcode() == Op_IfFalse) failed
roland
parents:
20680
diff
changeset
|
1831 if (p_f->Opcode() != Op_IfFalse) { |
6b40d295742c
8078866: compiler/eliminateAutobox/6934604/TestIntBoxing.java assert(p_f->Opcode() == Op_IfFalse) failed
roland
parents:
20680
diff
changeset
|
1832 return; |
6b40d295742c
8078866: compiler/eliminateAutobox/6934604/TestIntBoxing.java assert(p_f->Opcode() == Op_IfFalse) failed
roland
parents:
20680
diff
changeset
|
1833 } |
0 | 1834 CountedLoopEndNode *pre_end = p_f->in(0)->as_CountedLoopEnd(); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1835 assert(pre_end->loopnode()->is_pre_loop(), ""); |
0 | 1836 Node *pre_opaq1 = pre_end->limit(); |
1837 // Occasionally it's possible for a pre-loop Opaque1 node to be | |
1838 // optimized away and then another round of loop opts attempted. | |
1839 // We can not optimize this particular loop in that case. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1840 if (pre_opaq1->Opcode() != Op_Opaque1) |
0 | 1841 return; |
1842 Opaque1Node *pre_opaq = (Opaque1Node*)pre_opaq1; | |
1843 Node *pre_limit = pre_opaq->in(1); | |
1844 | |
1845 // Where do we put new limit calculations | |
1846 Node *pre_ctrl = pre_end->loopnode()->in(LoopNode::EntryControl); | |
1847 | |
1848 // Ensure the original loop limit is available from the | |
1849 // pre-loop Opaque1 node. | |
1850 Node *orig_limit = pre_opaq->original_loop_limit(); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
1851 if (orig_limit == NULL || _igvn.type(orig_limit) == Type::TOP) |
0 | 1852 return; |
1853 | |
1854 // Must know if its a count-up or count-down loop | |
1855 | |
1856 int stride_con = cl->stride_con(); | |
1857 Node *zero = _igvn.intcon(0); | |
1858 Node *one = _igvn.intcon(1); | |
3345 | 1859 // Use symmetrical int range [-max_jint,max_jint] |
1860 Node *mini = _igvn.intcon(-max_jint); | |
0 | 1861 set_ctrl(zero, C->root()); |
1862 set_ctrl(one, C->root()); | |
3345 | 1863 set_ctrl(mini, C->root()); |
0 | 1864 |
1865 // Range checks that do not dominate the loop backedge (ie. | |
1866 // conditionally executed) can lengthen the pre loop limit beyond | |
1867 // the original loop limit. To prevent this, the pre limit is | |
1868 // (for stride > 0) MINed with the original loop limit (MAXed | |
1869 // stride < 0) when some range_check (rc) is conditionally | |
1870 // executed. | |
1871 bool conditional_rc = false; | |
1872 | |
1873 // Check loop body for tests of trip-counter plus loop-invariant vs | |
1874 // loop-invariant. | |
1875 for( uint i = 0; i < loop->_body.size(); i++ ) { | |
1876 Node *iff = loop->_body[i]; | |
1877 if( iff->Opcode() == Op_If ) { // Test? | |
1878 | |
1879 // Test is an IfNode, has 2 projections. If BOTH are in the loop | |
1880 // we need loop unswitching instead of iteration splitting. | |
1881 Node *exit = loop->is_loop_exit(iff); | |
1882 if( !exit ) continue; | |
1883 int flip = (exit->Opcode() == Op_IfTrue) ? 1 : 0; | |
1884 | |
1885 // Get boolean condition to test | |
1886 Node *i1 = iff->in(1); | |
1887 if( !i1->is_Bool() ) continue; | |
1888 BoolNode *bol = i1->as_Bool(); | |
1889 BoolTest b_test = bol->_test; | |
1890 // Flip sense of test if exit condition is flipped | |
1891 if( flip ) | |
1892 b_test = b_test.negate(); | |
1893 | |
1894 // Get compare | |
1895 Node *cmp = bol->in(1); | |
1896 | |
1897 // Look for trip_counter + offset vs limit | |
1898 Node *rc_exp = cmp->in(1); | |
1899 Node *limit = cmp->in(2); | |
1900 jint scale_con= 1; // Assume trip counter not scaled | |
1901 | |
1902 Node *limit_c = get_ctrl(limit); | |
1903 if( loop->is_member(get_loop(limit_c) ) ) { | |
1904 // Compare might have operands swapped; commute them | |
1905 b_test = b_test.commute(); | |
1906 rc_exp = cmp->in(2); | |
1907 limit = cmp->in(1); | |
1908 limit_c = get_ctrl(limit); | |
1909 if( loop->is_member(get_loop(limit_c) ) ) | |
1910 continue; // Both inputs are loop varying; cannot RCE | |
1911 } | |
1912 // Here we know 'limit' is loop invariant | |
1913 | |
1914 // 'limit' maybe pinned below the zero trip test (probably from a | |
1915 // previous round of rce), in which case, it can't be used in the | |
1916 // zero trip test expression which must occur before the zero test's if. | |
1917 if( limit_c == ctrl ) { | |
1918 continue; // Don't rce this check but continue looking for other candidates. | |
1919 } | |
1920 | |
1921 // Check for scaled induction variable plus an offset | |
1922 Node *offset = NULL; | |
1923 | |
1924 if (!is_scaled_iv_plus_offset(rc_exp, trip_counter, &scale_con, &offset)) { | |
1925 continue; | |
1926 } | |
1927 | |
1928 Node *offset_c = get_ctrl(offset); | |
1929 if( loop->is_member( get_loop(offset_c) ) ) | |
1930 continue; // Offset is not really loop invariant | |
1931 // Here we know 'offset' is loop invariant. | |
1932 | |
1933 // As above for the 'limit', the 'offset' maybe pinned below the | |
1934 // zero trip test. | |
1935 if( offset_c == ctrl ) { | |
1936 continue; // Don't rce this check but continue looking for other candidates. | |
1937 } | |
3345 | 1938 #ifdef ASSERT |
1939 if (TraceRangeLimitCheck) { | |
1940 tty->print_cr("RC bool node%s", flip ? " flipped:" : ":"); | |
1941 bol->dump(2); | |
1942 } | |
1943 #endif | |
0 | 1944 // At this point we have the expression as: |
1945 // scale_con * trip_counter + offset :: limit | |
1946 // where scale_con, offset and limit are loop invariant. Trip_counter | |
1947 // monotonically increases by stride_con, a constant. Both (or either) | |
1948 // stride_con and scale_con can be negative which will flip about the | |
1949 // sense of the test. | |
1950 | |
1951 // Adjust pre and main loop limits to guard the correct iteration set | |
1952 if( cmp->Opcode() == Op_CmpU ) {// Unsigned compare is really 2 tests | |
1953 if( b_test._test == BoolTest::lt ) { // Range checks always use lt | |
3345 | 1954 // The underflow and overflow limits: 0 <= scale*I+offset < limit |
1955 add_constraint( stride_con, scale_con, offset, zero, limit, pre_ctrl, &pre_limit, &main_limit ); | |
0 | 1956 if (!conditional_rc) { |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1957 // (0-offset)/scale could be outside of loop iterations range. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1958 conditional_rc = !loop->dominates_backedge(iff) || RangeLimitCheck; |
0 | 1959 } |
1960 } else { | |
1961 #ifndef PRODUCT | |
1962 if( PrintOpto ) | |
1963 tty->print_cr("missed RCE opportunity"); | |
1964 #endif | |
1965 continue; // In release mode, ignore it | |
1966 } | |
1967 } else { // Otherwise work on normal compares | |
1968 switch( b_test._test ) { | |
3345 | 1969 case BoolTest::gt: |
1970 // Fall into GE case | |
1971 case BoolTest::ge: | |
1972 // Convert (I*scale+offset) >= Limit to (I*(-scale)+(-offset)) <= -Limit | |
0 | 1973 scale_con = -scale_con; |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1974 offset = new (C) SubINode( zero, offset ); |
0 | 1975 register_new_node( offset, pre_ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1976 limit = new (C) SubINode( zero, limit ); |
0 | 1977 register_new_node( limit, pre_ctrl ); |
1978 // Fall into LE case | |
3345 | 1979 case BoolTest::le: |
1980 if (b_test._test != BoolTest::gt) { | |
1981 // Convert X <= Y to X < Y+1 | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
1982 limit = new (C) AddINode( limit, one ); |
3345 | 1983 register_new_node( limit, pre_ctrl ); |
1984 } | |
0 | 1985 // Fall into LT case |
1986 case BoolTest::lt: | |
3345 | 1987 // The underflow and overflow limits: MIN_INT <= scale*I+offset < limit |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1988 // Note: (MIN_INT+1 == -MAX_INT) is used instead of MIN_INT here |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1989 // to avoid problem with scale == -1: MIN_INT/(-1) == MIN_INT. |
3345 | 1990 add_constraint( stride_con, scale_con, offset, mini, limit, pre_ctrl, &pre_limit, &main_limit ); |
0 | 1991 if (!conditional_rc) { |
3383
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1992 // ((MIN_INT+1)-offset)/scale could be outside of loop iterations range. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1993 // Note: negative offset is replaced with 0 but (MIN_INT+1)/scale could |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1994 // still be outside of loop range. |
38569792a45a
7044725: -XX:-UnrollLimitCheck -Xcomp : Exception: String index out of range: 29488
kvn
parents:
3367
diff
changeset
|
1995 conditional_rc = !loop->dominates_backedge(iff) || RangeLimitCheck; |
0 | 1996 } |
1997 break; | |
1998 default: | |
1999 #ifndef PRODUCT | |
2000 if( PrintOpto ) | |
2001 tty->print_cr("missed RCE opportunity"); | |
2002 #endif | |
2003 continue; // Unhandled case | |
2004 } | |
2005 } | |
2006 | |
2007 // Kill the eliminated test | |
2008 C->set_major_progress(); | |
2009 Node *kill_con = _igvn.intcon( 1-flip ); | |
2010 set_ctrl(kill_con, C->root()); | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
3930
diff
changeset
|
2011 _igvn.replace_input_of(iff, 1, kill_con); |
0 | 2012 // Find surviving projection |
2013 assert(iff->is_If(), ""); | |
2014 ProjNode* dp = ((IfNode*)iff)->proj_out(1-flip); | |
2015 // Find loads off the surviving projection; remove their control edge | |
2016 for (DUIterator_Fast imax, i = dp->fast_outs(imax); i < imax; i++) { | |
2017 Node* cd = dp->fast_out(i); // Control-dependent node | |
13045
94a83e0f9ce1
8017065: C2 allows safepoint checks to leak into G1 pre-barriers
iveresov
parents:
13020
diff
changeset
|
2018 if (cd->is_Load() && cd->depends_only_on_test()) { // Loads can now float around in the loop |
0 | 2019 // Allow the load to float around in the loop, or before it |
2020 // but NOT before the pre-loop. | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
3930
diff
changeset
|
2021 _igvn.replace_input_of(cd, 0, ctrl); // ctrl, not NULL |
0 | 2022 --i; |
2023 --imax; | |
2024 } | |
2025 } | |
2026 | |
2027 } // End of is IF | |
2028 | |
2029 } | |
2030 | |
2031 // Update loop limits | |
2032 if (conditional_rc) { | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2033 pre_limit = (stride_con > 0) ? (Node*)new (C) MinINode(pre_limit, orig_limit) |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2034 : (Node*)new (C) MaxINode(pre_limit, orig_limit); |
0 | 2035 register_new_node(pre_limit, pre_ctrl); |
2036 } | |
2037 _igvn.hash_delete(pre_opaq); | |
2038 pre_opaq->set_req(1, pre_limit); | |
2039 | |
2040 // Note:: we are making the main loop limit no longer precise; | |
2041 // need to round up based on stride. | |
3345 | 2042 cl->set_nonexact_trip_count(); |
2043 if (!LoopLimitCheck && stride_con != 1 && stride_con != -1) { // Cutout for common case | |
0 | 2044 // "Standard" round-up logic: ([main_limit-init+(y-1)]/y)*y+init |
2045 // Hopefully, compiler will optimize for powers of 2. | |
2046 Node *ctrl = get_ctrl(main_limit); | |
2047 Node *stride = cl->stride(); | |
2048 Node *init = cl->init_trip(); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2049 Node *span = new (C) SubINode(main_limit,init); |
0 | 2050 register_new_node(span,ctrl); |
2051 Node *rndup = _igvn.intcon(stride_con + ((stride_con>0)?-1:1)); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2052 Node *add = new (C) AddINode(span,rndup); |
0 | 2053 register_new_node(add,ctrl); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2054 Node *div = new (C) DivINode(0,add,stride); |
0 | 2055 register_new_node(div,ctrl); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2056 Node *mul = new (C) MulINode(div,stride); |
0 | 2057 register_new_node(mul,ctrl); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2058 Node *newlim = new (C) AddINode(mul,init); |
0 | 2059 register_new_node(newlim,ctrl); |
2060 main_limit = newlim; | |
2061 } | |
2062 | |
2063 Node *main_cle = cl->loopexit(); | |
2064 Node *main_bol = main_cle->in(1); | |
2065 // Hacking loop bounds; need private copies of exit test | |
2066 if( main_bol->outcnt() > 1 ) {// BoolNode shared? | |
2067 _igvn.hash_delete(main_cle); | |
2068 main_bol = main_bol->clone();// Clone a private BoolNode | |
2069 register_new_node( main_bol, main_cle->in(0) ); | |
2070 main_cle->set_req(1,main_bol); | |
2071 } | |
2072 Node *main_cmp = main_bol->in(1); | |
2073 if( main_cmp->outcnt() > 1 ) { // CmpNode shared? | |
2074 _igvn.hash_delete(main_bol); | |
2075 main_cmp = main_cmp->clone();// Clone a private CmpNode | |
2076 register_new_node( main_cmp, main_cle->in(0) ); | |
2077 main_bol->set_req(1,main_cmp); | |
2078 } | |
2079 // Hack the now-private loop bounds | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
3930
diff
changeset
|
2080 _igvn.replace_input_of(main_cmp, 2, main_limit); |
0 | 2081 // The OpaqueNode is unshared by design |
2082 assert( opqzm->outcnt() == 1, "cannot hack shared node" ); | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
3930
diff
changeset
|
2083 _igvn.replace_input_of(opqzm, 1, main_limit); |
0 | 2084 } |
2085 | |
2086 //------------------------------DCE_loop_body---------------------------------- | |
2087 // Remove simplistic dead code from loop body | |
2088 void IdealLoopTree::DCE_loop_body() { | |
2089 for( uint i = 0; i < _body.size(); i++ ) | |
2090 if( _body.at(i)->outcnt() == 0 ) | |
2091 _body.map( i--, _body.pop() ); | |
2092 } | |
2093 | |
2094 | |
2095 //------------------------------adjust_loop_exit_prob-------------------------- | |
2096 // Look for loop-exit tests with the 50/50 (or worse) guesses from the parsing stage. | |
2097 // Replace with a 1-in-10 exit guess. | |
2098 void IdealLoopTree::adjust_loop_exit_prob( PhaseIdealLoop *phase ) { | |
2099 Node *test = tail(); | |
2100 while( test != _head ) { | |
2101 uint top = test->Opcode(); | |
2102 if( top == Op_IfTrue || top == Op_IfFalse ) { | |
2103 int test_con = ((ProjNode*)test)->_con; | |
2104 assert(top == (uint)(test_con? Op_IfTrue: Op_IfFalse), "sanity"); | |
2105 IfNode *iff = test->in(0)->as_If(); | |
2106 if( iff->outcnt() == 2 ) { // Ignore dead tests | |
2107 Node *bol = iff->in(1); | |
2108 if( bol && bol->req() > 1 && bol->in(1) && | |
2109 ((bol->in(1)->Opcode() == Op_StorePConditional ) || | |
420
a1980da045cc
6462850: generate biased locking code in C2 ideal graph
kvn
parents:
401
diff
changeset
|
2110 (bol->in(1)->Opcode() == Op_StoreIConditional ) || |
0 | 2111 (bol->in(1)->Opcode() == Op_StoreLConditional ) || |
2112 (bol->in(1)->Opcode() == Op_CompareAndSwapI ) || | |
2113 (bol->in(1)->Opcode() == Op_CompareAndSwapL ) || | |
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
39
diff
changeset
|
2114 (bol->in(1)->Opcode() == Op_CompareAndSwapP ) || |
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
39
diff
changeset
|
2115 (bol->in(1)->Opcode() == Op_CompareAndSwapN ))) |
0 | 2116 return; // Allocation loops RARELY take backedge |
2117 // Find the OTHER exit path from the IF | |
2118 Node* ex = iff->proj_out(1-test_con); | |
2119 float p = iff->_prob; | |
2120 if( !phase->is_member( this, ex ) && iff->_fcnt == COUNT_UNKNOWN ) { | |
2121 if( top == Op_IfTrue ) { | |
2122 if( p < (PROB_FAIR + PROB_UNLIKELY_MAG(3))) { | |
2123 iff->_prob = PROB_STATIC_FREQUENT; | |
2124 } | |
2125 } else { | |
2126 if( p > (PROB_FAIR - PROB_UNLIKELY_MAG(3))) { | |
2127 iff->_prob = PROB_STATIC_INFREQUENT; | |
2128 } | |
2129 } | |
2130 } | |
2131 } | |
2132 } | |
2133 test = phase->idom(test); | |
2134 } | |
2135 } | |
2136 | |
2137 | |
2138 //------------------------------policy_do_remove_empty_loop-------------------- | |
2139 // Micro-benchmark spamming. Policy is to always remove empty loops. | |
2140 // The 'DO' part is to replace the trip counter with the value it will | |
2141 // have on the last iteration. This will break the loop. | |
2142 bool IdealLoopTree::policy_do_remove_empty_loop( PhaseIdealLoop *phase ) { | |
2143 // Minimum size must be empty loop | |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
2144 if (_body.size() > EMPTY_LOOP_SIZE) |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2145 return false; |
0 | 2146 |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2147 if (!_head->is_CountedLoop()) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2148 return false; // Dead loop |
0 | 2149 CountedLoopNode *cl = _head->as_CountedLoop(); |
3850
6987871cfb9b
7077439: Possible reference through NULL in loopPredicate.cpp:726
kvn
parents:
3845
diff
changeset
|
2150 if (!cl->is_valid_counted_loop()) |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2151 return false; // Malformed loop |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2152 if (!phase->is_member(this, phase->get_ctrl(cl->loopexit()->in(CountedLoopEndNode::TestValue)))) |
0 | 2153 return false; // Infinite loop |
2403 | 2154 |
0 | 2155 #ifdef ASSERT |
2156 // Ensure only one phi which is the iv. | |
2157 Node* iv = NULL; | |
2158 for (DUIterator_Fast imax, i = cl->fast_outs(imax); i < imax; i++) { | |
2159 Node* n = cl->fast_out(i); | |
2160 if (n->Opcode() == Op_Phi) { | |
2161 assert(iv == NULL, "Too many phis" ); | |
2162 iv = n; | |
2163 } | |
2164 } | |
2165 assert(iv == cl->phi(), "Wrong phi" ); | |
2166 #endif | |
2403 | 2167 |
2168 // main and post loops have explicitly created zero trip guard | |
2169 bool needs_guard = !cl->is_main_loop() && !cl->is_post_loop(); | |
2170 if (needs_guard) { | |
2465 | 2171 // Skip guard if values not overlap. |
2172 const TypeInt* init_t = phase->_igvn.type(cl->init_trip())->is_int(); | |
2173 const TypeInt* limit_t = phase->_igvn.type(cl->limit())->is_int(); | |
2174 int stride_con = cl->stride_con(); | |
2175 if (stride_con > 0) { | |
2176 needs_guard = (init_t->_hi >= limit_t->_lo); | |
2177 } else { | |
2178 needs_guard = (init_t->_lo <= limit_t->_hi); | |
2179 } | |
2180 } | |
2181 if (needs_guard) { | |
2403 | 2182 // Check for an obvious zero trip guard. |
2445 | 2183 Node* inctrl = PhaseIdealLoop::skip_loop_predicates(cl->in(LoopNode::EntryControl)); |
2403 | 2184 if (inctrl->Opcode() == Op_IfTrue) { |
2185 // The test should look like just the backedge of a CountedLoop | |
2186 Node* iff = inctrl->in(0); | |
2187 if (iff->is_If()) { | |
2188 Node* bol = iff->in(1); | |
2189 if (bol->is_Bool() && bol->as_Bool()->_test._test == cl->loopexit()->test_trip()) { | |
2190 Node* cmp = bol->in(1); | |
2191 if (cmp->is_Cmp() && cmp->in(1) == cl->init_trip() && cmp->in(2) == cl->limit()) { | |
2192 needs_guard = false; | |
2193 } | |
2194 } | |
2195 } | |
2196 } | |
2197 } | |
2198 | |
2199 #ifndef PRODUCT | |
2200 if (PrintOpto) { | |
2201 tty->print("Removing empty loop with%s zero trip guard", needs_guard ? "out" : ""); | |
2202 this->dump_head(); | |
2203 } else if (TraceLoopOpts) { | |
2204 tty->print("Empty with%s zero trip guard ", needs_guard ? "out" : ""); | |
2205 this->dump_head(); | |
2206 } | |
2207 #endif | |
2208 | |
2209 if (needs_guard) { | |
2210 // Peel the loop to ensure there's a zero trip guard | |
2211 Node_List old_new; | |
2212 phase->do_peeling(this, old_new); | |
2213 } | |
2214 | |
0 | 2215 // Replace the phi at loop head with the final value of the last |
2216 // iteration. Then the CountedLoopEnd will collapse (backedge never | |
2217 // taken) and all loop-invariant uses of the exit values will be correct. | |
2218 Node *phi = cl->phi(); | |
3345 | 2219 Node *exact_limit = phase->exact_limit(this); |
2220 if (exact_limit != cl->limit()) { | |
2221 // We also need to replace the original limit to collapse loop exit. | |
2222 Node* cmp = cl->loopexit()->cmp_node(); | |
2223 assert(cl->limit() == cmp->in(2), "sanity"); | |
2224 phase->_igvn._worklist.push(cmp->in(2)); // put limit on worklist | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
3930
diff
changeset
|
2225 phase->_igvn.replace_input_of(cmp, 2, exact_limit); // put cmp on worklist |
3345 | 2226 } |
2227 // Note: the final value after increment should not overflow since | |
2228 // counted loop has limit check predicate. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2229 Node *final = new (phase->C) SubINode( exact_limit, cl->stride() ); |
0 | 2230 phase->register_new_node(final,cl->in(LoopNode::EntryControl)); |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
2231 phase->_igvn.replace_node(phi,final); |
0 | 2232 phase->C->set_major_progress(); |
2233 return true; | |
2234 } | |
2235 | |
2465 | 2236 //------------------------------policy_do_one_iteration_loop------------------- |
2237 // Convert one iteration loop into normal code. | |
2238 bool IdealLoopTree::policy_do_one_iteration_loop( PhaseIdealLoop *phase ) { | |
2239 if (!_head->as_Loop()->is_valid_counted_loop()) | |
2240 return false; // Only for counted loop | |
2241 | |
2242 CountedLoopNode *cl = _head->as_CountedLoop(); | |
2243 if (!cl->has_exact_trip_count() || cl->trip_count() != 1) { | |
2244 return false; | |
2245 } | |
2246 | |
2247 #ifndef PRODUCT | |
2248 if(TraceLoopOpts) { | |
2249 tty->print("OneIteration "); | |
2250 this->dump_head(); | |
2251 } | |
2252 #endif | |
2253 | |
2254 Node *init_n = cl->init_trip(); | |
2255 #ifdef ASSERT | |
2256 // Loop boundaries should be constant since trip count is exact. | |
2257 assert(init_n->get_int() + cl->stride_con() >= cl->limit()->get_int(), "should be one iteration"); | |
2258 #endif | |
2259 // Replace the phi at loop head with the value of the init_trip. | |
2260 // Then the CountedLoopEnd will collapse (backedge will not be taken) | |
2261 // and all loop-invariant uses of the exit values will be correct. | |
2262 phase->_igvn.replace_node(cl->phi(), cl->init_trip()); | |
2263 phase->C->set_major_progress(); | |
2264 return true; | |
2265 } | |
0 | 2266 |
2267 //============================================================================= | |
2268 //------------------------------iteration_split_impl--------------------------- | |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2269 bool IdealLoopTree::iteration_split_impl( PhaseIdealLoop *phase, Node_List &old_new ) { |
2465 | 2270 // Compute exact loop trip count if possible. |
2271 compute_exact_trip_count(phase); | |
2272 | |
2273 // Convert one iteration loop into normal code. | |
2274 if (policy_do_one_iteration_loop(phase)) | |
2275 return true; | |
2276 | |
0 | 2277 // Check and remove empty loops (spam micro-benchmarks) |
2465 | 2278 if (policy_do_remove_empty_loop(phase)) |
1172 | 2279 return true; // Here we removed an empty loop |
0 | 2280 |
2281 bool should_peel = policy_peeling(phase); // Should we peel? | |
2282 | |
2283 bool should_unswitch = policy_unswitching(phase); | |
2284 | |
2285 // Non-counted loops may be peeled; exactly 1 iteration is peeled. | |
2286 // This removes loop-invariant tests (usually null checks). | |
2465 | 2287 if (!_head->is_CountedLoop()) { // Non-counted loop |
0 | 2288 if (PartialPeelLoop && phase->partial_peel(this, old_new)) { |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2289 // Partial peel succeeded so terminate this round of loop opts |
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2290 return false; |
0 | 2291 } |
2465 | 2292 if (should_peel) { // Should we peel? |
0 | 2293 #ifndef PRODUCT |
2294 if (PrintOpto) tty->print_cr("should_peel"); | |
2295 #endif | |
2296 phase->do_peeling(this,old_new); | |
2465 | 2297 } else if (should_unswitch) { |
0 | 2298 phase->do_unswitching(this, old_new); |
2299 } | |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2300 return true; |
0 | 2301 } |
2302 CountedLoopNode *cl = _head->as_CountedLoop(); | |
2303 | |
3850
6987871cfb9b
7077439: Possible reference through NULL in loopPredicate.cpp:726
kvn
parents:
3845
diff
changeset
|
2304 if (!cl->is_valid_counted_loop()) return true; // Ignore various kinds of broken loops |
0 | 2305 |
2306 // Do nothing special to pre- and post- loops | |
2465 | 2307 if (cl->is_pre_loop() || cl->is_post_loop()) return true; |
0 | 2308 |
2309 // Compute loop trip count from profile data | |
2310 compute_profile_trip_cnt(phase); | |
2311 | |
2312 // Before attempting fancy unrolling, RCE or alignment, see if we want | |
2313 // to completely unroll this loop or do loop unswitching. | |
2465 | 2314 if (cl->is_normal_loop()) { |
789
273b2358ef1a
6837146: Should perform unswitch before maximally unroll in loop transformation
cfang
parents:
605
diff
changeset
|
2315 if (should_unswitch) { |
273b2358ef1a
6837146: Should perform unswitch before maximally unroll in loop transformation
cfang
parents:
605
diff
changeset
|
2316 phase->do_unswitching(this, old_new); |
273b2358ef1a
6837146: Should perform unswitch before maximally unroll in loop transformation
cfang
parents:
605
diff
changeset
|
2317 return true; |
273b2358ef1a
6837146: Should perform unswitch before maximally unroll in loop transformation
cfang
parents:
605
diff
changeset
|
2318 } |
0 | 2319 bool should_maximally_unroll = policy_maximally_unroll(phase); |
2465 | 2320 if (should_maximally_unroll) { |
0 | 2321 // Here we did some unrolling and peeling. Eventually we will |
2322 // completely unroll this loop and it will no longer be a loop. | |
2323 phase->do_maximally_unroll(this,old_new); | |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2324 return true; |
0 | 2325 } |
2326 } | |
2327 | |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
2328 // Skip next optimizations if running low on nodes. Note that |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
2329 // policy_unswitching and policy_maximally_unroll have this check. |
20671
9e69e8d1c900
8058148: MaxNodeLimit and LiveNodeCountInliningCutoff
vlivanov
parents:
17887
diff
changeset
|
2330 int nodes_left = phase->C->max_node_limit() - phase->C->live_nodes(); |
9e69e8d1c900
8058148: MaxNodeLimit and LiveNodeCountInliningCutoff
vlivanov
parents:
17887
diff
changeset
|
2331 if ((int)(2 * _body.size()) > nodes_left) { |
2453
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
2332 return true; |
d7a3fed1c1c9
7004547: regular loop unroll should not unroll more than max unrolling
kvn
parents:
2448
diff
changeset
|
2333 } |
0 | 2334 |
2335 // Counted loops may be peeled, may need some iterations run up | |
2336 // front for RCE, and may want to align loop refs to a cache | |
2337 // line. Thus we clone a full loop up front whose trip count is | |
2338 // at least 1 (if peeling), but may be several more. | |
2339 | |
2340 // The main loop will start cache-line aligned with at least 1 | |
2341 // iteration of the unrolled body (zero-trip test required) and | |
2342 // will have some range checks removed. | |
2343 | |
2344 // A post-loop will finish any odd iterations (leftover after | |
2345 // unrolling), plus any needed for RCE purposes. | |
2346 | |
2347 bool should_unroll = policy_unroll(phase); | |
2348 | |
2349 bool should_rce = policy_range_check(phase); | |
2350 | |
2351 bool should_align = policy_align(phase); | |
2352 | |
2353 // If not RCE'ing (iteration splitting) or Aligning, then we do not | |
2354 // need a pre-loop. We may still need to peel an initial iteration but | |
2355 // we will not be needing an unknown number of pre-iterations. | |
2356 // | |
2357 // Basically, if may_rce_align reports FALSE first time through, | |
2358 // we will not be able to later do RCE or Aligning on this loop. | |
2359 bool may_rce_align = !policy_peel_only(phase) || should_rce || should_align; | |
2360 | |
2361 // If we have any of these conditions (RCE, alignment, unrolling) met, then | |
2362 // we switch to the pre-/main-/post-loop model. This model also covers | |
2363 // peeling. | |
2465 | 2364 if (should_rce || should_align || should_unroll) { |
2365 if (cl->is_normal_loop()) // Convert to 'pre/main/post' loops | |
0 | 2366 phase->insert_pre_post_loops(this,old_new, !may_rce_align); |
2367 | |
2368 // Adjust the pre- and main-loop limits to let the pre and post loops run | |
2369 // with full checks, but the main-loop with no checks. Remove said | |
2370 // checks from the main body. | |
2465 | 2371 if (should_rce) |
0 | 2372 phase->do_range_check(this,old_new); |
2373 | |
2374 // Double loop body for unrolling. Adjust the minimum-trip test (will do | |
2375 // twice as many iterations as before) and the main body limit (only do | |
2376 // an even number of trips). If we are peeling, we might enable some RCE | |
2377 // and we'd rather unroll the post-RCE'd loop SO... do not unroll if | |
2378 // peeling. | |
2465 | 2379 if (should_unroll && !should_peel) |
2380 phase->do_unroll(this,old_new, true); | |
0 | 2381 |
2382 // Adjust the pre-loop limits to align the main body | |
2383 // iterations. | |
2465 | 2384 if (should_align) |
0 | 2385 Unimplemented(); |
2386 | |
2387 } else { // Else we have an unchanged counted loop | |
2465 | 2388 if (should_peel) // Might want to peel but do nothing else |
0 | 2389 phase->do_peeling(this,old_new); |
2390 } | |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2391 return true; |
0 | 2392 } |
2393 | |
2394 | |
2395 //============================================================================= | |
2396 //------------------------------iteration_split-------------------------------- | |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2397 bool IdealLoopTree::iteration_split( PhaseIdealLoop *phase, Node_List &old_new ) { |
0 | 2398 // Recursively iteration split nested loops |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2399 if (_child && !_child->iteration_split(phase, old_new)) |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2400 return false; |
0 | 2401 |
2402 // Clean out prior deadwood | |
2403 DCE_loop_body(); | |
2404 | |
2405 | |
2406 // Look for loop-exit tests with my 50/50 guesses from the Parsing stage. | |
2407 // Replace with a 1-in-10 exit guess. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2408 if (_parent /*not the root loop*/ && |
0 | 2409 !_irreducible && |
2410 // Also ignore the occasional dead backedge | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2411 !tail()->is_top()) { |
0 | 2412 adjust_loop_exit_prob(phase); |
2413 } | |
2414 | |
2415 // Gate unrolling, RCE and peeling efforts. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2416 if (!_child && // If not an inner loop, do not split |
0 | 2417 !_irreducible && |
39
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
0
diff
changeset
|
2418 _allow_optimizations && |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2419 !tail()->is_top()) { // Also ignore the occasional dead backedge |
0 | 2420 if (!_has_call) { |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2421 if (!iteration_split_impl(phase, old_new)) { |
1172 | 2422 return false; |
2423 } | |
0 | 2424 } else if (policy_unswitching(phase)) { |
2425 phase->do_unswitching(this, old_new); | |
2426 } | |
2427 } | |
2428 | |
2429 // Minor offset re-organization to remove loop-fallout uses of | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2430 // trip counter when there was no major reshaping. |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2431 phase->reorg_offsets(this); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2432 |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2433 if (_next && !_next->iteration_split(phase, old_new)) |
401
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2434 return false; |
ee8f06bfb27c
6743188: incomplete fix for 6700047 C2 failed in idom_no_update
never
parents:
400
diff
changeset
|
2435 return true; |
0 | 2436 } |
1172 | 2437 |
2438 | |
2445 | 2439 //============================================================================= |
1763 | 2440 // Process all the loops in the loop tree and replace any fill |
23872
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2441 // patterns with an intrinsic version. |
1763 | 2442 bool PhaseIdealLoop::do_intrinsify_fill() { |
2443 bool changed = false; | |
2444 for (LoopTreeIterator iter(_ltree_root); !iter.done(); iter.next()) { | |
2445 IdealLoopTree* lpt = iter.current(); | |
2446 changed |= intrinsify_fill(lpt); | |
2447 } | |
2448 return changed; | |
2449 } | |
2450 | |
2451 | |
2452 // Examine an inner loop looking for a a single store of an invariant | |
2453 // value in a unit stride loop, | |
2454 bool PhaseIdealLoop::match_fill_loop(IdealLoopTree* lpt, Node*& store, Node*& store_value, | |
2455 Node*& shift, Node*& con) { | |
2456 const char* msg = NULL; | |
2457 Node* msg_node = NULL; | |
2458 | |
2459 store_value = NULL; | |
2460 con = NULL; | |
2461 shift = NULL; | |
2462 | |
2463 // Process the loop looking for stores. If there are multiple | |
2464 // stores or extra control flow give at this point. | |
2465 CountedLoopNode* head = lpt->_head->as_CountedLoop(); | |
2466 for (uint i = 0; msg == NULL && i < lpt->_body.size(); i++) { | |
2467 Node* n = lpt->_body.at(i); | |
2468 if (n->outcnt() == 0) continue; // Ignore dead | |
2469 if (n->is_Store()) { | |
2470 if (store != NULL) { | |
2471 msg = "multiple stores"; | |
2472 break; | |
2473 } | |
2474 int opc = n->Opcode(); | |
6848
8e47bac5643a
7054512: Compress class pointers after perm gen removal
roland
parents:
6846
diff
changeset
|
2475 if (opc == Op_StoreP || opc == Op_StoreN || opc == Op_StoreNKlass || opc == Op_StoreCM) { |
1763 | 2476 msg = "oop fills not handled"; |
2477 break; | |
2478 } | |
2479 Node* value = n->in(MemNode::ValueIn); | |
2480 if (!lpt->is_invariant(value)) { | |
2481 msg = "variant store value"; | |
1785
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2482 } else if (!_igvn.type(n->in(MemNode::Address))->isa_aryptr()) { |
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2483 msg = "not array address"; |
1763 | 2484 } |
2485 store = n; | |
2486 store_value = value; | |
2487 } else if (n->is_If() && n != head->loopexit()) { | |
2488 msg = "extra control flow"; | |
2489 msg_node = n; | |
2490 } | |
2491 } | |
2492 | |
2493 if (store == NULL) { | |
2494 // No store in loop | |
2495 return false; | |
2496 } | |
2497 | |
2498 if (msg == NULL && head->stride_con() != 1) { | |
2499 // could handle negative strides too | |
2500 if (head->stride_con() < 0) { | |
2501 msg = "negative stride"; | |
2502 } else { | |
2503 msg = "non-unit stride"; | |
2504 } | |
2505 } | |
2506 | |
2507 if (msg == NULL && !store->in(MemNode::Address)->is_AddP()) { | |
2508 msg = "can't handle store address"; | |
2509 msg_node = store->in(MemNode::Address); | |
2510 } | |
2511 | |
1813
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2512 if (msg == NULL && |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2513 (!store->in(MemNode::Memory)->is_Phi() || |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2514 store->in(MemNode::Memory)->in(LoopNode::LoopBackControl) != store)) { |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2515 msg = "store memory isn't proper phi"; |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2516 msg_node = store->in(MemNode::Memory); |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2517 } |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2518 |
1763 | 2519 // Make sure there is an appropriate fill routine |
2520 BasicType t = store->as_Mem()->memory_type(); | |
2521 const char* fill_name; | |
2522 if (msg == NULL && | |
2523 StubRoutines::select_fill_function(t, false, fill_name) == NULL) { | |
2524 msg = "unsupported store"; | |
2525 msg_node = store; | |
2526 } | |
2527 | |
2528 if (msg != NULL) { | |
2529 #ifndef PRODUCT | |
2530 if (TraceOptimizeFill) { | |
2531 tty->print_cr("not fill intrinsic candidate: %s", msg); | |
2532 if (msg_node != NULL) msg_node->dump(); | |
2533 } | |
2534 #endif | |
2535 return false; | |
2536 } | |
2537 | |
2538 // Make sure the address expression can be handled. It should be | |
23872
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2539 // head->phi * elsize + con. head->phi might have a ConvI2L(CastII()). |
1763 | 2540 Node* elements[4]; |
23872
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2541 Node* cast = NULL; |
1763 | 2542 Node* conv = NULL; |
1785
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2543 bool found_index = false; |
1763 | 2544 int count = store->in(MemNode::Address)->as_AddP()->unpack_offsets(elements, ARRAY_SIZE(elements)); |
2545 for (int e = 0; e < count; e++) { | |
2546 Node* n = elements[e]; | |
2547 if (n->is_Con() && con == NULL) { | |
2548 con = n; | |
2549 } else if (n->Opcode() == Op_LShiftX && shift == NULL) { | |
2550 Node* value = n->in(1); | |
2551 #ifdef _LP64 | |
2552 if (value->Opcode() == Op_ConvI2L) { | |
2553 conv = value; | |
2554 value = value->in(1); | |
2555 } | |
23872
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2556 if (value->Opcode() == Op_CastII && |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2557 value->as_CastII()->has_range_check()) { |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2558 // Skip range check dependent CastII nodes |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2559 cast = value; |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2560 value = value->in(1); |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2561 } |
1763 | 2562 #endif |
2563 if (value != head->phi()) { | |
2564 msg = "unhandled shift in address"; | |
2565 } else { | |
2448
8b2317d732ec
7026957: assert(type2aelembytes(store->as_Mem()->memory_type(), true) == 1 << shift->in(2)->get_int()) failed
never
parents:
2445
diff
changeset
|
2566 if (type2aelembytes(store->as_Mem()->memory_type(), true) != (1 << n->in(2)->get_int())) { |
8b2317d732ec
7026957: assert(type2aelembytes(store->as_Mem()->memory_type(), true) == 1 << shift->in(2)->get_int()) failed
never
parents:
2445
diff
changeset
|
2567 msg = "scale doesn't match"; |
8b2317d732ec
7026957: assert(type2aelembytes(store->as_Mem()->memory_type(), true) == 1 << shift->in(2)->get_int()) failed
never
parents:
2445
diff
changeset
|
2568 } else { |
8b2317d732ec
7026957: assert(type2aelembytes(store->as_Mem()->memory_type(), true) == 1 << shift->in(2)->get_int()) failed
never
parents:
2445
diff
changeset
|
2569 found_index = true; |
8b2317d732ec
7026957: assert(type2aelembytes(store->as_Mem()->memory_type(), true) == 1 << shift->in(2)->get_int()) failed
never
parents:
2445
diff
changeset
|
2570 shift = n; |
8b2317d732ec
7026957: assert(type2aelembytes(store->as_Mem()->memory_type(), true) == 1 << shift->in(2)->get_int()) failed
never
parents:
2445
diff
changeset
|
2571 } |
1763 | 2572 } |
2573 } else if (n->Opcode() == Op_ConvI2L && conv == NULL) { | |
23872
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2574 conv = n; |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2575 n = n->in(1); |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2576 if (n->Opcode() == Op_CastII && |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2577 n->as_CastII()->has_range_check()) { |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2578 // Skip range check dependent CastII nodes |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2579 cast = n; |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2580 n = n->in(1); |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2581 } |
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2582 if (n == head->phi()) { |
1785
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2583 found_index = true; |
1763 | 2584 } else { |
2585 msg = "unhandled input to ConvI2L"; | |
2586 } | |
2587 } else if (n == head->phi()) { | |
2588 // no shift, check below for allowed cases | |
1785
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2589 found_index = true; |
1763 | 2590 } else { |
2591 msg = "unhandled node in address"; | |
2592 msg_node = n; | |
2593 } | |
2594 } | |
2595 | |
2596 if (count == -1) { | |
2597 msg = "malformed address expression"; | |
2598 msg_node = store; | |
2599 } | |
2600 | |
1785
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2601 if (!found_index) { |
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2602 msg = "missing use of index"; |
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2603 } |
5e4f03302987
6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled
never
parents:
1763
diff
changeset
|
2604 |
1763 | 2605 // byte sized items won't have a shift |
2606 if (msg == NULL && shift == NULL && t != T_BYTE && t != T_BOOLEAN) { | |
2607 msg = "can't find shift"; | |
2608 msg_node = store; | |
2609 } | |
2610 | |
2611 if (msg != NULL) { | |
2612 #ifndef PRODUCT | |
2613 if (TraceOptimizeFill) { | |
2614 tty->print_cr("not fill intrinsic: %s", msg); | |
2615 if (msg_node != NULL) msg_node->dump(); | |
2616 } | |
2617 #endif | |
2618 return false; | |
2619 } | |
2620 | |
2621 // No make sure all the other nodes in the loop can be handled | |
2622 VectorSet ok(Thread::current()->resource_area()); | |
2623 | |
2624 // store related values are ok | |
2625 ok.set(store->_idx); | |
2626 ok.set(store->in(MemNode::Memory)->_idx); | |
2627 | |
8779
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2628 CountedLoopEndNode* loop_exit = head->loopexit(); |
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2629 guarantee(loop_exit != NULL, "no loop exit node"); |
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2630 |
1763 | 2631 // Loop structure is ok |
2632 ok.set(head->_idx); | |
8779
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2633 ok.set(loop_exit->_idx); |
1763 | 2634 ok.set(head->phi()->_idx); |
2635 ok.set(head->incr()->_idx); | |
8779
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2636 ok.set(loop_exit->cmp_node()->_idx); |
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2637 ok.set(loop_exit->in(1)->_idx); |
1763 | 2638 |
2639 // Address elements are ok | |
2640 if (con) ok.set(con->_idx); | |
2641 if (shift) ok.set(shift->_idx); | |
23872
94ec11846b18
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
23065
diff
changeset
|
2642 if (cast) ok.set(cast->_idx); |
1763 | 2643 if (conv) ok.set(conv->_idx); |
2644 | |
2645 for (uint i = 0; msg == NULL && i < lpt->_body.size(); i++) { | |
2646 Node* n = lpt->_body.at(i); | |
2647 if (n->outcnt() == 0) continue; // Ignore dead | |
2648 if (ok.test(n->_idx)) continue; | |
2649 // Backedge projection is ok | |
8779
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2650 if (n->is_IfTrue() && n->in(0) == loop_exit) continue; |
1763 | 2651 if (!n->is_AddP()) { |
2652 msg = "unhandled node"; | |
2653 msg_node = n; | |
2654 break; | |
2655 } | |
2656 } | |
2657 | |
2658 // Make sure no unexpected values are used outside the loop | |
2659 for (uint i = 0; msg == NULL && i < lpt->_body.size(); i++) { | |
2660 Node* n = lpt->_body.at(i); | |
2661 // These values can be replaced with other nodes if they are used | |
2662 // outside the loop. | |
8779
a59625d96f71
8009181: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopTransform.cpp
morris
parents:
8703
diff
changeset
|
2663 if (n == store || n == loop_exit || n == head->incr() || n == store->in(MemNode::Memory)) continue; |
1763 | 2664 for (SimpleDUIterator iter(n); iter.has_next(); iter.next()) { |
2665 Node* use = iter.get(); | |
2666 if (!lpt->_body.contains(use)) { | |
2667 msg = "node is used outside loop"; | |
2668 // lpt->_body.dump(); | |
2669 msg_node = n; | |
2670 break; | |
2671 } | |
2672 } | |
2673 } | |
2674 | |
2675 #ifdef ASSERT | |
2676 if (TraceOptimizeFill) { | |
2677 if (msg != NULL) { | |
2678 tty->print_cr("no fill intrinsic: %s", msg); | |
2679 if (msg_node != NULL) msg_node->dump(); | |
2680 } else { | |
2681 tty->print_cr("fill intrinsic for:"); | |
2682 } | |
2683 store->dump(); | |
2684 if (Verbose) { | |
2685 lpt->_body.dump(); | |
2686 } | |
2687 } | |
2688 #endif | |
2689 | |
2690 return msg == NULL; | |
2691 } | |
2692 | |
2693 | |
2694 | |
2695 bool PhaseIdealLoop::intrinsify_fill(IdealLoopTree* lpt) { | |
2696 // Only for counted inner loops | |
2697 if (!lpt->is_counted() || !lpt->is_inner()) { | |
2698 return false; | |
2699 } | |
2700 | |
2701 // Must have constant stride | |
2702 CountedLoopNode* head = lpt->_head->as_CountedLoop(); | |
3850
6987871cfb9b
7077439: Possible reference through NULL in loopPredicate.cpp:726
kvn
parents:
3845
diff
changeset
|
2703 if (!head->is_valid_counted_loop() || !head->is_normal_loop()) { |
1763 | 2704 return false; |
2705 } | |
2706 | |
2707 // Check that the body only contains a store of a loop invariant | |
2708 // value that is indexed by the loop phi. | |
2709 Node* store = NULL; | |
2710 Node* store_value = NULL; | |
2711 Node* shift = NULL; | |
2712 Node* offset = NULL; | |
2713 if (!match_fill_loop(lpt, store, store_value, shift, offset)) { | |
2714 return false; | |
2715 } | |
2716 | |
2445 | 2717 #ifndef PRODUCT |
2718 if (TraceLoopOpts) { | |
2719 tty->print("ArrayFill "); | |
2720 lpt->dump_head(); | |
2721 } | |
2722 #endif | |
2723 | |
1763 | 2724 // Now replace the whole loop body by a call to a fill routine that |
2725 // covers the same region as the loop. | |
2726 Node* base = store->in(MemNode::Address)->as_AddP()->in(AddPNode::Base); | |
2727 | |
2728 // Build an expression for the beginning of the copy region | |
2729 Node* index = head->init_trip(); | |
2730 #ifdef _LP64 | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2731 index = new (C) ConvI2LNode(index); |
1763 | 2732 _igvn.register_new_node_with_optimizer(index); |
2733 #endif | |
2734 if (shift != NULL) { | |
2735 // byte arrays don't require a shift but others do. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2736 index = new (C) LShiftXNode(index, shift->in(2)); |
1763 | 2737 _igvn.register_new_node_with_optimizer(index); |
2738 } | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2739 index = new (C) AddPNode(base, base, index); |
1763 | 2740 _igvn.register_new_node_with_optimizer(index); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2741 Node* from = new (C) AddPNode(base, index, offset); |
1763 | 2742 _igvn.register_new_node_with_optimizer(from); |
2743 // Compute the number of elements to copy | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2744 Node* len = new (C) SubINode(head->limit(), head->init_trip()); |
1763 | 2745 _igvn.register_new_node_with_optimizer(len); |
2746 | |
2747 BasicType t = store->as_Mem()->memory_type(); | |
2748 bool aligned = false; | |
2749 if (offset != NULL && head->init_trip()->is_Con()) { | |
2750 int element_size = type2aelembytes(t); | |
2751 aligned = (offset->find_intptr_t_type()->get_con() + head->init_trip()->get_int() * element_size) % HeapWordSize == 0; | |
2752 } | |
2753 | |
2754 // Build a call to the fill routine | |
2755 const char* fill_name; | |
2756 address fill = StubRoutines::select_fill_function(t, aligned, fill_name); | |
2757 assert(fill != NULL, "what?"); | |
2758 | |
2759 // Convert float/double to int/long for fill routines | |
2760 if (t == T_FLOAT) { | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2761 store_value = new (C) MoveF2INode(store_value); |
1763 | 2762 _igvn.register_new_node_with_optimizer(store_value); |
2763 } else if (t == T_DOUBLE) { | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2764 store_value = new (C) MoveD2LNode(store_value); |
1763 | 2765 _igvn.register_new_node_with_optimizer(store_value); |
2766 } | |
2767 | |
14418
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2768 if (CCallingConventionRequiresIntsAsLongs && |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2769 // See StubRoutines::select_fill_function for types. FLOAT has been converted to INT. |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2770 (t == T_FLOAT || t == T_INT || is_subword_type(t))) { |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2771 store_value = new (C) ConvI2LNode(store_value); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2772 _igvn.register_new_node_with_optimizer(store_value); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2773 } |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2774 |
1763 | 2775 Node* mem_phi = store->in(MemNode::Memory); |
2776 Node* result_ctrl; | |
2777 Node* result_mem; | |
2778 const TypeFunc* call_type = OptoRuntime::array_fill_Type(); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2779 CallLeafNode *call = new (C) CallLeafNoFPNode(call_type, fill, |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2780 fill_name, TypeAryPtr::get_array_body_type(t)); |
14418
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2781 uint cnt = 0; |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2782 call->init_req(TypeFunc::Parms + cnt++, from); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2783 call->init_req(TypeFunc::Parms + cnt++, store_value); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2784 if (CCallingConventionRequiresIntsAsLongs) { |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2785 call->init_req(TypeFunc::Parms + cnt++, C->top()); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2786 } |
1844
75588558f1bf
6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)"
never
parents:
1813
diff
changeset
|
2787 #ifdef _LP64 |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2788 len = new (C) ConvI2LNode(len); |
1844
75588558f1bf
6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)"
never
parents:
1813
diff
changeset
|
2789 _igvn.register_new_node_with_optimizer(len); |
75588558f1bf
6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)"
never
parents:
1813
diff
changeset
|
2790 #endif |
14418
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2791 call->init_req(TypeFunc::Parms + cnt++, len); |
1844
75588558f1bf
6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)"
never
parents:
1813
diff
changeset
|
2792 #ifdef _LP64 |
14418
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2793 call->init_req(TypeFunc::Parms + cnt++, C->top()); |
1844
75588558f1bf
6980792: Crash "exception happened outside interpreter, nmethods and vtable stubs (1)"
never
parents:
1813
diff
changeset
|
2794 #endif |
14418
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2795 call->init_req(TypeFunc::Control, head->init_control()); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2796 call->init_req(TypeFunc::I_O, C->top()); // Does no I/O. |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2797 call->init_req(TypeFunc::Memory, mem_phi->in(LoopNode::EntryControl)); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2798 call->init_req(TypeFunc::ReturnAdr, C->start()->proj_out(TypeFunc::ReturnAdr)); |
cfd05ec74089
8024342: PPC64 (part 111): Support for C calling conventions that require 64-bit ints.
goetz
parents:
12027
diff
changeset
|
2799 call->init_req(TypeFunc::FramePtr, C->start()->proj_out(TypeFunc::FramePtr)); |
1763 | 2800 _igvn.register_new_node_with_optimizer(call); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2801 result_ctrl = new (C) ProjNode(call,TypeFunc::Control); |
1763 | 2802 _igvn.register_new_node_with_optimizer(result_ctrl); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6636
diff
changeset
|
2803 result_mem = new (C) ProjNode(call,TypeFunc::Memory); |
1763 | 2804 _igvn.register_new_node_with_optimizer(result_mem); |
2805 | |
6906 | 2806 /* Disable following optimization until proper fix (add missing checks). |
2807 | |
1763 | 2808 // If this fill is tightly coupled to an allocation and overwrites |
2809 // the whole body, allow it to take over the zeroing. | |
2810 AllocateNode* alloc = AllocateNode::Ideal_allocation(base, this); | |
2811 if (alloc != NULL && alloc->is_AllocateArray()) { | |
2812 Node* length = alloc->as_AllocateArray()->Ideal_length(); | |
2813 if (head->limit() == length && | |
2814 head->init_trip() == _igvn.intcon(0)) { | |
2815 if (TraceOptimizeFill) { | |
2816 tty->print_cr("Eliminated zeroing in allocation"); | |
2817 } | |
2818 alloc->maybe_set_complete(&_igvn); | |
2819 } else { | |
2820 #ifdef ASSERT | |
2821 if (TraceOptimizeFill) { | |
2822 tty->print_cr("filling array but bounds don't match"); | |
2823 alloc->dump(); | |
2824 head->init_trip()->dump(); | |
2825 head->limit()->dump(); | |
2826 length->dump(); | |
2827 } | |
2828 #endif | |
2829 } | |
2830 } | |
6906 | 2831 */ |
1763 | 2832 |
2833 // Redirect the old control and memory edges that are outside the loop. | |
2834 Node* exit = head->loopexit()->proj_out(0); | |
1813
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2835 // Sometimes the memory phi of the head is used as the outgoing |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2836 // state of the loop. It's safe in this case to replace it with the |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2837 // result_mem. |
c77e8f982901
6984979: OptimizeFill misses some cases with an odd memory graph
never
parents:
1785
diff
changeset
|
2838 _igvn.replace_node(store->in(MemNode::Memory), result_mem); |
23817 | 2839 lazy_replace(exit, result_ctrl); |
1763 | 2840 _igvn.replace_node(store, result_mem); |
2841 // Any uses the increment outside of the loop become the loop limit. | |
2842 _igvn.replace_node(head->incr(), head->limit()); | |
2843 | |
2844 // Disconnect the head from the loop. | |
2845 for (uint i = 0; i < lpt->_body.size(); i++) { | |
2846 Node* n = lpt->_body.at(i); | |
2847 _igvn.replace_node(n, C->top()); | |
2848 } | |
2849 | |
2850 return true; | |
2851 } |