graal-jvmci-8: src/share/vm/gc_implementation/g1/g1RemSet.cpp comparison

comparison src/share/vm/gc_implementation/g1/g1RemSet.cpp @ 616:4f360ec815ba

6720309: G1: don't synchronously update RSet during evacuation pauses 6720334: G1: don't update RSets of collection set regions during an evacuation pause Summary: Introduced a deferred update mechanism for delaying the rset updates during the collection pause Reviewed-by: apetrusenko, tonyp

author	iveresov
date	Fri, 06 Mar 2009 13:50:14 -0800
parents	58054a18d735
children	87fa6e083d82

comparison

equal deleted inserted replaced

-:c6c601a0f2d6
+:4f360ec815ba
 _cg1r(g1->concurrent_g1_refine()),
 _par_traversal_in_progress(false), _new_refs(NULL),
 _cards_scanned(NULL), _total_cards_scanned(0)
 {
 _seq_task = new SubTasksDone(NumSeqTasks);
-_new_refs = NEW_C_HEAP_ARRAY(GrowableArray<oop*>*, ParallelGCThreads);
+guarantee(n_workers() > 0, "There should be some workers");
+_new_refs = NEW_C_HEAP_ARRAY(GrowableArray<oop*>*, n_workers());
+for (uint i = 0; i < n_workers(); i++) {
+_new_refs[i] = new (ResourceObj::C_HEAP) GrowableArray<oop*>(8192,true);
+}
 }
 HRInto_G1RemSet::~HRInto_G1RemSet() {
 delete _seq_task;
+for (uint i = 0; i < n_workers(); i++) {
+delete _new_refs[i];
+}
+FREE_C_HEAP_ARRAY(GrowableArray<oop*>*, _new_refs);
 }
 void CountNonCleanMemRegionClosure::do_MemRegion(MemRegion mr) {
 if (_g1->is_in_g1_reserved(mr.start())) {
 _n += (int) ((mr.byte_size() / CardTableModRefBS::card_size));
 if (!card_region->in_collection_set()) {
 // If the card is dirty, then we will scan it during updateRS.
 if (!_ct_bs->is_card_claimed(card_index) &&
 !_ct_bs->is_card_dirty(card_index)) {
 assert(_ct_bs->is_card_clean(card_index) ||
-_ct_bs->is_card_claimed(card_index),
+_ct_bs->is_card_claimed(card_index) ||
-"Card is either dirty, clean, or claimed");
+_ct_bs->is_card_deferred(card_index),
+"Card is either clean, claimed or deferred");
 if (_ct_bs->claim_card(card_index))
 scanCard(card_index, card_region);
 }
 }
 }
 assert( _cards_scanned != NULL, "invariant" );
 _cards_scanned[worker_i] = scanRScl.cards_done();
 _g1p->record_scan_rs_start_time(worker_i, rs_time_start * 1000.0);
 _g1p->record_scan_rs_time(worker_i, scan_rs_time_sec * 1000.0);
-if (ParallelGCThreads > 0) {
-// In this case, we called scanNewRefsRS and recorded the corresponding
+double scan_new_refs_time_ms = _g1p->get_scan_new_refs_time(worker_i);
-// time.
+if (scan_new_refs_time_ms > 0.0) {
-double scan_new_refs_time_ms = _g1p->get_scan_new_refs_time(worker_i);
+closure_app_time_ms += scan_new_refs_time_ms;
-if (scan_new_refs_time_ms > 0.0) {
+}
-closure_app_time_ms += scan_new_refs_time_ms;
-}
-}
 _g1p->record_obj_copy_time(worker_i, closure_app_time_ms);
 }
 void HRInto_G1RemSet::updateRS(int worker_i) {
 ConcurrentG1Refine* cg1r = _g1->concurrent_g1_refine();
 HRInto_G1RemSet::scanNewRefsRS(OopsInHeapRegionClosure* oc,
 int worker_i) {
 double scan_new_refs_start_sec = os::elapsedTime();
 G1CollectedHeap* g1h = G1CollectedHeap::heap();
 CardTableModRefBS* ct_bs = (CardTableModRefBS*) (g1h->barrier_set());
-while (_new_refs[worker_i]->is_nonempty()) {
+for (int i = 0; i < _new_refs[worker_i]->length(); i++) {
-oop* p = _new_refs[worker_i]->pop();
+oop* p = _new_refs[worker_i]->at(i);
 oop obj = *p;
 // *p was in the collection set when p was pushed on "_new_refs", but
 // another thread may have processed this location from an RS, so it
 // might not point into the CS any longer.  If so, it's obviously been
 // processed, and we don't need to do anything further.
 if (g1h->obj_in_cs(obj)) {
 HeapRegion* r = g1h->heap_region_containing(p);
 DEBUG_ONLY(HeapRegion* to = g1h->heap_region_containing(obj));
-assert(ParallelGCThreads > 1
-|| to->rem_set()->contains_reference(p),
-"Invariant: pushed after being added."
-"(Not reliable in parallel code.)");
 oc->set_region(r);
 // If "p" has already been processed concurrently, this is
 // idempotent.
 oc->do_oop(p);
 }
 scanNewRefsRS(oc, worker_i);
 scanRS(oc, worker_i);
 }
 } else {
 assert(worker_i == 0, "invariant");
 updateRS(0);
+scanNewRefsRS(oc, 0);
 scanRS(oc, 0);
 }
 }
 void HRInto_G1RemSet::
 dcqs.concatenate_logs();
 assert(!_par_traversal_in_progress, "Invariant between iterations.");
 if (ParallelGCThreads > 0) {
 set_par_traversal(true);
-int n_workers = _g1->workers()->total_workers();
+_seq_task->set_par_threads((int)n_workers());
-_seq_task->set_par_threads(n_workers);
-for (uint i = 0; i < ParallelGCThreads; i++)
-_new_refs[i] = new (ResourceObj::C_HEAP) GrowableArray<oop*>(8192,true);
 if (cg1r->do_traversal()) {
 updateRS(0);
 // Have to do this again after updaters
 cleanupHRRS();
 }
 HeapRegionRemSet* hrrs = r->rem_set();
 hrrs->init_for_par_iteration();
 return false;
 }
 };
+class UpdateRSetOopsIntoCSImmediate : public OopClosure {
+G1CollectedHeap* _g1;
+public:
+UpdateRSetOopsIntoCSImmediate(G1CollectedHeap* g1) : _g1(g1) { }
+virtual void do_oop(narrowOop* p) {
+guarantee(false, "NYI");
+}
+virtual void do_oop(oop* p) {
+HeapRegion* to = _g1->heap_region_containing(*p);
+if (to->in_collection_set()) {
+if (to->rem_set()->add_reference(p, 0)) {
+_g1->schedule_popular_region_evac(to);
+}
+}
+}
+};
+class UpdateRSetOopsIntoCSDeferred : public OopClosure {
+G1CollectedHeap* _g1;
+CardTableModRefBS* _ct_bs;
+DirtyCardQueue* _dcq;
+public:
+UpdateRSetOopsIntoCSDeferred(G1CollectedHeap* g1, DirtyCardQueue* dcq) :
+_g1(g1), _ct_bs((CardTableModRefBS*)_g1->barrier_set()), _dcq(dcq) { }
+virtual void do_oop(narrowOop* p) {
+guarantee(false, "NYI");
+}
+virtual void do_oop(oop* p) {
+oop obj = *p;
+if (_g1->obj_in_cs(obj)) {
+size_t card_index = _ct_bs->index_for(p);
+if (_ct_bs->mark_card_deferred(card_index)) {
+_dcq->enqueue((jbyte*)_ct_bs->byte_for_index(card_index));
+}
+}
+}
+};
+void HRInto_G1RemSet::new_refs_iterate(OopClosure* cl) {
+for (size_t i = 0; i < n_workers(); i++) {
+for (int j = 0; j < _new_refs[i]->length(); j++) {
+oop* p = _new_refs[i]->at(j);
+cl->do_oop(p);
+}
+}
+}
 void HRInto_G1RemSet::cleanup_after_oops_into_collection_set_do() {
 guarantee( _cards_scanned != NULL, "invariant" );
 _total_cards_scanned = 0;
 for (uint i = 0; i < n_workers(); ++i)
 if (ParallelGCThreads > 0) {
 ConcurrentG1Refine* cg1r = _g1->concurrent_g1_refine();
 if (cg1r->do_traversal()) {
 cg1r->cg1rThread()->set_do_traversal(false);
 }
-for (uint i = 0; i < ParallelGCThreads; i++) {
-delete _new_refs[i];
-}
 set_par_traversal(false);
 }
+if (_g1->evacuation_failed()) {
+// Restore remembered sets for the regions pointing into
+// the collection set.
+if (G1DeferredRSUpdate) {
+DirtyCardQueue dcq(&_g1->dirty_card_queue_set());
+UpdateRSetOopsIntoCSDeferred deferred_update(_g1, &dcq);
+new_refs_iterate(&deferred_update);
+} else {
+UpdateRSetOopsIntoCSImmediate immediate_update(_g1);
+new_refs_iterate(&immediate_update);
+}
+}
+for (uint i = 0; i < n_workers(); i++) {
+_new_refs[i]->clear();
+}
 assert(!_par_traversal_in_progress, "Invariant between iterations.");
 }
 class UpdateRSObjectClosure: public ObjectClosure {
 UpdateRSOopClosure* _update_rs_oop_cl;
 {}
 bool doHeapRegion(HeapRegion* r) {
 if (!r->in_collection_set() &&
 !r->continuesHumongous() &&
-!r->is_young()) {
+!r->is_young() &&
+!r->is_survivor()) {
 _update_rs_oop_cl.set_from(r);
 UpdateRSObjectClosure update_rs_obj_cl(&_update_rs_oop_cl);
 // For each run of dirty card in the region:
 //   1) Clear the cards.
 // as a result, it is possible for other threads to actually
 // allocate objects in the region (after the acquire the lock)
 // before all the cards on the region are dirtied. This is unlikely,
 // and it doesn't happen often, but it can happen. So, the extra
 // check below filters out those cards.
-if (r->is_young()) {
+if (r->is_young() || r->is_survivor()) {
 return;
 }
 // While we are processing RSet buffers during the collection, we
 // actually don't want to scan any cards on the collection set,
 // since we don't want to update remebered sets with entries that

Mercurial > hg > graal-jvmci-8

comparison src/share/vm/gc_implementation/g1/g1RemSet.cpp @ 616:4f360ec815ba