graal-jvmci-8: src/share/vm/compiler/compileBroker.cpp comparison

8042428: CompileQueue::free_all() code is incorrect Summary: Free task after getting next pointer of freelist. Reviewed-by: kvn, adlertz

comparison

equal deleted inserted replaced

-:0c0e68524c17
+:c47fcf523fff
 // Notify CompilerThreads that a task is available.
 lock()->notify_all();
 }
+/**
+* Empties compilation queue by putting all compilation tasks onto
+* a freelist. Furthermore, the method wakes up all threads that are
+* waiting on a compilation task to finish. This can happen if background
+* compilation is disabled.
+*/
 void CompileQueue::free_all() {
 MutexLocker mu(lock());
-if (_first != NULL) {
+CompileTask* next = _first;
-for (CompileTask* task = _first; task != NULL; task = task->next()) {
-// Wake up thread that blocks on the compile task.
+// Iterate over all tasks in the compile queue
-task->lock()->notify();
+while (next != NULL) {
-// Puts task back on the freelist.
+CompileTask* current = next;
-CompileTask::free(task);
+next = current->next();
-}
+// Wake up thread that blocks on the compile task.
-_first = NULL;
+current->lock()->notify();
-}
+// Put the task back on the freelist.
+CompileTask::free(current);
+}
+_first = NULL;
 // Wake up all threads that block on the queue.
 lock()->notify_all();
 }
 // ------------------------------------------------------------------

Mercurial > hg > graal-jvmci-8