Mercurial > hg > graal-jvmci-8

comparison src/cpu/x86/vm/templateTable_x86_32.cpp @ 3249:e1162778c1c8

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
7009266: G1: assert(obj->is_oop_or_null(true )) failed: Error Summary: A referent object that is only weakly reachable at the start of concurrent marking but is re-attached to the strongly reachable object graph during marking may not be marked as live. This can cause the reference object to be processed prematurely and leave dangling pointers to the referent object. Implement a read barrier for the java.lang.ref.Reference::referent field by intrinsifying the Reference.get() method, and intercepting accesses though JNI, reflection, and Unsafe, so that when a non-null referent object is read it is also logged in an SATB buffer. Reviewed-by: kvn, iveresov, never, tonyp, dholmes
author johnc
date Thu, 07 Apr 2011 09:53:20 -0700
parents 8033953d67ff
children 92add02409c9
comparison
equal deleted inserted replaced
3248:e6beb62de02d 3249:e1162778c1c8
137 } else { 137 } else {
138 __ leal(rdx, obj); 138 __ leal(rdx, obj);
139 } 139 }
140 __ get_thread(rcx); 140 __ get_thread(rcx);
141 __ save_bcp(); 141 __ save_bcp();
142 __ g1_write_barrier_pre(rdx, rcx, rsi, rbx, val != noreg); 142 __ g1_write_barrier_pre(rdx /* obj */,
143 rbx /* pre_val */,
144 rcx /* thread */,
145 rsi /* tmp */,
146 val != noreg /* tosca_live */,
147 false /* expand_call */);
143 148
144 // Do the actual store 149 // Do the actual store
145 // noreg means NULL 150 // noreg means NULL
146 if (val == noreg) { 151 if (val == noreg) {
147 __ movptr(Address(rdx, 0), NULL_WORD); 152 __ movptr(Address(rdx, 0), NULL_WORD);
148 // No post barrier for NULL 153 // No post barrier for NULL
149 } else { 154 } else {
150 __ movl(Address(rdx, 0), val); 155 __ movl(Address(rdx, 0), val);
151 __ g1_write_barrier_post(rdx, rax, rcx, rbx, rsi); 156 __ g1_write_barrier_post(rdx /* store_adr */,
157 val /* new_val */,
158 rcx /* thread */,
159 rbx /* tmp */,
160 rsi /* tmp2 */);
152 } 161 }
153 __ restore_bcp(); 162 __ restore_bcp();
154 163
155 } 164 }
156 break; 165 break;