Mercurial > hg > graal-jvmci-8
comparison src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp @ 20543:e7d0505c8a30
8059758: Footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zero out) virtual memory used for auxiliary data structures. This causes a footprint regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: jwilhelm, brutisso
| author | tschatzl |
|---|---|
| date | Fri, 10 Oct 2014 15:51:58 +0200 |
| parents | d3fd73295885 |
| children | 1d6eb209432a c2844108a708 |
comparison
equal
deleted
inserted
replaced
| 20542:0fcaab91d485 | 20543:e7d0505c8a30 |
|---|---|
| 383 | 383 |
| 384 void G1RegionMappingChangedListener::reset_from_card_cache(uint start_idx, size_t num_regions) { | 384 void G1RegionMappingChangedListener::reset_from_card_cache(uint start_idx, size_t num_regions) { |
| 385 OtherRegionsTable::invalidate(start_idx, num_regions); | 385 OtherRegionsTable::invalidate(start_idx, num_regions); |
| 386 } | 386 } |
| 387 | 387 |
| 388 void G1RegionMappingChangedListener::on_commit(uint start_idx, size_t num_regions) { | 388 void G1RegionMappingChangedListener::on_commit(uint start_idx, size_t num_regions, bool zero_filled) { |
| 389 // The from card cache is not the memory that is actually committed. So we cannot | |
| 390 // take advantage of the zero_filled parameter. | |
| 389 reset_from_card_cache(start_idx, num_regions); | 391 reset_from_card_cache(start_idx, num_regions); |
| 390 } | 392 } |
| 391 | 393 |
| 392 void G1CollectedHeap::push_dirty_cards_region(HeapRegion* hr) | 394 void G1CollectedHeap::push_dirty_cards_region(HeapRegion* hr) |
| 393 { | 395 { |