Mercurial > hg > graal-jvmci-8

comparison src/share/vm/gc_implementation/g1/g1RegionToSpaceMapper.cpp @ 20543:e7d0505c8a30

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8059758: Footprint regressions with JDK-8038423 Summary: Changes in JDK-8038423 always initialize (zero out) virtual memory used for auxiliary data structures. This causes a footprint regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything. Reviewed-by: jwilhelm, brutisso
author tschatzl
date Fri, 10 Oct 2014 15:51:58 +0200
parents 7b2fc3129653
children ae52ee069062
comparison
equal deleted inserted replaced
20542:0fcaab91d485 20543:e7d0505c8a30
67 } 67 }
68 68
69 virtual void commit_regions(uintptr_t start_idx, size_t num_regions) { 69 virtual void commit_regions(uintptr_t start_idx, size_t num_regions) {
70 _storage.commit(start_idx * _pages_per_region, num_regions * _pages_per_region); 70 _storage.commit(start_idx * _pages_per_region, num_regions * _pages_per_region);
71 _commit_map.set_range(start_idx, start_idx + num_regions); 71 _commit_map.set_range(start_idx, start_idx + num_regions);
72 fire_on_commit(start_idx, num_regions); 72 fire_on_commit(start_idx, num_regions, true);
73 } 73 }
74 74
75 virtual void uncommit_regions(uintptr_t start_idx, size_t num_regions) { 75 virtual void uncommit_regions(uintptr_t start_idx, size_t num_regions) {
76 _storage.uncommit(start_idx * _pages_per_region, num_regions * _pages_per_region); 76 _storage.uncommit(start_idx * _pages_per_region, num_regions * _pages_per_region);
77 _commit_map.clear_range(start_idx, start_idx + num_regions); 77 _commit_map.clear_range(start_idx, start_idx + num_regions);
113 virtual void commit_regions(uintptr_t start_idx, size_t num_regions) { 113 virtual void commit_regions(uintptr_t start_idx, size_t num_regions) {
114 for (uintptr_t i = start_idx; i < start_idx + num_regions; i++) { 114 for (uintptr_t i = start_idx; i < start_idx + num_regions; i++) {
115 assert(!_commit_map.at(i), err_msg("Trying to commit storage at region "INTPTR_FORMAT" that is already committed", i)); 115 assert(!_commit_map.at(i), err_msg("Trying to commit storage at region "INTPTR_FORMAT" that is already committed", i));
116 uintptr_t idx = region_idx_to_page_idx(i); 116 uintptr_t idx = region_idx_to_page_idx(i);
117 uint old_refcount = _refcounts.get_by_index(idx); 117 uint old_refcount = _refcounts.get_by_index(idx);
118 bool zero_filled = false;
118 if (old_refcount == 0) { 119 if (old_refcount == 0) {
119 _storage.commit(idx, 1); 120 _storage.commit(idx, 1);
121 zero_filled = true;
120 } 122 }
121 _refcounts.set_by_index(idx, old_refcount + 1); 123 _refcounts.set_by_index(idx, old_refcount + 1);
122 _commit_map.set_bit(i); 124 _commit_map.set_bit(i);
123 fire_on_commit(i, 1); 125 fire_on_commit(i, 1, zero_filled);
124 } 126 }
125 } 127 }
126 128
127 virtual void uncommit_regions(uintptr_t start_idx, size_t num_regions) { 129 virtual void uncommit_regions(uintptr_t start_idx, size_t num_regions) {
128 for (uintptr_t i = start_idx; i < start_idx + num_regions; i++) { 130 for (uintptr_t i = start_idx; i < start_idx + num_regions; i++) {
137 _commit_map.clear_bit(i); 139 _commit_map.clear_bit(i);
138 } 140 }
139 } 141 }
140 }; 142 };
141 143
142 void G1RegionToSpaceMapper::fire_on_commit(uint start_idx, size_t num_regions) { 144 void G1RegionToSpaceMapper::fire_on_commit(uint start_idx, size_t num_regions, bool zero_filled) {
143 if (_listener != NULL) { 145 if (_listener != NULL) {
144 _listener->on_commit(start_idx, num_regions); 146 _listener->on_commit(start_idx, num_regions, zero_filled);
145 } 147 }
146 } 148 }
147 149
148 G1RegionToSpaceMapper* G1RegionToSpaceMapper::create_mapper(ReservedSpace rs, 150 G1RegionToSpaceMapper* G1RegionToSpaceMapper::create_mapper(ReservedSpace rs,
149 size_t os_commit_granularity, 151 size_t os_commit_granularity,