Mercurial > hg > graal-jvmci-8

diff src/share/vm/services/management.cpp @ 20248:009de2b033fc
8029070: memory leak in jmm_SetVMGlobal Reviewed-by: kvn, dholmes
author: iignatyev
date: Mon, 23 Dec 2013 20:56:18 +0400
parents: ce8f6bb717c9
children: 966601b12d4f
--- a/src/share/vm/services/management.cpp	Thu Jan 16 13:25:25 2014 -0800
+++ b/src/share/vm/services/management.cpp	Mon Dec 23 20:56:18 2013 +0400
@@ -1824,7 +1824,7 @@
               "This flag is not writeable.");
   }
 
-  bool succeed;
+  bool succeed = false;
   if (flag->is_bool()) {
     bool bvalue = (new_value.z == JNI_TRUE ? true : false);
     succeed = CommandLineFlags::boolAtPut(name, &bvalue, Flag::MANAGEMENT);
@@ -1856,6 +1856,9 @@
     }
     ccstr svalue = java_lang_String::as_utf8_string(str);
     succeed = CommandLineFlags::ccstrAtPut(name, &svalue, Flag::MANAGEMENT);
+    if (succeed) {
+      FREE_C_HEAP_ARRAY(char, svalue, mtInternal);
+    }
   }
   assert(succeed, "Setting flag should succeed");
 JVM_END