Mercurial > hg > graal-jvmci-8
diff src/share/vm/gc_implementation/g1/collectionSetChooser.hpp @ 8681:27714220e50e
8007036: G1: Too many old regions added to last mixed GC
Summary: Stop adding old regions to collection set when the remaining reclaimable bytes reaches, or goes below, G1HeapWastePercent. Changes were also reviewed by Vitaly Davidovich <vitalyd@gmail.com>.
Reviewed-by: brutisso
| author | johnc |
|---|---|
| date | Mon, 04 Mar 2013 12:42:14 -0800 |
| parents | a2f7274eb6ef |
| children | de6a9e811145 |
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/g1/collectionSetChooser.hpp Mon Mar 04 13:01:24 2013 +0100 +++ b/src/share/vm/gc_implementation/g1/collectionSetChooser.hpp Mon Mar 04 12:42:14 2013 -0800 @@ -51,6 +51,8 @@ uint _curr_index; // The number of candidate old regions added to the CSet chooser. + // Note: this is not updated when removing a region using + // remove_and_move_to_next() below. uint _length; // Keeps track of the start of the next array chunk to be claimed by @@ -111,13 +113,8 @@ hr->live_bytes() < _region_live_threshold_bytes; } - // Calculate the minimum number of old regions we'll add to the CSet - // during a mixed GC. - uint calc_min_old_cset_length(); - - // Calculate the maximum number of old regions we'll add to the CSet - // during a mixed GC. - uint calc_max_old_cset_length(); + // Returns the number candidate old regions added + uint length() { return _length; } // Serial version. void add_region(HeapRegion *hr);