Mercurial > hg > graal-jvmci-8
diff jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java @ 23700:9e1235406b59
[Findbugs] various warnings reported for JVMCI sources (JDK-8159613)
author | Doug Simon <doug.simon@oracle.com> |
---|---|
date | Sat, 18 Jun 2016 13:19:01 +0200 |
parents | d814713e3b02 |
children | 6542cd8da2da |
line wrap: on
line diff
--- a/jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java Fri Jun 17 19:13:02 2016 +0200 +++ b/jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java Sat Jun 18 13:19:01 2016 +0200 @@ -300,7 +300,8 @@ */ private long getEntryAt(int index) { assertBounds(index); - return UNSAFE.getAddress(getMetaspaceConstantPool() + config().constantPoolSize + index * runtime().getHostJVMCIBackend().getTarget().wordSize); + int offset = index * runtime().getHostJVMCIBackend().getTarget().wordSize; + return UNSAFE.getAddress(getMetaspaceConstantPool() + config().constantPoolSize + offset); } /** @@ -311,7 +312,8 @@ */ private int getIntAt(int index) { assertTag(index, JVM_CONSTANT.Integer); - return UNSAFE.getInt(getMetaspaceConstantPool() + config().constantPoolSize + index * runtime().getHostJVMCIBackend().getTarget().wordSize); + int offset = index * runtime().getHostJVMCIBackend().getTarget().wordSize; + return UNSAFE.getInt(getMetaspaceConstantPool() + config().constantPoolSize + offset); } /** @@ -322,7 +324,8 @@ */ private long getLongAt(int index) { assertTag(index, JVM_CONSTANT.Long); - return UNSAFE.getLong(getMetaspaceConstantPool() + config().constantPoolSize + index * runtime().getHostJVMCIBackend().getTarget().wordSize); + int offset = index * runtime().getHostJVMCIBackend().getTarget().wordSize; + return UNSAFE.getLong(getMetaspaceConstantPool() + config().constantPoolSize + offset); } /** @@ -333,7 +336,8 @@ */ private float getFloatAt(int index) { assertTag(index, JVM_CONSTANT.Float); - return UNSAFE.getFloat(getMetaspaceConstantPool() + config().constantPoolSize + index * runtime().getHostJVMCIBackend().getTarget().wordSize); + int offset = index * runtime().getHostJVMCIBackend().getTarget().wordSize; + return UNSAFE.getFloat(getMetaspaceConstantPool() + config().constantPoolSize + offset); } /** @@ -344,7 +348,8 @@ */ private double getDoubleAt(int index) { assertTag(index, JVM_CONSTANT.Double); - return UNSAFE.getDouble(getMetaspaceConstantPool() + config().constantPoolSize + index * runtime().getHostJVMCIBackend().getTarget().wordSize); + int offset = index * runtime().getHostJVMCIBackend().getTarget().wordSize; + return UNSAFE.getDouble(getMetaspaceConstantPool() + config().constantPoolSize + offset); } /** @@ -355,7 +360,8 @@ */ private int getNameAndTypeAt(int index) { assertTag(index, JVM_CONSTANT.NameAndType); - return UNSAFE.getInt(getMetaspaceConstantPool() + config().constantPoolSize + index * runtime().getHostJVMCIBackend().getTarget().wordSize); + int offset = index * runtime().getHostJVMCIBackend().getTarget().wordSize; + return UNSAFE.getInt(getMetaspaceConstantPool() + config().constantPoolSize + offset); } /** @@ -436,7 +442,8 @@ */ private int getUncachedKlassRefIndexAt(int index) { assertTagIsFieldOrMethod(index); - final int refIndex = UNSAFE.getInt(getMetaspaceConstantPool() + config().constantPoolSize + index * runtime().getHostJVMCIBackend().getTarget().wordSize); + int offset = index * runtime().getHostJVMCIBackend().getTarget().wordSize; + final int refIndex = UNSAFE.getInt(getMetaspaceConstantPool() + config().constantPoolSize + offset); // klass ref index is in the low 16-bits. return refIndex & 0xFFFF; } @@ -682,15 +689,15 @@ if (!klass.isPrimitive() && !klass.isArray()) { UNSAFE.ensureClassInitialized(klass); } - switch (tag) { - case MethodRef: - if (Bytecodes.isInvokeHandleAlias(opcode)) { - final int methodRefCacheIndex = rawIndexToConstantPoolIndex(cpi, opcode); - if (isInvokeHandle(methodRefCacheIndex, type)) { - compilerToVM().resolveInvokeHandleInPool(this, methodRefCacheIndex); - } + if (tag == JVM_CONSTANT.MethodRef) { + if (Bytecodes.isInvokeHandleAlias(opcode)) { + final int methodRefCacheIndex = rawIndexToConstantPoolIndex(cpi, opcode); + if (isInvokeHandle(methodRefCacheIndex, type)) { + compilerToVM().resolveInvokeHandleInPool(this, methodRefCacheIndex); } + } } + break; case InvokeDynamic: if (isInvokedynamicIndex(cpi)) {