Mercurial > hg > graal-jvmci-8
diff jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java @ 23700:9e1235406b59
[Findbugs] various warnings reported for JVMCI sources (JDK-8159613)
| author | Doug Simon <doug.simon@oracle.com> |
|---|---|
| date | Sat, 18 Jun 2016 13:19:01 +0200 |
| parents | b5557b757040 |
| children | 9ac04c6047c8 |
line wrap: on
line diff
--- a/jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java Fri Jun 17 19:13:02 2016 +0200 +++ b/jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java Sat Jun 18 13:19:01 2016 +0200 @@ -592,7 +592,8 @@ // Get Klass::_fields final long metaspaceFields = UNSAFE.getAddress(getMetaspaceKlass() + config.instanceKlassFieldsOffset); assert config.fieldInfoFieldSlots == 6 : "revisit the field parsing code"; - metaspaceData = metaspaceFields + config.arrayU2DataOffset + config.fieldInfoFieldSlots * Short.BYTES * index; + int offset = config.fieldInfoFieldSlots * Short.BYTES * index; + metaspaceData = metaspaceFields + config.arrayU2DataOffset + offset; } private int getAccessFlags() { @@ -620,7 +621,8 @@ * on top an array of Java shorts. */ private int readFieldSlot(int index) { - return UNSAFE.getChar(metaspaceData + Short.BYTES * index); + int offset = Short.BYTES * index; + return UNSAFE.getChar(metaspaceData + offset); } /** @@ -659,6 +661,7 @@ } } + @SuppressFBWarnings(value = "SE_COMPARATOR_SHOULD_BE_SERIALIZABLE", justification = "comparator is only used transiently") private static class OffsetComparator implements java.util.Comparator<HotSpotResolvedJavaField> { @Override public int compare(HotSpotResolvedJavaField o1, HotSpotResolvedJavaField o2) {