Mercurial > hg > graal-jvmci-8
diff jvmci/jdk.vm.ci.meta/src/jdk/vm/ci/meta/AbstractProfiledItem.java @ 23700:9e1235406b59
[Findbugs] various warnings reported for JVMCI sources (JDK-8159613)
author | Doug Simon <doug.simon@oracle.com> |
---|---|
date | Sat, 18 Jun 2016 13:19:01 +0200 |
parents | 1bbd4a7c274b |
children |
line wrap: on
line diff
--- a/jvmci/jdk.vm.ci.meta/src/jdk/vm/ci/meta/AbstractProfiledItem.java Fri Jun 17 19:13:02 2016 +0200 +++ b/jvmci/jdk.vm.ci.meta/src/jdk/vm/ci/meta/AbstractProfiledItem.java Sat Jun 18 13:19:01 2016 +0200 @@ -51,14 +51,14 @@ return probability; } + /** + * Returns -1 if the {@linkplain #getProbability() probability} of this item is greater than + * {@code o}'s probability, 0 if there are equal otherwise 1. + */ @Override public int compareTo(AbstractProfiledItem<?> o) { - if (getProbability() > o.getProbability()) { - return -1; - } else if (getProbability() < o.getProbability()) { - return 1; - } - return 0; + // Need to swap the order of operands so that higher probabilities are sorted first + return Double.compare(o.getProbability(), getProbability()); } @Override