Mercurial > hg > graal-jvmci-8

diff src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp @ 23026:b7c8142a9e0b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8069367: Eagerly reclaimed humongous objects left on mark stack Summary: Prevent eager reclaim of objects that might be on mark stack. Reviewed-by: brutisso, tschatzl
author kbarrett
date Wed, 15 Apr 2015 12:16:01 -0400
parents 24c446b2460d
children 399885e13e90
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp	Wed Apr 08 10:32:16 2015 -0400
+++ b/src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp	Wed Apr 15 12:16:01 2015 -0400
@@ -332,14 +332,28 @@
           // be pushed on the stack. So, some duplicate work, but no
           // correctness problems.
           if (is_below_finger(objAddr, global_finger)) {
-            if (_cm->verbose_high()) {
-              gclog_or_tty->print_cr("[%u] below a finger (local: " PTR_FORMAT
-                                     ", global: " PTR_FORMAT ") pushing "
-                                     PTR_FORMAT " on mark stack",
-                                     _worker_id, p2i(_finger),
-                                     p2i(global_finger), p2i(objAddr));
+            if (obj->is_typeArray()) {
+              // Immediately process arrays of primitive types, rather
+              // than pushing on the mark stack.  This keeps us from
+              // adding humongous objects to the mark stack that might
+              // be reclaimed before the entry is processed - see
+              // selection of candidates for eager reclaim of humongous
+              // objects.  The cost of the additional type test is
+              // mitigated by avoiding a trip through the mark stack,
+              // by only doing a bookkeeping update and avoiding the
+              // actual scan of the object - a typeArray contains no
+              // references, and the metadata is built-in.
+              process_grey_object<false>(obj);
+            } else {
+              if (_cm->verbose_high()) {
+                gclog_or_tty->print_cr("[%u] below a finger (local: " PTR_FORMAT
+                                       ", global: " PTR_FORMAT ") pushing "
+                                       PTR_FORMAT " on mark stack",
+                                       _worker_id, p2i(_finger),
+                                       p2i(global_finger), p2i(objAddr));
+              }
+              push(obj);
             }
-            push(obj);
           }
         }
       }