Mercurial > hg > graal-jvmci-8
view make/linux/platform_i486.suncc @ 12301:2c022e432e10
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
author | stefank |
---|---|
date | Fri, 20 Sep 2013 10:53:28 +0200 |
parents | a294fd0c4b38 |
children |
line wrap: on
line source
os_family = linux arch = x86 arch_model = x86_32 os_arch = linux_x86 os_arch_model = linux_x86_32 lib_arch = i386 compiler = sparcWorks gnu_dis_arch = i386 sysdefs = -DLINUX -DSPARC_WORKS -D_GNU_SOURCE -DIA32