Mercurial > hg > graal-jvmci-8

view src/share/vm/classfile/defaultMethods.hpp @ 12301:2c022e432e10

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8024974: Incorrect use of GC_locker::is_active() Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint. Reviewed-by: brutisso, dcubed Contributed-by: per.liden@oracle.com
author stefank
date Fri, 20 Sep 2013 10:53:28 +0200
parents 4735d2c84362
children 36b97be47bde
line wrap: on
line source

/*
 * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
 *
 */

#ifndef SHARE_VM_CLASSFILE_DEFAULTMETHODS_HPP
#define SHARE_VM_CLASSFILE_DEFAULTMETHODS_HPP

#include "runtime/handles.hpp"
#include "utilities/growableArray.hpp"
#include "utilities/exceptions.hpp"

class InstanceKlass;
class Symbol;
class Method;

class DefaultMethods : AllStatic {
 public:

  // Analyzes class and determines which default methods are inherited
  // from interfaces (and has no other implementation).  For each method
  // (and each different signature the method could have), create an
  // "overpass" method that is an instance method that redirects to the
  // default method.  Overpass methods are added to the methods lists for
  // the class.
  static void generate_default_methods(
      InstanceKlass* klass, GrowableArray<Method*>* mirandas, TRAPS);


  // Called during linking when an invokespecial to an direct interface
  // method is found.  Selects and returns a method if there is a unique
  // default method in the 'super_iface' part of the hierarchy which is
  // also a candidate default for 'this_klass'.  Otherwise throws an AME.
  static Method* find_super_default(
      Klass* this_klass, Klass* super_iface,
      Symbol* method_name, Symbol* method_sig, TRAPS);
};

#endif // SHARE_VM_CLASSFILE_DEFAULTMETHODS_HPP