Mercurial > hg > graal-jvmci-8
view src/share/vm/gc_implementation/g1/vm_operations_g1.hpp @ 1358:72f725c5a7be
6940310: G1: MT-unsafe calls to CM::region_stack_push() / CM::region_stack_pop()
Summary: Calling the methods region_stack_push() and region_stack_pop() concurrent is not MT-safe. The assumption is that we will only call region_stack_push() during a GC pause and region_stack_pop() during marking. Unfortunately, we also call region_stack_push() during marking which seems to be introducing subtle marking failures. This change introduces lock-based methods for pushing / popping to be called during marking.
Reviewed-by: iveresov, johnc
author | tonyp |
---|---|
date | Mon, 05 Apr 2010 12:19:22 -0400 |
parents | 3fc996d4edd2 |
children | c18cbe5936b8 |
line wrap: on
line source
/* * Copyright 2001-2009 Sun Microsystems, Inc. All Rights Reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, * CA 95054 USA or visit www.sun.com if you need additional information or * have any questions. * */ // VM_operations for the G1 collector. // VM_GC_Operation: // - VM_CGC_Operation // - VM_G1CollectFull // - VM_G1CollectForAllocation // - VM_G1IncCollectionPause // - VM_G1PopRegionCollectionPause class VM_G1CollectFull: public VM_GC_Operation { private: public: VM_G1CollectFull(int gc_count_before, GCCause::Cause gc_cause) : VM_GC_Operation(gc_count_before) { _gc_cause = gc_cause; } ~VM_G1CollectFull() {} virtual VMOp_Type type() const { return VMOp_G1CollectFull; } virtual void doit(); virtual const char* name() const { return "full garbage-first collection"; } }; class VM_G1CollectForAllocation: public VM_GC_Operation { private: HeapWord* _res; size_t _size; // size of object to be allocated public: VM_G1CollectForAllocation(size_t size, int gc_count_before) : VM_GC_Operation(gc_count_before) { _size = size; _res = NULL; } ~VM_G1CollectForAllocation() {} virtual VMOp_Type type() const { return VMOp_G1CollectForAllocation; } virtual void doit(); virtual const char* name() const { return "garbage-first collection to satisfy allocation"; } HeapWord* result() { return _res; } }; class VM_G1IncCollectionPause: public VM_GC_Operation { public: VM_G1IncCollectionPause(int gc_count_before, GCCause::Cause gc_cause = GCCause::_g1_inc_collection_pause) : VM_GC_Operation(gc_count_before) { _gc_cause = gc_cause; } virtual VMOp_Type type() const { return VMOp_G1IncCollectionPause; } virtual void doit(); virtual const char* name() const { return "garbage-first incremental collection pause"; } }; // Concurrent GC stop-the-world operations such as initial and final mark; // consider sharing these with CMS's counterparts. class VM_CGC_Operation: public VM_Operation { VoidClosure* _cl; const char* _printGCMessage; public: VM_CGC_Operation(VoidClosure* cl, const char *printGCMsg) : _cl(cl), _printGCMessage(printGCMsg) {} ~VM_CGC_Operation() {} virtual VMOp_Type type() const { return VMOp_CGC_Operation; } virtual void doit(); virtual bool doit_prologue(); virtual void doit_epilogue(); virtual const char* name() const { return "concurrent gc"; } };