view graal/com.oracle.graal.compiler.test/src/com/oracle/graal/compiler/test/ConditionalEliminationTest.java @ 10750:9f5a4074e36b

test for nullness and disjunctive conditions in ConditionalEliminationPhase
author Lukas Stadler <lukas.stadler@jku.at>
date Mon, 15 Jul 2013 13:36:59 +0200
parents 1194e94f9c16
children 88d0dc388450
line wrap: on
line source

/*
 * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
 */
package com.oracle.graal.compiler.test;

import static org.junit.Assert.*;

import org.junit.*;

import com.oracle.graal.nodes.*;
import com.oracle.graal.nodes.calc.*;
import com.oracle.graal.nodes.java.*;
import com.oracle.graal.phases.common.*;

/**
 * Collection of tests for {@link ConditionalEliminationPhase} including those that triggered bugs
 * in this phase.
 */
public class ConditionalEliminationTest extends GraalCompilerTest {

    static class Entry {

        final String name;

        public Entry(String name) {
            this.name = name;
        }
    }

    static class EntryWithNext extends Entry {

        public EntryWithNext(String name, Entry next) {
            super(name);
            this.next = next;
        }

        final Entry next;
    }

    public static Entry search(Entry start, String name, Entry alternative) {
        Entry current = start;
        do {
            while (current instanceof EntryWithNext) {
                if (name != null && current.name == name) {
                    current = null;
                } else {
                    Entry next = ((EntryWithNext) current).next;
                    current = next;
                }
            }

            if (current != null) {
                if (current.name.equals(name)) {
                    return current;
                }
            }
            if (current == alternative) {
                return null;
            }
            current = alternative;

        } while (true);
    }

    /**
     * This test presents a code pattern that triggered a bug where a (non-eliminated) checkcast
     * caused an enclosing instanceof (for the same object and target type) to be incorrectly
     * eliminated.
     */
    @Test
    public void testReanchoringIssue() {
        Entry end = new Entry("end");
        EntryWithNext e1 = new EntryWithNext("e1", end);
        EntryWithNext e2 = new EntryWithNext("e2", e1);

        test("search", e2, "e3", new Entry("e4"));
    }

    @SuppressWarnings("unused")
    public static int testNullnessSnippet(Object a, Object b) {
        if (a == null) {
            if (a == b) {
                if (b == null) {
                    return 1;
                } else {
                    return -2;
                }
            } else {
                if (b == null) {
                    return 3;
                } else {
                    return 4;
                }
            }
        } else {
            if (a == b) {
                if (b == null) {
                    return -5;
                } else {
                    return 6;
                }
            } else {
                if (b == null) {
                    return 7;
                } else {
                    return 8;
                }
            }
        }
    }

    @Test
    public void testNullness() {
        test("testNullnessSnippet", null, null);
        test("testNullnessSnippet", null, new Object());
        test("testNullnessSnippet", new Object(), null);
        test("testNullnessSnippet", new Object(), new Object());

        StructuredGraph graph = parse("testNullnessSnippet");
        new ConditionalEliminationPhase(runtime()).apply(graph);
        new CanonicalizerPhase.Instance(runtime(), null, true).apply(graph);
        for (ConstantNode constant : graph.getNodes().filter(ConstantNode.class)) {
            assertTrue("unexpected constant: " + constant, constant.asConstant().isNull() || constant.asConstant().asInt() > 0);
        }
    }

    @SuppressWarnings("unused")
    public static int testDisjunctionSnippet(Object a) {
        if (a instanceof Integer) {
            if (a == null) {
                return -1;
            } else {
                return 2;
            }
        } else {
            return 3;
        }
    }

    @Test
    public void testDisjunction() {
        StructuredGraph graph = parse("testDisjunctionSnippet");
        new CanonicalizerPhase.Instance(runtime(), null, true).apply(graph);
        IfNode ifNode = (IfNode) graph.start().next();
        InstanceOfNode instanceOf = (InstanceOfNode) ifNode.condition();
        LogicDisjunctionNode disjunction = graph.unique(new LogicDisjunctionNode(graph.unique(new IsNullNode(graph.getLocal(0))), instanceOf));
        ifNode.setCondition(disjunction);
        ifNode.negate(disjunction);
        new CanonicalizerPhase.Instance(runtime(), null, true).apply(graph);
        new ConditionalEliminationPhase(runtime()).apply(graph);
        new CanonicalizerPhase.Instance(runtime(), null, true).apply(graph);
        for (ConstantNode constant : graph.getNodes().filter(ConstantNode.class)) {
            assertTrue("unexpected constant: " + constant, constant.asConstant().isNull() || constant.asConstant().asInt() > 0);
        }
    }
}