# HG changeset patch # User Lukas Stadler # Date 1398241578 -7200 # Node ID 2f1aefd300792f577e7cc91df4080010fdee4199 # Parent c341bd90c883bea5e03d484f3b3ca2c5a5667001 warning in AbstractFrameStateBuilder diff -r c341bd90c883 -r 2f1aefd30079 graal/com.oracle.graal.java/src/com/oracle/graal/java/AbstractFrameStateBuilder.java --- a/graal/com.oracle.graal.java/src/com/oracle/graal/java/AbstractFrameStateBuilder.java Wed Apr 23 10:26:18 2014 +0200 +++ b/graal/com.oracle.graal.java/src/com/oracle/graal/java/AbstractFrameStateBuilder.java Wed Apr 23 10:26:18 2014 +0200 @@ -69,6 +69,12 @@ public abstract boolean isCompatibleWith(S other); public void clearNonLiveLocals(BciBlock block, LocalLiveness liveness, boolean liveIn) { + /* + * (lstadler) if somebody is tempted to remove/disable this clearing code: it's possible to + * remove it for normal compilations, but not for OSR compilations - otherwise dead object + * slots at the OSR entry aren't cleared. it is also not enough to rely on PiNodes with + * Kind.Illegal, because the conflicting branch might not have been parsed. + */ if (liveness == null) { return; }