# HG changeset patch # User Stefan Anzinger # Date 1404142055 -7200 # Node ID 34ac3ddfd5ac55f6262b062e81e5ed46bf89d0c2 # Parent 5f01f7c48d40ef59b9c78a5833be146b993f013e [SPARC] fixing findbug warnings diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/GraalOptions.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/UnsafeAccess.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/AbstractObjectStamp.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/FloatStamp.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/IllegalStamp.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/IntegerStamp.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/ObjectStamp.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/PrimitiveStamp.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/StampFactory.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/StampProvider.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.compiler.common/src/com/oracle/graal/compiler/common/type/VoidStamp.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.hotspot.sparc/src/com/oracle/graal/hotspot/sparc/SPARCHotSpotPatchReturnAddressOp.java --- a/graal/com.oracle.graal.hotspot.sparc/src/com/oracle/graal/hotspot/sparc/SPARCHotSpotPatchReturnAddressOp.java Mon Jun 30 12:02:19 2014 +0200 +++ b/graal/com.oracle.graal.hotspot.sparc/src/com/oracle/graal/hotspot/sparc/SPARCHotSpotPatchReturnAddressOp.java Mon Jun 30 17:27:35 2014 +0200 @@ -26,11 +26,9 @@ import static com.oracle.graal.sparc.SPARC.*; import static com.oracle.graal.api.code.ValueUtil.*; -import com.oracle.graal.api.code.*; import com.oracle.graal.api.meta.*; import com.oracle.graal.asm.sparc.*; -import com.oracle.graal.asm.sparc.SPARCMacroAssembler.Mov; -import com.oracle.graal.asm.sparc.SPARCMacroAssembler.Setx; +import com.oracle.graal.asm.sparc.SPARCMacroAssembler.*; import com.oracle.graal.asm.sparc.SPARCAssembler.*; import com.oracle.graal.lir.*; import com.oracle.graal.lir.asm.*; @@ -53,7 +51,7 @@ // FIXME This is non-trivial. On SPARC we need to flush all register windows first before we // can patch the return address (see: frame::patch_pc). new Flushw().emit(masm); - int frameSize = crb.frameMap.frameSize(); +// int frameSize = crb.frameMap.frameSize(); // new SPARCAssembler.Ldx(new SPARCAddress(o7, 1), g3).emit(masm); // new Setx(8 * 15 - 1, g4, false).emit(masm); new Mov(asLongReg(address), g4).emit(masm); diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/meta/DefaultHotSpotLoweringProvider.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/MethodHandleNode.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.hotspotvmconfig/src/com/oracle/graal/hotspotvmconfig/HotSpotVMConstant.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.hotspotvmconfig/src/com/oracle/graal/hotspotvmconfig/HotSpotVMField.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.hotspotvmconfig/src/com/oracle/graal/hotspotvmconfig/HotSpotVMFlag.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.hotspotvmconfig/src/com/oracle/graal/hotspotvmconfig/HotSpotVMType.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCControlFlow.java --- a/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCControlFlow.java Mon Jun 30 12:02:19 2014 +0200 +++ b/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCControlFlow.java Mon Jun 30 17:27:35 2014 +0200 @@ -332,6 +332,7 @@ } } + @SuppressWarnings("unused") private static void cmove(CompilationResultBuilder crb, SPARCMacroAssembler masm, Kind kind, Value result, ConditionFlag cond, Value other) { if (!isRegister(other)) { SPARCMove.move(crb, masm, result, other); @@ -371,8 +372,11 @@ case F_Unordered: fc = FCond.Fbu; break; + default: + GraalInternalError.shouldNotReachHere("Unknown condition code " + cond); + break; } - new Fbfcc(masm, fc, true, 2).equals(masm); + new Fbfcc(masm, fc, true, 2); SPARCMove.move(crb, masm, result, other); break; default: diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/BinaryOpLogicNode.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/MemoryMap.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/InliningPhase.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/InliningUtil.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/util/HashSetNodeEventListener.java diff -r 5f01f7c48d40 -r 34ac3ddfd5ac test/whitelist_baseline.txt