# HG changeset patch # User tschatzl # Date 1392024892 -3600 # Node ID 695a6aba51c32c09194acd7702825f7247956bef # Parent a2e452cdf1d5fb9b6d62aba9b0d0b768aff596b8 8033545: Missing volatile specifier in Bitmap::par_put_range_within_word Summary: The method Bitmap::par_put_range_within_word reloads the original value during a CAS, which may be optimized away. Instead of reloading, use the value returned by Atomic::cmpxchg_ptr() for further processing. Reviewed-by: tschatzl, brutisso, tonyp Contributed-by: Matthias Braun diff -r a2e452cdf1d5 -r 695a6aba51c3 src/share/vm/utilities/bitMap.cpp --- a/src/share/vm/utilities/bitMap.cpp Fri Feb 07 12:51:08 2014 -0800 +++ b/src/share/vm/utilities/bitMap.cpp Mon Feb 10 10:34:52 2014 +0100 @@ -107,7 +107,7 @@ while (true) { intptr_t res = Atomic::cmpxchg_ptr(nw, pw, w); if (res == w) break; - w = *pw; + w = res; nw = value ? (w | ~mr) : (w & mr); } }