# HG changeset patch # User asaha # Date 1466026252 25200 # Node ID b5f2f874db7c490116ec16ce17eb160dbd4c0089 # Parent db71151912ba39760878bdf0accf892ce31f17a2# Parent d71d6679e8793e3acf4561a39787dbaccc7d7906 Merge diff -r db71151912ba -r b5f2f874db7c .hgtags --- a/.hgtags Wed Jun 15 13:48:09 2016 -0700 +++ b/.hgtags Wed Jun 15 14:30:52 2016 -0700 @@ -861,6 +861,8 @@ f3e1e734e2d29101a9537ddeb71ecad413fcd352 jdk8u92-b13 24a09407d71bb2cc4848bfa21660c890b4d722b1 jdk8u92-b14 445941ba41c0e3829fe02140690b144281ac2141 jdk8u92-b31 +f958bebdee267695e37aadd27753ac8b1e1823c8 jdk8u92-b32 +d1bb0e79ff79d21068388d9c62ca01e3c072fd0d jdk8u92-b33 b374548dcb4834eb8731a06b52faddd0f10bd45d jdk8u81-b00 ead07188d11107e877e8e4ad215ff6cb238a8a92 jdk8u101-b01 34429bad9986677f4991c80aeb22665842881cba jdk8u101-b02 diff -r db71151912ba -r b5f2f874db7c src/cpu/x86/vm/macroAssembler_x86.cpp --- a/src/cpu/x86/vm/macroAssembler_x86.cpp Wed Jun 15 13:48:09 2016 -0700 +++ b/src/cpu/x86/vm/macroAssembler_x86.cpp Wed Jun 15 14:30:52 2016 -0700 @@ -3202,7 +3202,24 @@ jmp(done); } else { // Stack: X Y - Label x_negative, y_odd; + Label x_negative, y_not_2; + + static double two = 2.0; + ExternalAddress two_addr((address)&two); + + // constant maybe too far on 64 bit + lea(tmp2, two_addr); + fld_d(Address(tmp2, 0)); // Stack: 2 X Y + fcmp(tmp, 2, true, false); // Stack: X Y + jcc(Assembler::parity, y_not_2); + jcc(Assembler::notEqual, y_not_2); + + fxch(); fpop(); // Stack: X + fmul(0); // Stack: X*X + + jmp(done); + + bind(y_not_2); fldz(); // Stack: 0 X Y fcmp(tmp, 1, true, false); // Stack: X Y diff -r db71151912ba -r b5f2f874db7c test/compiler/floatingpoint/TestPow2.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/compiler/floatingpoint/TestPow2.java Wed Jun 15 14:30:52 2016 -0700 @@ -0,0 +1,73 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8063086 + * @summary X^2 special case for C2 yields different result than interpreter + * @library /testlibrary /testlibrary/whitebox /compiler/whitebox + * @build TestPow2 + * @run main ClassFileInstaller sun.hotspot.WhiteBox + * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI + * -XX:-BackgroundCompilation -XX:-UseOnStackReplacement TestPow2 + * + */ + +import java.lang.reflect.*; +import sun.hotspot.WhiteBox; + +public class TestPow2 { + + private static final WhiteBox WHITE_BOX = WhiteBox.getWhiteBox(); + + private static final double base = 5350.456329377186; + private static final double exp = 2.0; + + static double m() { + return Math.pow(base, exp); + } + + static public void main(String[] args) throws NoSuchMethodException { + Method test_method = TestPow2.class.getDeclaredMethod("m"); + + double interpreter_result = m(); + + // Compile with C1 if possible + WHITE_BOX.enqueueMethodForCompilation(test_method, CompilerWhiteBoxTest.COMP_LEVEL_SIMPLE); + + double c1_result = m(); + + WHITE_BOX.deoptimizeMethod(test_method); + + // Compile it with C2 if possible + WHITE_BOX.enqueueMethodForCompilation(test_method, CompilerWhiteBoxTest.COMP_LEVEL_FULL_OPTIMIZATION); + + double c2_result = m(); + + if (interpreter_result != c1_result || interpreter_result != c2_result || + c1_result != c2_result) { + System.out.println("interpreter = " + interpreter_result + " c1 = " + c1_result + " c2 = " + c2_result); + throw new RuntimeException("Test Failed"); + } + } +}