annotate src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp @ 452:00b023ae2d78

6722113: CMS: Incorrect overflow handling during precleaning of Reference lists Summary: When we encounter marking stack overflow during precleaning of Reference lists, we were using the overflow list mechanism, which can cause problems on account of mutating the mark word of the header because of conflicts with mutator accesses and updates of that field. Instead we should use the usual mechanism for overflow handling in concurrent phases, namely dirtying of the card on which the overflowed object lies. Since precleaning effectively does a form of discovered list processing, albeit with discovery enabled, we needed to adjust some code to be correct in the face of interleaved processing and discovery. Reviewed-by: apetrusenko, jcoomes
author ysr
date Thu, 20 Nov 2008 12:27:41 -0800
parents a61af66fc99e
children bb843ebc7c55
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
a61af66fc99e Initial load
duke
parents:
diff changeset
2 * Copyright 2005-2006 Sun Microsystems, Inc. All Rights Reserved.
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
a61af66fc99e Initial load
duke
parents:
diff changeset
19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
a61af66fc99e Initial load
duke
parents:
diff changeset
20 * CA 95054 USA or visit www.sun.com if you need additional information or
a61af66fc99e Initial load
duke
parents:
diff changeset
21 * have any questions.
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24 # include "incls/_precompiled.incl"
a61af66fc99e Initial load
duke
parents:
diff changeset
25 # include "incls/_vmCMSOperations.cpp.incl"
a61af66fc99e Initial load
duke
parents:
diff changeset
26
a61af66fc99e Initial load
duke
parents:
diff changeset
27 HS_DTRACE_PROBE_DECL(hs_private, cms__initmark__begin);
a61af66fc99e Initial load
duke
parents:
diff changeset
28 HS_DTRACE_PROBE_DECL(hs_private, cms__initmark__end);
a61af66fc99e Initial load
duke
parents:
diff changeset
29
a61af66fc99e Initial load
duke
parents:
diff changeset
30 HS_DTRACE_PROBE_DECL(hs_private, cms__remark__begin);
a61af66fc99e Initial load
duke
parents:
diff changeset
31 HS_DTRACE_PROBE_DECL(hs_private, cms__remark__end);
a61af66fc99e Initial load
duke
parents:
diff changeset
32
a61af66fc99e Initial load
duke
parents:
diff changeset
33 //////////////////////////////////////////////////////////
a61af66fc99e Initial load
duke
parents:
diff changeset
34 // Methods in abstract class VM_CMS_Operation
a61af66fc99e Initial load
duke
parents:
diff changeset
35 //////////////////////////////////////////////////////////
a61af66fc99e Initial load
duke
parents:
diff changeset
36 void VM_CMS_Operation::acquire_pending_list_lock() {
a61af66fc99e Initial load
duke
parents:
diff changeset
37 // The caller may block while communicating
a61af66fc99e Initial load
duke
parents:
diff changeset
38 // with the SLT thread in order to acquire/release the PLL.
a61af66fc99e Initial load
duke
parents:
diff changeset
39 ConcurrentMarkSweepThread::slt()->
a61af66fc99e Initial load
duke
parents:
diff changeset
40 manipulatePLL(SurrogateLockerThread::acquirePLL);
a61af66fc99e Initial load
duke
parents:
diff changeset
41 }
a61af66fc99e Initial load
duke
parents:
diff changeset
42
a61af66fc99e Initial load
duke
parents:
diff changeset
43 void VM_CMS_Operation::release_and_notify_pending_list_lock() {
a61af66fc99e Initial load
duke
parents:
diff changeset
44 // The caller may block while communicating
a61af66fc99e Initial load
duke
parents:
diff changeset
45 // with the SLT thread in order to acquire/release the PLL.
a61af66fc99e Initial load
duke
parents:
diff changeset
46 ConcurrentMarkSweepThread::slt()->
a61af66fc99e Initial load
duke
parents:
diff changeset
47 manipulatePLL(SurrogateLockerThread::releaseAndNotifyPLL);
a61af66fc99e Initial load
duke
parents:
diff changeset
48 }
a61af66fc99e Initial load
duke
parents:
diff changeset
49
a61af66fc99e Initial load
duke
parents:
diff changeset
50 void VM_CMS_Operation::verify_before_gc() {
a61af66fc99e Initial load
duke
parents:
diff changeset
51 if (VerifyBeforeGC &&
a61af66fc99e Initial load
duke
parents:
diff changeset
52 GenCollectedHeap::heap()->total_collections() >= VerifyGCStartAt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
53 HandleMark hm;
a61af66fc99e Initial load
duke
parents:
diff changeset
54 FreelistLocker x(_collector);
a61af66fc99e Initial load
duke
parents:
diff changeset
55 MutexLockerEx y(_collector->bitMapLock(), Mutex::_no_safepoint_check_flag);
a61af66fc99e Initial load
duke
parents:
diff changeset
56 Universe::heap()->prepare_for_verify();
a61af66fc99e Initial load
duke
parents:
diff changeset
57 Universe::verify(true);
a61af66fc99e Initial load
duke
parents:
diff changeset
58 }
a61af66fc99e Initial load
duke
parents:
diff changeset
59 }
a61af66fc99e Initial load
duke
parents:
diff changeset
60
a61af66fc99e Initial load
duke
parents:
diff changeset
61 void VM_CMS_Operation::verify_after_gc() {
a61af66fc99e Initial load
duke
parents:
diff changeset
62 if (VerifyAfterGC &&
a61af66fc99e Initial load
duke
parents:
diff changeset
63 GenCollectedHeap::heap()->total_collections() >= VerifyGCStartAt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
64 HandleMark hm;
a61af66fc99e Initial load
duke
parents:
diff changeset
65 FreelistLocker x(_collector);
a61af66fc99e Initial load
duke
parents:
diff changeset
66 MutexLockerEx y(_collector->bitMapLock(), Mutex::_no_safepoint_check_flag);
a61af66fc99e Initial load
duke
parents:
diff changeset
67 Universe::verify(true);
a61af66fc99e Initial load
duke
parents:
diff changeset
68 }
a61af66fc99e Initial load
duke
parents:
diff changeset
69 }
a61af66fc99e Initial load
duke
parents:
diff changeset
70
a61af66fc99e Initial load
duke
parents:
diff changeset
71 bool VM_CMS_Operation::lost_race() const {
a61af66fc99e Initial load
duke
parents:
diff changeset
72 if (CMSCollector::abstract_state() == CMSCollector::Idling) {
a61af66fc99e Initial load
duke
parents:
diff changeset
73 // We lost a race to a foreground collection
a61af66fc99e Initial load
duke
parents:
diff changeset
74 // -- there's nothing to do
a61af66fc99e Initial load
duke
parents:
diff changeset
75 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
76 }
a61af66fc99e Initial load
duke
parents:
diff changeset
77 assert(CMSCollector::abstract_state() == legal_state(),
a61af66fc99e Initial load
duke
parents:
diff changeset
78 "Inconsistent collector state?");
a61af66fc99e Initial load
duke
parents:
diff changeset
79 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
80 }
a61af66fc99e Initial load
duke
parents:
diff changeset
81
a61af66fc99e Initial load
duke
parents:
diff changeset
82 bool VM_CMS_Operation::doit_prologue() {
a61af66fc99e Initial load
duke
parents:
diff changeset
83 assert(Thread::current()->is_ConcurrentGC_thread(), "just checking");
a61af66fc99e Initial load
duke
parents:
diff changeset
84 assert(!CMSCollector::foregroundGCShouldWait(), "Possible deadlock");
a61af66fc99e Initial load
duke
parents:
diff changeset
85 assert(!ConcurrentMarkSweepThread::cms_thread_has_cms_token(),
a61af66fc99e Initial load
duke
parents:
diff changeset
86 "Possible deadlock");
a61af66fc99e Initial load
duke
parents:
diff changeset
87
a61af66fc99e Initial load
duke
parents:
diff changeset
88 if (needs_pll()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
89 acquire_pending_list_lock();
a61af66fc99e Initial load
duke
parents:
diff changeset
90 }
a61af66fc99e Initial load
duke
parents:
diff changeset
91 // Get the Heap_lock after the pending_list_lock.
a61af66fc99e Initial load
duke
parents:
diff changeset
92 Heap_lock->lock();
a61af66fc99e Initial load
duke
parents:
diff changeset
93 if (lost_race()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
94 assert(_prologue_succeeded == false, "Initialized in c'tor");
a61af66fc99e Initial load
duke
parents:
diff changeset
95 Heap_lock->unlock();
a61af66fc99e Initial load
duke
parents:
diff changeset
96 if (needs_pll()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
97 release_and_notify_pending_list_lock();
a61af66fc99e Initial load
duke
parents:
diff changeset
98 }
a61af66fc99e Initial load
duke
parents:
diff changeset
99 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
100 _prologue_succeeded = true;
a61af66fc99e Initial load
duke
parents:
diff changeset
101 }
a61af66fc99e Initial load
duke
parents:
diff changeset
102 return _prologue_succeeded;
a61af66fc99e Initial load
duke
parents:
diff changeset
103 }
a61af66fc99e Initial load
duke
parents:
diff changeset
104
a61af66fc99e Initial load
duke
parents:
diff changeset
105 void VM_CMS_Operation::doit_epilogue() {
a61af66fc99e Initial load
duke
parents:
diff changeset
106 assert(Thread::current()->is_ConcurrentGC_thread(), "just checking");
a61af66fc99e Initial load
duke
parents:
diff changeset
107 assert(!CMSCollector::foregroundGCShouldWait(), "Possible deadlock");
a61af66fc99e Initial load
duke
parents:
diff changeset
108 assert(!ConcurrentMarkSweepThread::cms_thread_has_cms_token(),
a61af66fc99e Initial load
duke
parents:
diff changeset
109 "Possible deadlock");
a61af66fc99e Initial load
duke
parents:
diff changeset
110
a61af66fc99e Initial load
duke
parents:
diff changeset
111 // Release the Heap_lock first.
a61af66fc99e Initial load
duke
parents:
diff changeset
112 Heap_lock->unlock();
a61af66fc99e Initial load
duke
parents:
diff changeset
113 if (needs_pll()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
114 release_and_notify_pending_list_lock();
a61af66fc99e Initial load
duke
parents:
diff changeset
115 }
a61af66fc99e Initial load
duke
parents:
diff changeset
116 }
a61af66fc99e Initial load
duke
parents:
diff changeset
117
a61af66fc99e Initial load
duke
parents:
diff changeset
118 //////////////////////////////////////////////////////////
a61af66fc99e Initial load
duke
parents:
diff changeset
119 // Methods in class VM_CMS_Initial_Mark
a61af66fc99e Initial load
duke
parents:
diff changeset
120 //////////////////////////////////////////////////////////
a61af66fc99e Initial load
duke
parents:
diff changeset
121 void VM_CMS_Initial_Mark::doit() {
a61af66fc99e Initial load
duke
parents:
diff changeset
122 if (lost_race()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
123 // Nothing to do.
a61af66fc99e Initial load
duke
parents:
diff changeset
124 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
125 }
a61af66fc99e Initial load
duke
parents:
diff changeset
126 HS_DTRACE_PROBE(hs_private, cms__initmark__begin);
a61af66fc99e Initial load
duke
parents:
diff changeset
127
a61af66fc99e Initial load
duke
parents:
diff changeset
128 GenCollectedHeap* gch = GenCollectedHeap::heap();
a61af66fc99e Initial load
duke
parents:
diff changeset
129 GCCauseSetter gccs(gch, GCCause::_cms_initial_mark);
a61af66fc99e Initial load
duke
parents:
diff changeset
130
a61af66fc99e Initial load
duke
parents:
diff changeset
131 VM_CMS_Operation::verify_before_gc();
a61af66fc99e Initial load
duke
parents:
diff changeset
132
a61af66fc99e Initial load
duke
parents:
diff changeset
133 IsGCActiveMark x; // stop-world GC active
a61af66fc99e Initial load
duke
parents:
diff changeset
134 _collector->do_CMS_operation(CMSCollector::CMS_op_checkpointRootsInitial);
a61af66fc99e Initial load
duke
parents:
diff changeset
135
a61af66fc99e Initial load
duke
parents:
diff changeset
136 VM_CMS_Operation::verify_after_gc();
a61af66fc99e Initial load
duke
parents:
diff changeset
137 HS_DTRACE_PROBE(hs_private, cms__initmark__end);
a61af66fc99e Initial load
duke
parents:
diff changeset
138 }
a61af66fc99e Initial load
duke
parents:
diff changeset
139
a61af66fc99e Initial load
duke
parents:
diff changeset
140 //////////////////////////////////////////////////////////
a61af66fc99e Initial load
duke
parents:
diff changeset
141 // Methods in class VM_CMS_Final_Remark_Operation
a61af66fc99e Initial load
duke
parents:
diff changeset
142 //////////////////////////////////////////////////////////
a61af66fc99e Initial load
duke
parents:
diff changeset
143 void VM_CMS_Final_Remark::doit() {
a61af66fc99e Initial load
duke
parents:
diff changeset
144 if (lost_race()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
145 // Nothing to do.
a61af66fc99e Initial load
duke
parents:
diff changeset
146 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
147 }
a61af66fc99e Initial load
duke
parents:
diff changeset
148 HS_DTRACE_PROBE(hs_private, cms__remark__begin);
a61af66fc99e Initial load
duke
parents:
diff changeset
149
a61af66fc99e Initial load
duke
parents:
diff changeset
150 GenCollectedHeap* gch = GenCollectedHeap::heap();
a61af66fc99e Initial load
duke
parents:
diff changeset
151 GCCauseSetter gccs(gch, GCCause::_cms_final_remark);
a61af66fc99e Initial load
duke
parents:
diff changeset
152
a61af66fc99e Initial load
duke
parents:
diff changeset
153 VM_CMS_Operation::verify_before_gc();
a61af66fc99e Initial load
duke
parents:
diff changeset
154
a61af66fc99e Initial load
duke
parents:
diff changeset
155 IsGCActiveMark x; // stop-world GC active
a61af66fc99e Initial load
duke
parents:
diff changeset
156 _collector->do_CMS_operation(CMSCollector::CMS_op_checkpointRootsFinal);
a61af66fc99e Initial load
duke
parents:
diff changeset
157
a61af66fc99e Initial load
duke
parents:
diff changeset
158 VM_CMS_Operation::verify_after_gc();
a61af66fc99e Initial load
duke
parents:
diff changeset
159 HS_DTRACE_PROBE(hs_private, cms__remark__end);
a61af66fc99e Initial load
duke
parents:
diff changeset
160 }
a61af66fc99e Initial load
duke
parents:
diff changeset
161
a61af66fc99e Initial load
duke
parents:
diff changeset
162 // VM operation to invoke a concurrent collection of a
a61af66fc99e Initial load
duke
parents:
diff changeset
163 // GenCollectedHeap heap.
a61af66fc99e Initial load
duke
parents:
diff changeset
164 void VM_GenCollectFullConcurrent::doit() {
a61af66fc99e Initial load
duke
parents:
diff changeset
165 assert(Thread::current()->is_VM_thread(), "Should be VM thread");
a61af66fc99e Initial load
duke
parents:
diff changeset
166
a61af66fc99e Initial load
duke
parents:
diff changeset
167 GenCollectedHeap* gch = GenCollectedHeap::heap();
a61af66fc99e Initial load
duke
parents:
diff changeset
168 if (_gc_count_before == gch->total_collections()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
169 // The "full" of do_full_collection call below "forces"
a61af66fc99e Initial load
duke
parents:
diff changeset
170 // a collection; the second arg, 0, below ensures that
a61af66fc99e Initial load
duke
parents:
diff changeset
171 // only the young gen is collected. XXX In the future,
a61af66fc99e Initial load
duke
parents:
diff changeset
172 // we'll probably need to have something in this interface
a61af66fc99e Initial load
duke
parents:
diff changeset
173 // to say do this only if we are sure we will not bail
a61af66fc99e Initial load
duke
parents:
diff changeset
174 // out to a full collection in this attempt, but that's
a61af66fc99e Initial load
duke
parents:
diff changeset
175 // for the future.
a61af66fc99e Initial load
duke
parents:
diff changeset
176 assert(SafepointSynchronize::is_at_safepoint(),
a61af66fc99e Initial load
duke
parents:
diff changeset
177 "We can only be executing this arm of if at a safepoint");
a61af66fc99e Initial load
duke
parents:
diff changeset
178 GCCauseSetter gccs(gch, _gc_cause);
a61af66fc99e Initial load
duke
parents:
diff changeset
179 gch->do_full_collection(gch->must_clear_all_soft_refs(),
a61af66fc99e Initial load
duke
parents:
diff changeset
180 0 /* collect only youngest gen */);
a61af66fc99e Initial load
duke
parents:
diff changeset
181 } // Else no need for a foreground young gc
a61af66fc99e Initial load
duke
parents:
diff changeset
182 assert((_gc_count_before < gch->total_collections()) ||
a61af66fc99e Initial load
duke
parents:
diff changeset
183 (GC_locker::is_active() /* gc may have been skipped */
a61af66fc99e Initial load
duke
parents:
diff changeset
184 && (_gc_count_before == gch->total_collections())),
a61af66fc99e Initial load
duke
parents:
diff changeset
185 "total_collections() should be monotonically increasing");
a61af66fc99e Initial load
duke
parents:
diff changeset
186
a61af66fc99e Initial load
duke
parents:
diff changeset
187 MutexLockerEx x(FullGCCount_lock, Mutex::_no_safepoint_check_flag);
a61af66fc99e Initial load
duke
parents:
diff changeset
188 if (gch->total_full_collections() == _full_gc_count_before) {
a61af66fc99e Initial load
duke
parents:
diff changeset
189 // Disable iCMS until the full collection is done.
a61af66fc99e Initial load
duke
parents:
diff changeset
190 CMSCollector::disable_icms();
a61af66fc99e Initial load
duke
parents:
diff changeset
191 // In case CMS thread was in icms_wait(), wake it up.
a61af66fc99e Initial load
duke
parents:
diff changeset
192 CMSCollector::start_icms();
a61af66fc99e Initial load
duke
parents:
diff changeset
193 // Nudge the CMS thread to start a concurrent collection
a61af66fc99e Initial load
duke
parents:
diff changeset
194 CMSCollector::request_full_gc(_full_gc_count_before);
a61af66fc99e Initial load
duke
parents:
diff changeset
195 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
196 FullGCCount_lock->notify_all(); // Inform the Java thread its work is done
a61af66fc99e Initial load
duke
parents:
diff changeset
197 }
a61af66fc99e Initial load
duke
parents:
diff changeset
198 }
a61af66fc99e Initial load
duke
parents:
diff changeset
199
a61af66fc99e Initial load
duke
parents:
diff changeset
200 bool VM_GenCollectFullConcurrent::evaluate_at_safepoint() const {
a61af66fc99e Initial load
duke
parents:
diff changeset
201 Thread* thr = Thread::current();
a61af66fc99e Initial load
duke
parents:
diff changeset
202 assert(thr != NULL, "Unexpected tid");
a61af66fc99e Initial load
duke
parents:
diff changeset
203 if (!thr->is_Java_thread()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
204 assert(thr->is_VM_thread(), "Expected to be evaluated by VM thread");
a61af66fc99e Initial load
duke
parents:
diff changeset
205 GenCollectedHeap* gch = GenCollectedHeap::heap();
a61af66fc99e Initial load
duke
parents:
diff changeset
206 if (_gc_count_before != gch->total_collections()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
207 // No need to do a young gc, we'll just nudge the CMS thread
a61af66fc99e Initial load
duke
parents:
diff changeset
208 // in the doit() method above, to be executed soon.
a61af66fc99e Initial load
duke
parents:
diff changeset
209 assert(_gc_count_before < gch->total_collections(),
a61af66fc99e Initial load
duke
parents:
diff changeset
210 "total_collections() should be monotnically increasing");
a61af66fc99e Initial load
duke
parents:
diff changeset
211 return false; // no need for foreground young gc
a61af66fc99e Initial load
duke
parents:
diff changeset
212 }
a61af66fc99e Initial load
duke
parents:
diff changeset
213 }
a61af66fc99e Initial load
duke
parents:
diff changeset
214 return true; // may still need foreground young gc
a61af66fc99e Initial load
duke
parents:
diff changeset
215 }
a61af66fc99e Initial load
duke
parents:
diff changeset
216
a61af66fc99e Initial load
duke
parents:
diff changeset
217
a61af66fc99e Initial load
duke
parents:
diff changeset
218 void VM_GenCollectFullConcurrent::doit_epilogue() {
a61af66fc99e Initial load
duke
parents:
diff changeset
219 Thread* thr = Thread::current();
a61af66fc99e Initial load
duke
parents:
diff changeset
220 assert(thr->is_Java_thread(), "just checking");
a61af66fc99e Initial load
duke
parents:
diff changeset
221 JavaThread* jt = (JavaThread*)thr;
a61af66fc99e Initial load
duke
parents:
diff changeset
222 // Release the Heap_lock first.
a61af66fc99e Initial load
duke
parents:
diff changeset
223 Heap_lock->unlock();
a61af66fc99e Initial load
duke
parents:
diff changeset
224 release_and_notify_pending_list_lock();
a61af66fc99e Initial load
duke
parents:
diff changeset
225
a61af66fc99e Initial load
duke
parents:
diff changeset
226 // It is fine to test whether completed collections has
a61af66fc99e Initial load
duke
parents:
diff changeset
227 // exceeded our request count without locking because
a61af66fc99e Initial load
duke
parents:
diff changeset
228 // the completion count is monotonically increasing;
a61af66fc99e Initial load
duke
parents:
diff changeset
229 // this will break for very long-running apps when the
a61af66fc99e Initial load
duke
parents:
diff changeset
230 // count overflows and wraps around. XXX fix me !!!
a61af66fc99e Initial load
duke
parents:
diff changeset
231 // e.g. at the rate of 1 full gc per ms, this could
a61af66fc99e Initial load
duke
parents:
diff changeset
232 // overflow in about 1000 years.
a61af66fc99e Initial load
duke
parents:
diff changeset
233 GenCollectedHeap* gch = GenCollectedHeap::heap();
a61af66fc99e Initial load
duke
parents:
diff changeset
234 if (gch->total_full_collections_completed() <= _full_gc_count_before) {
a61af66fc99e Initial load
duke
parents:
diff changeset
235 // Now, wait for witnessing concurrent gc cycle to complete,
a61af66fc99e Initial load
duke
parents:
diff changeset
236 // but do so in native mode, because we want to lock the
a61af66fc99e Initial load
duke
parents:
diff changeset
237 // FullGCEvent_lock, which may be needed by the VM thread
a61af66fc99e Initial load
duke
parents:
diff changeset
238 // or by the CMS thread, so we do not want to be suspended
a61af66fc99e Initial load
duke
parents:
diff changeset
239 // while holding that lock.
a61af66fc99e Initial load
duke
parents:
diff changeset
240 ThreadToNativeFromVM native(jt);
a61af66fc99e Initial load
duke
parents:
diff changeset
241 MutexLockerEx ml(FullGCCount_lock, Mutex::_no_safepoint_check_flag);
a61af66fc99e Initial load
duke
parents:
diff changeset
242 // Either a concurrent or a stop-world full gc is sufficient
a61af66fc99e Initial load
duke
parents:
diff changeset
243 // witness to our request.
a61af66fc99e Initial load
duke
parents:
diff changeset
244 while (gch->total_full_collections_completed() <= _full_gc_count_before) {
a61af66fc99e Initial load
duke
parents:
diff changeset
245 FullGCCount_lock->wait(Mutex::_no_safepoint_check_flag);
a61af66fc99e Initial load
duke
parents:
diff changeset
246 }
a61af66fc99e Initial load
duke
parents:
diff changeset
247 }
a61af66fc99e Initial load
duke
parents:
diff changeset
248 // Enable iCMS back.
a61af66fc99e Initial load
duke
parents:
diff changeset
249 CMSCollector::enable_icms();
a61af66fc99e Initial load
duke
parents:
diff changeset
250 }